)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5b746b74d67a923d7f25f459d69cef9c05602d6c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     ramishra \u003cramishra@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-04-06 10:08:23 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Simplify ceilometer service template conditions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Also removes leftover ceilometer_qdr_publish condition."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"65150bf0_e49b0f90","line":7,"updated":"2021-04-06 06:26:50.000000000","message":"can we do this because we upgraded to use \u0027wallaby\u0027 version of templates ?","commit_id":"95bf4b25213d526bb35e38bf3078d4e6dd15674f"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"72ce11679ecb783b363ad2acb920a12527be6cde","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     ramishra \u003cramishra@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-04-06 10:08:23 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Simplify ceilometer service template conditions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Also removes leftover ceilometer_qdr_publish condition."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"98315a03_a277bce5","line":7,"in_reply_to":"65150bf0_e49b0f90","updated":"2021-04-06 06:53:10.000000000","message":"Some of the stuff is wrong usage pattern copied from one to other. wallaby version adds a new variant of \u0027if\u0027 macro.","commit_id":"95bf4b25213d526bb35e38bf3078d4e6dd15674f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5b746b74d67a923d7f25f459d69cef9c05602d6c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Simplify ceilometer service template conditions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Also removes leftover ceilometer_qdr_publish condition."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I520d32488f3300ebe895040c2cd5f0acc0c0d386"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"33db2732_29d41974","line":9,"range":{"start_line":9,"start_character":22,"end_line":9,"end_character":44},"updated":"2021-04-06 06:26:50.000000000","message":"and ceilometer_enable_gnocchi\n\nbut actually there are a few ceilometer_qdr_publish conditions left in here like https://review.opendev.org/c/openstack/tripleo-heat-templates/+/781622/4/deployment/ceilometer/ceilometer-agent-notification-container-puppet.yaml#108","commit_id":"95bf4b25213d526bb35e38bf3078d4e6dd15674f"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"72ce11679ecb783b363ad2acb920a12527be6cde","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Simplify ceilometer service template conditions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Also removes leftover ceilometer_qdr_publish condition."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I520d32488f3300ebe895040c2cd5f0acc0c0d386"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"66a9d29d_5a45d81a","line":9,"range":{"start_line":9,"start_character":22,"end_line":9,"end_character":44},"in_reply_to":"33db2732_29d41974","updated":"2021-04-06 06:53:10.000000000","message":"That one is used. Please check L131.","commit_id":"95bf4b25213d526bb35e38bf3078d4e6dd15674f"}],"deployment/ceilometer/ceilometer-agent-central-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c0a89f7c725b9af5f20b720d21bd6d81a6a01e36","unresolved":true,"context_lines":[{"line_number":133,"context_line":"            environment:"},{"line_number":134,"context_line":"              KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":135,"context_line":"        step_5:"},{"line_number":136,"context_line":"          map_merge:"},{"line_number":137,"context_line":"            - if:"},{"line_number":138,"context_line":"              - {get_param: CeilometerEnableGnocchi}"},{"line_number":139,"context_line":"              - ceilometer_gnocchi_upgrade:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f2ebf59d_1aecb100","line":136,"range":{"start_line":136,"start_character":10,"end_line":136,"end_character":20},"updated":"2021-04-06 03:57:02.000000000","message":"Can we remove this map_merge as well ? It seems that we have a single item under this.","commit_id":"e554b4bb4f1ec6138f4616de4b5ffbc2b5e47a75"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b280c7802ef6803e56f47513d607bbe01b0279fb","unresolved":true,"context_lines":[{"line_number":133,"context_line":"            environment:"},{"line_number":134,"context_line":"              KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":135,"context_line":"        step_5:"},{"line_number":136,"context_line":"          map_merge:"},{"line_number":137,"context_line":"            - if:"},{"line_number":138,"context_line":"              - {get_param: CeilometerEnableGnocchi}"},{"line_number":139,"context_line":"              - ceilometer_gnocchi_upgrade:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f72369a3_6280203b","line":136,"range":{"start_line":136,"start_character":10,"end_line":136,"end_character":20},"in_reply_to":"e0441b8b_9871a301","updated":"2021-04-06 04:53:26.000000000","message":"Thank you. I understand that but pointed this because I saw this just around the change you made. We\u0027d need further review to get rid of the similar usage but that can be done later.","commit_id":"e554b4bb4f1ec6138f4616de4b5ffbc2b5e47a75"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"746cf5ab4847fc08189b2c134996dcd643a10eb7","unresolved":true,"context_lines":[{"line_number":133,"context_line":"            environment:"},{"line_number":134,"context_line":"              KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":135,"context_line":"        step_5:"},{"line_number":136,"context_line":"          map_merge:"},{"line_number":137,"context_line":"            - if:"},{"line_number":138,"context_line":"              - {get_param: CeilometerEnableGnocchi}"},{"line_number":139,"context_line":"              - ceilometer_gnocchi_upgrade:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e0441b8b_9871a301","line":136,"range":{"start_line":136,"start_character":10,"end_line":136,"end_character":20},"in_reply_to":"f2ebf59d_1aecb100","updated":"2021-04-06 04:41:07.000000000","message":"Done. These templates can surely be further optimized. I was only looking at conditions and make them a little more readable.","commit_id":"e554b4bb4f1ec6138f4616de4b5ffbc2b5e47a75"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2f102622c80a53b9243f29a4420f25d44857472a","unresolved":true,"context_lines":[{"line_number":132,"context_line":"                  - /var/log/containers/ceilometer:/var/log/ceilometer:z"},{"line_number":133,"context_line":"            environment:"},{"line_number":134,"context_line":"              KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":135,"context_line":"        if:"},{"line_number":136,"context_line":"          - {get_param: CeilometerEnableGnocchi}"},{"line_number":137,"context_line":"          - step_5:"},{"line_number":138,"context_line":"              ceilometer_gnocchi_upgrade:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4d830af6_516eb4ef","line":135,"range":{"start_line":135,"start_character":8,"end_line":135,"end_character":11},"updated":"2021-04-06 07:06:58.000000000","message":"Not sure if this would work. Let\u0027s see the gate results. Probably a heat bug.","commit_id":"95bf4b25213d526bb35e38bf3078d4e6dd15674f"}],"deployment/ceilometer/ceilometer-agent-notification-container-puppet.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5b746b74d67a923d7f25f459d69cef9c05602d6c","unresolved":true,"context_lines":[{"line_number":107,"context_line":"conditions:"},{"line_number":108,"context_line":"  ceilometer_qdr_publish:"},{"line_number":109,"context_line":"    or:"},{"line_number":110,"context_line":"      - {equals: [{get_param: CeilometerQdrPublishEvents}, true]}"},{"line_number":111,"context_line":"      - {equals: [{get_param: CeilometerQdrPublishMetrics}, true]}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"outputs:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2ffd567c_506e53d9","side":"PARENT","line":110,"updated":"2021-04-06 06:26:50.000000000","message":"general question about this pattern for learning ;)\n\n... is it because we have switched to \u0027wallaby\u0027 version of the templates?\n\ni.e. we no longer need to set conditional based on the template parameters like we used to do and can now directly reference the parameter with get_param?","commit_id":"bd1ee6ba5f294b12133dea1778f62c910b49134d"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"72ce11679ecb783b363ad2acb920a12527be6cde","unresolved":true,"context_lines":[{"line_number":107,"context_line":"conditions:"},{"line_number":108,"context_line":"  ceilometer_qdr_publish:"},{"line_number":109,"context_line":"    or:"},{"line_number":110,"context_line":"      - {equals: [{get_param: CeilometerQdrPublishEvents}, true]}"},{"line_number":111,"context_line":"      - {equals: [{get_param: CeilometerQdrPublishMetrics}, true]}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"outputs:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"22a9ae10_08feb1c1","side":"PARENT","line":110,"in_reply_to":"2ffd567c_506e53d9","updated":"2021-04-06 06:53:10.000000000","message":"If the parameter is boolean, you don\u0027t need to build a condition with the parameter and check for it to be \u0027true\u0027. It can directly be used in the \u0027if\u0027 macro.","commit_id":"bd1ee6ba5f294b12133dea1778f62c910b49134d"}]}