)]}'
{"deployment/keystone/keystone-container-puppet.yaml":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0273d1c0e9a379c468d3446e908d472fd04d3068","unresolved":true,"context_lines":[{"line_number":762,"context_line":"                name: tripleo_keystone_resources"},{"line_number":763,"context_line":"                tasks_from: clouds"},{"line_number":764,"context_line":"              vars:"},{"line_number":765,"context_line":"                tripleo_keystone_resources_cloud_name: {get_param: RootStackName}-system-admin"},{"line_number":766,"context_line":"                tripleo_keystone_resources_cloud_config:"},{"line_number":767,"context_line":"                  auth:"},{"line_number":768,"context_line":"                    auth_url: {get_param: [EndpointMap, KeystonePublic, uri_no_suffix]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"27bf27b2_e42e826a","line":765,"range":{"start_line":765,"start_character":81,"end_line":765,"end_character":82},"updated":"2021-03-19 21:09:39.000000000","message":"This needs to be quoted I think, other wise it\u0027s going to blowup parsing the template:\n\n  ValueError: Error parsing template file:///home/stack/overcloud-deploy-overcloud/tripleo-heat-templates/deployment/keystone/keystone-container-puppet.yaml while parsing a block mapping                                                    \n  in \"\u003cunicode string\u003e\", line 765, column 17:                                                                                                                                                                                               \n                    tripleo_keystone_resources_cloud ...                                                                                                                                                                                    \n                    ^                                                                                                                                                                                                                       \nexpected \u003cblock end\u003e, but found \u0027\u003cscalar\u003e\u0027                                                                                                                                                                                                  \n  in \"\u003cunicode string\u003e\", line 765, column 82:                                                                                                                                                                                               \n     ... name: {get_param: RootStackName}-system-admin","commit_id":"b251a8fdf7997bc0fc5ed356102ac87e7f30f477"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"30a988254a3a3f6d1bc842540ce654bc1aa91882","unresolved":true,"context_lines":[{"line_number":762,"context_line":"                name: tripleo_keystone_resources"},{"line_number":763,"context_line":"                tasks_from: clouds"},{"line_number":764,"context_line":"              vars:"},{"line_number":765,"context_line":"                tripleo_keystone_resources_cloud_name: {get_param: RootStackName}_system_admin"},{"line_number":766,"context_line":"                tripleo_keystone_resources_cloud_config:"},{"line_number":767,"context_line":"                  auth:"},{"line_number":768,"context_line":"                    auth_url: {get_param: [EndpointMap, KeystonePublic, uri_no_suffix]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3042d22e_95b5fc04","line":765,"range":{"start_line":765,"start_character":55,"end_line":765,"end_character":81},"updated":"2021-03-22 16:41:14.000000000","message":"this needs an intermediate var perhaps","commit_id":"b3342e65e6d252f52ff49c5e6c4ac1065ba8fdc4"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"381cc806f159b022eafd8bcb9555df04f3216163","unresolved":true,"context_lines":[{"line_number":313,"context_line":"  RootStackName:"},{"line_number":314,"context_line":"    description: The name of the stack/plan."},{"line_number":315,"context_line":"    type: string"},{"line_number":316,"context_line":"  RootStackNameProfile:"},{"line_number":317,"context_line":"    description: \u003e-"},{"line_number":318,"context_line":"      The name of the RootStackName\u0027s primary system-admin account"},{"line_number":319,"context_line":"      to be created in clouds.yaml."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"12d8ab0e_5881211a","line":316,"range":{"start_line":316,"start_character":2,"end_line":316,"end_character":22},"updated":"2021-03-24 02:03:16.000000000","message":"May be just \u0027RootStackProfile\u0027?","commit_id":"d7e61f90a7eabb0885167f4ee1310bdebd6c4d09"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"47b38c519765357b8b6bf8b3a61c7359bd7ad472","unresolved":true,"context_lines":[{"line_number":313,"context_line":"  RootStackName:"},{"line_number":314,"context_line":"    description: The name of the stack/plan."},{"line_number":315,"context_line":"    type: string"},{"line_number":316,"context_line":"  RootStackNameProfile:"},{"line_number":317,"context_line":"    description: \u003e-"},{"line_number":318,"context_line":"      The name of the RootStackName\u0027s primary system-admin account"},{"line_number":319,"context_line":"      to be created in clouds.yaml."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0f8aa99e_91242ab3","line":316,"range":{"start_line":316,"start_character":2,"end_line":316,"end_character":22},"in_reply_to":"12d8ab0e_5881211a","updated":"2021-03-29 21:31:28.000000000","message":"Yeah - that sounds good. I\u0027ll incorporate that into the next patch.","commit_id":"d7e61f90a7eabb0885167f4ee1310bdebd6c4d09"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"381cc806f159b022eafd8bcb9555df04f3216163","unresolved":true,"context_lines":[{"line_number":318,"context_line":"      The name of the RootStackName\u0027s primary system-admin account"},{"line_number":319,"context_line":"      to be created in clouds.yaml."},{"line_number":320,"context_line":"    type: string"},{"line_number":321,"context_line":"    default: \u0027overcloud-system-admin\u0027"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"resources:"},{"line_number":324,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"efef95b5_b8b3e13a","line":321,"range":{"start_line":321,"start_character":4,"end_line":321,"end_character":37},"updated":"2021-03-24 02:03:16.000000000","message":"With the default, I think it would be created on undercloud as part of undercloud install and then overwritten with the one for overcloud, which probably something we don\u0027t want.","commit_id":"d7e61f90a7eabb0885167f4ee1310bdebd6c4d09"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"47b38c519765357b8b6bf8b3a61c7359bd7ad472","unresolved":true,"context_lines":[{"line_number":318,"context_line":"      The name of the RootStackName\u0027s primary system-admin account"},{"line_number":319,"context_line":"      to be created in clouds.yaml."},{"line_number":320,"context_line":"    type: string"},{"line_number":321,"context_line":"    default: \u0027overcloud-system-admin\u0027"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"resources:"},{"line_number":324,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"39d76dbf_7019aaa8","line":321,"range":{"start_line":321,"start_character":4,"end_line":321,"end_character":37},"in_reply_to":"efef95b5_b8b3e13a","updated":"2021-03-29 21:31:28.000000000","message":"So leave this without a default for now? Is there a way I can infer this from RootStackName on the fly?\n\nI wasn\u0027t able to find an example of that anywhere.","commit_id":"d7e61f90a7eabb0885167f4ee1310bdebd6c4d09"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"85c14552d7825202cf5a6531b3b9a093b5c088ee","unresolved":true,"context_lines":[{"line_number":317,"context_line":"    description: \u003e-"},{"line_number":318,"context_line":"      The name of the RootStackName\u0027s primary system-admin account"},{"line_number":319,"context_line":"      to be created in clouds.yaml."},{"line_number":320,"context_line":"    type: string"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"resources:"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"38d7e72c_95de407b","line":320,"updated":"2021-04-12 21:34:04.000000000","message":"This is probably going to fail because I\u0027m not supplying a default value and I\u0027m also not including an explicit value for all the CI.\n\nDoes heat support doing something like?\n\n  {get_param: RooStackName}-system-admin\n\nBecause I think that would make dealing with this easier than having people specify another argument when we could derive it from RootStackName.","commit_id":"4d9a44faf08d344c00f28749135a0249007d3f66"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e79d6e4440b540240655d1ffca0f759e37c6f1cf","unresolved":true,"context_lines":[{"line_number":317,"context_line":"    description: \u003e-"},{"line_number":318,"context_line":"      The name of the RootStackName\u0027s primary system-admin account"},{"line_number":319,"context_line":"      to be created in clouds.yaml."},{"line_number":320,"context_line":"    type: string"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"resources:"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b070993d_d4aba00d","line":320,"in_reply_to":"38d7e72c_95de407b","updated":"2021-04-15 02:35:53.000000000","message":"Yeah, you can get rid of this parameter and just create it by concatenating these strings.\n\ntripleo_keystone_resources_cloud_name:\n  list_join:\n    - \u0027-\u0027\n    - {get_param: RootStackName}\n    - \u0027system-admin\u0027","commit_id":"4d9a44faf08d344c00f28749135a0249007d3f66"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e794c61755a9ca9136714d0069318f25d2abf191","unresolved":false,"context_lines":[{"line_number":317,"context_line":"    description: \u003e-"},{"line_number":318,"context_line":"      The name of the RootStackName\u0027s primary system-admin account"},{"line_number":319,"context_line":"      to be created in clouds.yaml."},{"line_number":320,"context_line":"    type: string"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"resources:"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d0ed6f2f_b6613c50","line":320,"in_reply_to":"b070993d_d4aba00d","updated":"2021-04-15 13:54:25.000000000","message":"Done","commit_id":"4d9a44faf08d344c00f28749135a0249007d3f66"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"20cd2024ceff790e0e2d67d6b84aa535d5899942","unresolved":true,"context_lines":[{"line_number":746,"context_line":"                    auth_url: {get_param: [EndpointMap, KeystonePublic, uri_no_suffix]}"},{"line_number":747,"context_line":"                    password: {get_param: AdminPassword}"},{"line_number":748,"context_line":"                    project_domain_name: Default"},{"line_number":749,"context_line":"                    project_name: admin"},{"line_number":750,"context_line":"                    user_domain_name: Default"},{"line_number":751,"context_line":"                    username: admin"},{"line_number":752,"context_line":"                  cacert:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"feea2534_b2104df3","line":749,"range":{"start_line":749,"start_character":34,"end_line":749,"end_character":39},"updated":"2021-04-22 13:53:57.000000000","message":"Maybe we should consider doing the inverse and make `overcloud` the system-scoped profile, instead of creating a new profile called `overcloud-system-admin`.","commit_id":"eb3e78f824e1fb8297defc7af21d8fbcffa7538e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4b8f8d62d2be42c768e983211133a2f00ab67785","unresolved":false,"context_lines":[{"line_number":746,"context_line":"                    auth_url: {get_param: [EndpointMap, KeystonePublic, uri_no_suffix]}"},{"line_number":747,"context_line":"                    password: {get_param: AdminPassword}"},{"line_number":748,"context_line":"                    project_domain_name: Default"},{"line_number":749,"context_line":"                    project_name: admin"},{"line_number":750,"context_line":"                    user_domain_name: Default"},{"line_number":751,"context_line":"                    username: admin"},{"line_number":752,"context_line":"                  cacert:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ab512982_d4510671","line":749,"range":{"start_line":749,"start_character":34,"end_line":749,"end_character":39},"in_reply_to":"feea2534_b2104df3","updated":"2021-04-23 20:48:09.000000000","message":"Done","commit_id":"eb3e78f824e1fb8297defc7af21d8fbcffa7538e"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2bfe29bfc33e29ebfd75005c48998b72515fd16b","unresolved":true,"context_lines":[{"line_number":778,"context_line":"                    if:"},{"line_number":779,"context_line":"                      - public_tls_enabled"},{"line_number":780,"context_line":"                      - {get_param: PublicTLSCAFile}"},{"line_number":781,"context_line":"                      - \u0027\u0027"},{"line_number":782,"context_line":"                  identity_api_version: \u00273\u0027"},{"line_number":783,"context_line":"                  volume_api_version: \u00273\u0027"},{"line_number":784,"context_line":"                  region_name: {get_param: KeystoneRegion}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"33a0ac77_db3e92a3","line":781,"range":{"start_line":781,"start_character":21,"end_line":781,"end_character":26},"updated":"2021-04-22 02:51:30.000000000","message":"You don\u0027t need this.","commit_id":"eb3e78f824e1fb8297defc7af21d8fbcffa7538e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"08302af054ea6dd60b008248f60f2b6152090f73","unresolved":true,"context_lines":[{"line_number":778,"context_line":"                    if:"},{"line_number":779,"context_line":"                      - public_tls_enabled"},{"line_number":780,"context_line":"                      - {get_param: PublicTLSCAFile}"},{"line_number":781,"context_line":"                      - \u0027\u0027"},{"line_number":782,"context_line":"                  identity_api_version: \u00273\u0027"},{"line_number":783,"context_line":"                  volume_api_version: \u00273\u0027"},{"line_number":784,"context_line":"                  region_name: {get_param: KeystoneRegion}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"82528211_39c71ed2","line":781,"range":{"start_line":781,"start_character":21,"end_line":781,"end_character":26},"in_reply_to":"04defd4c_9fd563a7","updated":"2021-04-30 10:13:22.000000000","message":"Would be good to be consistent, yep. Dropping it in both place is probably better.","commit_id":"eb3e78f824e1fb8297defc7af21d8fbcffa7538e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4b8f8d62d2be42c768e983211133a2f00ab67785","unresolved":true,"context_lines":[{"line_number":778,"context_line":"                    if:"},{"line_number":779,"context_line":"                      - public_tls_enabled"},{"line_number":780,"context_line":"                      - {get_param: PublicTLSCAFile}"},{"line_number":781,"context_line":"                      - \u0027\u0027"},{"line_number":782,"context_line":"                  identity_api_version: \u00273\u0027"},{"line_number":783,"context_line":"                  volume_api_version: \u00273\u0027"},{"line_number":784,"context_line":"                  region_name: {get_param: KeystoneRegion}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"04defd4c_9fd563a7","line":781,"range":{"start_line":781,"start_character":21,"end_line":781,"end_character":26},"in_reply_to":"33a0ac77_db3e92a3","updated":"2021-04-23 20:48:09.000000000","message":"This was copy/pasted from the existing example on line 756. Should I remove both?","commit_id":"eb3e78f824e1fb8297defc7af21d8fbcffa7538e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"7b04df6dc4ad41eee7dd16ba9e1113b2e4dbe4a3","unresolved":true,"context_lines":[{"line_number":752,"context_line":"                    if:"},{"line_number":753,"context_line":"                      - public_tls_enabled"},{"line_number":754,"context_line":"                      - {get_param: PublicTLSCAFile}"},{"line_number":755,"context_line":"                      - \u0027\u0027"},{"line_number":756,"context_line":"                  identity_api_version: \u00273\u0027"},{"line_number":757,"context_line":"                  volume_api_version: \u00273\u0027"},{"line_number":758,"context_line":"                  region_name: {get_param: KeystoneRegion}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba43d442_104e73f2","line":755,"updated":"2021-04-30 10:12:29.000000000","message":"I think we can drop that line - iirc Rabi has done something to make the \"if\" smarter/cleaner/shorter.","commit_id":"2c83c9d8a5abe3b663161ba3fe8a55fd60dfcdc0"}]}