)]}'
{"common/deploy-steps.j2":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"58cf275cb923a08b00a18d0599299f31bd1f4a26","unresolved":true,"context_lines":[{"line_number":698,"context_line":"                      debug:"},{"line_number":699,"context_line":"                        msg: Use --start-at-task \u0027Overcloud common bootstrap tasks\u0027 to resume from this task"},{"line_number":700,"context_line":"                    - name: Write config data"},{"line_number":701,"context_line":"                      include_tasks: common_deploy_steps_tasks_step_1.yaml"},{"line_number":702,"context_line":"                      when:"},{"line_number":703,"context_line":"                        - (deploy_identifier is defined and deploy_identifier !\u003d \"\" and deploy_identifier is not none)"},{"line_number":704,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"06cc3b51_d5f4732c","line":701,"range":{"start_line":701,"start_character":37,"end_line":701,"end_character":69},"updated":"2021-03-24 16:28:38.000000000","message":"It likely would be better to split the container setup items out of this and not move this specific file. This file includes dry run puppet bits which likely should not be moved out of the deploy steps. We can move the container related setup items to their own common file and include that here.","commit_id":"11bb46ad9f0e8eb56d75742d8df47704445b8932"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"3409f8f31bce7e8abd3b9a3857c5afc242b733c3","unresolved":true,"context_lines":[{"line_number":698,"context_line":"                      debug:"},{"line_number":699,"context_line":"                        msg: Use --start-at-task \u0027Overcloud common bootstrap tasks\u0027 to resume from this task"},{"line_number":700,"context_line":"                    - name: Write config data"},{"line_number":701,"context_line":"                      include_tasks: common_deploy_steps_tasks_step_1.yaml"},{"line_number":702,"context_line":"                      when:"},{"line_number":703,"context_line":"                        - (deploy_identifier is defined and deploy_identifier !\u003d \"\" and deploy_identifier is not none)"},{"line_number":704,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"8100947f_00b387fe","line":701,"range":{"start_line":701,"start_character":37,"end_line":701,"end_character":74},"updated":"2021-03-24 10:08:38.000000000","message":"nit: this is no longer executed at step 1, maybe it could be renamed to common_bootstrap_tasks.yaml","commit_id":"11bb46ad9f0e8eb56d75742d8df47704445b8932"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"4906d722107d1fce24358abf85b3817b76336df2","unresolved":false,"context_lines":[{"line_number":698,"context_line":"                      debug:"},{"line_number":699,"context_line":"                        msg: Use --start-at-task \u0027Overcloud common bootstrap tasks\u0027 to resume from this task"},{"line_number":700,"context_line":"                    - name: Write config data"},{"line_number":701,"context_line":"                      include_tasks: common_deploy_steps_tasks_step_1.yaml"},{"line_number":702,"context_line":"                      when:"},{"line_number":703,"context_line":"                        - (deploy_identifier is defined and deploy_identifier !\u003d \"\" and deploy_identifier is not none)"},{"line_number":704,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"93788f31_7f3d6977","line":701,"range":{"start_line":701,"start_character":37,"end_line":701,"end_character":69},"in_reply_to":"06cc3b51_d5f4732c","updated":"2021-03-26 08:20:56.000000000","message":"Done","commit_id":"11bb46ad9f0e8eb56d75742d8df47704445b8932"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"4906d722107d1fce24358abf85b3817b76336df2","unresolved":false,"context_lines":[{"line_number":698,"context_line":"                      debug:"},{"line_number":699,"context_line":"                        msg: Use --start-at-task \u0027Overcloud common bootstrap tasks\u0027 to resume from this task"},{"line_number":700,"context_line":"                    - name: Write config data"},{"line_number":701,"context_line":"                      include_tasks: common_deploy_steps_tasks_step_1.yaml"},{"line_number":702,"context_line":"                      when:"},{"line_number":703,"context_line":"                        - (deploy_identifier is defined and deploy_identifier !\u003d \"\" and deploy_identifier is not none)"},{"line_number":704,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"45e51228_bc0befa1","line":701,"range":{"start_line":701,"start_character":37,"end_line":701,"end_character":74},"in_reply_to":"4f830c0a_1d4a36ff","updated":"2021-03-26 08:20:56.000000000","message":"Done","commit_id":"11bb46ad9f0e8eb56d75742d8df47704445b8932"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"db3da8a0a8605df9d94fefcfca7a187fe4c6ce97","unresolved":true,"context_lines":[{"line_number":698,"context_line":"                      debug:"},{"line_number":699,"context_line":"                        msg: Use --start-at-task \u0027Overcloud common bootstrap tasks\u0027 to resume from this task"},{"line_number":700,"context_line":"                    - name: Write config data"},{"line_number":701,"context_line":"                      include_tasks: common_deploy_steps_tasks_step_1.yaml"},{"line_number":702,"context_line":"                      when:"},{"line_number":703,"context_line":"                        - (deploy_identifier is defined and deploy_identifier !\u003d \"\" and deploy_identifier is not none)"},{"line_number":704,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"4f830c0a_1d4a36ff","line":701,"range":{"start_line":701,"start_character":37,"end_line":701,"end_character":74},"in_reply_to":"8100947f_00b387fe","updated":"2021-03-24 11:49:14.000000000","message":"nice cach","commit_id":"11bb46ad9f0e8eb56d75742d8df47704445b8932"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"3409f8f31bce7e8abd3b9a3857c5afc242b733c3","unresolved":true,"context_lines":[{"line_number":701,"context_line":"                      include_tasks: common_deploy_steps_tasks_step_1.yaml"},{"line_number":702,"context_line":"                      when:"},{"line_number":703,"context_line":"                        - (deploy_identifier is defined and deploy_identifier !\u003d \"\" and deploy_identifier is not none)"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"{%- for step in range(1,deploy_steps_max) %}"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"            - hosts: DEPLOY_SOURCE_HOST"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"b2f4b2a9_031c264c","line":704,"updated":"2021-03-24 10:08:38.000000000","message":"To align with other playbooks, a set of tags should probably be defined.\nSomething like:\n\n  tags:\n    - overcloud\n    - common_bootstrap","commit_id":"11bb46ad9f0e8eb56d75742d8df47704445b8932"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"4906d722107d1fce24358abf85b3817b76336df2","unresolved":false,"context_lines":[{"line_number":701,"context_line":"                      include_tasks: common_deploy_steps_tasks_step_1.yaml"},{"line_number":702,"context_line":"                      when:"},{"line_number":703,"context_line":"                        - (deploy_identifier is defined and deploy_identifier !\u003d \"\" and deploy_identifier is not none)"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"{%- for step in range(1,deploy_steps_max) %}"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"            - hosts: DEPLOY_SOURCE_HOST"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"fe68b939_e65ee0af","line":704,"in_reply_to":"b2f4b2a9_031c264c","updated":"2021-03-26 08:20:56.000000000","message":"Done","commit_id":"11bb46ad9f0e8eb56d75742d8df47704445b8932"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b6001d5f2ad054f1ae03cc9f51041e181b9b1c41","unresolved":true,"context_lines":[{"line_number":697,"context_line":"                      delegate_to: localhost"},{"line_number":698,"context_line":"                      run_once: true"},{"line_number":699,"context_line":"                      debug:"},{"line_number":700,"context_line":"                        msg: Use --start-at-task \u0027Overcloud common bootstrap tasks\u0027 to resume from this task"},{"line_number":701,"context_line":"                    - name: Write config data"},{"line_number":702,"context_line":"                      include_tasks: common_container_setup_tasks.yaml"},{"line_number":703,"context_line":"                      when:"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"35885c71_f5534b2e","line":700,"range":{"start_line":700,"start_character":67,"end_line":700,"end_character":76},"updated":"2021-03-26 13:16:13.000000000","message":"let\u0027s replace \"bootstrap\" with \"container setup\".  We have bootstrap stuff that runs in host prep","commit_id":"ecd9e3ba964616a21befe10fc3bf9e567d234504"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"3a202c18c3747343d1d35a3887ca1f782f9e1763","unresolved":true,"context_lines":[{"line_number":697,"context_line":"                      delegate_to: localhost"},{"line_number":698,"context_line":"                      run_once: true"},{"line_number":699,"context_line":"                      debug:"},{"line_number":700,"context_line":"                        msg: Use --start-at-task \u0027Overcloud common bootstrap tasks\u0027 to resume from this task"},{"line_number":701,"context_line":"                    - name: Write config data"},{"line_number":702,"context_line":"                      include_tasks: common_container_setup_tasks.yaml"},{"line_number":703,"context_line":"                      when:"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3e9d7ca0_fa7a3d5a","line":700,"range":{"start_line":700,"start_character":67,"end_line":700,"end_character":76},"in_reply_to":"35885c71_f5534b2e","updated":"2021-03-26 13:58:17.000000000","message":"Ah yes absolutely. Thanks","commit_id":"ecd9e3ba964616a21befe10fc3bf9e567d234504"}]}