)]}'
{"deployment/swift/swift-ringbuilder-container-puppet.yaml":[{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"144972896725359ba337e9a7d16af58d1e3b41ef","unresolved":true,"context_lines":[{"line_number":111,"context_line":"                    - repeat:"},{"line_number":112,"context_line":"                        template: \u0027:%PORT%/DEVICE\u0027"},{"line_number":113,"context_line":"                        for_each:"},{"line_number":114,"context_line":"                          DEVICE: \"%{hiera(\u0027swift::storage::disks::args\u0027)}\""},{"line_number":115,"context_line":"            - tripleo::profile::base::swift::ringbuilder::raw_disks:"},{"line_number":116,"context_line":"                yaql:"},{"line_number":117,"context_line":"                  expression: $.data.raw_disk_lists.flatten()"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"dbbfc5e2_e616933b","line":114,"updated":"2021-03-20 17:41:57.000000000","message":"I\u0027m not sure we can do this here ... can we ?","commit_id":"d1991d0187dd0faed649ff422c2f0e390f18d389"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"10de7a2620bab452737bbca0ef4fd1a65c622ce4","unresolved":true,"context_lines":[{"line_number":101,"context_line":"            tripleo::profile::base::swift::ringbuilder::raw_disk_prefix: \u0027r1z1-\u0027"},{"line_number":102,"context_line":"          -"},{"line_number":103,"context_line":"            if:"},{"line_number":104,"context_line":"            - use_node_data_lookup"},{"line_number":105,"context_line":"            - {}"},{"line_number":106,"context_line":"            - tripleo::profile::base::swift::ringbuilder::raw_disks:"},{"line_number":107,"context_line":"                yaql:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"0b2e581c_a2c1ccd8","line":104,"range":{"start_line":104,"start_character":14,"end_line":104,"end_character":34},"updated":"2021-03-22 16:44:00.000000000","message":"for Heat performance sakes, it\u0027s better to use {get_param: SwiftUseNodeDataLookup} directly","commit_id":"ec7f38e2e5b48ead2facc256a7b4ead426de4f22"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"42330781adf28449e6bb377054db0108cde51aca","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            tripleo::profile::base::swift::ringbuilder::raw_disk_prefix: \u0027r1z1-\u0027"},{"line_number":102,"context_line":"          -"},{"line_number":103,"context_line":"            if:"},{"line_number":104,"context_line":"            - use_node_data_lookup"},{"line_number":105,"context_line":"            - {}"},{"line_number":106,"context_line":"            - tripleo::profile::base::swift::ringbuilder::raw_disks:"},{"line_number":107,"context_line":"                yaql:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"d21c9c07_e7164446","line":104,"range":{"start_line":104,"start_character":14,"end_line":104,"end_character":34},"in_reply_to":"0b2e581c_a2c1ccd8","updated":"2021-03-26 14:15:12.000000000","message":"Changed.","commit_id":"ec7f38e2e5b48ead2facc256a7b4ead426de4f22"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2335fdc6b5c5faaf9e68b68e3960393b2af2c8d2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"heat_template_version: rocky"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  OpenStack Swift Ringbuilder"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"2e3f7602_0a623bec","line":1,"range":{"start_line":1,"start_character":23,"end_line":1,"end_character":28},"updated":"2021-04-06 11:00:54.000000000","message":"wallaby","commit_id":"d0840392231996cacfcf59d20d7fc951d3a5be20"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"78a90ddda85221128182194b8a27311a1ce6da67","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: rocky"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  OpenStack Swift Ringbuilder"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"ea29e1fc_010794cf","line":1,"range":{"start_line":1,"start_character":23,"end_line":1,"end_character":28},"in_reply_to":"2e3f7602_0a623bec","updated":"2021-04-06 13:49:51.000000000","message":"Ack","commit_id":"d0840392231996cacfcf59d20d7fc951d3a5be20"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2335fdc6b5c5faaf9e68b68e3960393b2af2c8d2","unresolved":true,"context_lines":[{"line_number":101,"context_line":"          -"},{"line_number":102,"context_line":"            if:"},{"line_number":103,"context_line":"            - {get_param: SwiftUseNodeDataLookup}"},{"line_number":104,"context_line":"            - {}"},{"line_number":105,"context_line":"            - tripleo::profile::base::swift::ringbuilder::raw_disks:"},{"line_number":106,"context_line":"                yaql:"},{"line_number":107,"context_line":"                  expression: $.data.raw_disk_lists.flatten()"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"57e50fa3_5bb24209","line":104,"range":{"start_line":104,"start_character":14,"end_line":104,"end_character":16},"updated":"2021-04-06 11:00:54.000000000","message":"Not required, \u0027if\u0027 can be moved up to remove that blank line.","commit_id":"d0840392231996cacfcf59d20d7fc951d3a5be20"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"78a90ddda85221128182194b8a27311a1ce6da67","unresolved":false,"context_lines":[{"line_number":101,"context_line":"          -"},{"line_number":102,"context_line":"            if:"},{"line_number":103,"context_line":"            - {get_param: SwiftUseNodeDataLookup}"},{"line_number":104,"context_line":"            - {}"},{"line_number":105,"context_line":"            - tripleo::profile::base::swift::ringbuilder::raw_disks:"},{"line_number":106,"context_line":"                yaql:"},{"line_number":107,"context_line":"                  expression: $.data.raw_disk_lists.flatten()"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"cf61c2b3_2b362963","line":104,"range":{"start_line":104,"start_character":14,"end_line":104,"end_character":16},"in_reply_to":"57e50fa3_5bb24209","updated":"2021-04-06 13:49:51.000000000","message":"Ack","commit_id":"d0840392231996cacfcf59d20d7fc951d3a5be20"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2335fdc6b5c5faaf9e68b68e3960393b2af2c8d2","unresolved":true,"context_lines":[{"line_number":103,"context_line":"            - {get_param: SwiftUseNodeDataLookup}"},{"line_number":104,"context_line":"            - {}"},{"line_number":105,"context_line":"            - tripleo::profile::base::swift::ringbuilder::raw_disks:"},{"line_number":106,"context_line":"                yaql:"},{"line_number":107,"context_line":"                  expression: $.data.raw_disk_lists.flatten()"},{"line_number":108,"context_line":"                  data:"},{"line_number":109,"context_line":"                    raw_disk_lists:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"d4122d9d_6d926165","line":106,"range":{"start_line":106,"start_character":16,"end_line":106,"end_character":20},"updated":"2021-04-06 11:00:54.000000000","message":"Can we not use yaql as I think we can manage with list_concat here?\n\n  if:\n    - not: {get_param: SwiftUseNodeDataLookup}\n    - tripleo::profile::base::swift::ringbuilder::raw_disks:\n        list_concat:\n          - if:\n              - swift_use_local_dir\n              - - \u0027:%PORT%/d1\u0027\n          - repeat:\n              ....","commit_id":"d0840392231996cacfcf59d20d7fc951d3a5be20"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"78a90ddda85221128182194b8a27311a1ce6da67","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            - {get_param: SwiftUseNodeDataLookup}"},{"line_number":104,"context_line":"            - {}"},{"line_number":105,"context_line":"            - tripleo::profile::base::swift::ringbuilder::raw_disks:"},{"line_number":106,"context_line":"                yaql:"},{"line_number":107,"context_line":"                  expression: $.data.raw_disk_lists.flatten()"},{"line_number":108,"context_line":"                  data:"},{"line_number":109,"context_line":"                    raw_disk_lists:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"a1576416_fb0e204e","line":106,"range":{"start_line":106,"start_character":16,"end_line":106,"end_character":20},"in_reply_to":"d4122d9d_6d926165","updated":"2021-04-06 13:49:51.000000000","message":"Ack","commit_id":"d0840392231996cacfcf59d20d7fc951d3a5be20"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"7bf2d8386152a9bb35ed6e5187ed9f914cdf654e","unresolved":true,"context_lines":[{"line_number":100,"context_line":"            tripleo::profile::base::swift::ringbuilder::raw_disk_prefix: \u0027r1z1-\u0027"},{"line_number":101,"context_line":"          - if:"},{"line_number":102,"context_line":"            - {get_param: SwiftUseNodeDataLookup}"},{"line_number":103,"context_line":"            - {}"},{"line_number":104,"context_line":"            - tripleo::profile::base::swift::ringbuilder::raw_disks:"},{"line_number":105,"context_line":"                list_concat:"},{"line_number":106,"context_line":"                    - if:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"50594dc0_3761395f","line":103,"range":{"start_line":103,"start_character":14,"end_line":103,"end_character":16},"updated":"2021-04-07 03:53:47.000000000","message":"you could have avoid this too as mentioned in my earlier comment.","commit_id":"57add501a4f66be788f0267f9422c98a0228c14e"}],"deployment/swift/swift-storage-container-puppet.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2335fdc6b5c5faaf9e68b68e3960393b2af2c8d2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"heat_template_version: rocky"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  OpenStack containerized Swift Storage services."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"a866a82f_3e6a42e6","line":1,"range":{"start_line":1,"start_character":23,"end_line":1,"end_character":28},"updated":"2021-04-06 11:00:54.000000000","message":"same","commit_id":"d0840392231996cacfcf59d20d7fc951d3a5be20"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2335fdc6b5c5faaf9e68b68e3960393b2af2c8d2","unresolved":true,"context_lines":[{"line_number":174,"context_line":"          -"},{"line_number":175,"context_line":"            if:"},{"line_number":176,"context_line":"            - use_node_data_lookup"},{"line_number":177,"context_line":"            - {}"},{"line_number":178,"context_line":"            - swift::storage::disks::args: {get_param: SwiftRawDisks}"},{"line_number":179,"context_line":"          - swift::storage::all::storage_local_net_ip:"},{"line_number":180,"context_line":"              str_replace:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"c1f7f93a_de0b49de","line":177,"range":{"start_line":177,"start_character":14,"end_line":177,"end_character":16},"updated":"2021-04-06 11:00:54.000000000","message":"You can use the 2 argument if condition with wallaby template.","commit_id":"d0840392231996cacfcf59d20d7fc951d3a5be20"}],"puppet/extraconfig/pre_deploy/per_node.yaml":[{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"7c014bba1986041635b80348ed58cc7ff5071742","unresolved":true,"context_lines":[{"line_number":68,"context_line":"            cnt \u003d ast.literal_eval(input)"},{"line_number":69,"context_line":"        print(json.dumps(cnt.get(\u0027${node_id_upper}\u0027, {})))"},{"line_number":70,"context_line":"        \" \u003e /etc/puppet/hieradata/${node_id_upper}.json"},{"line_number":71,"context_line":"        echo \"- ${node_id_upper}\" \u003e\u003e /etc/puppet/hiera.yaml"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  NodeSpecificDeployment:"},{"line_number":74,"context_line":"    type: OS::Heat::SoftwareDeployment"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"82e377ae_999612ae","line":71,"updated":"2021-03-21 20:53:18.000000000","message":"This shouldn\u0027t be needed but somehow \u0027\"%{::uuid}\"\u0027 doesn\u0027t appear to be working.","commit_id":"fce124af80aa4c103febc25d7ff8a832d9c626ee"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"eb3f1ad0eab6e5004894f1d804173290e6d3388b","unresolved":true,"context_lines":[{"line_number":55,"context_line":"            cnt \u003d ast.literal_eval(input)"},{"line_number":56,"context_line":"        print(json.dumps(cnt.get(\u0027${node_id}\u0027, {})))"},{"line_number":57,"context_line":"        \" \u003e /etc/puppet/hieradata/${node_id}.json"},{"line_number":58,"context_line":"        echo \"- ${node_id}\" \u003e\u003e /etc/puppet/hiera.yaml"},{"line_number":59,"context_line":"        # handle upper case node id LP#1816652"},{"line_number":60,"context_line":"        echo $node_lookup | $(get_python) -c \""},{"line_number":61,"context_line":"        import ast"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"b59e6685_c72e914d","line":58,"updated":"2021-03-22 16:45:28.000000000","message":"is this idempotent?","commit_id":"ec7f38e2e5b48ead2facc256a7b4ead426de4f22"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"42330781adf28449e6bb377054db0108cde51aca","unresolved":true,"context_lines":[{"line_number":55,"context_line":"            cnt \u003d ast.literal_eval(input)"},{"line_number":56,"context_line":"        print(json.dumps(cnt.get(\u0027${node_id}\u0027, {})))"},{"line_number":57,"context_line":"        \" \u003e /etc/puppet/hieradata/${node_id}.json"},{"line_number":58,"context_line":"        echo \"- ${node_id}\" \u003e\u003e /etc/puppet/hiera.yaml"},{"line_number":59,"context_line":"        # handle upper case node id LP#1816652"},{"line_number":60,"context_line":"        echo $node_lookup | $(get_python) -c \""},{"line_number":61,"context_line":"        import ast"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"0d42bd11_f4245722","line":58,"in_reply_to":"b59e6685_c72e914d","updated":"2021-03-26 14:15:12.000000000","message":"It works only once when deploying and after it\u0027s removed ... I don\u0027t like this line but I did that just to get passed through the initial issue I had.   /etc/puppet/hiera.yaml contains \"- ${::uuid}\" which seems to be sourcing the file already in place but for some reasons, in all my deployments, I\u0027ve never seen this to actually work.","commit_id":"ec7f38e2e5b48ead2facc256a7b4ead426de4f22"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2335fdc6b5c5faaf9e68b68e3960393b2af2c8d2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"heat_template_version: rocky"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Configure hieradata overrides for specific nodes"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"acb70c9e_2c062f25","line":1,"range":{"start_line":1,"start_character":23,"end_line":1,"end_character":28},"updated":"2021-04-06 11:00:54.000000000","message":"same","commit_id":"d0840392231996cacfcf59d20d7fc951d3a5be20"}]}