)]}'
{"deployment/frr/frr-container-ansible.yaml":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"ddb2dcde9cf5731dda8790d06f424efb1045cd09","unresolved":true,"context_lines":[{"line_number":233,"context_line":"                tripleo_container_manage_config_id: \"frr\""},{"line_number":234,"context_line":"                tripleo_container_manage_config_patterns: \"frr.json\""},{"line_number":235,"context_line":"                tripleo_container_manage_systemd_order: true"},{"line_number":236,"context_line":"                tripleo_container_manage_clean_orphans: false"},{"line_number":237,"context_line":"      update_tasks: []"},{"line_number":238,"context_line":"      upgrade_tasks: []"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"585ea9a5_65233e41","line":236,"updated":"2021-03-24 12:19:06.000000000","message":"Nice catch!","commit_id":"c61c563d25ffd2b72ff035f98b528c404a14c332"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"3aad6b80ad71d3a0be48053341fb31201fcd6ff9","unresolved":true,"context_lines":[{"line_number":205,"context_line":"        # Frr is special because it needs to be up before we try any tasks that need to reach nodes"},{"line_number":206,"context_line":"        # via the network  That is why we need to duplicate the podman setup steps"},{"line_number":207,"context_line":"        - name: Configure and start FRR before an HA service"},{"line_number":208,"context_line":"          block:"},{"line_number":209,"context_line":"            - name: Configure FRR"},{"line_number":210,"context_line":"              import_role:"},{"line_number":211,"context_line":"                name: tripleo_frr"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"4b7bea1c_16ce22f1","line":208,"range":{"start_line":208,"start_character":0,"end_line":208,"end_character":10},"updated":"2021-04-01 10:14:23.000000000","message":"nit: just if you happen to respin this patch, the block could be dropped","commit_id":"4eda9146933b7b653aa8dcf12bc42aeb38a1bea8"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"3aad6b80ad71d3a0be48053341fb31201fcd6ff9","unresolved":true,"context_lines":[{"line_number":233,"context_line":"                tripleo_container_manage_config_id: \"frr\""},{"line_number":234,"context_line":"                tripleo_container_manage_config_patterns: \"frr.json\""},{"line_number":235,"context_line":"                tripleo_container_manage_systemd_order: true"},{"line_number":236,"context_line":"                tripleo_container_manage_clean_orphans: false"},{"line_number":237,"context_line":"      update_tasks: []"},{"line_number":238,"context_line":"      upgrade_tasks: []"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"a1e63558_ac659437","line":236,"updated":"2021-04-01 10:14:23.000000000","message":"We confirmed this was not in fact needed, right?","commit_id":"4eda9146933b7b653aa8dcf12bc42aeb38a1bea8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3a9f9440380653c2cd4b205396c3a7b6df3423d4","unresolved":true,"context_lines":[{"line_number":222,"context_line":"            tripleo_frr_zebra: {get_param: FrrZebraEnabled}"},{"line_number":223,"context_line":"        - name: Start FRR"},{"line_number":224,"context_line":"          include_role:"},{"line_number":225,"context_line":"            name: tripleo_container_manage"},{"line_number":226,"context_line":"          vars:"},{"line_number":227,"context_line":"            tripleo_container_manage_config: \"/var/lib/tripleo-config/container-startup-config/step_0\""},{"line_number":228,"context_line":"            tripleo_container_manage_config_id: \"frr\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7c679e01_505c59ed","line":225,"updated":"2021-04-07 18:41:31.000000000","message":"So bad news is that this won\u0027t work on the undercloud if frr is deployed with push_destination: true. We don\u0027t run container image prepare until external deploy step task 1 so the container is unavailable until then","commit_id":"79ddf2f8799c1aef8eaf766516bc24996872e057"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"5365256ffefbcf46a7e681ba404e4e944742dc50","unresolved":true,"context_lines":[{"line_number":222,"context_line":"            tripleo_frr_zebra: {get_param: FrrZebraEnabled}"},{"line_number":223,"context_line":"        - name: Start FRR"},{"line_number":224,"context_line":"          include_role:"},{"line_number":225,"context_line":"            name: tripleo_container_manage"},{"line_number":226,"context_line":"          vars:"},{"line_number":227,"context_line":"            tripleo_container_manage_config: \"/var/lib/tripleo-config/container-startup-config/step_0\""},{"line_number":228,"context_line":"            tripleo_container_manage_config_id: \"frr\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"015a3b76_060876fb","line":225,"in_reply_to":"7c679e01_505c59ed","updated":"2021-04-08 12:09:19.000000000","message":"Ack thanks Alex. If this becomes an issue, we\u0027ll come up with some documented workaround (hopefully it is doable)","commit_id":"79ddf2f8799c1aef8eaf766516bc24996872e057"}]}