)]}'
{"deployment/cephadm/ceph-osd.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"17735526c6c4e40fd39770b90f856f98e6cb8b1e","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    type: boolean"},{"line_number":42,"context_line":"    default: false"},{"line_number":43,"context_line":"    description: Parameter used to trigger the dashboard deployment."},{"line_number":44,"context_line":"  CephOsdCount:"},{"line_number":45,"context_line":"    type: number"},{"line_number":46,"context_line":"    default: 0"},{"line_number":47,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"20226376_cd7c238f","line":44,"updated":"2021-03-29 17:01:12.000000000","message":"My understanding is the CephOsdCount and CephOsdType parameters are only used by the HCI derived parameters feature. I don\u0027t know of something could be added to the parameter names (even just \u0027Hci\u0027). Otherwise, is there a risk the user will feel they must provide valid values? For example, I think you could set CephOsdCount to a wacky number, and nothing would happen unless it\u0027s an HCI deployment and you ask it to derive the HCI parameters.\n\nAlso, are HCI nodes required to be homogeneous? Or do these need to be role dependent?","commit_id":"7c427bb09434c0c9a97d9f4321ded3a2c5328996"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"43511e78dd39df434abe67c5e81b5ffda84ae9fb","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    type: boolean"},{"line_number":42,"context_line":"    default: false"},{"line_number":43,"context_line":"    description: Parameter used to trigger the dashboard deployment."},{"line_number":44,"context_line":"  CephOsdCount:"},{"line_number":45,"context_line":"    type: number"},{"line_number":46,"context_line":"    default: 0"},{"line_number":47,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bc4c0399_17b17636","line":44,"in_reply_to":"20226376_cd7c238f","updated":"2021-05-03 20:32:59.000000000","message":"I\u0027ve changed the name to CephHciOsdCount and CephHciOsdType as suggested.\nHCI nodes can be role dependent.\nI have a lot to clean up on the depends-on patch.","commit_id":"7c427bb09434c0c9a97d9f4321ded3a2c5328996"}]}