)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"24f1ffaa5872b2d91e71d8326d5d5506b14e97ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a6695794_64b0e845","updated":"2023-05-09 17:59:27.000000000","message":"Wanted to note that I agree with abandoning this. We will address this differently in the future, which will not require the use of collectd.","commit_id":"eaf9ebc1ba54f297df2fcafd911cbedea1e4c594"}],"environments/metrics/collectd-read-rabbitmq.yaml":[{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"5802e46b74154a3046b046e718eeceecb2690cb3","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"parameter_defaults:"},{"line_number":6,"context_line":"  ControllerExtraConfig:"},{"line_number":7,"context_line":"    rabbitmq::management_ip_address: \"%{hiera(\u0027rabbitmq::interface\u0027)}\""},{"line_number":8,"context_line":"    tripleo::profile::base::metrics::collectd::python_read_plugins:"},{"line_number":9,"context_line":"      - python-collectd-rabbitmq"},{"line_number":10,"context_line":"    collectd::plugin::python::modules:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1edea0af_43a959b0","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":70},"updated":"2021-05-06 12:19:07.000000000","message":"I think this should be added by rabbitmq deployer instead.\nMaybe setting `RabbitmqEnableManagementAccess: true` will change the ip to the proper interface. [1]\n\n[1] - https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/rabbitmq/rabbitmq-container-puppet.yaml#L224","commit_id":"eaf9ebc1ba54f297df2fcafd911cbedea1e4c594"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"3d6514b0a93b4ad22760947dfe982ae275c94f6c","unresolved":true,"context_lines":[{"line_number":11,"context_line":"      collectd_rabbitmq_monitoring:"},{"line_number":12,"context_line":"        config:"},{"line_number":13,"context_line":"          - host: \"%{hiera(\u0027rabbitmq::interface\u0027)}\""},{"line_number":14,"context_line":"            port: 15672"},{"line_number":15,"context_line":"            username: \"%{hiera(\u0027rabbitmq::default_user\u0027)}\""},{"line_number":16,"context_line":"            password: \"%{hiera(\u0027rabbitmq::default_pass\u0027)}\""},{"line_number":17,"context_line":"            interval: 30"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e0358cac_6bf64e48","line":14,"updated":"2021-03-24 17:47:23.000000000","message":"I think it would be more proper to use `rabbitmq::management_port` here in case it ever changes or becomes a supported config value in tripleo\n\nhttps://github.com/voxpupuli/puppet-rabbitmq/blob/7f806ac6983ec8d087a2c9e86b4e1467198d6981/data/common.yaml#L22","commit_id":"eaf9ebc1ba54f297df2fcafd911cbedea1e4c594"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"da0605878095f5b25a9c30fc87ba85e357919525","unresolved":true,"context_lines":[{"line_number":11,"context_line":"      collectd_rabbitmq_monitoring:"},{"line_number":12,"context_line":"        config:"},{"line_number":13,"context_line":"          - host: \"%{hiera(\u0027rabbitmq::interface\u0027)}\""},{"line_number":14,"context_line":"            port: 15672"},{"line_number":15,"context_line":"            username: \"%{hiera(\u0027rabbitmq::default_user\u0027)}\""},{"line_number":16,"context_line":"            password: \"%{hiera(\u0027rabbitmq::default_pass\u0027)}\""},{"line_number":17,"context_line":"            interval: 30"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"81d407e8_2a62369c","line":14,"in_reply_to":"347c5c21_bf288234","updated":"2021-03-24 18:31:48.000000000","message":"\"Is there a simple way to run a hiera lookup\" - There is the \"puppet-lookup\" command line tool; not sure if it includes the data from tripleo modules by default? I figure it\u0027s equally likely that your test was a typo and that I\u0027m terribly misunderstanding this (all my work was done migrating from puppet to ansible, so not that deep in the puppet).","commit_id":"eaf9ebc1ba54f297df2fcafd911cbedea1e4c594"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"cd2a9097bdcb0b77053c039c662763ec33d2d612","unresolved":true,"context_lines":[{"line_number":11,"context_line":"      collectd_rabbitmq_monitoring:"},{"line_number":12,"context_line":"        config:"},{"line_number":13,"context_line":"          - host: \"%{hiera(\u0027rabbitmq::interface\u0027)}\""},{"line_number":14,"context_line":"            port: 15672"},{"line_number":15,"context_line":"            username: \"%{hiera(\u0027rabbitmq::default_user\u0027)}\""},{"line_number":16,"context_line":"            password: \"%{hiera(\u0027rabbitmq::default_pass\u0027)}\""},{"line_number":17,"context_line":"            interval: 30"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5e59b6b3_8fe4f6f9","line":14,"in_reply_to":"3706fd41_5b0f88dd","updated":"2021-03-24 18:06:52.000000000","message":"Oh, that\u0027s surprising!\n\nThey don\u0027t bubble up to TripleO, the literal string \"%{hiera(\u0027rabbitmq::interface\u0027)}\" ends up being passed down to puppet and it renders it based on the hieradata on the host. My understanding was hieradata set in the puppet code could also be used, but maybe I\u0027m wrong and  only values set by THT end up in the hieradata somehow. If it doesn\u0027t work it doesn\u0027t work I guess; only other option would be adding it here: https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/rabbitmq/rabbitmq-container-puppet.yaml#L151 \n\nMy other concern is the firewall - is it turned on in your test environment? I don\u0027t have one handy to recall if it would block localhost connections, but this port is not listed in the ruleset.","commit_id":"eaf9ebc1ba54f297df2fcafd911cbedea1e4c594"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"4a7c0aa15fe525065ccc498bb0afdf8e7cfddcf2","unresolved":true,"context_lines":[{"line_number":11,"context_line":"      collectd_rabbitmq_monitoring:"},{"line_number":12,"context_line":"        config:"},{"line_number":13,"context_line":"          - host: \"%{hiera(\u0027rabbitmq::interface\u0027)}\""},{"line_number":14,"context_line":"            port: 15672"},{"line_number":15,"context_line":"            username: \"%{hiera(\u0027rabbitmq::default_user\u0027)}\""},{"line_number":16,"context_line":"            password: \"%{hiera(\u0027rabbitmq::default_pass\u0027)}\""},{"line_number":17,"context_line":"            interval: 30"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"347c5c21_bf288234","line":14,"in_reply_to":"5e59b6b3_8fe4f6f9","updated":"2021-03-24 18:12:40.000000000","message":"Yea I tested this and results in a metric returned like:\n\ncollectd_rabbitmq_monitoring_gauge{endpoint\u003d\"prom-http\",host\u003d\"controller-0.osp-cloudops-04\",plugin_instance\u003d\"base\",service\u003d\"default-cops04-coll-meter-smartgateway\",type_instance\u003d\"channels\"}\n\nAs far as I can tell the management interface is available to other containers, but not to the host itself, or to other hosts?\n\nI had also been thinking about just setting a default in the deployment and such, but I guess I was trying to resolve this as simply as possible.\n\nI think I will try another overcloud update and see if that rabbitmq::management_port works. Possibly I just had a typo or something when I last tested it.\n\nIs there a simple way to run a hiera lookup without running the overcloud deploy to see if a value would actually be returned?","commit_id":"eaf9ebc1ba54f297df2fcafd911cbedea1e4c594"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"5802e46b74154a3046b046e718eeceecb2690cb3","unresolved":true,"context_lines":[{"line_number":11,"context_line":"      collectd_rabbitmq_monitoring:"},{"line_number":12,"context_line":"        config:"},{"line_number":13,"context_line":"          - host: \"%{hiera(\u0027rabbitmq::interface\u0027)}\""},{"line_number":14,"context_line":"            port: 15672"},{"line_number":15,"context_line":"            username: \"%{hiera(\u0027rabbitmq::default_user\u0027)}\""},{"line_number":16,"context_line":"            password: \"%{hiera(\u0027rabbitmq::default_pass\u0027)}\""},{"line_number":17,"context_line":"            interval: 30"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dbeb9ac3_6e2e0aaf","line":14,"in_reply_to":"81d407e8_2a62369c","updated":"2021-05-06 12:19:07.000000000","message":"I agree with Chriss here. I think this should be something like\n\"%{hiera(\u0027rabbitmq::management_port\u0027)}\"","commit_id":"eaf9ebc1ba54f297df2fcafd911cbedea1e4c594"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"09070e8de292a44c58a7548d6e180fc8796ef23e","unresolved":true,"context_lines":[{"line_number":11,"context_line":"      collectd_rabbitmq_monitoring:"},{"line_number":12,"context_line":"        config:"},{"line_number":13,"context_line":"          - host: \"%{hiera(\u0027rabbitmq::interface\u0027)}\""},{"line_number":14,"context_line":"            port: 15672"},{"line_number":15,"context_line":"            username: \"%{hiera(\u0027rabbitmq::default_user\u0027)}\""},{"line_number":16,"context_line":"            password: \"%{hiera(\u0027rabbitmq::default_pass\u0027)}\""},{"line_number":17,"context_line":"            interval: 30"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3706fd41_5b0f88dd","line":14,"in_reply_to":"e0358cac_6bf64e48","updated":"2021-03-24 17:56:01.000000000","message":"I actually tested that, but for some reason that value was not populated and resulted in an empty string. I\u0027m still not exactly sure how this bubbles up to TripleO, or if it does if those values are only available in the puppet code.","commit_id":"eaf9ebc1ba54f297df2fcafd911cbedea1e4c594"}]}