)]}'
{"common/deploy-steps.j2":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6d4417ee39fd80166dbad1321f3d9d32dacbe96e","unresolved":true,"context_lines":[{"line_number":264,"context_line":"          expression: coalesce($.data, []).flatten().distinct()"},{"line_number":265,"context_line":"          data:"},{"line_number":266,"context_line":"          {%- for role in enabled_roles %}"},{"line_number":267,"context_line":"            - get_param: [role_data, {{role.name}}, post_container_setup_tasks]"},{"line_number":268,"context_line":"          {%- endfor %}"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"  ExternalDeployTasks:"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"c8d5e6ec_beb6aac1","line":267,"range":{"start_line":267,"start_character":52,"end_line":267,"end_character":78},"updated":"2021-03-24 16:30:35.000000000","message":"Let\u0027s call this post_host_prep_tasks or pre_deploy_step_tasks.  I think the latter might be preferred.","commit_id":"83560196224f28babb8ad24666aaf478cffd626d"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"6e6d92fa90deaf1f72d177b136eb5ba9fa98dc76","unresolved":true,"context_lines":[{"line_number":717,"context_line":""},{"line_number":718,"context_line":"            - hosts: {{primary_role_name}}:DEPLOY_TARGET_HOST"},{"line_number":719,"context_line":"              strategy: tripleo_free"},{"line_number":720,"context_line":"              name: Post Container Setup Deployment Tasks"},{"line_number":721,"context_line":"              become: true"},{"line_number":722,"context_line":"              gather_facts: \"{% raw %}{{ gather_facts | default(false) }}{% endraw %}\""},{"line_number":723,"context_line":"              any_errors_fatal: yes"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bb37268a_02470623","line":720,"updated":"2021-03-24 12:15:41.000000000","message":"IIUC the intent here is to be able to hook tasks that run after overcloud common bootstrap tasks. I am not totally convinced on the naming of this playbook, though I don\u0027t have a strong objection to it being name as proposed either.\n\nToday, common bootstrap tasks are mostly container related but are not limited to. There is also a somewhat convention that post_* task playbooks are named after certain playbooks (e.g. post_deploy_steps, post_update_steps_tasks, external_post_deploy_steps_tasks, etc).\n\nAn alternative name could be post_overcloud_common_bootstrap_tasks which is, admittedly, mouthful. I\u0027m fine with it as is, just wanted to raise this for awareness and potential discussion should there be a need to.","commit_id":"83560196224f28babb8ad24666aaf478cffd626d"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"6e6d92fa90deaf1f72d177b136eb5ba9fa98dc76","unresolved":true,"context_lines":[{"line_number":746,"context_line":"                        msg: Use --start-at-task \u0027{{role.name}} Post Container Setup Tasks\u0027 to resume from this task"},{"line_number":747,"context_line":"                    - include_tasks: {{role.name}}/post_container_setup_tasks.yaml"},{"line_number":748,"context_line":"{%- endfor %}"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"{%- for step in range(1,deploy_steps_max) %}"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"            - hosts: DEPLOY_SOURCE_HOST"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9734d2e7_0386fd02","line":749,"updated":"2021-03-24 12:15:41.000000000","message":"Tags here as well?","commit_id":"83560196224f28babb8ad24666aaf478cffd626d"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"6e6d92fa90deaf1f72d177b136eb5ba9fa98dc76","unresolved":true,"context_lines":[{"line_number":932,"context_line":"                - import_tasks: deploy_steps_tasks_step_0.yaml"},{"line_number":933,"context_line":"                  vars:"},{"line_number":934,"context_line":"                    step: 0"},{"line_number":935,"context_line":"                - name: Write config data at the start of step 1"},{"line_number":936,"context_line":"                  import_tasks: common_deploy_steps_tasks_step_1.yaml"},{"line_number":937,"context_line":"{%- for step in range(1,deploy_steps_max) %}"},{"line_number":938,"context_line":"                - import_tasks: common_deploy_steps_tasks.yaml"},{"line_number":939,"context_line":"                  vars:"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"442463f4_cb1d0551","line":936,"range":{"start_line":935,"start_character":16,"end_line":936,"end_character":69},"updated":"2021-03-24 12:15:41.000000000","message":"This is the equivalent of the \"Overcloud common bootstrap tasks playbook being proposed in https://review.opendev.org/c/openstack/tripleo-heat-templates/+/781963. Should post_container_setup_tasks.yaml be added after this task?","commit_id":"83560196224f28babb8ad24666aaf478cffd626d"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"eb9ef4321832003fa3962045996ada2b2da8b098","unresolved":true,"context_lines":[{"line_number":737,"context_line":"                docker_puppet_process_count: DOCKER_PUPPET_PROCESS_COUNT"},{"line_number":738,"context_line":"                docker_puppet_mount_host_puppet: DOCKER_PUPPET_MOUNT_HOST_PUPPET"},{"line_number":739,"context_line":"              tasks:"},{"line_number":740,"context_line":"{%- for role in roles %}"},{"line_number":741,"context_line":"                - name: {{role.name}} Pre Deployment Step Tasks"},{"line_number":742,"context_line":"                  delegate_to: localhost"},{"line_number":743,"context_line":"                  run_once: true"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7dcccc4d_4602b795","line":740,"updated":"2021-03-31 13:01:00.000000000","message":"I probably want to use a block here, although in the previous patchset when I was using a block I was hitting some rather odd ansible behaviour (i.e. some nodes would just get skipped)","commit_id":"c5819681075716b6297b07b4cde3b54e8b581156"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d6fe7d68ba625b4e541954272db5c99ce692bf8b","unresolved":true,"context_lines":[{"line_number":742,"context_line":"                  delegate_to: localhost"},{"line_number":743,"context_line":"                  run_once: true"},{"line_number":744,"context_line":"                  debug:"},{"line_number":745,"context_line":"                    msg: Use --start-at-task \u0027{{role.name}} Pre Deployment Step Tasks\u0027 to resume from this task"},{"line_number":746,"context_line":"                - name: {{role.name}} Pre Deployment Step Tasks block"},{"line_number":747,"context_line":"                  include_tasks: {{role.name}}/pre_deploy_step_tasks.yaml"},{"line_number":748,"context_line":"                  when:"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"c6363b88_18ca4fd9","line":745,"updated":"2021-03-31 13:21:05.000000000","message":"Don\u0027t put this in the loop. This should just be --start-at-task \u0027Pre Deployment Steps Tasks\u0027.  We want be able to start at this overall stop but not at a specific role\u0027s","commit_id":"c5819681075716b6297b07b4cde3b54e8b581156"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"deee560bea99ec91a9c7ddf576d1982f15584aa8","unresolved":true,"context_lines":[{"line_number":742,"context_line":"                  delegate_to: localhost"},{"line_number":743,"context_line":"                  run_once: true"},{"line_number":744,"context_line":"                  debug:"},{"line_number":745,"context_line":"                    msg: Use --start-at-task \u0027{{role.name}} Pre Deployment Step Tasks\u0027 to resume from this task"},{"line_number":746,"context_line":"                - name: {{role.name}} Pre Deployment Step Tasks block"},{"line_number":747,"context_line":"                  include_tasks: {{role.name}}/pre_deploy_step_tasks.yaml"},{"line_number":748,"context_line":"                  when:"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"4c3f9247_b7eb3444","line":745,"in_reply_to":"c6363b88_18ca4fd9","updated":"2021-03-31 14:13:42.000000000","message":"Ah, ok yeah makes sense","commit_id":"c5819681075716b6297b07b4cde3b54e8b581156"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d6fe7d68ba625b4e541954272db5c99ce692bf8b","unresolved":true,"context_lines":[{"line_number":746,"context_line":"                - name: {{role.name}} Pre Deployment Step Tasks block"},{"line_number":747,"context_line":"                  include_tasks: {{role.name}}/pre_deploy_step_tasks.yaml"},{"line_number":748,"context_line":"                  when:"},{"line_number":749,"context_line":"                    - \"\u0027{{role.name}}/pre_deploy_step_tasks.yaml\u0027 is exists\""},{"line_number":750,"context_line":"{%- endfor %}"},{"line_number":751,"context_line":"              tags:"},{"line_number":752,"context_line":"                - overcloud"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7282f29f_09e8383e","line":749,"updated":"2021-03-31 13:21:05.000000000","message":"This should have when condition for - tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027 otherwise this could run on all nodes","commit_id":"c5819681075716b6297b07b4cde3b54e8b581156"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"deee560bea99ec91a9c7ddf576d1982f15584aa8","unresolved":true,"context_lines":[{"line_number":746,"context_line":"                - name: {{role.name}} Pre Deployment Step Tasks block"},{"line_number":747,"context_line":"                  include_tasks: {{role.name}}/pre_deploy_step_tasks.yaml"},{"line_number":748,"context_line":"                  when:"},{"line_number":749,"context_line":"                    - \"\u0027{{role.name}}/pre_deploy_step_tasks.yaml\u0027 is exists\""},{"line_number":750,"context_line":"{%- endfor %}"},{"line_number":751,"context_line":"              tags:"},{"line_number":752,"context_line":"                - overcloud"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"dae2bcdb_cb8914cf","line":749,"in_reply_to":"7282f29f_09e8383e","updated":"2021-03-31 14:13:42.000000000","message":"Thanks :) We literally saw that just now and were testing the change","commit_id":"c5819681075716b6297b07b4cde3b54e8b581156"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"0b2524af80e48ae6989ab2d6752aaae499595f48","unresolved":true,"context_lines":[{"line_number":264,"context_line":"    properties:"},{"line_number":265,"context_line":"      type: comma_delimited_list"},{"line_number":266,"context_line":"      value:"},{"line_number":267,"context_line":"        yaql:"},{"line_number":268,"context_line":"          # processing from per-role unique tasks into globally unique tasks"},{"line_number":269,"context_line":"          expression: coalesce($.data, []).flatten().distinct()"},{"line_number":270,"context_line":"          data:"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"a069d509_831f3aa0","line":267,"range":{"start_line":267,"start_character":8,"end_line":267,"end_character":12},"updated":"2021-04-05 07:55:20.000000000","message":"I think we can use list_concat_unique instead of yaql here (intention is to use less of yaql)? I\u0027ve converted others with https://review.opendev.org/c/openstack/tripleo-heat-templates/+/784729","commit_id":"9b2956d505f5032e8716658441baf4ce52413917"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"fd3629a18e90c52a9b7d7b1b6cf1ebe094d4305f","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    properties:"},{"line_number":265,"context_line":"      type: comma_delimited_list"},{"line_number":266,"context_line":"      value:"},{"line_number":267,"context_line":"        yaql:"},{"line_number":268,"context_line":"          # processing from per-role unique tasks into globally unique tasks"},{"line_number":269,"context_line":"          expression: coalesce($.data, []).flatten().distinct()"},{"line_number":270,"context_line":"          data:"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"369488f0_43c41023","line":267,"range":{"start_line":267,"start_character":8,"end_line":267,"end_character":12},"in_reply_to":"1e3e0e7d_60b93e72","updated":"2021-04-06 07:26:31.000000000","message":"Done","commit_id":"9b2956d505f5032e8716658441baf4ce52413917"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2e48ebe2859a8c1fc1f12de4b906e88b75fe3cd3","unresolved":true,"context_lines":[{"line_number":264,"context_line":"    properties:"},{"line_number":265,"context_line":"      type: comma_delimited_list"},{"line_number":266,"context_line":"      value:"},{"line_number":267,"context_line":"        yaql:"},{"line_number":268,"context_line":"          # processing from per-role unique tasks into globally unique tasks"},{"line_number":269,"context_line":"          expression: coalesce($.data, []).flatten().distinct()"},{"line_number":270,"context_line":"          data:"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1e3e0e7d_60b93e72","line":267,"range":{"start_line":267,"start_character":8,"end_line":267,"end_character":12},"in_reply_to":"25089e6a_81279dd8","updated":"2021-04-05 10:29:48.000000000","message":"I\u0027ve changed the existing ones assuming we\u0027ll change this one before adding:) But if it\u0027s merged as is then I\u0027ll update that patch.\n\nWe should not add yaql when not necessary as it\u0027s memory intensive and we\u0027re working on reducing the usage of yaql functions.","commit_id":"9b2956d505f5032e8716658441baf4ce52413917"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"d80e32d42d47a96e5f0dc08aebc04f62ca1a2b48","unresolved":true,"context_lines":[{"line_number":264,"context_line":"    properties:"},{"line_number":265,"context_line":"      type: comma_delimited_list"},{"line_number":266,"context_line":"      value:"},{"line_number":267,"context_line":"        yaql:"},{"line_number":268,"context_line":"          # processing from per-role unique tasks into globally unique tasks"},{"line_number":269,"context_line":"          expression: coalesce($.data, []).flatten().distinct()"},{"line_number":270,"context_line":"          data:"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"25089e6a_81279dd8","line":267,"range":{"start_line":267,"start_character":8,"end_line":267,"end_character":12},"in_reply_to":"a069d509_831f3aa0","updated":"2021-04-05 10:15:54.000000000","message":"Cool! :)\nRabi, maybe you could rebase yours on top of this one (close to being approved) and transform it to list_concat_unique?","commit_id":"9b2956d505f5032e8716658441baf4ce52413917"}]}