)]}'
{"deployment/cinder/cinder-backup-container-puppet.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"29f52b13c65532fb87fe450c6cddf08ac13db9ad","unresolved":true,"context_lines":[{"line_number":1,"context_line":"heat_template_version: rocky"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  OpenStack containerized Cinder Backup service"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a62af55a_1aea39ba","line":1,"range":{"start_line":1,"start_character":23,"end_line":1,"end_character":28},"updated":"2021-04-06 05:17:32.000000000","message":"wallaby","commit_id":"42e2a302466f5a649bbf215af58d336b22ff2a34"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bff442e652669be3619ae932ef3e9d50232a5fd6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: rocky"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  OpenStack containerized Cinder Backup service"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e93cd035_11d47662","line":1,"range":{"start_line":1,"start_character":23,"end_line":1,"end_character":28},"in_reply_to":"0108b1c6_b13b17ae","updated":"2021-04-06 17:03:12.000000000","message":"Done","commit_id":"42e2a302466f5a649bbf215af58d336b22ff2a34"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"484dc876bb262bbb87a20b169b050e5ab230d1f8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: rocky"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  OpenStack containerized Cinder Backup service"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"855f9b0c_acd82492","line":1,"range":{"start_line":1,"start_character":23,"end_line":1,"end_character":28},"in_reply_to":"018d60ff_9cc67d29","updated":"2021-04-06 14:46:54.000000000","message":"What I meant by \"won\u0027t work\" is, pep8 jobs would fail and it can\u0027t merge.","commit_id":"42e2a302466f5a649bbf215af58d336b22ff2a34"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"62d2e70042655b69832984c3e0cacc9bc83569ed","unresolved":true,"context_lines":[{"line_number":1,"context_line":"heat_template_version: rocky"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  OpenStack containerized Cinder Backup service"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0108b1c6_b13b17ae","line":1,"range":{"start_line":1,"start_character":23,"end_line":1,"end_character":28},"in_reply_to":"855f9b0c_acd82492","updated":"2021-04-06 15:15:40.000000000","message":"I see [1] changed all the templates to wallaby, but I didn\u0027t think that forced every other outstanding THT patch to be rebased. I\u0027ll rebase just to be sure.\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/782978","commit_id":"42e2a302466f5a649bbf215af58d336b22ff2a34"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"afdfa7e0d64a970928512c1fb72154404dba8e75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: rocky"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  OpenStack containerized Cinder Backup service"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f1d29543_da58aa7a","line":1,"range":{"start_line":1,"start_character":23,"end_line":1,"end_character":28},"in_reply_to":"a62af55a_1aea39ba","updated":"2021-04-06 14:38:10.000000000","message":"True, but unrelated to this patch.","commit_id":"42e2a302466f5a649bbf215af58d336b22ff2a34"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"90050a6663a1231009d9ab78aae2992c0d7159a6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: rocky"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  OpenStack containerized Cinder Backup service"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"018d60ff_9cc67d29","line":1,"range":{"start_line":1,"start_character":23,"end_line":1,"end_character":28},"in_reply_to":"f1d29543_da58aa7a","updated":"2021-04-06 14:41:19.000000000","message":"It won\u0027t work because of the check[1], try rechecking:)\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/tools/yaml-validate.py#L35-L37","commit_id":"42e2a302466f5a649bbf215af58d336b22ff2a34"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"29f52b13c65532fb87fe450c6cddf08ac13db9ad","unresolved":true,"context_lines":[{"line_number":145,"context_line":"        map_merge:"},{"line_number":146,"context_line":"          - get_attr: [CinderBase, role_data, config_settings]"},{"line_number":147,"context_line":"          -"},{"line_number":148,"context_line":"            if:"},{"line_number":149,"context_line":"            - {equals: [{get_param: CinderBackupBackend}, \u0027ceph\u0027]}"},{"line_number":150,"context_line":"            - cinder::backup::ceph::backup_ceph_user:"},{"line_number":151,"context_line":"                str_replace:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b0d0a138_f8398c55","line":148,"range":{"start_line":148,"start_character":12,"end_line":148,"end_character":15},"updated":"2021-04-06 05:17:32.000000000","message":"can be moved up for better readability.\n\n- if:","commit_id":"42e2a302466f5a649bbf215af58d336b22ff2a34"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"afdfa7e0d64a970928512c1fb72154404dba8e75","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        map_merge:"},{"line_number":146,"context_line":"          - get_attr: [CinderBase, role_data, config_settings]"},{"line_number":147,"context_line":"          -"},{"line_number":148,"context_line":"            if:"},{"line_number":149,"context_line":"            - {equals: [{get_param: CinderBackupBackend}, \u0027ceph\u0027]}"},{"line_number":150,"context_line":"            - cinder::backup::ceph::backup_ceph_user:"},{"line_number":151,"context_line":"                str_replace:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"72b9f281_40562b0e","line":148,"range":{"start_line":148,"start_character":12,"end_line":148,"end_character":15},"in_reply_to":"b0d0a138_f8398c55","updated":"2021-04-06 14:38:10.000000000","message":"True, but unrelated to this patch","commit_id":"42e2a302466f5a649bbf215af58d336b22ff2a34"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"29f52b13c65532fb87fe450c6cddf08ac13db9ad","unresolved":true,"context_lines":[{"line_number":166,"context_line":"                        - {equals: [{get_param: CinderBackupRbdClusterName}, \u0027\u0027]}"},{"line_number":167,"context_line":"                        - {get_param: CephClusterName}"},{"line_number":168,"context_line":"                        - {get_param: CinderBackupRbdClusterName}"},{"line_number":169,"context_line":"            - {}"},{"line_number":170,"context_line":"          -"},{"line_number":171,"context_line":"            if:"},{"line_number":172,"context_line":"            - {equals: [{get_param: CinderBackupBackend}, \u0027swift\u0027]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"331a386e_a0286922","line":169,"range":{"start_line":169,"start_character":11,"end_line":169,"end_character":16},"updated":"2021-04-06 05:17:32.000000000","message":"Not needed with \u0027wallaby\u0027 template version.","commit_id":"42e2a302466f5a649bbf215af58d336b22ff2a34"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"afdfa7e0d64a970928512c1fb72154404dba8e75","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                        - {equals: [{get_param: CinderBackupRbdClusterName}, \u0027\u0027]}"},{"line_number":167,"context_line":"                        - {get_param: CephClusterName}"},{"line_number":168,"context_line":"                        - {get_param: CinderBackupRbdClusterName}"},{"line_number":169,"context_line":"            - {}"},{"line_number":170,"context_line":"          -"},{"line_number":171,"context_line":"            if:"},{"line_number":172,"context_line":"            - {equals: [{get_param: CinderBackupBackend}, \u0027swift\u0027]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"54790665_85c954d3","line":169,"range":{"start_line":169,"start_character":11,"end_line":169,"end_character":16},"in_reply_to":"331a386e_a0286922","updated":"2021-04-06 14:38:10.000000000","message":"True, but unrelated to this patch","commit_id":"42e2a302466f5a649bbf215af58d336b22ff2a34"}]}
