)]}'
{"ci/environments/scenario001-standalone.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"95e89a440dbacb9ca150030aa79ebe7961d56fc5","unresolved":true,"context_lines":[{"line_number":109,"context_line":"      dashboard_enabled: false"},{"line_number":110,"context_line":"  NovaEnableRbdBackend: true"},{"line_number":111,"context_line":"  CinderEnableRbdBackend: true"},{"line_number":112,"context_line":"  CinderRbdBackendName: tripleo_ceph,tripleo_ceph2,tripleo_ceph3"},{"line_number":113,"context_line":"  CinderRbdMultiConfig:"},{"line_number":114,"context_line":"    tripleo_ceph2:"},{"line_number":115,"context_line":"      CephClusterName: ceph2"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fafc4253_cfeff957","line":112,"updated":"2021-04-18 18:40:44.000000000","message":"wonder if we can build this list in tht appending to the pre-existing CinderRbdBackendName parameter value, the list of \"keys\" in the CinderRbdMultiConfig ... so that we don\u0027t risk the two to diverge; but we can do it in a follow up eventually if doable","commit_id":"e2936d7604b665d35bd8e01f237c0bec0ba205e9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"cf8de080ba9bcfbc82aab9f6f4c5d387ad33de65","unresolved":true,"context_lines":[{"line_number":109,"context_line":"      dashboard_enabled: false"},{"line_number":110,"context_line":"  NovaEnableRbdBackend: true"},{"line_number":111,"context_line":"  CinderEnableRbdBackend: true"},{"line_number":112,"context_line":"  CinderRbdBackendName: tripleo_ceph,tripleo_ceph2,tripleo_ceph3"},{"line_number":113,"context_line":"  CinderRbdMultiConfig:"},{"line_number":114,"context_line":"    tripleo_ceph2:"},{"line_number":115,"context_line":"      CephClusterName: ceph2"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"feb07a6f_720d2d14","line":112,"in_reply_to":"fafc4253_cfeff957","updated":"2021-04-18 19:07:26.000000000","message":"I tried real hard to pull as much data as I could from CephExternalMultiConfig so the user wouldn\u0027t need to specify a value that could be derived. But I kept encountering a chicken/egg problem where I needed to extract a value using a Heat function before it was available, or I wanted to feed the result back into another Heat expression but it was too late (any expansion had already taken place).","commit_id":"e2936d7604b665d35bd8e01f237c0bec0ba205e9"}],"container_config_scripts/nova_libvirt_init_secret.sh":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"62dcd620106c5cb4df0c1bd972c564bf2875ab8f","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    else"},{"line_number":50,"context_line":"        /usr/bin/virsh secret-define --file $SECRET_FILE"},{"line_number":51,"context_line":"    fi"},{"line_number":52,"context_line":"    "},{"line_number":53,"context_line":"    # Fetch the key from the keyring and ensure the secret is set"},{"line_number":54,"context_line":"    KEY\u003d$(awk \u0027$1 \u003d\u003d \"key\" {print $3}\u0027 /etc/ceph/${CLUSTER}.client.${CLIENT}.keyring)"},{"line_number":55,"context_line":"    if /usr/bin/virsh secret-get-value $FSID 2\u003e/dev/null | grep -q $KEY; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"393eaad9_7b2eea26","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":4},"updated":"2021-04-13 06:46:18.000000000","message":"nit","commit_id":"aabe9b55fea238ea2fbac4a3caf3bfa77bf41958"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"4dce43a1aaa605ed084d0474777a794a72b80371","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    else"},{"line_number":50,"context_line":"        /usr/bin/virsh secret-define --file $SECRET_FILE"},{"line_number":51,"context_line":"    fi"},{"line_number":52,"context_line":"    "},{"line_number":53,"context_line":"    # Fetch the key from the keyring and ensure the secret is set"},{"line_number":54,"context_line":"    KEY\u003d$(awk \u0027$1 \u003d\u003d \"key\" {print $3}\u0027 /etc/ceph/${CLUSTER}.client.${CLIENT}.keyring)"},{"line_number":55,"context_line":"    if /usr/bin/virsh secret-get-value $FSID 2\u003e/dev/null | grep -q $KEY; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"2bb1c832_192f584b","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":4},"in_reply_to":"393eaad9_7b2eea26","updated":"2021-04-14 19:46:39.000000000","message":"Had to rebase, so I fixed this.","commit_id":"aabe9b55fea238ea2fbac4a3caf3bfa77bf41958"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"ca20fb3ff6a85cd66ebdd2cb864028e2dfb94c87","unresolved":true,"context_lines":[{"line_number":53,"context_line":"    # Fetch the key from the keyring and ensure the secret is set"},{"line_number":54,"context_line":"    KEY\u003d$(awk \u0027$1 \u003d\u003d \"key\" {print $3}\u0027 /etc/ceph/${CLUSTER}.client.${CLIENT}.keyring)"},{"line_number":55,"context_line":"    if /usr/bin/virsh secret-get-value $FSID 2\u003e/dev/null | grep -q $KEY; then"},{"line_number":56,"context_line":"        echo \"The virsh secret for $FSID has already been set\""},{"line_number":57,"context_line":"    else"},{"line_number":58,"context_line":"        /usr/bin/virsh secret-set-value --secret $FSID --base64 $KEY"},{"line_number":59,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"0d303dc5_730a21b6","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":62},"updated":"2021-04-15 14:28:02.000000000","message":"I guess it\u0027s safe to assume the secret never changes?","commit_id":"e2936d7604b665d35bd8e01f237c0bec0ba205e9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"243452b6137ac6d4e5e4b2ad0dbeeab9302786d0","unresolved":true,"context_lines":[{"line_number":53,"context_line":"    # Fetch the key from the keyring and ensure the secret is set"},{"line_number":54,"context_line":"    KEY\u003d$(awk \u0027$1 \u003d\u003d \"key\" {print $3}\u0027 /etc/ceph/${CLUSTER}.client.${CLIENT}.keyring)"},{"line_number":55,"context_line":"    if /usr/bin/virsh secret-get-value $FSID 2\u003e/dev/null | grep -q $KEY; then"},{"line_number":56,"context_line":"        echo \"The virsh secret for $FSID has already been set\""},{"line_number":57,"context_line":"    else"},{"line_number":58,"context_line":"        /usr/bin/virsh secret-set-value --secret $FSID --base64 $KEY"},{"line_number":59,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"26ed2845_ede17865","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":62},"in_reply_to":"0d303dc5_730a21b6","updated":"2021-04-15 14:59:08.000000000","message":"The secret is $KEY, so if it changes the grep will fail and L58 will update it.\n\nThis is similar to the way the original puppet-nova code handled it [1].\n\n[1] https://opendev.org/openstack/puppet-nova/src/branch/master/manifests/compute/rbd.pp#L122","commit_id":"e2936d7604b665d35bd8e01f237c0bec0ba205e9"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"ea699fe748dfda5f2fab2a08e6bfcb6b4d5a31c2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    # Fetch the key from the keyring and ensure the secret is set"},{"line_number":54,"context_line":"    KEY\u003d$(awk \u0027$1 \u003d\u003d \"key\" {print $3}\u0027 /etc/ceph/${CLUSTER}.client.${CLIENT}.keyring)"},{"line_number":55,"context_line":"    if /usr/bin/virsh secret-get-value $FSID 2\u003e/dev/null | grep -q $KEY; then"},{"line_number":56,"context_line":"        echo \"The virsh secret for $FSID has already been set\""},{"line_number":57,"context_line":"    else"},{"line_number":58,"context_line":"        /usr/bin/virsh secret-set-value --secret $FSID --base64 $KEY"},{"line_number":59,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"19377b25_e9df49a8","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":62},"in_reply_to":"26ed2845_ede17865","updated":"2021-04-15 16:04:41.000000000","message":"Ah I thought it was grep-ing for FSID","commit_id":"e2936d7604b665d35bd8e01f237c0bec0ba205e9"}]}