)]}'
{"ci/environments/scenario010-standalone.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ec2ed14a30b05a9056c1d54aa24e49ea86bd84de","unresolved":true,"context_lines":[{"line_number":23,"context_line":"parameter_defaults:"},{"line_number":24,"context_line":"  StandaloneExtraConfig:"},{"line_number":25,"context_line":"    octavia::controller::connection_retry_interval: 10"},{"line_number":26,"context_line":"  OctaviaAmphoraSshKeyFile: /home/zuul/.ssh/id_rsa.pub"},{"line_number":27,"context_line":"  OctaviaAmphoraImageFilename: /home/zuul/amphora.qcow2"},{"line_number":28,"context_line":"  OctaviaCaKeyPassphrase: \u0027upstreamci\u0027"},{"line_number":29,"context_line":"  OctaviaManageNovaFlavor: true"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"d36d5895_07cbcbd5","side":"PARENT","line":26,"range":{"start_line":26,"start_character":2,"end_line":26,"end_character":54},"updated":"2021-08-16 02:45:58.000000000","message":"We should not have merged this before https://review.opendev.org/c/openstack/tripleo-ansible/+/783824 (incorrect dependency). Pl see https://bugs.launchpad.net/tripleo/+bug/1940007 and sc010 failures in this patch.","commit_id":"0b874947a1b02160863839a7cf4b487500a1b8a2"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"80f2cef4921c5a175120de147b120092a7ee6c8a","unresolved":true,"context_lines":[{"line_number":23,"context_line":"parameter_defaults:"},{"line_number":24,"context_line":"  StandaloneExtraConfig:"},{"line_number":25,"context_line":"    octavia::controller::connection_retry_interval: 10"},{"line_number":26,"context_line":"  OctaviaAmphoraSshKeyFile: /home/zuul/.ssh/id_rsa.pub"},{"line_number":27,"context_line":"  OctaviaAmphoraImageFilename: /home/zuul/amphora.qcow2"},{"line_number":28,"context_line":"  OctaviaCaKeyPassphrase: \u0027upstreamci\u0027"},{"line_number":29,"context_line":"  OctaviaManageNovaFlavor: true"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"48fa3b95_9158ca70","side":"PARENT","line":26,"range":{"start_line":26,"start_character":2,"end_line":26,"end_character":54},"in_reply_to":"c9ddb218_0b156cc6","updated":"2021-08-16 12:12:13.000000000","message":"https://review.opendev.org/c/openstack/tripleo-heat-templates/+/804732 is a fix/workaround","commit_id":"0b874947a1b02160863839a7cf4b487500a1b8a2"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"d00b574ca72581281f8d0d2f3de5319d6cc5628d","unresolved":true,"context_lines":[{"line_number":23,"context_line":"parameter_defaults:"},{"line_number":24,"context_line":"  StandaloneExtraConfig:"},{"line_number":25,"context_line":"    octavia::controller::connection_retry_interval: 10"},{"line_number":26,"context_line":"  OctaviaAmphoraSshKeyFile: /home/zuul/.ssh/id_rsa.pub"},{"line_number":27,"context_line":"  OctaviaAmphoraImageFilename: /home/zuul/amphora.qcow2"},{"line_number":28,"context_line":"  OctaviaCaKeyPassphrase: \u0027upstreamci\u0027"},{"line_number":29,"context_line":"  OctaviaManageNovaFlavor: true"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"c9ddb218_0b156cc6","side":"PARENT","line":26,"range":{"start_line":26,"start_character":2,"end_line":26,"end_character":54},"in_reply_to":"d36d5895_07cbcbd5","updated":"2021-08-16 09:54:19.000000000","message":"Yeah. sorry about that :/\nWe can propose to revert (only) this line, it will fix the issue (i\u0027m working on it)","commit_id":"0b874947a1b02160863839a7cf4b487500a1b8a2"}],"deployment/octavia/octavia-deployment-config.j2.yaml":[{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"19a8b371f3cc57d59d5cd05182fdd97f5d7c6b0b","unresolved":true,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"resources:"},{"line_number":205,"context_line":"{% if not octavia_standalone %}"},{"line_number":206,"context_line":"  default_key_pair:"},{"line_number":207,"context_line":"    type: OS::Nova::KeyPair"},{"line_number":208,"context_line":"    external_id: default"},{"line_number":209,"context_line":"{% endif %}"},{"line_number":210,"context_line":"  OctaviaVars:"},{"line_number":211,"context_line":"    type: OS::Heat::Value"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"16666aa2_2cad3c00","line":208,"range":{"start_line":206,"start_character":2,"end_line":208,"end_character":24},"updated":"2021-04-26 13:39:07.000000000","message":"If I keep these around I get the error:\n.../octavia-deployment-config.yaml\u003e.resources.default_key_pair: : publicURL endpoint for compute service in regionOne region not found","commit_id":"b87bf771b5101b0f06dc86b4cc3931ad2b9c48e7"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"c2187997da4a98b6578c9c838adc40abd5804d51","unresolved":true,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"resources:"},{"line_number":205,"context_line":"{% if not octavia_standalone %}"},{"line_number":206,"context_line":"  default_key_pair:"},{"line_number":207,"context_line":"    type: OS::Nova::KeyPair"},{"line_number":208,"context_line":"    external_id: default"},{"line_number":209,"context_line":"{% endif %}"},{"line_number":210,"context_line":"  OctaviaVars:"},{"line_number":211,"context_line":"    type: OS::Heat::Value"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d2e7901f_e803e3f5","line":208,"range":{"start_line":206,"start_character":2,"end_line":208,"end_character":24},"in_reply_to":"16666aa2_2cad3c00","updated":"2021-04-27 08:46:16.000000000","message":"Yes we can safely remove this block","commit_id":"b87bf771b5101b0f06dc86b4cc3931ad2b9c48e7"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"19a8b371f3cc57d59d5cd05182fdd97f5d7c6b0b","unresolved":true,"context_lines":[{"line_number":221,"context_line":"          amp_hw_arch: { get_param: OctaviaAmphoraImageArchitecture }"},{"line_number":222,"context_line":"          amp_ssh_key_name: { get_param: OctaviaAmphoraSshKeyName }"},{"line_number":223,"context_line":"          amp_ssh_key_path: { get_param: OctaviaAmphoraSshKeyFile }"},{"line_number":224,"context_line":"{% if not octavia_standalone %}"},{"line_number":225,"context_line":"          amp_ssh_key_data: { get_attr: [default_key_pair, public_key] }"},{"line_number":226,"context_line":"{% endif %}"},{"line_number":227,"context_line":"{% raw %}"},{"line_number":228,"context_line":"          amp_to_raw: {if: [octavia_raw_image_check, true, false]}"},{"line_number":229,"context_line":"          auth_username: { get_param: OctaviaUserName }"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ea03d647_584e49db","line":226,"range":{"start_line":224,"start_character":0,"end_line":226,"end_character":11},"updated":"2021-04-26 13:39:07.000000000","message":"related to the  above","commit_id":"b87bf771b5101b0f06dc86b4cc3931ad2b9c48e7"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"c2187997da4a98b6578c9c838adc40abd5804d51","unresolved":true,"context_lines":[{"line_number":221,"context_line":"          amp_hw_arch: { get_param: OctaviaAmphoraImageArchitecture }"},{"line_number":222,"context_line":"          amp_ssh_key_name: { get_param: OctaviaAmphoraSshKeyName }"},{"line_number":223,"context_line":"          amp_ssh_key_path: { get_param: OctaviaAmphoraSshKeyFile }"},{"line_number":224,"context_line":"{% if not octavia_standalone %}"},{"line_number":225,"context_line":"          amp_ssh_key_data: { get_attr: [default_key_pair, public_key] }"},{"line_number":226,"context_line":"{% endif %}"},{"line_number":227,"context_line":"{% raw %}"},{"line_number":228,"context_line":"          amp_to_raw: {if: [octavia_raw_image_check, true, false]}"},{"line_number":229,"context_line":"          auth_username: { get_param: OctaviaUserName }"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"4835e8e5_3776a11c","line":226,"range":{"start_line":224,"start_character":0,"end_line":226,"end_character":11},"in_reply_to":"ea03d647_584e49db","updated":"2021-04-27 08:46:16.000000000","message":"Ack","commit_id":"b87bf771b5101b0f06dc86b4cc3931ad2b9c48e7"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"19a8b371f3cc57d59d5cd05182fdd97f5d7c6b0b","unresolved":true,"context_lines":[{"line_number":254,"context_line":"          container_cli: { get_param: ContainerCli }"},{"line_number":255,"context_line":"          enable_log_offloading: { get_param: OctaviaLogOffload }"},{"line_number":256,"context_line":"          stack_action: { get_param: StackAction }"},{"line_number":257,"context_line":"          amp_ssh_key_dir: \"{{playbook_dir}}/octavia-ansible/ssh_key\""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"outputs:"},{"line_number":260,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a4d3333_30eae6d5","line":257,"range":{"start_line":257,"start_character":8,"end_line":257,"end_character":69},"updated":"2021-04-26 13:39:07.000000000","message":"If I comment out the two keypair items i mention above, I still error out at the very end of the deployment with:\n2021-04-26 13:35:38.543 150633 WARNING tripleoclient.v1.overcloud_deploy.DeployOvercloud [-] Unable to create artifact tarball, [Errno 13] Permission denied: \u0027/home/stack/overcloud-deploy/overcloud/config-download/overcloud/octavia-ansibl\ne/ssh_key/octavia_id_rsa\u0027: PermissionError: [Errno 13] Permission denied: \u0027/home/stack/overcloud-deploy/overcloud/config-download/overcloud/octavia-ansible/ssh_key/octavia_id_rsa\u0027\n2021-04-26 13:35:38.544 150633 ERROR tripleoclient.v1.overcloud_deploy.DeployOvercloud [-] Exception occured while running the command: git.exc.GitCommandError: Cmd(\u0027git\u0027) failed due to: exit code(128)\n  cmdline: git add .\n  stderr: \u0027error: open(\"octavia-ansible/ssh_key/octavia_id_rsa\"): Permission denied\nerror: unable to index file \u0027octavia-ansible/ssh_key/octavia_id_rsa\u0027\nfatal: adding files failed\u0027","commit_id":"b87bf771b5101b0f06dc86b4cc3931ad2b9c48e7"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"c2187997da4a98b6578c9c838adc40abd5804d51","unresolved":true,"context_lines":[{"line_number":254,"context_line":"          container_cli: { get_param: ContainerCli }"},{"line_number":255,"context_line":"          enable_log_offloading: { get_param: OctaviaLogOffload }"},{"line_number":256,"context_line":"          stack_action: { get_param: StackAction }"},{"line_number":257,"context_line":"          amp_ssh_key_dir: \"{{playbook_dir}}/octavia-ansible/ssh_key\""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"outputs:"},{"line_number":260,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ce4270cb_584f462a","line":257,"range":{"start_line":257,"start_character":8,"end_line":257,"end_character":69},"in_reply_to":"1a4d3333_30eae6d5","updated":"2021-04-27 08:46:16.000000000","message":"maybe \"{{playbook_dir}}\" is not appropriate here, do we have a directory to store this kind of objects on the undercloud?","commit_id":"b87bf771b5101b0f06dc86b4cc3931ad2b9c48e7"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"e3901d6d8892a7ee936aee29b2c196d6a2b052f7","unresolved":true,"context_lines":[{"line_number":254,"context_line":"          container_cli: { get_param: ContainerCli }"},{"line_number":255,"context_line":"          enable_log_offloading: { get_param: OctaviaLogOffload }"},{"line_number":256,"context_line":"          stack_action: { get_param: StackAction }"},{"line_number":257,"context_line":"          amp_ssh_key_dir: \"{{playbook_dir}}/octavia-ansible/ssh_key\""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"outputs:"},{"line_number":260,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"cfea4520_f70debde","line":257,"range":{"start_line":257,"start_character":8,"end_line":257,"end_character":69},"in_reply_to":"ce4270cb_584f462a","updated":"2021-04-27 13:23:00.000000000","message":"(Note I am not entirely sure about this stuff) I think the problem is that the key and its folder have root permissions:\n[stack@undercloud-0 ~]$ ls -la /home/stack/overcloud-deploy/overcloud/config-download/overcloud/octavia-ansible/*\n-rw-r--r--. 1 root          root   614 Apr 26 13:31 /home/stack/overcloud-deploy/overcloud/config-download/overcloud/octavia-ansible/inventory.yaml\n-rw-r--r--. 1 root          root 47143 Apr 26 13:35 /home/stack/overcloud-deploy/overcloud/config-download/overcloud/octavia-ansible/octavia-ansible.log\n\n/home/stack/overcloud-deploy/overcloud/config-download/overcloud/octavia-ansible/group_vars:\ntotal 4\ndrwxr-xr-x. 2 tripleo-admin root   31 Apr 26 13:31 .\ndrwxr-xr-x. 4 tripleo-admin root   88 Apr 26 13:35 ..\n-rw-r--r--. 1 root          root 1526 Apr 26 13:31 octavia_vars.yaml\n\n/home/stack/overcloud-deploy/overcloud/config-download/overcloud/octavia-ansible/ssh_key:\ntotal 8\ndrwxr-xr-x. 2 tripleo-admin root   54 Apr 26 13:31 .\ndrwxr-xr-x. 4 tripleo-admin root   88 Apr 26 13:35 ..\n-rw-------. 1 root          root 3357 Apr 26 13:31 octavia_id_rsa\n-rw-r--r--. 1 root          root  726 Apr 26 13:31 octavia_id_rsa.pub\n\nNormally the whole overcloud-deploy folder is owned stack:stack, so there\u0027s that.\n\nI am not sure where this octavia ssh key should live ideally. I see that the tripleo-admin .ssh keypair is in /home/stack/.ssh so there is some precedent for that I guess?","commit_id":"b87bf771b5101b0f06dc86b4cc3931ad2b9c48e7"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"a2c70ed2c3d2ee764b6308f41ee4b90c979fbd06","unresolved":true,"context_lines":[{"line_number":189,"context_line":"  DeploymentUser:"},{"line_number":190,"context_line":"    default: \u0027stack\u0027"},{"line_number":191,"context_line":"    description: User who owns the created SSH keys for Octavia."},{"line_number":192,"context_line":"    type: string"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"conditions:"},{"line_number":195,"context_line":"  octavia_raw_image_check:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"16eca081_eaef7ab3","line":192,"updated":"2021-08-02 22:56:22.000000000","message":"when not using stack, how does the user know this needs to be set?","commit_id":"68a913a35065bc38fbbb2b31e4ec7d85ebe413e3"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"84e31e8cd774ef07af29f649999cd3e96c084e61","unresolved":true,"context_lines":[{"line_number":189,"context_line":"  DeploymentUser:"},{"line_number":190,"context_line":"    default: \u0027stack\u0027"},{"line_number":191,"context_line":"    description: User who owns the created SSH keys for Octavia."},{"line_number":192,"context_line":"    type: string"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"conditions:"},{"line_number":195,"context_line":"  octavia_raw_image_check:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7753d8a9_4aea9c59","line":192,"in_reply_to":"16eca081_eaef7ab3","updated":"2021-08-10 06:40:53.000000000","message":"I was thinking about getting the username from python-tripleoclient, but it looks it\u0027s a difficult task (we\u0027re even using sudo to deploy tripleo standalone so we\u0027re losing that context :/)\nI think I will chose a unique/hardcoded path on the deployment node (/etc/octavia/ssh).","commit_id":"68a913a35065bc38fbbb2b31e4ec7d85ebe413e3"}]}