)]}'
{"deployment/heat/heat-base-puppet.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"48a1474bc3784be1b65cdc90284c5b3a08ed1477","unresolved":true,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"conditions:"},{"line_number":137,"context_line":"  service_debug_unset: {equals : [{get_param: HeatDebug}, \u0027\u0027]}"},{"line_number":138,"context_line":"  cache_enabled: {equals : [{get_param: EnableCache}, true]}"},{"line_number":139,"context_line":"  cors_allowed_origin_unset: {equals : [{get_param: HeatCorsAllowedOrigin}, \u0027\u0027]}"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"outputs:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c27457f0_f0e094cb","line":138,"range":{"start_line":138,"start_character":2,"end_line":138,"end_character":60},"updated":"2021-04-09 05:18:12.000000000","message":"Let\u0027s stop using these kind of conditions for boolean params.","commit_id":"b277ccf6bbe27d9502a289848731d77f33477776"}],"deployment/keystone/keystone-container-puppet.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2eb2db13c0a116a671c393be59bb49224d77d54c","unresolved":true,"context_lines":[{"line_number":487,"context_line":"            if:"},{"line_number":488,"context_line":"            - cache_enabled"},{"line_number":489,"context_line":"            - keystone::cache_enabled: true"},{"line_number":490,"context_line":"              keystone::cache_backend: \u0027dogpile.cache.memcached\u0027"},{"line_number":491,"context_line":"            - {}"},{"line_number":492,"context_line":"          -"},{"line_number":493,"context_line":"            if:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a5414e01_d7b4b7ec","line":490,"updated":"2021-04-08 08:36:58.000000000","message":"looks good\n\n\"keystone::cache_backend\": \"dogpile.cache.memcached\",   @ https://d6b4abbfa913b9a8df09-4778d0f97be87381c8bb555db36b10bd.ssl.cf1.rackcdn.com/784242/2/check/tripleo-ci-centos-8-scenario003-standalone/a05cb9c/logs/undercloud/etc/puppet/hieradata/service_configs.json","commit_id":"b277ccf6bbe27d9502a289848731d77f33477776"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2eb2db13c0a116a671c393be59bb49224d77d54c","unresolved":true,"context_lines":[{"line_number":501,"context_line":"            if:"},{"line_number":502,"context_line":"            - keystone_openidc_enabled"},{"line_number":503,"context_line":"            -"},{"line_number":504,"context_line":"              map_merge:"},{"line_number":505,"context_line":"                - keystone_openidc_enabled: True"},{"line_number":506,"context_line":"                  keystone::federation::openidc::methods:"},{"line_number":507,"context_line":"                    get_param: KeystoneAuthMethods"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f2b9909_14982201","line":504,"updated":"2021-04-08 08:36:58.000000000","message":"this bit looks OK from visual inspection but would be nice to verify the map_merge in a job ... but i don\u0027t think we have this keystone_openidc_enabled in upstrea CI anywhere :/","commit_id":"b277ccf6bbe27d9502a289848731d77f33477776"}]}
