)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"2ec007b88f4dda704a94223cfedf83b812393ba3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"2394ad86_b513da1e","updated":"2022-02-28 10:58:56.000000000","message":"recheck","commit_id":"f4fc7fec1dabf23125c1ae6eeedc6a33db23457d"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"c05f277d14692efa236686d18c7107357e8d7861","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"8468d6af_3ff342e3","updated":"2022-02-25 16:56:44.000000000","message":"recheck","commit_id":"f4fc7fec1dabf23125c1ae6eeedc6a33db23457d"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"86159854ffcf03b2385f23c04371a65043102f89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"6d4f3e4a_02892802","updated":"2022-03-14 13:58:26.000000000","message":"lgtm","commit_id":"0fa959acb8c9a3768743d2b001c6a0376763b54f"}],"deployment/frr/frr-container-ansible.yaml":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"575477cd77b1842dabfc46cdb336cd35b2aaeaa0","unresolved":true,"context_lines":[{"line_number":134,"context_line":"    default: \"datacentre:br-ex\""},{"line_number":135,"context_line":"    tags:"},{"line_number":136,"context_line":"      - role_specific"},{"line_number":137,"context_line":"  OvnBgpAgentMode:"},{"line_number":138,"context_line":"    description: \u003e"},{"line_number":139,"context_line":"      Configures how VM IPs are advertised via BGP."},{"line_number":140,"context_line":"      Mode \u0027bgp\u0027: Exposes VM IPs on provider networks and FIPs associated to"},{"line_number":141,"context_line":"                  VMs on tenant networks via MP-BGP IPv4 and IPv6 unicast."},{"line_number":142,"context_line":"      Mode \u0027evpn\u0027: Exposes VM IPs on the tenant networks via MP-BGP EVPN VXLAN."},{"line_number":143,"context_line":"    type: string"},{"line_number":144,"context_line":"    default: \u0027evpn\u0027"},{"line_number":145,"context_line":"    constraints:"},{"line_number":146,"context_line":"      - allowed_values: [ \u0027bgp\u0027, \u0027evpn\u0027 ]"},{"line_number":147,"context_line":"  FrrOvnBgpAgentDriver:"},{"line_number":148,"context_line":"    description: \u003e"},{"line_number":149,"context_line":"      Configures how VM IPs are advertised via BGP. EVPN driver exposes VM IPs"},{"line_number":150,"context_line":"      on provider networks and FIPs associated to VMs on tenant networks via"},{"line_number":151,"context_line":"      MP-BGP IPv4 and IPv6 unicast. BGP driver exposes VM IPs on the tenant"},{"line_number":152,"context_line":"      networks via MP-BGP EVPN VXLAN."},{"line_number":153,"context_line":"    type: string"},{"line_number":154,"context_line":"    default: \u0027osp_ovn_evpn_driver\u0027"},{"line_number":155,"context_line":"    constraints:"},{"line_number":156,"context_line":"      - allowed_values: [ \u0027osp_ovn_bgp_driver\u0027, \u0027osp_ovn_evpn_driver\u0027 ]"},{"line_number":157,"context_line":"  FrrOvnBgpAgentExposeTenantNetworks:"},{"line_number":158,"context_line":"    description: \u003e"},{"line_number":159,"context_line":"      Exposes VM IPs on tenant networks via MP-BGP IPv4 and IPv6 unicast."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"cfaecc06_33b1a591","line":156,"range":{"start_line":137,"start_character":0,"end_line":156,"end_character":71},"updated":"2021-06-22 06:47:31.000000000","message":"isn\u0027t the mode and the driver the same?","commit_id":"31f5b6a43132a7a41d28a2d350882474921960a7"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"9c4cece0802e5b5c2950a6f900b0632702a2ec7e","unresolved":true,"context_lines":[{"line_number":134,"context_line":"    default: \"datacentre:br-ex\""},{"line_number":135,"context_line":"    tags:"},{"line_number":136,"context_line":"      - role_specific"},{"line_number":137,"context_line":"  OvnBgpAgentMode:"},{"line_number":138,"context_line":"    description: \u003e"},{"line_number":139,"context_line":"      Configures how VM IPs are advertised via BGP."},{"line_number":140,"context_line":"      Mode \u0027bgp\u0027: Exposes VM IPs on provider networks and FIPs associated to"},{"line_number":141,"context_line":"                  VMs on tenant networks via MP-BGP IPv4 and IPv6 unicast."},{"line_number":142,"context_line":"      Mode \u0027evpn\u0027: Exposes VM IPs on the tenant networks via MP-BGP EVPN VXLAN."},{"line_number":143,"context_line":"    type: string"},{"line_number":144,"context_line":"    default: \u0027evpn\u0027"},{"line_number":145,"context_line":"    constraints:"},{"line_number":146,"context_line":"      - allowed_values: [ \u0027bgp\u0027, \u0027evpn\u0027 ]"},{"line_number":147,"context_line":"  FrrOvnBgpAgentDriver:"},{"line_number":148,"context_line":"    description: \u003e"},{"line_number":149,"context_line":"      Configures how VM IPs are advertised via BGP. EVPN driver exposes VM IPs"},{"line_number":150,"context_line":"      on provider networks and FIPs associated to VMs on tenant networks via"},{"line_number":151,"context_line":"      MP-BGP IPv4 and IPv6 unicast. BGP driver exposes VM IPs on the tenant"},{"line_number":152,"context_line":"      networks via MP-BGP EVPN VXLAN."},{"line_number":153,"context_line":"    type: string"},{"line_number":154,"context_line":"    default: \u0027osp_ovn_evpn_driver\u0027"},{"line_number":155,"context_line":"    constraints:"},{"line_number":156,"context_line":"      - allowed_values: [ \u0027osp_ovn_bgp_driver\u0027, \u0027osp_ovn_evpn_driver\u0027 ]"},{"line_number":157,"context_line":"  FrrOvnBgpAgentExposeTenantNetworks:"},{"line_number":158,"context_line":"    description: \u003e"},{"line_number":159,"context_line":"      Exposes VM IPs on tenant networks via MP-BGP IPv4 and IPv6 unicast."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7c0d4f_4c59aebe","line":156,"range":{"start_line":137,"start_character":0,"end_line":156,"end_character":71},"in_reply_to":"cfaecc06_33b1a591","updated":"2021-06-22 07:00:38.000000000","message":"Yep. OvnBgpAgentMode was a draft, I forgot to remove it.","commit_id":"31f5b6a43132a7a41d28a2d350882474921960a7"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"575477cd77b1842dabfc46cdb336cd35b2aaeaa0","unresolved":true,"context_lines":[{"line_number":159,"context_line":"      Exposes VM IPs on tenant networks via MP-BGP IPv4 and IPv6 unicast."},{"line_number":160,"context_line":"      Requires the BGP driver (see THT parameter FrrOvnBgpAgentDriver)."},{"line_number":161,"context_line":"    type: boolean"},{"line_number":162,"context_line":"    default: true"},{"line_number":163,"context_line":"outputs:"},{"line_number":164,"context_line":"  role_data:"},{"line_number":165,"context_line":"    description: Role data for the FRR service"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"76ecdfd0_c0029305","line":162,"range":{"start_line":162,"start_character":0,"end_line":162,"end_character":17},"updated":"2021-06-22 06:47:31.000000000","message":"perhaps this default should be \"false\"  instead","commit_id":"31f5b6a43132a7a41d28a2d350882474921960a7"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"9c4cece0802e5b5c2950a6f900b0632702a2ec7e","unresolved":true,"context_lines":[{"line_number":159,"context_line":"      Exposes VM IPs on tenant networks via MP-BGP IPv4 and IPv6 unicast."},{"line_number":160,"context_line":"      Requires the BGP driver (see THT parameter FrrOvnBgpAgentDriver)."},{"line_number":161,"context_line":"    type: boolean"},{"line_number":162,"context_line":"    default: true"},{"line_number":163,"context_line":"outputs:"},{"line_number":164,"context_line":"  role_data:"},{"line_number":165,"context_line":"    description: Role data for the FRR service"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d70438de_66562222","line":162,"range":{"start_line":162,"start_character":0,"end_line":162,"end_character":17},"in_reply_to":"76ecdfd0_c0029305","updated":"2021-06-22 07:00:38.000000000","message":"I set \u0027true\u0027 as default value to match with what is in tripleo-ansible and in the upstream OVN BGP agent. Why do you suggest defaulting to false here?\n\nhttps://github.com/luis5tb/bgp-agent/blob/a01a57beffd2fa4841c6c8ca1326827c9f16a512/bgp_agent/config.py#L24-L26\n\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/785664/4/tripleo_ansible/roles/tripleo_frr/defaults/main.yml@44","commit_id":"31f5b6a43132a7a41d28a2d350882474921960a7"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"906cf3f07b48bbd54758f68c0481283715c06fba","unresolved":true,"context_lines":[{"line_number":283,"context_line":"            - path: /etc/pki/tls/private/ovn_bgp_agent.key"},{"line_number":284,"context_line":"              owner: neutron:neutron"},{"line_number":285,"context_line":"              optional: true"},{"line_number":286,"context_line":"              perm: \u00270644\u0027"},{"line_number":287,"context_line":"      metadata_settings:"},{"line_number":288,"context_line":"        if:"},{"line_number":289,"context_line":"          - {get_param: EnableInternalTLS}"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"02468cb7_5255fdff","line":286,"range":{"start_line":286,"start_character":21,"end_line":286,"end_character":25},"updated":"2022-03-07 10:42:25.000000000","message":"Don\u0027t allow \u0027others\u0027 to read, otherwise it poses a security risk.\n\n      perm: \u00270640\u0027","commit_id":"f4fc7fec1dabf23125c1ae6eeedc6a33db23457d"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"e071db136b30e3e4e091e86e2e1a997e0411bfd0","unresolved":false,"context_lines":[{"line_number":283,"context_line":"            - path: /etc/pki/tls/private/ovn_bgp_agent.key"},{"line_number":284,"context_line":"              owner: neutron:neutron"},{"line_number":285,"context_line":"              optional: true"},{"line_number":286,"context_line":"              perm: \u00270644\u0027"},{"line_number":287,"context_line":"      metadata_settings:"},{"line_number":288,"context_line":"        if:"},{"line_number":289,"context_line":"          - {get_param: EnableInternalTLS}"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"4a18d237_052f6c43","line":286,"range":{"start_line":286,"start_character":21,"end_line":286,"end_character":25},"in_reply_to":"02468cb7_5255fdff","updated":"2022-03-07 10:46:00.000000000","message":"Done","commit_id":"f4fc7fec1dabf23125c1ae6eeedc6a33db23457d"}]}