)]}'
{"deployment/cinder/cinder-api-container-puppet.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"7051cd9439c87c43a1fad4683c4e88be06033fae","unresolved":true,"context_lines":[{"line_number":92,"context_line":"conditions:"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  cinder_workers_set:"},{"line_number":95,"context_line":"    not: {equals : [{get_param: CinderWorkers}, 0]}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"resources:"},{"line_number":98,"context_line":"  ContainersCommon:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d83717e6_b6dd493d","line":95,"updated":"2021-04-12 15:12:28.000000000","message":"probably doesn\u0027t matter, but the logic is changed here if CinderWorkers is explicitly set to 0. No idea why someone would do that. But, then why was the condition ever needed initially?","commit_id":"1f14b0ae8674a447cd742f233c5c64e4754a41d8"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a1d5ec689c3a4a00e506957b2e97e57b53c9467e","unresolved":true,"context_lines":[{"line_number":92,"context_line":"conditions:"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  cinder_workers_set:"},{"line_number":95,"context_line":"    not: {equals : [{get_param: CinderWorkers}, 0]}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"resources:"},{"line_number":98,"context_line":"  ContainersCommon:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a799e889_e315918c","line":95,"in_reply_to":"29ee758d_c8eec614","updated":"2021-04-12 16:22:51.000000000","message":"I\u0027m a storage guy, but this looks to be more of a wsgi thing. The original patch is [1], but in the current context I\u0027m not sure the conditional is even necessary. Is there any reason to *not* emit the hieradata on L210?\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/387202/4/puppet/services/cinder-api.yaml","commit_id":"1f14b0ae8674a447cd742f233c5c64e4754a41d8"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ee05ee618f09972a4603faf6681d12afe9c5f19d","unresolved":true,"context_lines":[{"line_number":92,"context_line":"conditions:"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  cinder_workers_set:"},{"line_number":95,"context_line":"    not: {equals : [{get_param: CinderWorkers}, 0]}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"resources:"},{"line_number":98,"context_line":"  ContainersCommon:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"cbdc5238_8f3c8672","line":95,"in_reply_to":"a799e889_e315918c","updated":"2021-04-13 08:48:10.000000000","message":"Could the parameter CinderWorkers parameter be update to use a allowed_pattern constraint instead? One allowed pattern is \u0027%{::os_workers}\u0027, the other is any number that is not zero?","commit_id":"1f14b0ae8674a447cd742f233c5c64e4754a41d8"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"898c4031d02f8a9e46a3b297f57feda4fc779ad2","unresolved":true,"context_lines":[{"line_number":92,"context_line":"conditions:"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  cinder_workers_set:"},{"line_number":95,"context_line":"    not: {equals : [{get_param: CinderWorkers}, 0]}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"resources:"},{"line_number":98,"context_line":"  ContainersCommon:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1e403189_cf05a22c","line":95,"in_reply_to":"cbdc5238_8f3c8672","updated":"2021-04-14 04:52:10.000000000","message":"I just realized that this condition would have never worked with as CinderWorkers is a string. I\u0027ll just drop it.","commit_id":"1f14b0ae8674a447cd742f233c5c64e4754a41d8"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e4c05e0bd9f433baf0bd733462c4fc699294572c","unresolved":true,"context_lines":[{"line_number":92,"context_line":"conditions:"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  cinder_workers_set:"},{"line_number":95,"context_line":"    not: {equals : [{get_param: CinderWorkers}, 0]}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"resources:"},{"line_number":98,"context_line":"  ContainersCommon:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"29ee758d_c8eec614","line":95,"in_reply_to":"d83717e6_b6dd493d","updated":"2021-04-12 15:40:57.000000000","message":"Not sure what would change i.e. it won\u0027t set the cinder::wsgi::apache::workers hiera if the parameter is set to 0 and use $::os_workers[1] like before, right?\n\nBut yeah why someone would set that to 0 is beyond my comprehension too.\n\n[1] https://github.com/openstack/puppet-cinder/blob/master/manifests/wsgi/apache.pp#L126","commit_id":"1f14b0ae8674a447cd742f233c5c64e4754a41d8"}],"deployment/cinder/cinder-common-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a1d5ec689c3a4a00e506957b2e97e57b53c9467e","unresolved":true,"context_lines":[{"line_number":182,"context_line":"        -"},{"line_number":183,"context_line":"          - name: cinder_enable_iscsi_backend fact"},{"line_number":184,"context_line":"            set_fact:"},{"line_number":185,"context_line":"              cinder_enable_iscsi_backend: {get_param: CinderEnableIscsiBackend}"},{"line_number":186,"context_line":"          - when: cinder_enable_iscsi_backend|bool"},{"line_number":187,"context_line":"            block:"},{"line_number":188,"context_line":"              - name: ensure LVM rpm dependencies are installed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ccabcf32_ecd06489","line":185,"updated":"2021-04-12 16:22:51.000000000","message":"This one I wasn\u0027t sure about. Because the value is being assigned to an ansible variable, I thought it needs to be a string and not a heat boolean. But tripleo-ci-centos-8-scenario002-standalone passes, the cinder-volume service looks happy, so I guess this is OK.","commit_id":"1f14b0ae8674a447cd742f233c5c64e4754a41d8"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"898c4031d02f8a9e46a3b297f57feda4fc779ad2","unresolved":true,"context_lines":[{"line_number":182,"context_line":"        -"},{"line_number":183,"context_line":"          - name: cinder_enable_iscsi_backend fact"},{"line_number":184,"context_line":"            set_fact:"},{"line_number":185,"context_line":"              cinder_enable_iscsi_backend: {get_param: CinderEnableIscsiBackend}"},{"line_number":186,"context_line":"          - when: cinder_enable_iscsi_backend|bool"},{"line_number":187,"context_line":"            block:"},{"line_number":188,"context_line":"              - name: ensure LVM rpm dependencies are installed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"671c475b_5de491da","line":185,"in_reply_to":"ccabcf32_ecd06489","updated":"2021-04-14 04:52:10.000000000","message":"yeah it\u0027s fine.","commit_id":"1f14b0ae8674a447cd742f233c5c64e4754a41d8"}]}