)]}'
{"releasenotes/notes/use-server-side-merging-service-net-map-0c65b5e421ce05bd.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"13475dab57f8abd21c29d0990f6bc209498d3eef","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    parameter_defaults section of an environment file."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    With the change to ServiceNetMap/VipSubnetMap interface, existing environments"},{"line_number":11,"context_line":"    where they are overridden have to specify \u0027merge\u0027 strategy for the parameters"},{"line_number":12,"context_line":"    in a new \u0027parameter_merge_strategies\u0027 section."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9320ad38_dcf60755","line":12,"range":{"start_line":10,"start_character":4,"end_line":12,"end_character":50},"updated":"2021-05-19 07:37:10.000000000","message":"Doesn\u0027t [1] ensure that we maintain the same default behaviour? I.e is it really necessary to do this manually?\nIf not, it would be nice to have a validation somewhere to warn the operator.\n\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/785825/2/overcloud-resource-registry-puppet.j2.yaml#351","commit_id":"b253d564f7cccd0a818239a3c877229242acfe55"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b52b0bb5e2dd4eb4ca2952c1e2ab9ab79c03029f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    parameter_defaults section of an environment file."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    With the change to ServiceNetMap/VipSubnetMap interface, existing environments"},{"line_number":11,"context_line":"    where they are overridden have to specify \u0027merge\u0027 strategy for the parameters"},{"line_number":12,"context_line":"    in a new \u0027parameter_merge_strategies\u0027 section."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"35891a58_36039e2d","line":12,"range":{"start_line":10,"start_character":4,"end_line":12,"end_character":50},"in_reply_to":"4cdb3f26_7ed40655","updated":"2021-05-19 08:08:19.000000000","message":"Thanks for explaining. This looks all good to me!","commit_id":"b253d564f7cccd0a818239a3c877229242acfe55"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"1cd4355aa718ffc2f68792de304e40dacefe9d6e","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    parameter_defaults section of an environment file."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    With the change to ServiceNetMap/VipSubnetMap interface, existing environments"},{"line_number":11,"context_line":"    where they are overridden have to specify \u0027merge\u0027 strategy for the parameters"},{"line_number":12,"context_line":"    in a new \u0027parameter_merge_strategies\u0027 section."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4cdb3f26_7ed40655","line":12,"range":{"start_line":10,"start_character":4,"end_line":12,"end_character":50},"in_reply_to":"9320ad38_dcf60755","updated":"2021-05-19 08:03:00.000000000","message":"It does ensure the behavior would not change for old environments where you specify the full ServiceNetMap. However, it would insist on adding that section with entries for the parameters in those environments to match with overcloud-resource-registry-puppet.j2.yaml. It\u0027s a validation in heat to ensure that user knows about it as different environments can\u0027t have different merge stragies for the same param. As there is already a validation in heat we probably don\u0027t need to validate again.\n\nThe message would be  (\"Conflicting merge strategy \u0027%(strategy)s\u0027 for \"\n                \"parameter \u0027%(param)s\u0027 in file \u0027%(env_file)s\u0027.\")\n\n[1] https://github.com/openstack/heat/blob/master/heat/common/environment_util.py#L122","commit_id":"b253d564f7cccd0a818239a3c877229242acfe55"}]}