)]}'
{"deployment/database/mysql-base.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f3b084c5a69c5e4e5261e13e3d2af93ba9d4b997","unresolved":true,"context_lines":[{"line_number":145,"context_line":"              $NETWORK: {get_param: [ServiceNetMap, MysqlNetwork]}"},{"line_number":146,"context_line":"        tripleo::profile::base::database::mysql::generate_dropin_file_limit:"},{"line_number":147,"context_line":"          {get_param: MysqlIncreaseFileLimit}"},{"line_number":148,"context_line":"        tripleo::profile::base::database::mysql::certificate_specs:"},{"line_number":149,"context_line":"          if:"},{"line_number":150,"context_line":"            - {get_param: EnableInternalTLS}"},{"line_number":151,"context_line":"            - service_certificate: \u0027/etc/pki/tls/certs/mysql.crt\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6c4870de_e09f1ae6","line":148,"updated":"2021-04-12 12:26:27.000000000","message":"Before the change, this key would not exist in hiera, if no internal TLS.\nAfter this change, it will be where with a null value. Would that null value properly map to hiera undef? The same applies to other changes, like ca_file","commit_id":"7ced44debc7f13a3775d799f1e39b66c09869296"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"9fac67f22ad5d33275a038eb563004508cb926e6","unresolved":true,"context_lines":[{"line_number":145,"context_line":"              $NETWORK: {get_param: [ServiceNetMap, MysqlNetwork]}"},{"line_number":146,"context_line":"        tripleo::profile::base::database::mysql::generate_dropin_file_limit:"},{"line_number":147,"context_line":"          {get_param: MysqlIncreaseFileLimit}"},{"line_number":148,"context_line":"        tripleo::profile::base::database::mysql::certificate_specs:"},{"line_number":149,"context_line":"          if:"},{"line_number":150,"context_line":"            - {get_param: EnableInternalTLS}"},{"line_number":151,"context_line":"            - service_certificate: \u0027/etc/pki/tls/certs/mysql.crt\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8411bf25_4f732536","line":148,"in_reply_to":"6c4870de_e09f1ae6","updated":"2021-04-12 12:28:57.000000000","message":"No, the key would be ignored if the condition is false with wallaby templates. That\u0027s the reason we could get rid of the map_merge.","commit_id":"7ced44debc7f13a3775d799f1e39b66c09869296"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"064db9a0e6afd3548e02b117824d5786767829ec","unresolved":true,"context_lines":[{"line_number":145,"context_line":"              $NETWORK: {get_param: [ServiceNetMap, MysqlNetwork]}"},{"line_number":146,"context_line":"        tripleo::profile::base::database::mysql::generate_dropin_file_limit:"},{"line_number":147,"context_line":"          {get_param: MysqlIncreaseFileLimit}"},{"line_number":148,"context_line":"        tripleo::profile::base::database::mysql::certificate_specs:"},{"line_number":149,"context_line":"          if:"},{"line_number":150,"context_line":"            - {get_param: EnableInternalTLS}"},{"line_number":151,"context_line":"            - service_certificate: \u0027/etc/pki/tls/certs/mysql.crt\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"34c4576b_c9f69dec","line":148,"in_reply_to":"8411bf25_4f732536","updated":"2021-04-12 13:30:23.000000000","message":"ack, thanks. Also I\u0027ve checked that null is properly interpreted by hiera as nil as well","commit_id":"7ced44debc7f13a3775d799f1e39b66c09869296"}]}
