)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"eb41c746db503a2e2da5f7ed9a2ad318e55a011d","unresolved":true,"context_lines":[{"line_number":19,"context_line":"the directory, meaning: drwxrwxrwt."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I6c239065d4c92c9afc62ff4e513e6d097a06e218"},{"line_number":22,"context_line":"Resolves: rhbz#1947532"},{"line_number":23,"context_line":"Closes-Bug: #1925316"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a9f504b5_27f871fb","line":22,"updated":"2021-04-21 13:10:52.000000000","message":"should have a launchpad bug","commit_id":"0c5f8654837d5788b472e2e9b74d9d9a59293a85"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7c205d6dba361303db7dd4ebc765083df74cc769","unresolved":true,"context_lines":[{"line_number":19,"context_line":"the directory, meaning: drwxrwxrwt."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I6c239065d4c92c9afc62ff4e513e6d097a06e218"},{"line_number":22,"context_line":"Resolves: rhbz#1947532"},{"line_number":23,"context_line":"Closes-Bug: #1925316"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"27777aa8_ddc2d7bc","line":22,"in_reply_to":"035103d5_c89fdc75","updated":"2021-04-21 15:16:31.000000000","message":"yea but this shouldn\u0027t be in the upstream commit :D","commit_id":"0c5f8654837d5788b472e2e9b74d9d9a59293a85"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"33da2c6b16e9644d1f0279fd96d0051ceb9585d4","unresolved":true,"context_lines":[{"line_number":19,"context_line":"the directory, meaning: drwxrwxrwt."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I6c239065d4c92c9afc62ff4e513e6d097a06e218"},{"line_number":22,"context_line":"Resolves: rhbz#1947532"},{"line_number":23,"context_line":"Closes-Bug: #1925316"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"035103d5_c89fdc75","line":22,"in_reply_to":"a9f504b5_27f871fb","updated":"2021-04-21 15:12:17.000000000","message":"just the line bellow ;).","commit_id":"0c5f8654837d5788b472e2e9b74d9d9a59293a85"}],"deployment/horizon/horizon-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"933807b3ea29bdacabd7aaddc5f1ba468cd0c9a4","unresolved":true,"context_lines":[{"line_number":380,"context_line":"          copy:"},{"line_number":381,"context_line":"            dest: /etc/tmpfiles.d/var-tmp-horizon.conf"},{"line_number":382,"context_line":"            content: |"},{"line_number":383,"context_line":"              d /var/tmp/horizon 0755 root root - -"},{"line_number":384,"context_line":"      upgrade_tasks: []"},{"line_number":385,"context_line":"      external_upgrade_tasks:"},{"line_number":386,"context_line":"        - when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b714daa1_77cccda9","line":383,"range":{"start_line":383,"start_character":38,"end_line":383,"end_character":48},"updated":"2021-04-21 11:40:51.000000000","message":"I\u0027ll check this in my lab but I guess we should make this owned by apache:apache instead, or allow 777 access.","commit_id":"957aacc9b49a98989cbb04c9d8c443a20d291bb7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a4154c128cee1710a2c12a58936d8833613bec22","unresolved":true,"context_lines":[{"line_number":380,"context_line":"          copy:"},{"line_number":381,"context_line":"            dest: /etc/tmpfiles.d/var-tmp-horizon.conf"},{"line_number":382,"context_line":"            content: |"},{"line_number":383,"context_line":"              d /var/tmp/horizon 0755 root root - -"},{"line_number":384,"context_line":"      upgrade_tasks: []"},{"line_number":385,"context_line":"      external_upgrade_tasks:"},{"line_number":386,"context_line":"        - when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bd7c39ec_b67728e3","line":383,"range":{"start_line":383,"start_character":38,"end_line":383,"end_character":48},"in_reply_to":"b714daa1_77cccda9","updated":"2021-04-21 11:49:34.000000000","message":"I confirmed that a temporary file for image upload is owned by apache:apache (48:48) so we should make it writable for that user.","commit_id":"957aacc9b49a98989cbb04c9d8c443a20d291bb7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4c641645561c498ba39438a768d455e70ad5ed71","unresolved":true,"context_lines":[{"line_number":382,"context_line":"            content: |"},{"line_number":383,"context_line":"              d /var/tmp/horizon 3777 root root - -"},{"line_number":384,"context_line":"      upgrade_tasks:"},{"line_number":385,"context_line":"        - name: Anchor for upgrade and update tasks"},{"line_number":386,"context_line":"          when: step|int \u003d\u003d 0"},{"line_number":387,"context_line":"          block: \u0026tmp_reset_label"},{"line_number":388,"context_line":"            - name: Reset selinux label on /var/tmp"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"802f6ebd_54cc6822","line":385,"range":{"start_line":385,"start_character":16,"end_line":385,"end_character":51},"updated":"2021-04-23 08:41:02.000000000","message":"Good catch.\n\nWould it be helpful to put bug number here (lp 1925316) for easy reference ?","commit_id":"dde70a252795b57f0ab9c2e60fd5e4d916a66d2c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1c0159bd7a19de0b117415ff97ec8e0c896ebe05","unresolved":true,"context_lines":[{"line_number":382,"context_line":"            content: |"},{"line_number":383,"context_line":"              d /var/tmp/horizon 3777 root root - -"},{"line_number":384,"context_line":"      upgrade_tasks:"},{"line_number":385,"context_line":"        - name: Anchor for upgrade and update tasks"},{"line_number":386,"context_line":"          when: step|int \u003d\u003d 0"},{"line_number":387,"context_line":"          block: \u0026tmp_reset_label"},{"line_number":388,"context_line":"            - name: Reset selinux label on /var/tmp"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f6f5edfc_ac83a0e3","line":385,"range":{"start_line":385,"start_character":16,"end_line":385,"end_character":51},"in_reply_to":"3c7ea171_077d9765","updated":"2021-04-23 12:38:40.000000000","message":"What I thought is that we\u0027d need to remove this in a future release, and adding a note with bug reference in code would help us to keep that in our TODO list.\nThe bug is referenced in the commit message but it is not sometimes easy to find the context behind this implementation later from git blame.","commit_id":"dde70a252795b57f0ab9c2e60fd5e4d916a66d2c"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"25c044d61cb3c398dd2c82824d3b8bd40bed5325","unresolved":true,"context_lines":[{"line_number":382,"context_line":"            content: |"},{"line_number":383,"context_line":"              d /var/tmp/horizon 3777 root root - -"},{"line_number":384,"context_line":"      upgrade_tasks:"},{"line_number":385,"context_line":"        - name: Anchor for upgrade and update tasks"},{"line_number":386,"context_line":"          when: step|int \u003d\u003d 0"},{"line_number":387,"context_line":"          block: \u0026tmp_reset_label"},{"line_number":388,"context_line":"            - name: Reset selinux label on /var/tmp"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3c7ea171_077d9765","line":385,"range":{"start_line":385,"start_character":16,"end_line":385,"end_character":51},"in_reply_to":"802f6ebd_54cc6822","updated":"2021-04-23 11:25:29.000000000","message":"there\u0027s already a \"Closes-Bug\" in the commit message... ?","commit_id":"dde70a252795b57f0ab9c2e60fd5e4d916a66d2c"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"da9fc6e691d7379f2534fc2e80ea56d79bf546e7","unresolved":true,"context_lines":[{"line_number":386,"context_line":"          when: step|int \u003d\u003d 0"},{"line_number":387,"context_line":"          block: \u0026tmp_reset_label"},{"line_number":388,"context_line":"            - name: Reset selinux label on /var/tmp"},{"line_number":389,"context_line":"                file:"},{"line_number":390,"context_line":"                  path: /var/tmp"},{"line_number":391,"context_line":"                  state: directory"},{"line_number":392,"context_line":"                  setype: tmp_t"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4d936534_3dcf69e1","line":389,"updated":"2021-04-23 09:27:10.000000000","message":"There seems to be a syntax error here.","commit_id":"dde70a252795b57f0ab9c2e60fd5e4d916a66d2c"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"25c044d61cb3c398dd2c82824d3b8bd40bed5325","unresolved":false,"context_lines":[{"line_number":386,"context_line":"          when: step|int \u003d\u003d 0"},{"line_number":387,"context_line":"          block: \u0026tmp_reset_label"},{"line_number":388,"context_line":"            - name: Reset selinux label on /var/tmp"},{"line_number":389,"context_line":"                file:"},{"line_number":390,"context_line":"                  path: /var/tmp"},{"line_number":391,"context_line":"                  state: directory"},{"line_number":392,"context_line":"                  setype: tmp_t"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"670ea035_162e982b","line":389,"in_reply_to":"4d936534_3dcf69e1","updated":"2021-04-23 11:25:29.000000000","message":"Done","commit_id":"dde70a252795b57f0ab9c2e60fd5e4d916a66d2c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"fcfc33e22e0be09c6e48a4387d5de7314fcbaf1c","unresolved":true,"context_lines":[{"line_number":390,"context_line":"                path: /var/tmp"},{"line_number":391,"context_line":"                state: directory"},{"line_number":392,"context_line":"                setype: tmp_t"},{"line_number":393,"context_line":"                mode: 3777"},{"line_number":394,"context_line":"      update_tasks:"},{"line_number":395,"context_line":"        - name: Anchor for upgrade and update tasks"},{"line_number":396,"context_line":"          when: step|int \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bfd1c78b_c14283b6","line":393,"range":{"start_line":393,"start_character":22,"end_line":393,"end_character":26},"updated":"2021-04-23 13:42:44.000000000","message":"3777 or 1777? My system (it\u0027s fedora tho) is 1777\n\nstat /var/tmp\n  File: /var/tmp\n  Size: 12288     \tBlocks: 24         IO Block: 4096   directory\nDevice: fd01h/64769d\tInode: 393237      Links: 17\nAccess: (1777/drwxrwxrwt)  Uid: (    0/    root)   Gid: (    0/    root)\nContext: system_u:object_r:tmp_t:s0\nAccess: 2021-04-23 07:41:41.648131115 -0600\nModify: 2021-04-23 07:30:01.936152227 -0600\nChange: 2021-04-23 07:30:01.936152227 -0600\n Birth: 2019-11-03 10:35:13.619174001 -0700","commit_id":"0c9b2816fe225e89219910d28c39e5a9e4041271"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"c985cd1b54556b32136524d239d04c27d0169580","unresolved":true,"context_lines":[{"line_number":390,"context_line":"                path: /var/tmp"},{"line_number":391,"context_line":"                state: directory"},{"line_number":392,"context_line":"                setype: tmp_t"},{"line_number":393,"context_line":"                mode: 3777"},{"line_number":394,"context_line":"      update_tasks:"},{"line_number":395,"context_line":"        - name: Anchor for upgrade and update tasks"},{"line_number":396,"context_line":"          when: step|int \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"60b4bded_06e0363d","line":393,"range":{"start_line":393,"start_character":22,"end_line":393,"end_character":26},"in_reply_to":"bfd1c78b_c14283b6","updated":"2021-04-23 14:26:38.000000000","message":"hmmmmm. you are right. 3777 seems to be 2777 + 1777 (i.e. stick bit for the group). Good catch! It didn\u0027t show up with plain \"ls -l\" - should have thought about the stat!","commit_id":"0c9b2816fe225e89219910d28c39e5a9e4041271"}]}