)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"0eb6bd93ee3720b98af3616c3d078e63bd725859","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make SkipRhelEnforcement boolean"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The SkipRhelEnforcement parameter is supposed to be take boolean value,"},{"line_number":10,"context_line":"thus should be typed as boolean so that its type is validated as part"},{"line_number":11,"context_line":"of template validations."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3d2ab6ef_3893a087","line":9,"range":{"start_line":9,"start_character":49,"end_line":9,"end_character":51},"updated":"2021-04-22 01:05:21.000000000","message":"small nit: shouldn\u0027t it be \"is supposed to take\" ? But my English is probably not better than yours.","commit_id":"5e2f8350728320d715d86609ee2a7b65cfd0d9af"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"49b626353c4bc4ed89b12330b6de0797ac997a04","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make SkipRhelEnforcement boolean"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The SkipRhelEnforcement parameter is supposed to be take boolean value,"},{"line_number":10,"context_line":"thus should be typed as boolean so that its type is validated as part"},{"line_number":11,"context_line":"of template validations."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"42f533c8_eec366f3","line":9,"range":{"start_line":9,"start_character":49,"end_line":9,"end_character":51},"in_reply_to":"3d2ab6ef_3893a087","updated":"2021-04-22 01:10:13.000000000","message":"You are totally correct !","commit_id":"5e2f8350728320d715d86609ee2a7b65cfd0d9af"}],"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"0eb6bd93ee3720b98af3616c3d078e63bd725859","unresolved":true,"context_lines":[{"line_number":355,"context_line":"          when:"},{"line_number":356,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":357,"context_line":"            - ansible_facts[\u0027distribution\u0027] \u003d\u003d \u0027RedHat\u0027"},{"line_number":358,"context_line":"            - not (skip_rhel_enforcement | bool)"},{"line_number":359,"context_line":"        - name: Ensure DNF modules have the right stream"},{"line_number":360,"context_line":"          vars:"},{"line_number":361,"context_line":"            dnf_module_list: {get_attr: [RoleParametersValue, value, \u0027dnf_module_list\u0027]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"18908238_1dc70eea","line":358,"range":{"start_line":358,"start_character":18,"end_line":358,"end_character":48},"updated":"2021-04-22 01:05:21.000000000","message":"small nit, might as well replace this with just:\n\n    - not skip_rhel_enforcement","commit_id":"5e2f8350728320d715d86609ee2a7b65cfd0d9af"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"49b626353c4bc4ed89b12330b6de0797ac997a04","unresolved":true,"context_lines":[{"line_number":355,"context_line":"          when:"},{"line_number":356,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":357,"context_line":"            - ansible_facts[\u0027distribution\u0027] \u003d\u003d \u0027RedHat\u0027"},{"line_number":358,"context_line":"            - not (skip_rhel_enforcement | bool)"},{"line_number":359,"context_line":"        - name: Ensure DNF modules have the right stream"},{"line_number":360,"context_line":"          vars:"},{"line_number":361,"context_line":"            dnf_module_list: {get_attr: [RoleParametersValue, value, \u0027dnf_module_list\u0027]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f8bb0f36_3f680e7c","line":358,"range":{"start_line":358,"start_character":18,"end_line":358,"end_character":48},"in_reply_to":"18908238_1dc70eea","updated":"2021-04-22 01:10:13.000000000","message":"This is actually redundant but doesn\u0027t harm and we do the same for the SkipPackageUpdate parameter which is already boolean.\nSo I think we can keep this as a kind of \"last line validation\"","commit_id":"5e2f8350728320d715d86609ee2a7b65cfd0d9af"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"8d308b1355d5c7f96774a337e644df5cbf12f418","unresolved":true,"context_lines":[{"line_number":355,"context_line":"          when:"},{"line_number":356,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":357,"context_line":"            - ansible_facts[\u0027distribution\u0027] \u003d\u003d \u0027RedHat\u0027"},{"line_number":358,"context_line":"            - not (skip_rhel_enforcement | bool)"},{"line_number":359,"context_line":"        - name: Ensure DNF modules have the right stream"},{"line_number":360,"context_line":"          vars:"},{"line_number":361,"context_line":"            dnf_module_list: {get_attr: [RoleParametersValue, value, \u0027dnf_module_list\u0027]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1335b0d0_09bfaea3","line":358,"range":{"start_line":358,"start_character":18,"end_line":358,"end_character":48},"in_reply_to":"f8bb0f36_3f680e7c","updated":"2021-04-22 01:17:43.000000000","message":"Yeah I validated with other booleans before posting this. Some of them have it, some others don\u0027t. No harms indeed.","commit_id":"5e2f8350728320d715d86609ee2a7b65cfd0d9af"}]}