)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"c4a1aabb53ea4a14680bc376c9bdd6af5592fcb2","unresolved":true,"context_lines":[{"line_number":20,"context_line":"This introduces a nova_virtlogd_wrapper container and virtlogd wrapper"},{"line_number":21,"context_line":"script, to only restart virtlogd on either manual or compute node restart."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"With NovaEnableVirtlogdContainerWrapper the virtlogd wrapper can be"},{"line_number":24,"context_line":"disabled."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Co-Authored-By: Rajesh Tailor \u003cratailor@redhat.com\u003e"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3bab48e6_d1b98d23","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":9},"updated":"2021-05-04 11:55:16.000000000","message":"Why would anyone want to disable it?","commit_id":"49415d04b2f97583d63004420b500d454f62386a"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"8170631f4533a77174cbaf2a2cc062db1132982a","unresolved":true,"context_lines":[{"line_number":20,"context_line":"This introduces a nova_virtlogd_wrapper container and virtlogd wrapper"},{"line_number":21,"context_line":"script, to only restart virtlogd on either manual or compute node restart."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"With NovaEnableVirtlogdContainerWrapper the virtlogd wrapper can be"},{"line_number":24,"context_line":"disabled."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Co-Authored-By: Rajesh Tailor \u003cratailor@redhat.com\u003e"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9fb5a295_9cf7c07b","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":9},"in_reply_to":"29001254_075be23e","updated":"2021-05-04 13:11:00.000000000","message":"It seems a bit dangerous though since this fails silently. Is there a compelling use case for it?\nAlso is it worth the extra cost of testing/maintaining two code paths?","commit_id":"49415d04b2f97583d63004420b500d454f62386a"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"4068415d1eada3cf66896337fcf52f25220936a7","unresolved":true,"context_lines":[{"line_number":20,"context_line":"This introduces a nova_virtlogd_wrapper container and virtlogd wrapper"},{"line_number":21,"context_line":"script, to only restart virtlogd on either manual or compute node restart."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"With NovaEnableVirtlogdContainerWrapper the virtlogd wrapper can be"},{"line_number":24,"context_line":"disabled."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Co-Authored-By: Rajesh Tailor \u003cratailor@redhat.com\u003e"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"29001254_075be23e","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":9},"in_reply_to":"3bab48e6_d1b98d23","updated":"2021-05-04 12:09:55.000000000","message":"If someone prefers to have virtlogd.conf changes with auto restart of virtlogd container and is ok to loose console.log output while doing that change automatically.","commit_id":"49415d04b2f97583d63004420b500d454f62386a"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"7873ebad24c587f2f5b7420867559c12316f2423","unresolved":true,"context_lines":[{"line_number":20,"context_line":"This introduces a nova_virtlogd_wrapper container and virtlogd wrapper"},{"line_number":21,"context_line":"script, to only restart virtlogd on either manual or compute node restart."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"With NovaEnableVirtlogdContainerWrapper the virtlogd wrapper can be"},{"line_number":24,"context_line":"disabled."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Co-Authored-By: Rajesh Tailor \u003cratailor@redhat.com\u003e"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"99e22421_a6ce5fb9","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":9},"in_reply_to":"9b401bc4_33480ce6","updated":"2021-05-04 15:42:24.000000000","message":"I\u0027ve seen bad things when virtlogd is in the bad state so this feature will certainly help. I also agree that this probably shouldn\u0027t be disabled but it\u0027s enabled by default and it\u0027s a good thing to let operators decide if they want it or not.","commit_id":"49415d04b2f97583d63004420b500d454f62386a"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"098df22277f6e61b3f61aaff8cd94b303a8fe5e8","unresolved":true,"context_lines":[{"line_number":20,"context_line":"This introduces a nova_virtlogd_wrapper container and virtlogd wrapper"},{"line_number":21,"context_line":"script, to only restart virtlogd on either manual or compute node restart."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"With NovaEnableVirtlogdContainerWrapper the virtlogd wrapper can be"},{"line_number":24,"context_line":"disabled."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Co-Authored-By: Rajesh Tailor \u003cratailor@redhat.com\u003e"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9b401bc4_33480ce6","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":9},"in_reply_to":"9fb5a295_9cf7c07b","updated":"2021-05-04 15:22:17.000000000","message":"\u003e It seems a bit dangerous though since this fails silently. Is there a compelling use case for it?\n\u003e Also is it worth the extra cost of testing/maintaining two code paths?\n\nwhen disable the wrapper you basically get what we have today. We\ncould remove it, I wanted to be able to be able to configure what we have today for a cycle or so and the remove it. But if the conses is to not be able to switch, I can remove it.","commit_id":"49415d04b2f97583d63004420b500d454f62386a"}]}