)]}'
{"overcloud.j2.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"109aa2353a5b0ced896d207ac6f24c877ba6d652","unresolved":true,"context_lines":[{"line_number":1161,"context_line":"{%- endfor %}"},{"line_number":1162,"context_line":"      role_data:"},{"line_number":1163,"context_line":"{%- for role in roles %}"},{"line_number":1164,"context_line":"        {{role.name}}: {get_attr: [{{role.name}}ServiceChainRoleData, value]}"},{"line_number":1165,"context_line":"{%- endfor %}"},{"line_number":1166,"context_line":""},{"line_number":1167,"context_line":"  BlacklistedIpAddresses:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"37225190_f84619d7","line":1164,"range":{"start_line":1164,"start_character":8,"end_line":1164,"end_character":77},"updated":"2021-04-28 10:04:40.000000000","message":"Don\u0027t you need RoleParameters? Why the whole role_data from ServiceChain?\n\nrole_parameters_map:\n{%- for role in roles %}\n  {{role.name}}:\n      map_merge:\n        - {{role.RoleParametersDefault|default({})}}\n        - get_param: {{role.name}}Parameters\n{%- endfor %}","commit_id":"01de8a6d52e6f0af779d0c7a2c90ba360f10fca0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a175451fd726877b5bb21fe6dae4437f658ded12","unresolved":true,"context_lines":[{"line_number":1161,"context_line":"{%- endfor %}"},{"line_number":1162,"context_line":"      role_data:"},{"line_number":1163,"context_line":"{%- for role in roles %}"},{"line_number":1164,"context_line":"        {{role.name}}: {get_attr: [{{role.name}}ServiceChainRoleData, value]}"},{"line_number":1165,"context_line":"{%- endfor %}"},{"line_number":1166,"context_line":""},{"line_number":1167,"context_line":"  BlacklistedIpAddresses:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7fbb72b9_5979cf02","line":1164,"range":{"start_line":1164,"start_character":8,"end_line":1164,"end_character":77},"in_reply_to":"37225190_f84619d7","updated":"2021-04-28 12:28:29.000000000","message":"Thanks I misunderstand which layer represents role parameters...\n\nThe reason why I tried using ServiceChain is that I wanted to put a logic to generate role specific parameters but I noticed that we already have two places... so adding one more won\u0027t make much difference...","commit_id":"01de8a6d52e6f0af779d0c7a2c90ba360f10fca0"}],"releasenotes/notes/all_nodes_extra_config-role_data-0b63fe70b5cebad9.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"de423605bb79fb2829a588d350a7a543707793f9","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Now the ``OS::TripleO::AllNodesDeployment`` requires the ``role_data``"},{"line_number":5,"context_line":"    parameter."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"28980b34_fc397177","line":4,"range":{"start_line":4,"start_character":63,"end_line":4,"end_character":72},"updated":"2021-04-29 00:38:09.000000000","message":"This should be fixed.","commit_id":"a7c89bade04f47b46208a701ff11fa00a098c06f"}]}