)]}'
{"deployment/openvswitch/openvswitch-dpdk-baremetal-ansible.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ba996741f5a2557dd974272322428a5be148f7f5","unresolved":true,"context_lines":[{"line_number":109,"context_line":"      Balance may be triggered."},{"line_number":110,"context_line":"    constraints:"},{"line_number":111,"context_line":"      - allowed_pattern: \"[0-9]*\""},{"line_number":112,"context_line":"    type: string"},{"line_number":113,"context_line":"    default: \"\""},{"line_number":114,"context_line":"    tags:"},{"line_number":115,"context_line":"      - role_specific"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"409f408e_c4256286","line":112,"updated":"2021-06-01 13:54:25.000000000","message":"Should this be an integer with a default of 0 and using range instead of a pattern?\n\nhttps://docs.openstack.org/heat/latest/template_guide/hot_spec.html#parameter-constraints","commit_id":"f352d74abec7f8344a4b3893ea3478aa498f31dc"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"321f5538e1c6be6332aef68ee499519350338773","unresolved":true,"context_lines":[{"line_number":109,"context_line":"      Balance may be triggered."},{"line_number":110,"context_line":"    constraints:"},{"line_number":111,"context_line":"      - allowed_pattern: \"[0-9]*\""},{"line_number":112,"context_line":"    type: string"},{"line_number":113,"context_line":"    default: \"\""},{"line_number":114,"context_line":"    tags:"},{"line_number":115,"context_line":"      - role_specific"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e32142f7_f21f4571","line":112,"in_reply_to":"342d2a4a_c14fcbd3","updated":"2021-06-01 14:56:54.000000000","message":"yea that\u0027s what i gets converted to when it\u0027s set, but because it needs to be an integer it\u0027s better to actually enforce that here","commit_id":"f352d74abec7f8344a4b3893ea3478aa498f31dc"},{"author":{"_account_id":14972,"name":"yogananth Subramanian","email":"ysubrama@redhat.com","username":"yogi"},"change_message_id":"176adb00d41c5ebe567e4e296258371c24a797c8","unresolved":true,"context_lines":[{"line_number":109,"context_line":"      Balance may be triggered."},{"line_number":110,"context_line":"    constraints:"},{"line_number":111,"context_line":"      - allowed_pattern: \"[0-9]*\""},{"line_number":112,"context_line":"    type: string"},{"line_number":113,"context_line":"    default: \"\""},{"line_number":114,"context_line":"    tags:"},{"line_number":115,"context_line":"      - role_specific"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"342d2a4a_c14fcbd3","line":112,"in_reply_to":"409f408e_c4256286","updated":"2021-06-01 14:54:24.000000000","message":"Hello Alex, the ovs db considers expects a string containing an integer for \"pmd-auto-lb-load-threshold\", hence I have used string with pattern.\nhttps://man7.org/linux/man-pages/man5/ovs-vswitchd.conf.db.5.html","commit_id":"f352d74abec7f8344a4b3893ea3478aa498f31dc"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ba8223726d6a9c84e40531c58ae62d4a0cb8601e","unresolved":true,"context_lines":[{"line_number":109,"context_line":"      Balance may be triggered."},{"line_number":110,"context_line":"    constraints:"},{"line_number":111,"context_line":"      - allowed_pattern: \"[0-9]*\""},{"line_number":112,"context_line":"    type: string"},{"line_number":113,"context_line":"    default: \"\""},{"line_number":114,"context_line":"    tags:"},{"line_number":115,"context_line":"      - role_specific"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"81f80dac_c0164d5a","line":112,"in_reply_to":"63c088b3_f0c43e02","updated":"2021-06-01 17:50:38.000000000","message":"k we\u0027ll go with this since there are already other params where we use this pattern. I don\u0027t necessarily like it because it\u0027s better to enforce the type here rather than later.","commit_id":"f352d74abec7f8344a4b3893ea3478aa498f31dc"},{"author":{"_account_id":14972,"name":"yogananth Subramanian","email":"ysubrama@redhat.com","username":"yogi"},"change_message_id":"393e9345f34e629d6fcbb3aca05b438e24a8a402","unresolved":true,"context_lines":[{"line_number":109,"context_line":"      Balance may be triggered."},{"line_number":110,"context_line":"    constraints:"},{"line_number":111,"context_line":"      - allowed_pattern: \"[0-9]*\""},{"line_number":112,"context_line":"    type: string"},{"line_number":113,"context_line":"    default: \"\""},{"line_number":114,"context_line":"    tags:"},{"line_number":115,"context_line":"      - role_specific"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"63c088b3_f0c43e02","line":112,"in_reply_to":"e32142f7_f21f4571","updated":"2021-06-01 16:26:39.000000000","message":"The default value of parameters being used here is not always 0, in case of \"pmd-auto-lb-load-threshold\" it is 95. Though the default value for a parameter used by OVS is unlikely to change  in future release of OVS, by using the default value used by OVS for the parameters in heat, heat code might end up being tightly coupled with OVS.\n\nUsing string, allow setting an empty sting \"\", then the key \"pmd-auto-lb-load-threshold\" would end up being removed from the OVS db and ovs would use the default value, in the case for  pmd-auto-lb-load-threshold, it would be 95, as stated in https://man7.org/linux/man-pages/man5/ovs-vswitchd.conf.db.5.html. So with the current heat and tripleo-ansible patch set, by using an empty string, no value would end up being set in OVS db and ovs would end up using the default.\n\nHence had used string in heat and in tripleo_ansible ( https://review.opendev.org/c/openstack/tripleo-ansible/+/790251/1/tripleo_ansible/roles/tripleo_ovs_dpdk/tasks/config.yml )\n\nWould love to hear you thoughts on it and happy to rewrite the patch set with integers.","commit_id":"f352d74abec7f8344a4b3893ea3478aa498f31dc"}],"releasenotes/notes/ovs-dpdk-pmd-params-55df11e67acb6736.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2bdf0ffedb55fbe0e43debe3000216af51797d27","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"- Add support for OVS DPDK pmd auto balance parameters."},{"line_number":4,"context_line":"  This feature adds 3 new THT parameters to set"},{"line_number":5,"context_line":"  pmd-auto-lb-load-threshold, pmd-auto-lb-improvement-threshold,"},{"line_number":6,"context_line":"  and pmd-auto-lb-rebal-interval in OVS through OvsPmdLoadThreshold,"},{"line_number":7,"context_line":"  OvsPmdImprovementThreshold and OvsPmdRebalInterval respectively."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df27c39a_f387de99","line":4,"range":{"start_line":4,"start_character":20,"end_line":4,"end_character":41},"updated":"2021-05-29 06:32:26.000000000","message":"These parameters are role specific to good to mention that here and in the commit message,","commit_id":"480030871fd6f0f5e7cf9ab9c72d33920fa01e9d"},{"author":{"_account_id":14972,"name":"yogananth Subramanian","email":"ysubrama@redhat.com","username":"yogi"},"change_message_id":"0490091a24e20d418918f2eb74227a60d561064f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"- Add support for OVS DPDK pmd auto balance parameters."},{"line_number":4,"context_line":"  This feature adds 3 new THT parameters to set"},{"line_number":5,"context_line":"  pmd-auto-lb-load-threshold, pmd-auto-lb-improvement-threshold,"},{"line_number":6,"context_line":"  and pmd-auto-lb-rebal-interval in OVS through OvsPmdLoadThreshold,"},{"line_number":7,"context_line":"  OvsPmdImprovementThreshold and OvsPmdRebalInterval respectively."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"af8fc540_04ea4b39","line":4,"range":{"start_line":4,"start_character":20,"end_line":4,"end_character":41},"in_reply_to":"df27c39a_f387de99","updated":"2021-05-31 16:43:52.000000000","message":"Ack","commit_id":"480030871fd6f0f5e7cf9ab9c72d33920fa01e9d"}]}