)]}'
{"deployment/ovn/ovn-controller-container-puppet.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"408d4f5f5226c9ba6b59714583a7c18fa438394a","unresolved":true,"context_lines":[{"line_number":406,"context_line":"      external_deploy_tasks:"},{"line_number":407,"context_line":"        - when:"},{"line_number":408,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":409,"context_line":"            - \"\u0027{get_param: RoleName}\u0027 in groups\""},{"line_number":410,"context_line":"          name: ovn_controller_external_deploy_init"},{"line_number":411,"context_line":"          block:"},{"line_number":412,"context_line":"            - name:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"14c9dd7c_f071d5d7","line":409,"range":{"start_line":409,"start_character":0,"end_line":409,"end_character":36},"updated":"2021-05-12 02:46:34.000000000","message":"I don\u0027t think get_param within quotes would be resolved by heat. I\u0027ve proposed a patch[1] to not add these tasks for roles with zero count, which could possibly help.\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/790893","commit_id":"eec1504d45d0ba3eabf6a458bb384dc74e916e5a"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"70a9da7793f09c3d1dadc65689d0581e7cd3d6cf","unresolved":true,"context_lines":[{"line_number":406,"context_line":"      external_deploy_tasks:"},{"line_number":407,"context_line":"        - when:"},{"line_number":408,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":409,"context_line":"            - \"\u0027{get_param: RoleName}\u0027 in groups\""},{"line_number":410,"context_line":"          name: ovn_controller_external_deploy_init"},{"line_number":411,"context_line":"          block:"},{"line_number":412,"context_line":"            - name:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"02c16294_71a74f33","line":409,"range":{"start_line":409,"start_character":0,"end_line":409,"end_character":36},"in_reply_to":"14c9dd7c_f071d5d7","updated":"2021-05-12 05:46:39.000000000","message":"Yes, I think this needs to use a str_replace similar to the one at L422.\nI updated this patch, but I do like Rabi\u0027s other proposed fix[1] better.\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/790893","commit_id":"eec1504d45d0ba3eabf6a458bb384dc74e916e5a"}]}
