)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b796e6f40607b580876cfe7a528d8cd611d477c9","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Don\u0027t add external tasks for roles with zero count"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We don\u0027t need to add these tasks for roles with zero"},{"line_number":10,"context_line":"count. We probably should not create service chains for"},{"line_number":11,"context_line":"roles with zero count, but that\u0027s a bigger change."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I41c6b4799eef7940b12811468dcc48e7b6fa543b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c49040a2_8ed276dc","line":10,"range":{"start_line":10,"start_character":7,"end_line":10,"end_character":51},"updated":"2021-05-12 05:50:20.000000000","message":"+1\nI wonder how many minutes we\u0027d shave of CI job\u0027s if we used a custom role_data with just the roles actually deployed? If jobs do service chaining for Ceph, BlockStorage, ObjectStorage roles etc by default ...","commit_id":"7fd0dd5d4b5d98d3f0d887979f892017cd632417"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2aaf445ecb805faa41e36aaa90c9bc74d92caeba","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Don\u0027t add external tasks for roles with zero count"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We don\u0027t need to add these tasks for roles with zero"},{"line_number":10,"context_line":"count. We probably should not create service chains for"},{"line_number":11,"context_line":"roles with zero count, but that\u0027s a bigger change."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I41c6b4799eef7940b12811468dcc48e7b6fa543b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4bf51d62_906ec580","line":10,"range":{"start_line":10,"start_character":7,"end_line":10,"end_character":51},"in_reply_to":"c49040a2_8ed276dc","updated":"2021-05-12 05:52:55.000000000","message":"Heat does not take a lot of time in CI atm. But yeah that\u0027s a good optimization for large deployments. I\u0027ll propose a patch later.","commit_id":"7fd0dd5d4b5d98d3f0d887979f892017cd632417"}],"common/deploy-steps.j2":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a593a45988ce1efee23d6712165abc8c10b5115d","unresolved":true,"context_lines":[{"line_number":700,"context_line":"                    - ((deploy_artifact_urls | default([]) | length) \u003e 0) or"},{"line_number":701,"context_line":"                      ((deploy_artifact_files | default([]) | length) \u003e 0)"},{"line_number":702,"context_line":"{% endraw %}"},{"line_number":703,"context_line":"{%- for role in roles %}"},{"line_number":704,"context_line":"                - name: {{role.name}} Host prep block"},{"line_number":705,"context_line":"                  when:"},{"line_number":706,"context_line":"                    - tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"dab1f3a1_cb3ae013","line":703,"updated":"2021-05-12 13:46:54.000000000","message":"Would we want to also skip these if role is 0?","commit_id":"7fd0dd5d4b5d98d3f0d887979f892017cd632417"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ea3f1bb86433c613b29aeca9d37e0f5a0b23969e","unresolved":true,"context_lines":[{"line_number":700,"context_line":"                    - ((deploy_artifact_urls | default([]) | length) \u003e 0) or"},{"line_number":701,"context_line":"                      ((deploy_artifact_files | default([]) | length) \u003e 0)"},{"line_number":702,"context_line":"{% endraw %}"},{"line_number":703,"context_line":"{%- for role in roles %}"},{"line_number":704,"context_line":"                - name: {{role.name}} Host prep block"},{"line_number":705,"context_line":"                  when:"},{"line_number":706,"context_line":"                    - tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"0121225d_7577f893","line":703,"in_reply_to":"9fff9ac1_7a7ae66c","updated":"2021-05-12 13:57:29.000000000","message":"i guess we can\u0027t","commit_id":"7fd0dd5d4b5d98d3f0d887979f892017cd632417"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"76204d33d1e916954bafffc6488543248c85ba6c","unresolved":true,"context_lines":[{"line_number":700,"context_line":"                    - ((deploy_artifact_urls | default([]) | length) \u003e 0) or"},{"line_number":701,"context_line":"                      ((deploy_artifact_files | default([]) | length) \u003e 0)"},{"line_number":702,"context_line":"{% endraw %}"},{"line_number":703,"context_line":"{%- for role in roles %}"},{"line_number":704,"context_line":"                - name: {{role.name}} Host prep block"},{"line_number":705,"context_line":"                  when:"},{"line_number":706,"context_line":"                    - tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9fff9ac1_7a7ae66c","line":703,"in_reply_to":"dab1f3a1_cb3ae013","updated":"2021-05-12 13:54:50.000000000","message":"I guess it would make sense, but this is inside the str_replace from L446 so I don\u0027t think we could use the heat if {{role.name}}NonZero condition to control it here.","commit_id":"7fd0dd5d4b5d98d3f0d887979f892017cd632417"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a593a45988ce1efee23d6712165abc8c10b5115d","unresolved":true,"context_lines":[{"line_number":772,"context_line":"                  run_once: true"},{"line_number":773,"context_line":"                  debug:"},{"line_number":774,"context_line":"                    msg: Use --start-at-task \u0027Pre Deployment Step Tasks\u0027 to resume from this task"},{"line_number":775,"context_line":"{%- for role in roles %}"},{"line_number":776,"context_line":"                - name: {{role.name}} Pre Deployment Step Tasks block"},{"line_number":777,"context_line":"                  include_tasks: {{role.name}}/pre_deploy_step_tasks.yaml"},{"line_number":778,"context_line":"                  when:"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"44d99535_ba71e5b1","line":775,"updated":"2021-05-12 13:46:54.000000000","message":"here too?","commit_id":"7fd0dd5d4b5d98d3f0d887979f892017cd632417"}]}