)]}'
{"deployment/nova/nova-apidb-client-puppet.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"663d407d931bcc04776ef4eb6c7c3e536a9857fa","unresolved":true,"context_lines":[{"line_number":57,"context_line":"                  plugin: collectd"},{"line_number":58,"context_line":"                  collectd_program_name: nova_api"},{"line_number":59,"context_line":"                  collectd_host: localhost"},{"line_number":60,"context_line":"                - read_default_file: /etc/my.cnf.d/tripleo.cnf"},{"line_number":61,"context_line":"                  read_default_group: tripleo"},{"line_number":62,"context_line":"      service_config_settings:"},{"line_number":63,"context_line":"        mysql:"},{"line_number":64,"context_line":"          nova::db::mysql_api::password: {get_param: NovaPassword}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"30aa7983_53335b8c","line":61,"range":{"start_line":60,"start_character":18,"end_line":61,"end_character":45},"updated":"2021-05-24 10:55:16.000000000","message":"would be better to set this once and map_merge the collectd keys?","commit_id":"04f99a410a6c251d92611d5f71856d49d06fcc28"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"6616c88cbb4835131093156201d232acf17395f5","unresolved":true,"context_lines":[{"line_number":57,"context_line":"                  plugin: collectd"},{"line_number":58,"context_line":"                  collectd_program_name: nova_api"},{"line_number":59,"context_line":"                  collectd_host: localhost"},{"line_number":60,"context_line":"                - read_default_file: /etc/my.cnf.d/tripleo.cnf"},{"line_number":61,"context_line":"                  read_default_group: tripleo"},{"line_number":62,"context_line":"      service_config_settings:"},{"line_number":63,"context_line":"        mysql:"},{"line_number":64,"context_line":"          nova::db::mysql_api::password: {get_param: NovaPassword}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"578ad6f1_b69d4e1e","line":61,"range":{"start_line":60,"start_character":18,"end_line":61,"end_character":45},"in_reply_to":"30aa7983_53335b8c","updated":"2021-05-24 11:03:44.000000000","message":"Adding an intrinsic function would probably be more expensive. I ignored them as these are just two keys repeated as before.","commit_id":"04f99a410a6c251d92611d5f71856d49d06fcc28"}],"deployment/nova/nova-az-config.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4de5fce30283c6a16be35c667bb7eab49958e23a","unresolved":true,"context_lines":[{"line_number":74,"context_line":"                - {get_param: NovaComputeAvailabilityZone}"},{"line_number":75,"context_line":"                - {get_param: RootStackName}"},{"line_number":76,"context_line":"            availability_zone:"},{"line_number":77,"context_line":"              if:"},{"line_number":78,"context_line":"                - availability_zone_set"},{"line_number":79,"context_line":"                - {get_param: NovaComputeAvailabilityZone}"},{"line_number":80,"context_line":"                - {get_param: RootStackName}"},{"line_number":81,"context_line":"            hosts: \"{{ groups[\u0027nova_compute\u0027] | default([]) | map(\u0027extract\u0027, hostvars, \u0027nova_host\u0027) | select(\u0027defined\u0027) | list }}\""},{"line_number":82,"context_line":"            auth:"},{"line_number":83,"context_line":"              username: admin"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2da391f0_1fbb4f90","line":80,"range":{"start_line":77,"start_character":0,"end_line":80,"end_character":44},"updated":"2021-05-14 10:27:10.000000000","message":"nit: this probably could be stored then referenced as a YAML variable?","commit_id":"7c3900dbefeed4bfc19f645919df624b9217b754"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"872ce7bfead25106ce0af4db2de65b069c20262d","unresolved":true,"context_lines":[{"line_number":74,"context_line":"                - {get_param: NovaComputeAvailabilityZone}"},{"line_number":75,"context_line":"                - {get_param: RootStackName}"},{"line_number":76,"context_line":"            availability_zone:"},{"line_number":77,"context_line":"              if:"},{"line_number":78,"context_line":"                - availability_zone_set"},{"line_number":79,"context_line":"                - {get_param: NovaComputeAvailabilityZone}"},{"line_number":80,"context_line":"                - {get_param: RootStackName}"},{"line_number":81,"context_line":"            hosts: \"{{ groups[\u0027nova_compute\u0027] | default([]) | map(\u0027extract\u0027, hostvars, \u0027nova_host\u0027) | select(\u0027defined\u0027) | list }}\""},{"line_number":82,"context_line":"            auth:"},{"line_number":83,"context_line":"              username: admin"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"53c743a5_e24ff191","line":80,"range":{"start_line":77,"start_character":0,"end_line":80,"end_character":44},"in_reply_to":"2da391f0_1fbb4f90","updated":"2021-05-14 11:28:06.000000000","message":"meh:)","commit_id":"7c3900dbefeed4bfc19f645919df624b9217b754"}],"deployment/nova/nova-base-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4de5fce30283c6a16be35c667bb7eab49958e23a","unresolved":true,"context_lines":[{"line_number":201,"context_line":"            if:"},{"line_number":202,"context_line":"            - compute_upgrade_level_set"},{"line_number":203,"context_line":"            - {get_param: UpgradeLevelNovaCompute}"},{"line_number":204,"context_line":"        - get_attr: [RoleParametersValue, value]"},{"line_number":205,"context_line":"      service_config_settings:"},{"line_number":206,"context_line":"        rabbitmq:"},{"line_number":207,"context_line":"          nova::rabbit_use_ssl: {get_param: RpcUseSSL}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"93523b7b_42a8b5c2","line":204,"range":{"start_line":204,"start_character":0,"end_line":204,"end_character":48},"updated":"2021-05-14 10:27:10.000000000","message":"does the changed order of merging this matter?","commit_id":"7c3900dbefeed4bfc19f645919df624b9217b754"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"872ce7bfead25106ce0af4db2de65b069c20262d","unresolved":true,"context_lines":[{"line_number":201,"context_line":"            if:"},{"line_number":202,"context_line":"            - compute_upgrade_level_set"},{"line_number":203,"context_line":"            - {get_param: UpgradeLevelNovaCompute}"},{"line_number":204,"context_line":"        - get_attr: [RoleParametersValue, value]"},{"line_number":205,"context_line":"      service_config_settings:"},{"line_number":206,"context_line":"        rabbitmq:"},{"line_number":207,"context_line":"          nova::rabbit_use_ssl: {get_param: RpcUseSSL}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4edefc9d_bfddfe00","line":204,"range":{"start_line":204,"start_character":0,"end_line":204,"end_character":48},"in_reply_to":"93523b7b_42a8b5c2","updated":"2021-05-14 11:28:06.000000000","message":"There are multiple maps merged earlier. This changes it to just 2. Order does not matter RoleParametersValue does not have  UpgradeLevelNovaCompute or MemcachedTLS.","commit_id":"7c3900dbefeed4bfc19f645919df624b9217b754"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4de5fce30283c6a16be35c667bb7eab49958e23a","unresolved":true,"context_lines":[{"line_number":488,"context_line":"    description: Whether to wait for `network-vif-plugged` events before starting guest transfer."},{"line_number":489,"context_line":"    default: true"},{"line_number":490,"context_line":"    type: boolean"},{"line_number":491,"context_line":"  NovaLiveMigrationPermitPostCopy:"},{"line_number":492,"context_line":"    description: \u003e"},{"line_number":493,"context_line":"      Set to \"True\" to activate the instance on the destination node before migration is complete,"},{"line_number":494,"context_line":"      and to set an upper bound on the memory that needs to be transferred."},{"line_number":495,"context_line":"    default: false"},{"line_number":496,"context_line":"    type: boolean"},{"line_number":497,"context_line":"    tags:"},{"line_number":498,"context_line":"      - role_specific"},{"line_number":499,"context_line":"  NovaLiveMigrationPermitAutoConverge:"},{"line_number":500,"context_line":"    description: \u003e"},{"line_number":501,"context_line":"        Set to \"True\" to slow down the instance CPU until the memory copy process is faster than the"},{"line_number":502,"context_line":"        instance\u0027s memory writes when the migration performance is slow and might not complete."},{"line_number":503,"context_line":"        Auto converge will only be used if this flag is set to True and post copy is not permitted"},{"line_number":504,"context_line":"        or post copy is unavailable due to the version of libvirt and QEMU."},{"line_number":505,"context_line":"    default: false"},{"line_number":506,"context_line":"    type: boolean"},{"line_number":507,"context_line":"    tags:"},{"line_number":508,"context_line":"      - role_specific"},{"line_number":509,"context_line":"  MultipathdEnable:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"06bff487_1508d505","line":506,"range":{"start_line":491,"start_character":0,"end_line":506,"end_character":17},"updated":"2021-05-14 10:27:10.000000000","message":"I don\u0027t think we can change parameters type because of upgrade impact?","commit_id":"7c3900dbefeed4bfc19f645919df624b9217b754"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"05f493984861ac4e8040e6df1041988e91cc079f","unresolved":true,"context_lines":[{"line_number":488,"context_line":"    description: Whether to wait for `network-vif-plugged` events before starting guest transfer."},{"line_number":489,"context_line":"    default: true"},{"line_number":490,"context_line":"    type: boolean"},{"line_number":491,"context_line":"  NovaLiveMigrationPermitPostCopy:"},{"line_number":492,"context_line":"    description: \u003e"},{"line_number":493,"context_line":"      Set to \"True\" to activate the instance on the destination node before migration is complete,"},{"line_number":494,"context_line":"      and to set an upper bound on the memory that needs to be transferred."},{"line_number":495,"context_line":"    default: false"},{"line_number":496,"context_line":"    type: boolean"},{"line_number":497,"context_line":"    tags:"},{"line_number":498,"context_line":"      - role_specific"},{"line_number":499,"context_line":"  NovaLiveMigrationPermitAutoConverge:"},{"line_number":500,"context_line":"    description: \u003e"},{"line_number":501,"context_line":"        Set to \"True\" to slow down the instance CPU until the memory copy process is faster than the"},{"line_number":502,"context_line":"        instance\u0027s memory writes when the migration performance is slow and might not complete."},{"line_number":503,"context_line":"        Auto converge will only be used if this flag is set to True and post copy is not permitted"},{"line_number":504,"context_line":"        or post copy is unavailable due to the version of libvirt and QEMU."},{"line_number":505,"context_line":"    default: false"},{"line_number":506,"context_line":"    type: boolean"},{"line_number":507,"context_line":"    tags:"},{"line_number":508,"context_line":"      - role_specific"},{"line_number":509,"context_line":"  MultipathdEnable:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b4fabc00_85742302","line":506,"range":{"start_line":491,"start_character":0,"end_line":506,"end_character":17},"in_reply_to":"06bff487_1508d505","updated":"2021-05-14 10:28:39.000000000","message":"what if an operator has NovaLiveMigrationPermitAutoConverge: \"true\" in the customizations?","commit_id":"7c3900dbefeed4bfc19f645919df624b9217b754"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"872ce7bfead25106ce0af4db2de65b069c20262d","unresolved":true,"context_lines":[{"line_number":488,"context_line":"    description: Whether to wait for `network-vif-plugged` events before starting guest transfer."},{"line_number":489,"context_line":"    default: true"},{"line_number":490,"context_line":"    type: boolean"},{"line_number":491,"context_line":"  NovaLiveMigrationPermitPostCopy:"},{"line_number":492,"context_line":"    description: \u003e"},{"line_number":493,"context_line":"      Set to \"True\" to activate the instance on the destination node before migration is complete,"},{"line_number":494,"context_line":"      and to set an upper bound on the memory that needs to be transferred."},{"line_number":495,"context_line":"    default: false"},{"line_number":496,"context_line":"    type: boolean"},{"line_number":497,"context_line":"    tags:"},{"line_number":498,"context_line":"      - role_specific"},{"line_number":499,"context_line":"  NovaLiveMigrationPermitAutoConverge:"},{"line_number":500,"context_line":"    description: \u003e"},{"line_number":501,"context_line":"        Set to \"True\" to slow down the instance CPU until the memory copy process is faster than the"},{"line_number":502,"context_line":"        instance\u0027s memory writes when the migration performance is slow and might not complete."},{"line_number":503,"context_line":"        Auto converge will only be used if this flag is set to True and post copy is not permitted"},{"line_number":504,"context_line":"        or post copy is unavailable due to the version of libvirt and QEMU."},{"line_number":505,"context_line":"    default: false"},{"line_number":506,"context_line":"    type: boolean"},{"line_number":507,"context_line":"    tags:"},{"line_number":508,"context_line":"      - role_specific"},{"line_number":509,"context_line":"  MultipathdEnable:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e6e61eba_069d1d50","line":506,"range":{"start_line":491,"start_character":0,"end_line":506,"end_character":17},"in_reply_to":"b4fabc00_85742302","updated":"2021-05-14 11:28:06.000000000","message":"Not sure what you mean. It has a constraint that can take only boolean values. Parameter would be converted to booleans by heat if the type is boolean.\n\n(undercloud) [CentOS-8 - stack@undercloud ~]$ cat test.yaml \nheat_template_version: wallaby\nparameters:\n  test_bool:\n    type: boolean\n  test_another_bool:\n    type: boolean\n\noutputs:\n  op1:\n    value: {get_param: test_bool}\n  op2:\n    value: {get_param: test_another_bool}\n\n(undercloud) [CentOS-8 - stack@undercloud ~]$ cat env.yaml \nparameter_defaults:\n  test_bool: \"true\"\n  test_another_bool: \"True\"\n(undercloud) [CentOS-8 - stack@undercloud ~]$ openstack stack create test -t test.yaml -e env.yaml \n+---------------------+--------------------------------------+\n| Field               | Value                                |\n+---------------------+--------------------------------------+\n| id                  | a4b12a33-fd2b-4e68-9947-5ad2e165cdd4 |\n| stack_name          | test                                 |\n| description         | No description                       |\n| creation_time       | 2021-05-14T11:20:40Z                 |\n| updated_time        | None                                 |\n| stack_status        | CREATE_COMPLETE                      |\n| stack_status_reason | Stack CREATE completed successfully  |\n+---------------------+--------------------------------------+\n(undercloud) [CentOS-8 - stack@undercloud ~]$ openstack stack output show test op1\n+--------------+----------------------+\n| Field        | Value                |\n+--------------+----------------------+\n| description  | No description given |\n| output_key   | op1                  |\n| output_value | True                 |\n+--------------+----------------------+\n(undercloud) [CentOS-8 - stack@undercloud ~]$ openstack stack output show test op2\n+--------------+----------------------+\n| Field        | Value                |\n+--------------+----------------------+\n| description  | No description given |\n| output_key   | op2                  |\n| output_value | True                 |\n+--------------+----------------------+","commit_id":"7c3900dbefeed4bfc19f645919df624b9217b754"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"0376aab7871741a70302cf9050e001958bbcd401","unresolved":false,"context_lines":[{"line_number":488,"context_line":"    description: Whether to wait for `network-vif-plugged` events before starting guest transfer."},{"line_number":489,"context_line":"    default: true"},{"line_number":490,"context_line":"    type: boolean"},{"line_number":491,"context_line":"  NovaLiveMigrationPermitPostCopy:"},{"line_number":492,"context_line":"    description: \u003e"},{"line_number":493,"context_line":"      Set to \"True\" to activate the instance on the destination node before migration is complete,"},{"line_number":494,"context_line":"      and to set an upper bound on the memory that needs to be transferred."},{"line_number":495,"context_line":"    default: false"},{"line_number":496,"context_line":"    type: boolean"},{"line_number":497,"context_line":"    tags:"},{"line_number":498,"context_line":"      - role_specific"},{"line_number":499,"context_line":"  NovaLiveMigrationPermitAutoConverge:"},{"line_number":500,"context_line":"    description: \u003e"},{"line_number":501,"context_line":"        Set to \"True\" to slow down the instance CPU until the memory copy process is faster than the"},{"line_number":502,"context_line":"        instance\u0027s memory writes when the migration performance is slow and might not complete."},{"line_number":503,"context_line":"        Auto converge will only be used if this flag is set to True and post copy is not permitted"},{"line_number":504,"context_line":"        or post copy is unavailable due to the version of libvirt and QEMU."},{"line_number":505,"context_line":"    default: false"},{"line_number":506,"context_line":"    type: boolean"},{"line_number":507,"context_line":"    tags:"},{"line_number":508,"context_line":"      - role_specific"},{"line_number":509,"context_line":"  MultipathdEnable:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"eb730470_922f0a72","line":506,"range":{"start_line":491,"start_character":0,"end_line":506,"end_character":17},"in_reply_to":"e6e61eba_069d1d50","updated":"2021-05-17 09:08:24.000000000","message":"Ack","commit_id":"7c3900dbefeed4bfc19f645919df624b9217b754"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"0376aab7871741a70302cf9050e001958bbcd401","unresolved":true,"context_lines":[{"line_number":799,"context_line":"      - and:"},{"line_number":800,"context_line":"        - {get_param: NovaNfsEnabled}"},{"line_number":801,"context_line":"        - equals: [{get_param: [RoleParameters, NovaNfsEnabled]}, \u0027\u0027]"},{"line_number":802,"context_line":"      - equals: [{get_param: [RoleParameters, NovaNfsEnabled]}, true]"},{"line_number":803,"context_line":"      - equals: [{get_param: [RoleParameters, NovaEnableRbdBackend]}, true]"},{"line_number":804,"context_line":"      - and:"},{"line_number":805,"context_line":"        - equals: [{get_param: [RoleParameters, NovaEnableRbdBackend]}, \u0027\u0027]"},{"line_number":806,"context_line":"        - {get_param: NovaEnableRbdBackend}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"dde4a31d_266613cc","line":803,"range":{"start_line":802,"start_character":0,"end_line":803,"end_character":75},"updated":"2021-05-17 09:08:24.000000000","message":"wasn\u0027t just get_param working as well?","commit_id":"04f99a410a6c251d92611d5f71856d49d06fcc28"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"b8d822c10c8be190463303fba81adaa47b8a8d28","unresolved":true,"context_lines":[{"line_number":799,"context_line":"      - and:"},{"line_number":800,"context_line":"        - {get_param: NovaNfsEnabled}"},{"line_number":801,"context_line":"        - equals: [{get_param: [RoleParameters, NovaNfsEnabled]}, \u0027\u0027]"},{"line_number":802,"context_line":"      - equals: [{get_param: [RoleParameters, NovaNfsEnabled]}, true]"},{"line_number":803,"context_line":"      - equals: [{get_param: [RoleParameters, NovaEnableRbdBackend]}, true]"},{"line_number":804,"context_line":"      - and:"},{"line_number":805,"context_line":"        - equals: [{get_param: [RoleParameters, NovaEnableRbdBackend]}, \u0027\u0027]"},{"line_number":806,"context_line":"        - {get_param: NovaEnableRbdBackend}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"0ba5aa01_214ed96e","line":803,"range":{"start_line":802,"start_character":0,"end_line":803,"end_character":75},"in_reply_to":"dde4a31d_266613cc","updated":"2021-05-17 09:30:40.000000000","message":"Nope, RoleParameters is a map, so the key may not exists and heat would return empty string.","commit_id":"04f99a410a6c251d92611d5f71856d49d06fcc28"}],"deployment/nova/nova-conductor-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1fba1b21e5a39d075f42988128044b78a29124f3","unresolved":true,"context_lines":[{"line_number":180,"context_line":"                template: \"/usr/bin/bootstrap_host_exec nova_conductor su nova -s /bin/bash -c \u0027/usr/bin/nova-manage db sync DB_SYNC_ARGS\u0027\""},{"line_number":181,"context_line":"                params:"},{"line_number":182,"context_line":"                  if:"},{"line_number":183,"context_line":"                    - {get_param: NovaAdditionalCell}"},{"line_number":184,"context_line":"                    - DB_SYNC_ARGS: \"\""},{"line_number":185,"context_line":"                    - DB_SYNC_ARGS: \"--local_cell\""},{"line_number":186,"context_line":"            environment:"},{"line_number":187,"context_line":"              TRIPLEO_DEPLOY_IDENTIFIER: {get_param: DeployIdentifier}"},{"line_number":188,"context_line":"        step_4:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1806669e_74b6f0f0","line":185,"range":{"start_line":183,"start_character":0,"end_line":185,"end_character":50},"updated":"2021-05-14 10:30:29.000000000","message":"this inverses the logic, please switch the places?","commit_id":"7c3900dbefeed4bfc19f645919df624b9217b754"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"872ce7bfead25106ce0af4db2de65b069c20262d","unresolved":true,"context_lines":[{"line_number":180,"context_line":"                template: \"/usr/bin/bootstrap_host_exec nova_conductor su nova -s /bin/bash -c \u0027/usr/bin/nova-manage db sync DB_SYNC_ARGS\u0027\""},{"line_number":181,"context_line":"                params:"},{"line_number":182,"context_line":"                  if:"},{"line_number":183,"context_line":"                    - {get_param: NovaAdditionalCell}"},{"line_number":184,"context_line":"                    - DB_SYNC_ARGS: \"\""},{"line_number":185,"context_line":"                    - DB_SYNC_ARGS: \"--local_cell\""},{"line_number":186,"context_line":"            environment:"},{"line_number":187,"context_line":"              TRIPLEO_DEPLOY_IDENTIFIER: {get_param: DeployIdentifier}"},{"line_number":188,"context_line":"        step_4:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"68f4116d_935dac51","line":185,"range":{"start_line":183,"start_character":0,"end_line":185,"end_character":50},"in_reply_to":"1806669e_74b6f0f0","updated":"2021-05-14 11:28:06.000000000","message":"ack","commit_id":"7c3900dbefeed4bfc19f645919df624b9217b754"}]}