)]}'
{"deployment/cinder/cinder-volume-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"aba4d409dcfadc01a91fab2aeeb22b4d5a7fd6ab","unresolved":true,"context_lines":[{"line_number":283,"context_line":"            - not: {equals : [{get_param: CinderRbdAvailabilityZone}, \u0027\u0027]}"},{"line_number":284,"context_line":"            - tripleo::profile::base::cinder::volume::rbd::backend_availability_zone: {get_param: CinderRbdAvailabilityZone}"},{"line_number":285,"context_line":"          - if:"},{"line_number":286,"context_line":"            - not: {equals : [{get_param: CinderEtcdLocalConnect}, true]}"},{"line_number":287,"context_line":"            - tripleo::profile::base::cinder::volume::etcd_host:"},{"line_number":288,"context_line":"                str_replace:"},{"line_number":289,"context_line":"                  template:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9cb8a5b9_9fa417b8","line":286,"range":{"start_line":286,"start_character":14,"end_line":286,"end_character":17},"updated":"2021-05-17 13:44:13.000000000","message":"This use of \"not:\" to invert the logic was incorrectly introduced by [1]. That patch correctly used \"not:\" in many places, but look carefully in [1] at its usage here are you\u0027ll see it\u0027s incorrect. I missed that when reviewing [1].\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/785748\n\nI don\u0027t want to muddy the waters, but maybe we could fix this in this patch? Just to reduce the churn?","commit_id":"c4da1eeba128c874069eb47a0a6669cda814b90f"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"ac47c08e548818893cd92f4a3d9bf82c4117fbfc","unresolved":true,"context_lines":[{"line_number":283,"context_line":"            - not: {equals : [{get_param: CinderRbdAvailabilityZone}, \u0027\u0027]}"},{"line_number":284,"context_line":"            - tripleo::profile::base::cinder::volume::rbd::backend_availability_zone: {get_param: CinderRbdAvailabilityZone}"},{"line_number":285,"context_line":"          - if:"},{"line_number":286,"context_line":"            - not: {equals : [{get_param: CinderEtcdLocalConnect}, true]}"},{"line_number":287,"context_line":"            - tripleo::profile::base::cinder::volume::etcd_host:"},{"line_number":288,"context_line":"                str_replace:"},{"line_number":289,"context_line":"                  template:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8a2760ff_caf66ace","line":286,"range":{"start_line":286,"start_character":14,"end_line":286,"end_character":17},"in_reply_to":"9cb8a5b9_9fa417b8","updated":"2021-05-19 19:16:52.000000000","message":"Aye I see it. Yeah I think we can squeeze that in this one","commit_id":"c4da1eeba128c874069eb47a0a6669cda814b90f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5017c38a8664817c3d882a284f3bacfe0fe39194","unresolved":true,"context_lines":[{"line_number":183,"context_line":"    description: When running Cinder A/A, whether to connect to Etcd"},{"line_number":184,"context_line":"      via the local IP for the Etcd network. If set to true, the ip"},{"line_number":185,"context_line":"      on the local node will be used. If set to false, the VIP on the Etcd"},{"line_number":186,"context_line":"      network will be used instead. Defaults to false."},{"line_number":187,"context_line":"  EnableInternalTLS:"},{"line_number":188,"context_line":"    type: boolean"},{"line_number":189,"context_line":"    default: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fcb32214_d38f3b78","line":186,"updated":"2021-05-19 19:23:31.000000000","message":"this likely needs updating as well","commit_id":"4488f5f0ff9aad9fa7af00821fe6e38e906fff4f"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"e45ccd8a9558a4c4c5f77352ced4324275aed3ed","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    description: When running Cinder A/A, whether to connect to Etcd"},{"line_number":184,"context_line":"      via the local IP for the Etcd network. If set to true, the ip"},{"line_number":185,"context_line":"      on the local node will be used. If set to false, the VIP on the Etcd"},{"line_number":186,"context_line":"      network will be used instead. Defaults to false."},{"line_number":187,"context_line":"  EnableInternalTLS:"},{"line_number":188,"context_line":"    type: boolean"},{"line_number":189,"context_line":"    default: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"49b14543_d24183cb","line":186,"in_reply_to":"fcb32214_d38f3b78","updated":"2021-05-19 19:25:30.000000000","message":"Ack","commit_id":"4488f5f0ff9aad9fa7af00821fe6e38e906fff4f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5017c38a8664817c3d882a284f3bacfe0fe39194","unresolved":true,"context_lines":[{"line_number":284,"context_line":"            - tripleo::profile::base::cinder::volume::rbd::backend_availability_zone: {get_param: CinderRbdAvailabilityZone}"},{"line_number":285,"context_line":"          - if:"},{"line_number":286,"context_line":"            - {equals : [{get_param: CinderEtcdLocalConnect}, true]}"},{"line_number":287,"context_line":"            - tripleo::profile::base::cinder::volume::etcd_host:"},{"line_number":288,"context_line":"                str_replace:"},{"line_number":289,"context_line":"                  template:"},{"line_number":290,"context_line":"                    \"%{hiera(\u0027fqdn_$NETWORK\u0027)}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b7eec1cf_9ff8ad74","line":287,"updated":"2021-05-19 19:23:31.000000000","message":"this can just be \"- {get_param: CinderEtcdLocalConnect}\" since it\u0027s a boolean","commit_id":"4488f5f0ff9aad9fa7af00821fe6e38e906fff4f"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"e45ccd8a9558a4c4c5f77352ced4324275aed3ed","unresolved":false,"context_lines":[{"line_number":284,"context_line":"            - tripleo::profile::base::cinder::volume::rbd::backend_availability_zone: {get_param: CinderRbdAvailabilityZone}"},{"line_number":285,"context_line":"          - if:"},{"line_number":286,"context_line":"            - {equals : [{get_param: CinderEtcdLocalConnect}, true]}"},{"line_number":287,"context_line":"            - tripleo::profile::base::cinder::volume::etcd_host:"},{"line_number":288,"context_line":"                str_replace:"},{"line_number":289,"context_line":"                  template:"},{"line_number":290,"context_line":"                    \"%{hiera(\u0027fqdn_$NETWORK\u0027)}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"304f556f_79465996","line":287,"in_reply_to":"b7eec1cf_9ff8ad74","updated":"2021-05-19 19:25:30.000000000","message":"Ack","commit_id":"4488f5f0ff9aad9fa7af00821fe6e38e906fff4f"}]}