)]}'
{"deployment/placement/placement-api-container-puppet.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ce71de7e5cc3cd6f48bce6566fc87f588fef719a","unresolved":true,"context_lines":[{"line_number":84,"context_line":"conditions:"},{"line_number":85,"context_line":"  placement_workers_set:"},{"line_number":86,"context_line":"    not: {equals : [{get_param: PlacementWorkers}, 0]}"},{"line_number":87,"context_line":"  enable_sqlalchemy_collectd: {equals : [{get_param: EnableSQLAlchemyCollectd}, true]}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"resources:"},{"line_number":90,"context_line":"  ApacheServiceBase:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"35e1dee8_8bafdbe0","line":87,"range":{"start_line":87,"start_character":2,"end_line":87,"end_character":86},"updated":"2021-05-24 08:44:47.000000000","message":"I don\u0027t see this condition used, can it not be removed since the if statements below test the parameter directly?","commit_id":"8e059ee87e5e87ded227560c45343f5483cee25e"}],"deployment/podman/podman-baremetal-ansible.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"1bef0036c4bb85d17d4ae0243bd17e312b71812b","unresolved":true,"context_lines":[{"line_number":79,"context_line":"          - name: Set login facts"},{"line_number":80,"context_line":"            no_log: true"},{"line_number":81,"context_line":"            set_fact:"},{"line_number":82,"context_line":"              container_registry_insecure_registries:"},{"line_number":83,"context_line":"                if:"},{"line_number":84,"context_line":"                  - insecure_registry_is_set"},{"line_number":85,"context_line":"                  - {get_param: DockerInsecureRegistryAddress}"},{"line_number":86,"context_line":"              container_registry_login: {get_param: ContainerImageRegistryLogin}"},{"line_number":87,"context_line":"              # default that is overwritten by the heat -\u003e dict conversion"},{"line_number":88,"context_line":"              container_registry_logins: {}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a4e355c4_9aee8149","line":85,"range":{"start_line":82,"start_character":14,"end_line":85,"end_character":62},"updated":"2021-06-01 00:33:01.000000000","message":"We need to set the fact - container_registry_insecure_registries to an empty list here. Otherwise I think it is explicitly set \"undef\" here?\n\nSee https://bugs.launchpad.net/tripleo/+bug/1929927","commit_id":"7a9cc5c8317cf2b71c4e813db7eff57625de1ff7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"63d3c90b07c1c322fa4d3b7e141bd94eb89dc037","unresolved":true,"context_lines":[{"line_number":79,"context_line":"          - name: Set login facts"},{"line_number":80,"context_line":"            no_log: true"},{"line_number":81,"context_line":"            set_fact:"},{"line_number":82,"context_line":"              container_registry_insecure_registries:"},{"line_number":83,"context_line":"                if:"},{"line_number":84,"context_line":"                  - insecure_registry_is_set"},{"line_number":85,"context_line":"                  - {get_param: DockerInsecureRegistryAddress}"},{"line_number":86,"context_line":"              container_registry_login: {get_param: ContainerImageRegistryLogin}"},{"line_number":87,"context_line":"              # default that is overwritten by the heat -\u003e dict conversion"},{"line_number":88,"context_line":"              container_registry_logins: {}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7ad55c51_b19c259d","line":85,"range":{"start_line":82,"start_character":14,"end_line":85,"end_character":62},"in_reply_to":"a4e355c4_9aee8149","updated":"2021-06-01 02:23:48.000000000","message":"I proposed https://review.opendev.org/c/openstack/tripleo-heat-templates/+/793871","commit_id":"7a9cc5c8317cf2b71c4e813db7eff57625de1ff7"}]}