)]}'
{"deployment/swift/swift-proxy-container-puppet.yaml":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"67d294767d9785a1eda92dfbba7c69a681c03888","unresolved":true,"context_lines":[{"line_number":147,"context_line":"        map_merge:"},{"line_number":148,"context_line":"          - get_attr: [SwiftBase, role_data, config_settings]"},{"line_number":149,"context_line":"          - get_attr: [TLSProxyBase, role_data, config_settings]"},{"line_number":150,"context_line":"          - swift::proxy::cors_allow_origin:"},{"line_number":151,"context_line":"              if:"},{"line_number":152,"context_line":"                - cors_allowed_origin_set"},{"line_number":153,"context_line":"                - {get_param: SwiftCorsAllowedOrigin}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7e2251aa_9d9d55f2","line":150,"updated":"2021-05-24 08:11:39.000000000","message":"I wonder, if we change it to this other format, and cors_allowed_origin_set is false we will end up with the option:\n\nswift::proxy::cors_allow_origin:\n\nwith no value, right? Won\u0027t this be an issue for the service? In comparison with the other approach when if condition was not met we didn\u0027t add anything or we add the parameter + the value.","commit_id":"e039454e3e4d7275682eab1e1b527547a8a82a06"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"9792aa1eb7d19f4c04ae102c820c3eb34c85960f","unresolved":true,"context_lines":[{"line_number":147,"context_line":"        map_merge:"},{"line_number":148,"context_line":"          - get_attr: [SwiftBase, role_data, config_settings]"},{"line_number":149,"context_line":"          - get_attr: [TLSProxyBase, role_data, config_settings]"},{"line_number":150,"context_line":"          - swift::proxy::cors_allow_origin:"},{"line_number":151,"context_line":"              if:"},{"line_number":152,"context_line":"                - cors_allowed_origin_set"},{"line_number":153,"context_line":"                - {get_param: SwiftCorsAllowedOrigin}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c532c898_a5bc0615","line":150,"in_reply_to":"7e2251aa_9d9d55f2","updated":"2021-05-24 08:36:16.000000000","message":"the key would be ignored/removed if the condition is false.","commit_id":"e039454e3e4d7275682eab1e1b527547a8a82a06"}]}