)]}'
{"deployment/octavia/octavia-api-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1eecc67a738ee3cfee43c4ae6c391d1813164302","unresolved":true,"context_lines":[{"line_number":229,"context_line":"          list_join:"},{"line_number":230,"context_line":"            - \"\\n\""},{"line_number":231,"context_line":"            - - \"include tripleo::profile::base::octavia::api\""},{"line_number":232,"context_line":"              - if:"},{"line_number":233,"context_line":"                - {get_param: OctaviaEnableDriverAgent}"},{"line_number":234,"context_line":"                - \"include octavia::driver_agent\""},{"line_number":235,"context_line":"              - {get_attr: [OctaviaProviderConfig, role_data, step_config]}"},{"line_number":236,"context_line":"              - {get_attr: [MySQLClient, role_data, step_config]}"},{"line_number":237,"context_line":"        config_image: {get_param: ContainerOctaviaConfigImage}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"da0191ab_53ffbe1d","line":234,"range":{"start_line":232,"start_character":0,"end_line":234,"end_character":49},"updated":"2021-06-29 03:09:16.000000000","message":"IMO we should not implement composition related to lower puppet classes in tht but should implement the same in puppet-tripleo, to be consistent with what we have in the other services.","commit_id":"e0adac953a75b0de4f8cc3ee14a9f69bce3e51d4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3cdf8c426ad9cbd0577a81c7b796c861ba736dfc","unresolved":true,"context_lines":[{"line_number":229,"context_line":"          list_join:"},{"line_number":230,"context_line":"            - \"\\n\""},{"line_number":231,"context_line":"            - - \"include tripleo::profile::base::octavia::api\""},{"line_number":232,"context_line":"              - if:"},{"line_number":233,"context_line":"                - {get_param: OctaviaEnableDriverAgent}"},{"line_number":234,"context_line":"                - \"include octavia::driver_agent\""},{"line_number":235,"context_line":"              - {get_attr: [OctaviaProviderConfig, role_data, step_config]}"},{"line_number":236,"context_line":"              - {get_attr: [MySQLClient, role_data, step_config]}"},{"line_number":237,"context_line":"        config_image: {get_param: ContainerOctaviaConfigImage}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0adb5d79_03e1fc24","line":234,"range":{"start_line":232,"start_character":0,"end_line":234,"end_character":49},"in_reply_to":"3c7f6078_55900551","updated":"2021-07-06 13:48:23.000000000","message":"We would just need to wrap the driver hiera in this to prevent it from being configured (which it seems is on L207). We don\u0027t have to make the include dynamic","commit_id":"e0adac953a75b0de4f8cc3ee14a9f69bce3e51d4"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"b9d30f1ec95d5f24636a8ebab7af9c76cf28e738","unresolved":true,"context_lines":[{"line_number":229,"context_line":"          list_join:"},{"line_number":230,"context_line":"            - \"\\n\""},{"line_number":231,"context_line":"            - - \"include tripleo::profile::base::octavia::api\""},{"line_number":232,"context_line":"              - if:"},{"line_number":233,"context_line":"                - {get_param: OctaviaEnableDriverAgent}"},{"line_number":234,"context_line":"                - \"include octavia::driver_agent\""},{"line_number":235,"context_line":"              - {get_attr: [OctaviaProviderConfig, role_data, step_config]}"},{"line_number":236,"context_line":"              - {get_attr: [MySQLClient, role_data, step_config]}"},{"line_number":237,"context_line":"        config_image: {get_param: ContainerOctaviaConfigImage}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3c7f6078_55900551","line":234,"range":{"start_line":232,"start_character":0,"end_line":234,"end_character":49},"in_reply_to":"da0191ab_53ffbe1d","updated":"2021-07-06 13:42:57.000000000","message":"It was done this way because we allow disabling the driver agent which is more of a deployment issue and less a configuration issue. I\u0027m good either way however - we will need to change this to pass the value of the OctaviaEnableDriverAgent to underlying puppet to avoid accidentally configuring driver agent options when it is disabled.","commit_id":"e0adac953a75b0de4f8cc3ee14a9f69bce3e51d4"}],"deployment/octavia/providers/ovn-provider-config.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2ef7ae860129a12da56d06356f24337e2e0c8208","unresolved":true,"context_lines":[{"line_number":84,"context_line":"      provider_driver_labels:"},{"line_number":85,"context_line":"        if:"},{"line_number":86,"context_line":"          - is_ovn_in_neutron_mechanism_driver"},{"line_number":87,"context_line":"          - [\u0027ovn: Octavia OVN driver.\u0027]"},{"line_number":88,"context_line":"      step_config:"},{"line_number":89,"context_line":"          if:"},{"line_number":90,"context_line":"            - is_ovn_in_neutron_mechanism_driver"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7159ae7d_6ab6733c","line":87,"updated":"2021-05-27 14:54:47.000000000","message":"So I\u0027m not a purveyor of yaml code, but I think we want to do things in this area and not above as it looks to be configuring how OVN is talking to OVNNB ?\n\nGenerally, if we are adding \"ovn\" to enabled_provider_drivers, we should add \"ovn\" to enabled_provider_agents as well.","commit_id":"54168283ea87b98ef12b8fb8b715344d22485c11"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2c72cb7fc2c5a6e187aff8fc7330d90fb097c4e4","unresolved":true,"context_lines":[{"line_number":84,"context_line":"      provider_driver_labels:"},{"line_number":85,"context_line":"        if:"},{"line_number":86,"context_line":"          - is_ovn_in_neutron_mechanism_driver"},{"line_number":87,"context_line":"          - [\u0027ovn: Octavia OVN driver.\u0027]"},{"line_number":88,"context_line":"      step_config:"},{"line_number":89,"context_line":"          if:"},{"line_number":90,"context_line":"            - is_ovn_in_neutron_mechanism_driver"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e844441f_71af5546","line":87,"updated":"2021-06-23 19:15:43.000000000","message":"Brent - I have a question.  Here is where we add \u0027ovn\u0027 to the \u0027provider_driver\u0027 list if OVN is the mech driver.  It feels like for \u0027enabled_provider_agents\u0027 we should be doing the same?  Again, showing my non-understanding of this code...\n\nI do see the correct line in the config file:\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_2a0/793422/3/check/tripleo-ci-centos-8-scenario010-ovn-provider-standalone/2a0d535/logs/undercloud/etc/puppet/hieradata/service_configs.json","commit_id":"19a28648dfd6e723ddd7a59adecf32e2192183d3"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"263a695d7eb1b01a6c2bbd61aa891f3bf71b7f01","unresolved":true,"context_lines":[{"line_number":84,"context_line":"      provider_driver_labels:"},{"line_number":85,"context_line":"        if:"},{"line_number":86,"context_line":"          - is_ovn_in_neutron_mechanism_driver"},{"line_number":87,"context_line":"          - [\u0027ovn: Octavia OVN driver.\u0027]"},{"line_number":88,"context_line":"      step_config:"},{"line_number":89,"context_line":"          if:"},{"line_number":90,"context_line":"            - is_ovn_in_neutron_mechanism_driver"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dd4b5de8_e81f93b3","line":87,"in_reply_to":"e844441f_71af5546","updated":"2021-06-24 00:10:21.000000000","message":"Yep, you\u0027re right.","commit_id":"19a28648dfd6e723ddd7a59adecf32e2192183d3"}]}