)]}'
{"deployment/podman/podman-baremetal-ansible.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"b3989b4740134a499963f94a082ed2d80e9f9bb2","unresolved":true,"context_lines":[{"line_number":79,"context_line":"          - name: Set login facts"},{"line_number":80,"context_line":"            no_log: true"},{"line_number":81,"context_line":"            set_fact:"},{"line_number":82,"context_line":"              container_registry_insecure_registries:"},{"line_number":83,"context_line":"                if:"},{"line_number":84,"context_line":"                  - insecure_registry_is_set"},{"line_number":85,"context_line":"                  - {get_param: DockerInsecureRegistryAddress}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"66673d88_ce7dfc5a","side":"PARENT","line":82,"range":{"start_line":82,"start_character":14,"end_line":82,"end_character":53},"updated":"2021-06-30 17:33:21.000000000","message":"Just FTR, \u0027container_registry_insecure_registries\u0027 is not the parent key here.\n\nIt\u0027s the (enclosing) \u0027key\u0027 for a \u0027value\u0027 which is decided based on a condition. If you don\u0027t have \u0027else\u0027, there is no value to use when the condition is false. Hence the key is ignored and it\u0027s a \u0027feature\u0027.\n\nI think the condition here was incorrect to start with, if we expect to use whatever is there in the parameter (which already has a default). I just changed it mechanically assuming that there would be defaults for this var in ansible roles and tasks, which was not the case.\n\nIf we expect ansible vars would not have defaults, we can probably check where else conditions are used in \u0027set_fact\u0027 and change those (if touched by the simplification changes).\n\nheat intrinsic \u0027if\u0027 without \u0027else\u0027 has number of benefits.\n\n- Allows us remove tasks/resource properties etc altogether based on a conditions.\n- Reduces the unnecessary empty defaults and the issues when you use them in other intrinsic functions\n- Finally reduces the template size and readability","commit_id":"16202b8318b8888578c810cea82e49f37b8e5288"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e787defa57b662c665de1655e1ae374b04d23391","unresolved":true,"context_lines":[{"line_number":86,"context_line":"          - name: Set login facts"},{"line_number":87,"context_line":"            no_log: true"},{"line_number":88,"context_line":"            set_fact:"},{"line_number":89,"context_line":"              container_registry_insecure_registries:"},{"line_number":90,"context_line":"                if:"},{"line_number":91,"context_line":"                  - insecure_registry_is_set"},{"line_number":92,"context_line":"                  - {get_param: DockerInsecureRegistryAddress}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f232ffe_0ec58cd7","side":"PARENT","line":89,"range":{"start_line":89,"start_character":14,"end_line":89,"end_character":52},"updated":"2021-07-01 04:15:16.000000000","message":"There is no issue here as is. We handle this var very badly in the tripleo_podman role.\n\nWe set a default for this var in https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_podman/defaults/main.yml#L23\n\nAnd then again create another var from it in https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_podman/defaults/main.yml#L36\n\nAnsible does not use the L23 when doing L36.\n\nWeird that we use so many different vars unnecessarily in the role. But changing L36 as below (like other vars there) and removing L23 should fix it.\n\ntripleo_podman_insecure_registries: \"{{ tripleo_container_registry_insecure_registries | default([] }}\"\n\nBut I\u0027m fine if we want to merge this.","commit_id":"122f4bf4b1cd5269119428dd557dba472e3051f4"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"5e9917b9c4a2ba45b7b867549b79dab3753d2ab0","unresolved":true,"context_lines":[{"line_number":86,"context_line":"          - name: Set login facts"},{"line_number":87,"context_line":"            no_log: true"},{"line_number":88,"context_line":"            set_fact:"},{"line_number":89,"context_line":"              container_registry_insecure_registries:"},{"line_number":90,"context_line":"                if:"},{"line_number":91,"context_line":"                  - insecure_registry_is_set"},{"line_number":92,"context_line":"                  - {get_param: DockerInsecureRegistryAddress}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cb990744_03630209","side":"PARENT","line":89,"range":{"start_line":89,"start_character":14,"end_line":89,"end_character":52},"in_reply_to":"9f232ffe_0ec58cd7","updated":"2021-07-01 11:29:14.000000000","message":"L23 in that role is a different var. Notice the \"tripleo_\" prefix there. That *will* get used at L36. Afacit, the var set here \"container_registry_insecure_registries\" is only used here in this template in the \"Run podman install\" task below.\n\nMaybe the actual bug is that this var is spelled wrong, and should be prefixed with \"tripleo_\"? In fact, all these vars need to be prefixed with tripleo_ afaict","commit_id":"122f4bf4b1cd5269119428dd557dba472e3051f4"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"c7ff35c314295c77ae0ab9214381cf171f5f4adf","unresolved":true,"context_lines":[{"line_number":86,"context_line":"          - name: Set login facts"},{"line_number":87,"context_line":"            no_log: true"},{"line_number":88,"context_line":"            set_fact:"},{"line_number":89,"context_line":"              container_registry_insecure_registries:"},{"line_number":90,"context_line":"                if:"},{"line_number":91,"context_line":"                  - insecure_registry_is_set"},{"line_number":92,"context_line":"                  - {get_param: DockerInsecureRegistryAddress}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8c56ffa0_4f00f53b","side":"PARENT","line":89,"range":{"start_line":89,"start_character":14,"end_line":89,"end_character":52},"in_reply_to":"cb990744_03630209","updated":"2021-07-01 11:38:56.000000000","message":"We use \u0027tripleo_\u0027 var in L116.","commit_id":"122f4bf4b1cd5269119428dd557dba472e3051f4"}]}