)]}'
{"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"cc9ba64a002ae47d638975a6b3b982363d9364a6","unresolved":false,"context_lines":[{"line_number":84,"context_line":"      Command or script snippet to run on all overcloud nodes to"},{"line_number":85,"context_line":"      initialize the Leapp process. E.g. a repository switch."},{"line_number":86,"context_line":"    default: \u0027\u0027"},{"line_number":87,"context_line":"  LeappInitCommand:"},{"line_number":88,"context_line":"    type: string"},{"line_number":89,"context_line":"    description: |"},{"line_number":90,"context_line":"      Command or script snippet to run on all overcloud nodes to"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7034122a_032d89e9","line":87,"range":{"start_line":87,"start_character":2,"end_line":87,"end_character":18},"updated":"2021-06-09 12:37:41.000000000","message":"I would prefer we put them in parameter_defaults of https://github.com/openstack/tripleo-heat-templates/blob/stable/train/overcloud-resource-registry-puppet.j2.yaml and probably not here and remove the default here.","commit_id":"db6f0936a5368fcf479f0e2e5bdc81f32aa2541a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0cd8187b566d007b48aa24b5a0cca33ef0b74273","unresolved":true,"context_lines":[{"line_number":84,"context_line":"      Command or script snippet to run on all overcloud nodes to"},{"line_number":85,"context_line":"      initialize the Leapp process. E.g. a repository switch."},{"line_number":86,"context_line":"    default: \u0027\u0027"},{"line_number":87,"context_line":"  LeappInitCommand:"},{"line_number":88,"context_line":"    type: string"},{"line_number":89,"context_line":"    description: |"},{"line_number":90,"context_line":"      Command or script snippet to run on all overcloud nodes to"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"97d03079_601451b2","line":87,"range":{"start_line":87,"start_character":2,"end_line":87,"end_character":18},"updated":"2021-06-02 10:51:48.000000000","message":"Should this script be put into UpgradeInitCommonCommand instead, perhaps?","commit_id":"db6f0936a5368fcf479f0e2e5bdc81f32aa2541a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3ce24ed0946f813f018de9a73551a637410f1b88","unresolved":false,"context_lines":[{"line_number":84,"context_line":"      Command or script snippet to run on all overcloud nodes to"},{"line_number":85,"context_line":"      initialize the Leapp process. E.g. a repository switch."},{"line_number":86,"context_line":"    default: \u0027\u0027"},{"line_number":87,"context_line":"  LeappInitCommand:"},{"line_number":88,"context_line":"    type: string"},{"line_number":89,"context_line":"    description: |"},{"line_number":90,"context_line":"      Command or script snippet to run on all overcloud nodes to"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e82e732b_e3d2ac86","line":87,"range":{"start_line":87,"start_character":2,"end_line":87,"end_character":18},"in_reply_to":"30258974_72f42548","updated":"2021-06-02 10:53:15.000000000","message":"Done","commit_id":"db6f0936a5368fcf479f0e2e5bdc81f32aa2541a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d044e62336f11e83f80f34c8ac4935695a4eb28b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"      Command or script snippet to run on all overcloud nodes to"},{"line_number":85,"context_line":"      initialize the Leapp process. E.g. a repository switch."},{"line_number":86,"context_line":"    default: \u0027\u0027"},{"line_number":87,"context_line":"  LeappInitCommand:"},{"line_number":88,"context_line":"    type: string"},{"line_number":89,"context_line":"    description: |"},{"line_number":90,"context_line":"      Command or script snippet to run on all overcloud nodes to"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ed72453d_63bee175","line":87,"range":{"start_line":87,"start_character":2,"end_line":87,"end_character":18},"in_reply_to":"7034122a_032d89e9","updated":"2021-06-09 15:04:08.000000000","message":"The point of having it here is to expose it to the user as something that can be edited based on any other modules that may block an upgrade for the particular hardware in use.","commit_id":"db6f0936a5368fcf479f0e2e5bdc81f32aa2541a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f1108ac32acef594a85ada69598b689844239934","unresolved":true,"context_lines":[{"line_number":84,"context_line":"      Command or script snippet to run on all overcloud nodes to"},{"line_number":85,"context_line":"      initialize the Leapp process. E.g. a repository switch."},{"line_number":86,"context_line":"    default: \u0027\u0027"},{"line_number":87,"context_line":"  LeappInitCommand:"},{"line_number":88,"context_line":"    type: string"},{"line_number":89,"context_line":"    description: |"},{"line_number":90,"context_line":"      Command or script snippet to run on all overcloud nodes to"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"30258974_72f42548","line":87,"range":{"start_line":87,"start_character":2,"end_line":87,"end_character":18},"in_reply_to":"97d03079_601451b2","updated":"2021-06-02 10:53:02.000000000","message":"No - UpgradeInitCommonCommand runs before the package changes, and the package changes end up reloading the modules.","commit_id":"db6f0936a5368fcf479f0e2e5bdc81f32aa2541a"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"fe288c7c927a5666b22ae559c6476c94f33ddf54","unresolved":false,"context_lines":[{"line_number":84,"context_line":"      Command or script snippet to run on all overcloud nodes to"},{"line_number":85,"context_line":"      initialize the Leapp process. E.g. a repository switch."},{"line_number":86,"context_line":"    default: \u0027\u0027"},{"line_number":87,"context_line":"  LeappInitCommand:"},{"line_number":88,"context_line":"    type: string"},{"line_number":89,"context_line":"    description: |"},{"line_number":90,"context_line":"      Command or script snippet to run on all overcloud nodes to"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"717b2224_4a43d6f9","line":87,"range":{"start_line":87,"start_character":2,"end_line":87,"end_character":18},"in_reply_to":"ed72453d_63bee175","updated":"2021-06-09 15:09:29.000000000","message":"Anyone can override that when in overcloud-resource-registry-puppet.j2.yaml, as we do for most of the parameters? IMO. it\u0027s probably cleaner and does not mess the service templates.","commit_id":"db6f0936a5368fcf479f0e2e5bdc81f32aa2541a"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"67cee7623b3588910cdc4c8f00b6515a0465d693","unresolved":true,"context_lines":[{"line_number":90,"context_line":"      Command or script snippet to run on all overcloud nodes to"},{"line_number":91,"context_line":"      apply any necessary workarounds to get Leapp working."},{"line_number":92,"context_line":"    default: |"},{"line_number":93,"context_line":"      for module in floppy pata_acpi; do"},{"line_number":94,"context_line":"        sudo lsmod | grep -q $module \u0026\u0026 { sudo rmmod $module; echo \"$module unloaded\"; } || echo \"$module was not loaded\""},{"line_number":95,"context_line":"      done"},{"line_number":96,"context_line":"  UpgradeInitCommand:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a6817e4b_c3f0dc84","line":93,"updated":"2021-06-10 05:41:01.000000000","message":"So currently, the reason why this isn\u0027t working in our CI jobs is because we are overriding the LeappInitCommand during the workarounds: https://gitlab.cee.redhat.com/rhos-upgrades/workarounds/-/blob/master/upgrade/13-16.2_upgrade_workarounds.yaml#L184-186 this very same thing could happen to any of our customers. Personally, I think it makes more sense to parametrize the list of modules to remove and add a new step at: https://github.com/openstack/tripleo-heat-templates/blob/stable/train/deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml#L317\n\nI could prepare a quick patch as an example if it is fine by you and we can give it a test in our CI.","commit_id":"db6f0936a5368fcf479f0e2e5bdc81f32aa2541a"}]}