)]}'
{"environments/lifecycle/upgrade-prepare.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"9c805535c5ea411e42c624636af8ede31261afd6","unresolved":true,"context_lines":[{"line_number":29,"context_line":"  # repo validation to work."},{"line_number":30,"context_line":"  CephAnsibleWarning: false"},{"line_number":31,"context_line":"  DnfStreams: [{\u0027module\u0027:\u0027container-tools\u0027, \u0027stream\u0027:\u00273.0\u0027}]"},{"line_number":32,"context_line":"  CephStorageParameters:"},{"line_number":33,"context_line":"    UpgradeLeappDevelSkip: \"\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"56f93515_0428c4d4","line":32,"range":{"start_line":32,"start_character":2,"end_line":32,"end_character":13},"updated":"2021-06-09 13:04:56.000000000","message":"Also, though we use hardcoded role names at some other places in THT, it\u0027s probably not a good thing to do. If customer uses a different role name in roles_data.yaml this won\u0027t work. We probably should document it instead (asking users to add to ceph related environments they use).","commit_id":"dc33cf0d01345a8fe0f43e32c4b2e95994267c3b"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"71beeb1a26bc8a89c4b95a3bae10e8080202f6c0","unresolved":true,"context_lines":[{"line_number":30,"context_line":"  CephAnsibleWarning: false"},{"line_number":31,"context_line":"  DnfStreams: [{\u0027module\u0027:\u0027container-tools\u0027, \u0027stream\u0027:\u00273.0\u0027}]"},{"line_number":32,"context_line":"  CephStorageParameters:"},{"line_number":33,"context_line":"    UpgradeLeappDevelSkip: \"\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9b7658c1_93a7d6bc","line":33,"range":{"start_line":33,"start_character":4,"end_line":33,"end_character":25},"updated":"2021-06-09 12:32:46.000000000","message":"To me this is does not look like a role specific parameter[1]. How do you set it for CephStorage role with this?\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/stable/train/deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml#L50","commit_id":"dc33cf0d01345a8fe0f43e32c4b2e95994267c3b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2231f4af7eebeb791301f7d5adbc89210555de47","unresolved":true,"context_lines":[{"line_number":30,"context_line":"  CephAnsibleWarning: false"},{"line_number":31,"context_line":"  DnfStreams: [{\u0027module\u0027:\u0027container-tools\u0027, \u0027stream\u0027:\u00273.0\u0027}]"},{"line_number":32,"context_line":"  CephStorageParameters:"},{"line_number":33,"context_line":"    UpgradeLeappDevelSkip: \"\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a7f7b34e_f84fcbb3","line":33,"range":{"start_line":33,"start_character":4,"end_line":33,"end_character":25},"in_reply_to":"9b7658c1_93a7d6bc","updated":"2021-06-09 12:37:59.000000000","message":"Quite right - let me add that to this patch.","commit_id":"dc33cf0d01345a8fe0f43e32c4b2e95994267c3b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7ca10a63fa51f61f8f5006113d346e179ba6c68a","unresolved":true,"context_lines":[{"line_number":30,"context_line":"  CephAnsibleWarning: false"},{"line_number":31,"context_line":"  DnfStreams: [{\u0027module\u0027:\u0027container-tools\u0027, \u0027stream\u0027:\u00273.0\u0027}]"},{"line_number":32,"context_line":"  CephStorageParameters:"},{"line_number":33,"context_line":"    UpgradeLeappDevelSkip: \"\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8ac293b9_1a50f79e","line":33,"range":{"start_line":33,"start_character":4,"end_line":33,"end_character":25},"in_reply_to":"a7f7b34e_f84fcbb3","updated":"2021-06-09 17:38:47.000000000","message":"Done for master: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/795605\n\nThis patch has been rebased on top of the backport.","commit_id":"dc33cf0d01345a8fe0f43e32c4b2e95994267c3b"}]}