)]}'
{"deployment/logging/rsyslog-container-puppet.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"4bb0013e7b2f1a5ce5509282dda78949d27bb7ff","unresolved":true,"context_lines":[{"line_number":68,"context_line":"    type: json"},{"line_number":69,"context_line":"  RsyslogAmqp1Local:"},{"line_number":70,"context_line":"    default: true"},{"line_number":71,"context_line":"    description: Set to false is you don\u0027t want connection value be generated to local QDR in RsyslogAmqp1Setting."},{"line_number":72,"context_line":"    type: boolean"},{"line_number":73,"context_line":"  MetricsQdrPort:"},{"line_number":74,"context_line":"    default: 5666"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"64ec25c6_f250da9d","line":71,"range":{"start_line":71,"start_character":30,"end_line":71,"end_character":32},"updated":"2021-06-26 16:00:43.000000000","message":"typo: s/is/if/ ?\n\nI\u0027d rewrite the scentance entirely tbh, maby start with: \"Set false to disable ....\" ?\n\nWhat does this actually do? QDR? RsyslogAmqp1Local?","commit_id":"1356c4b917cdcc9b9481316d9a316529a1c877fa"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"3cda2a1e170e0a7f5c9ff756764216a2b7ebb011","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    type: json"},{"line_number":69,"context_line":"  RsyslogAmqp1Local:"},{"line_number":70,"context_line":"    default: true"},{"line_number":71,"context_line":"    description: Set to false is you don\u0027t want connection value be generated to local QDR in RsyslogAmqp1Setting."},{"line_number":72,"context_line":"    type: boolean"},{"line_number":73,"context_line":"  MetricsQdrPort:"},{"line_number":74,"context_line":"    default: 5666"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"84c3c29b_83d071ce","line":71,"range":{"start_line":71,"start_character":30,"end_line":71,"end_character":32},"in_reply_to":"64ec25c6_f250da9d","updated":"2021-08-25 12:28:52.000000000","message":"Done","commit_id":"1356c4b917cdcc9b9481316d9a316529a1c877fa"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"4bb0013e7b2f1a5ce5509282dda78949d27bb7ff","unresolved":true,"context_lines":[{"line_number":226,"context_line":"                  - {get_param: RsyslogAmqp1Setting}"},{"line_number":227,"context_line":"                  - template: rsyslog-record"},{"line_number":228,"context_line":"                  - if:"},{"line_number":229,"context_line":"                    - amqp1_local"},{"line_number":230,"context_line":"                    - host:"},{"line_number":231,"context_line":"                        str_replace:"},{"line_number":232,"context_line":"                          template:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"53deaa8a_6b44c73f","line":229,"range":{"start_line":229,"start_character":22,"end_line":229,"end_character":33},"updated":"2021-06-26 16:00:43.000000000","message":"nit: you can just do {get_param: RsyslogAmqp1Local} here, and drop the entry in conditions section above.","commit_id":"1356c4b917cdcc9b9481316d9a316529a1c877fa"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"3cda2a1e170e0a7f5c9ff756764216a2b7ebb011","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                  - {get_param: RsyslogAmqp1Setting}"},{"line_number":227,"context_line":"                  - template: rsyslog-record"},{"line_number":228,"context_line":"                  - if:"},{"line_number":229,"context_line":"                    - amqp1_local"},{"line_number":230,"context_line":"                    - host:"},{"line_number":231,"context_line":"                        str_replace:"},{"line_number":232,"context_line":"                          template:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"721f0968_632ef3d7","line":229,"range":{"start_line":229,"start_character":22,"end_line":229,"end_character":33},"in_reply_to":"53deaa8a_6b44c73f","updated":"2021-08-25 12:28:52.000000000","message":"Done","commit_id":"1356c4b917cdcc9b9481316d9a316529a1c877fa"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"4bb0013e7b2f1a5ce5509282dda78949d27bb7ff","unresolved":true,"context_lines":[{"line_number":241,"context_line":"                                    template: \"ROLENAMEMetricsQdrNetwork\""},{"line_number":242,"context_line":"                                    params:"},{"line_number":243,"context_line":"                                      ROLENAME: {get_param: RoleName}"},{"line_number":244,"context_line":"                    - {}"},{"line_number":245,"context_line":"            - {}"},{"line_number":246,"context_line":"          - if:"},{"line_number":247,"context_line":"            - use_tls"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"33eddf9f_99bf91e5","line":244,"range":{"start_line":244,"start_character":22,"end_line":244,"end_character":24},"updated":"2021-06-26 16:00:43.000000000","message":"I don\u0027t think this is needed.","commit_id":"1356c4b917cdcc9b9481316d9a316529a1c877fa"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"3cda2a1e170e0a7f5c9ff756764216a2b7ebb011","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                                    template: \"ROLENAMEMetricsQdrNetwork\""},{"line_number":242,"context_line":"                                    params:"},{"line_number":243,"context_line":"                                      ROLENAME: {get_param: RoleName}"},{"line_number":244,"context_line":"                    - {}"},{"line_number":245,"context_line":"            - {}"},{"line_number":246,"context_line":"          - if:"},{"line_number":247,"context_line":"            - use_tls"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"20e72820_e4b001d0","line":244,"range":{"start_line":244,"start_character":22,"end_line":244,"end_character":24},"in_reply_to":"33eddf9f_99bf91e5","updated":"2021-08-25 12:28:52.000000000","message":"Done","commit_id":"1356c4b917cdcc9b9481316d9a316529a1c877fa"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a8536414ee8a03b8dfc44ed3722c23743b65112d","unresolved":true,"context_lines":[{"line_number":71,"context_line":"    description: Set to false to disable prefilling host connection value to local QDR in RsyslogAmqp1Setting."},{"line_number":72,"context_line":"    type: boolean"},{"line_number":73,"context_line":"  MetricsQdrPort:"},{"line_number":74,"context_line":"    default: 5666"},{"line_number":75,"context_line":"    description: Service name or port number on which the qdrouterd will accept"},{"line_number":76,"context_line":"                 connections."},{"line_number":77,"context_line":"    type: number"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5bc7191a_f6e77064","line":74,"range":{"start_line":74,"start_character":13,"end_line":74,"end_character":17},"updated":"2021-08-31 10:45:53.000000000","message":"outside of the patch scope, but I couldn\u0027t find a firewall rule for that port","commit_id":"91627638d64f13280a245fb36097f3e13771b766"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"28c63bb38c0ecbc1f195d5f6c60a890e00c1cafd","unresolved":true,"context_lines":[{"line_number":71,"context_line":"    description: Set to false to disable prefilling host connection value to local QDR in RsyslogAmqp1Setting."},{"line_number":72,"context_line":"    type: boolean"},{"line_number":73,"context_line":"  MetricsQdrPort:"},{"line_number":74,"context_line":"    default: 5666"},{"line_number":75,"context_line":"    description: Service name or port number on which the qdrouterd will accept"},{"line_number":76,"context_line":"                 connections."},{"line_number":77,"context_line":"    type: number"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"907b5e16_345c173f","line":74,"range":{"start_line":74,"start_character":13,"end_line":74,"end_character":17},"in_reply_to":"21a37a71_2c883ce9","updated":"2021-09-01 16:17:17.000000000","message":"thanks! LGTM","commit_id":"91627638d64f13280a245fb36097f3e13771b766"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"e3391f3d97ca01c2086b00da879a8a37d1dd56e9","unresolved":true,"context_lines":[{"line_number":71,"context_line":"    description: Set to false to disable prefilling host connection value to local QDR in RsyslogAmqp1Setting."},{"line_number":72,"context_line":"    type: boolean"},{"line_number":73,"context_line":"  MetricsQdrPort:"},{"line_number":74,"context_line":"    default: 5666"},{"line_number":75,"context_line":"    description: Service name or port number on which the qdrouterd will accept"},{"line_number":76,"context_line":"                 connections."},{"line_number":77,"context_line":"    type: number"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"21a37a71_2c883ce9","line":74,"range":{"start_line":74,"start_character":13,"end_line":74,"end_character":17},"in_reply_to":"5bc7191a_f6e77064","updated":"2021-08-31 12:39:55.000000000","message":"It is not outside of the patch scope. You need this parameter on line 235.\n\nThe rule is at: https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/metrics/qdr-container-puppet.yaml#L172","commit_id":"91627638d64f13280a245fb36097f3e13771b766"}]}