)]}'
{"environments/undercloud.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f1135f193bdbd19a0ae6bce02ad1fa12c48a2431","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  # Disable keystone by default"},{"line_number":21,"context_line":"  OS::TripleO::Services::Keystone: OS::Heat::None"},{"line_number":22,"context_line":"  OS::TripleO::Services::Memcached: OS::Heat::None"},{"line_number":23,"context_line":"  # services we disable by default on the undercloud"},{"line_number":24,"context_line":"  OS::TripleO::Services::AodhApi: OS::Heat::None"},{"line_number":25,"context_line":"  OS::TripleO::Services::AodhEvaluator: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"a219c11a_3d9cabb0","line":22,"range":{"start_line":22,"start_character":25,"end_line":22,"end_character":34},"updated":"2021-09-13 13:59:23.000000000","message":"Is memcached used for anything else in metalsmith or was it only being used for keystone auth token bits?","commit_id":"97507daf59e7427fb724bb31ff0f7415c90674f7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2a1c6967170b8f0982e17026840b303c5ee8c127","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  # Disable keystone by default"},{"line_number":21,"context_line":"  OS::TripleO::Services::Keystone: OS::Heat::None"},{"line_number":22,"context_line":"  OS::TripleO::Services::Memcached: OS::Heat::None"},{"line_number":23,"context_line":"  # services we disable by default on the undercloud"},{"line_number":24,"context_line":"  OS::TripleO::Services::AodhApi: OS::Heat::None"},{"line_number":25,"context_line":"  OS::TripleO::Services::AodhEvaluator: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"782ae1ec_25e06ecf","line":22,"range":{"start_line":22,"start_character":25,"end_line":22,"end_character":34},"in_reply_to":"a219c11a_3d9cabb0","updated":"2021-09-13 14:16:48.000000000","message":"I\u0027ve not seen any other configuration options other than keystone authtoken bits with ironic. It\u0027s file based cache for images.","commit_id":"97507daf59e7427fb724bb31ff0f7415c90674f7"}],"extraconfig/post_deploy/undercloud_post.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8d5838ec06881c64bc8616dfcac41d83549d78fd","unresolved":true,"context_lines":[{"line_number":105,"context_line":"    config[\u0027auth\u0027] \u003d {}"},{"line_number":106,"context_line":"    config[\u0027auth\u0027][\u0027username\u0027] \u003d \u0027admin\u0027"},{"line_number":107,"context_line":"    config[\u0027auth\u0027][\u0027password\u0027] \u003d CONF.get(\u0027admin_password\u0027, \u0027admin\u0027)"},{"line_number":108,"context_line":"    config[\u0027baremetal_endpoint_override\u0027] \u003d CONF.get("},{"line_number":109,"context_line":"        \u0027endpoints\u0027, {}).get(\u0027baremetal\u0027, \u0027https://192.168.24.2:13385/\u0027)"},{"line_number":110,"context_line":"    config[\u0027network_endpoint_override\u0027] \u003d CONF.get("},{"line_number":111,"context_line":"            \u0027endpoints\u0027, {}).get(\u0027network\u0027, \u0027https://192.168.24.2:13696/\u0027)"},{"line_number":112,"context_line":"    config[\u0027baremetal_introspection_endpoint_override\u0027] \u003d CONF.get("},{"line_number":113,"context_line":"            \u0027endpoints\u0027, {}).get("},{"line_number":114,"context_line":"                \u0027baremetal_introspection\u0027, \u0027https://192.168.24.2:13696/\u0027)"},{"line_number":115,"context_line":"    config[\u0027baremetal_api_version\u0027] \u003d \u00271\u0027"},{"line_number":116,"context_line":"    config[\u0027network_api_version\u0027] \u003d \u00272\u0027"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"923e81d7_c227feff","line":114,"range":{"start_line":108,"start_character":0,"end_line":114,"end_character":73},"updated":"2021-09-17 13:20:07.000000000","message":"I get the addresses are defaults.... but a defaulted v4 value just seems bad, especially in a world which desperately needs to move everything to v6. A local hostname or dns alias would of course be better, since it could support both. Just a thought.","commit_id":"c293dfc7b1f4aed4d2f92c7f9aa38c06fe0d9841"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"1bf778982d3afe6d349d632f6dd391d5a21c7b32","unresolved":true,"context_lines":[{"line_number":105,"context_line":"    config[\u0027auth\u0027] \u003d {}"},{"line_number":106,"context_line":"    config[\u0027auth\u0027][\u0027username\u0027] \u003d \u0027admin\u0027"},{"line_number":107,"context_line":"    config[\u0027auth\u0027][\u0027password\u0027] \u003d CONF.get(\u0027admin_password\u0027, \u0027admin\u0027)"},{"line_number":108,"context_line":"    config[\u0027baremetal_endpoint_override\u0027] \u003d CONF.get("},{"line_number":109,"context_line":"        \u0027endpoints\u0027, {}).get(\u0027baremetal\u0027, \u0027https://192.168.24.2:13385/\u0027)"},{"line_number":110,"context_line":"    config[\u0027network_endpoint_override\u0027] \u003d CONF.get("},{"line_number":111,"context_line":"            \u0027endpoints\u0027, {}).get(\u0027network\u0027, \u0027https://192.168.24.2:13696/\u0027)"},{"line_number":112,"context_line":"    config[\u0027baremetal_introspection_endpoint_override\u0027] \u003d CONF.get("},{"line_number":113,"context_line":"            \u0027endpoints\u0027, {}).get("},{"line_number":114,"context_line":"                \u0027baremetal_introspection\u0027, \u0027https://192.168.24.2:13696/\u0027)"},{"line_number":115,"context_line":"    config[\u0027baremetal_api_version\u0027] \u003d \u00271\u0027"},{"line_number":116,"context_line":"    config[\u0027network_api_version\u0027] \u003d \u00272\u0027"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"c74ff627_4e4c3929","line":114,"range":{"start_line":108,"start_character":0,"end_line":114,"end_character":73},"in_reply_to":"2ec66397_711ee8b7","updated":"2021-09-17 14:14:17.000000000","message":"It\u0027s mostly redundant (leftover from my POC). Won\u0027t harm. I can remove it in a followup if that\u0027s confusing.","commit_id":"c293dfc7b1f4aed4d2f92c7f9aa38c06fe0d9841"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"039b943bfca1f96f57f62a3b07a7bae5af053472","unresolved":true,"context_lines":[{"line_number":105,"context_line":"    config[\u0027auth\u0027] \u003d {}"},{"line_number":106,"context_line":"    config[\u0027auth\u0027][\u0027username\u0027] \u003d \u0027admin\u0027"},{"line_number":107,"context_line":"    config[\u0027auth\u0027][\u0027password\u0027] \u003d CONF.get(\u0027admin_password\u0027, \u0027admin\u0027)"},{"line_number":108,"context_line":"    config[\u0027baremetal_endpoint_override\u0027] \u003d CONF.get("},{"line_number":109,"context_line":"        \u0027endpoints\u0027, {}).get(\u0027baremetal\u0027, \u0027https://192.168.24.2:13385/\u0027)"},{"line_number":110,"context_line":"    config[\u0027network_endpoint_override\u0027] \u003d CONF.get("},{"line_number":111,"context_line":"            \u0027endpoints\u0027, {}).get(\u0027network\u0027, \u0027https://192.168.24.2:13696/\u0027)"},{"line_number":112,"context_line":"    config[\u0027baremetal_introspection_endpoint_override\u0027] \u003d CONF.get("},{"line_number":113,"context_line":"            \u0027endpoints\u0027, {}).get("},{"line_number":114,"context_line":"                \u0027baremetal_introspection\u0027, \u0027https://192.168.24.2:13696/\u0027)"},{"line_number":115,"context_line":"    config[\u0027baremetal_api_version\u0027] \u003d \u00271\u0027"},{"line_number":116,"context_line":"    config[\u0027network_api_version\u0027] \u003d \u00272\u0027"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"9ce201f1_bc93c5bf","line":114,"range":{"start_line":108,"start_character":0,"end_line":114,"end_character":73},"in_reply_to":"923e81d7_c227feff","updated":"2021-09-17 13:45:19.000000000","message":"these IPs need to come from local_ip as well. We shouldn\u0027t hard code these addresses. Are they outputted in hiera somewhere where we can lookup these endpoints?","commit_id":"c293dfc7b1f4aed4d2f92c7f9aa38c06fe0d9841"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"4de73590a8745cc3fb870f8ec4cb124d0335cae1","unresolved":true,"context_lines":[{"line_number":105,"context_line":"    config[\u0027auth\u0027] \u003d {}"},{"line_number":106,"context_line":"    config[\u0027auth\u0027][\u0027username\u0027] \u003d \u0027admin\u0027"},{"line_number":107,"context_line":"    config[\u0027auth\u0027][\u0027password\u0027] \u003d CONF.get(\u0027admin_password\u0027, \u0027admin\u0027)"},{"line_number":108,"context_line":"    config[\u0027baremetal_endpoint_override\u0027] \u003d CONF.get("},{"line_number":109,"context_line":"        \u0027endpoints\u0027, {}).get(\u0027baremetal\u0027, \u0027https://192.168.24.2:13385/\u0027)"},{"line_number":110,"context_line":"    config[\u0027network_endpoint_override\u0027] \u003d CONF.get("},{"line_number":111,"context_line":"            \u0027endpoints\u0027, {}).get(\u0027network\u0027, \u0027https://192.168.24.2:13696/\u0027)"},{"line_number":112,"context_line":"    config[\u0027baremetal_introspection_endpoint_override\u0027] \u003d CONF.get("},{"line_number":113,"context_line":"            \u0027endpoints\u0027, {}).get("},{"line_number":114,"context_line":"                \u0027baremetal_introspection\u0027, \u0027https://192.168.24.2:13696/\u0027)"},{"line_number":115,"context_line":"    config[\u0027baremetal_api_version\u0027] \u003d \u00271\u0027"},{"line_number":116,"context_line":"    config[\u0027network_api_version\u0027] \u003d \u00272\u0027"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"fec5079c_cddbfa99","line":114,"range":{"start_line":108,"start_character":0,"end_line":114,"end_character":73},"in_reply_to":"9ce201f1_bc93c5bf","updated":"2021-09-17 14:06:12.000000000","message":"They actually come from EndpointMap[1] like before[2]. Only the default fallback is hardcoded which is kind of redundant.\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/794912/23/extraconfig/post_deploy/undercloud_post.yaml#163\n\n[2] https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/keystone/keystone-container-puppet.yaml#L820","commit_id":"c293dfc7b1f4aed4d2f92c7f9aa38c06fe0d9841"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5545fb4b2877e7520a574e58c696acb68d5622df","unresolved":true,"context_lines":[{"line_number":105,"context_line":"    config[\u0027auth\u0027] \u003d {}"},{"line_number":106,"context_line":"    config[\u0027auth\u0027][\u0027username\u0027] \u003d \u0027admin\u0027"},{"line_number":107,"context_line":"    config[\u0027auth\u0027][\u0027password\u0027] \u003d CONF.get(\u0027admin_password\u0027, \u0027admin\u0027)"},{"line_number":108,"context_line":"    config[\u0027baremetal_endpoint_override\u0027] \u003d CONF.get("},{"line_number":109,"context_line":"        \u0027endpoints\u0027, {}).get(\u0027baremetal\u0027, \u0027https://192.168.24.2:13385/\u0027)"},{"line_number":110,"context_line":"    config[\u0027network_endpoint_override\u0027] \u003d CONF.get("},{"line_number":111,"context_line":"            \u0027endpoints\u0027, {}).get(\u0027network\u0027, \u0027https://192.168.24.2:13696/\u0027)"},{"line_number":112,"context_line":"    config[\u0027baremetal_introspection_endpoint_override\u0027] \u003d CONF.get("},{"line_number":113,"context_line":"            \u0027endpoints\u0027, {}).get("},{"line_number":114,"context_line":"                \u0027baremetal_introspection\u0027, \u0027https://192.168.24.2:13696/\u0027)"},{"line_number":115,"context_line":"    config[\u0027baremetal_api_version\u0027] \u003d \u00271\u0027"},{"line_number":116,"context_line":"    config[\u0027network_api_version\u0027] \u003d \u00272\u0027"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"2ec66397_711ee8b7","line":114,"range":{"start_line":108,"start_character":0,"end_line":114,"end_character":73},"in_reply_to":"fec5079c_cddbfa99","updated":"2021-09-17 14:11:05.000000000","message":"What\u0027s the situation where we\u0027d fall back to these defaults? Seems like something we should just drop","commit_id":"c293dfc7b1f4aed4d2f92c7f9aa38c06fe0d9841"}]}