)]}'
{"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"177705272d6436fec49bfad56719916ff33879fe","unresolved":true,"context_lines":[{"line_number":329,"context_line":"                  - \u0027\u0027"},{"line_number":330,"context_line":"                  - - \"#!/bin/bash\\n\\n\""},{"line_number":331,"context_line":"                    - {get_param: LeappInitCommand}"},{"line_number":332,"context_line":"            - name: Disable unsopported Kernel drivers before upgrade via Leapp"},{"line_number":333,"context_line":"              vars:"},{"line_number":334,"context_line":"                modules_to_unload: { get_attr: [RoleParametersValue, value, \u0027upgrade_leapp_modules_to_unload\u0027]}"},{"line_number":335,"context_line":"              modprobe:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"32ace07e_1a45b4fd","line":332,"range":{"start_line":332,"start_character":11,"end_line":332,"end_character":19},"updated":"2021-06-10 07:37:25.000000000","message":"This will need to be immediately before running leapp (~line 385?), otherwise the package changes below may cause modules to be reloaded.","commit_id":"e85b135495c36833579ef757d4a7168a34c6eb7b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"177705272d6436fec49bfad56719916ff33879fe","unresolved":true,"context_lines":[{"line_number":329,"context_line":"                  - \u0027\u0027"},{"line_number":330,"context_line":"                  - - \"#!/bin/bash\\n\\n\""},{"line_number":331,"context_line":"                    - {get_param: LeappInitCommand}"},{"line_number":332,"context_line":"            - name: Disable unsopported Kernel drivers before upgrade via Leapp"},{"line_number":333,"context_line":"              vars:"},{"line_number":334,"context_line":"                modules_to_unload: { get_attr: [RoleParametersValue, value, \u0027upgrade_leapp_modules_to_unload\u0027]}"},{"line_number":335,"context_line":"              modprobe:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ad31316d_65a58bc5","line":332,"range":{"start_line":332,"start_character":28,"end_line":332,"end_character":39},"updated":"2021-06-10 07:37:25.000000000","message":"unsupported (spelling error)","commit_id":"e85b135495c36833579ef757d4a7168a34c6eb7b"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"94ba6a323ad7c81977c99433d83761704d78f69a","unresolved":true,"context_lines":[{"line_number":376,"context_line":"            - name: unmount and remove nfs nova entry"},{"line_number":377,"context_line":"              mount: path\u003d/var/lib/nova/instances state\u003dabsent"},{"line_number":378,"context_line":"              ignore_errors: true"},{"line_number":379,"context_line":"            - name: disable unsupported kernel drivers before upgrade via Leapp"},{"line_number":380,"context_line":"              vars:"},{"line_number":381,"context_line":"                modules_to_unload: { get_attr: [RoleParametersValue, value, \u0027upgrade_leapp_modules_to_unload\u0027]}"},{"line_number":382,"context_line":"              modprobe:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"62cd769d_95f112bd","line":379,"updated":"2021-06-10 11:27:01.000000000","message":"They are supported in RHEL7. I would rephrase it as it\u0027s confusing.","commit_id":"3c67e681fa61a9aef85dcb8e83395b4d8686094a"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"c90f3bf3948d58a63b807e9cdce16f2810ae6aa4","unresolved":false,"context_lines":[{"line_number":376,"context_line":"            - name: unmount and remove nfs nova entry"},{"line_number":377,"context_line":"              mount: path\u003d/var/lib/nova/instances state\u003dabsent"},{"line_number":378,"context_line":"              ignore_errors: true"},{"line_number":379,"context_line":"            - name: disable unsupported kernel drivers before upgrade via Leapp"},{"line_number":380,"context_line":"              vars:"},{"line_number":381,"context_line":"                modules_to_unload: { get_attr: [RoleParametersValue, value, \u0027upgrade_leapp_modules_to_unload\u0027]}"},{"line_number":382,"context_line":"              modprobe:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a988de6_a18440f4","line":379,"in_reply_to":"62cd769d_95f112bd","updated":"2021-06-10 11:43:21.000000000","message":"Done","commit_id":"3c67e681fa61a9aef85dcb8e83395b4d8686094a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"81d2b34d6c1a5007b9248261c75268c97d219526","unresolved":true,"context_lines":[{"line_number":84,"context_line":"      Command or script snippet to run on all overcloud nodes to"},{"line_number":85,"context_line":"      initialize the Leapp process. E.g. a repository switch."},{"line_number":86,"context_line":"    default: \u0027\u0027"},{"line_number":87,"context_line":"  LeappUnloadKernelDrivers:"},{"line_number":88,"context_line":"    type: comma_delimited_list"},{"line_number":89,"context_line":"    default: [\u0027floppy\u0027, \u0027pata_acpi\u0027]"},{"line_number":90,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df665869_a7b71652","line":87,"range":{"start_line":87,"start_character":2,"end_line":87,"end_character":27},"updated":"2021-06-10 14:20:26.000000000","message":"I do wonder whether this is an interface we are going to want to carry forward to our next upgrade? I know that the default values are only applicable to RHEL7-\u003e8, but we may have something similar we have to do in RHEL8-\u003e9?","commit_id":"1e39ea9e6504e561acebd5056d4e00aee92d84c0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"620f420351a0214af669f54deab81890a8c8ab31","unresolved":true,"context_lines":[{"line_number":376,"context_line":"            - name: unmount and remove nfs nova entry"},{"line_number":377,"context_line":"              mount: path\u003d/var/lib/nova/instances state\u003dabsent"},{"line_number":378,"context_line":"              ignore_errors: true"},{"line_number":379,"context_line":"            - name: disable unsupported kernel drivers in RHEL8 before upgrade via Leapp"},{"line_number":380,"context_line":"              vars:"},{"line_number":381,"context_line":"                modules_to_unload: { get_attr: [RoleParametersValue, value, \u0027upgrade_leapp_modules_to_unload\u0027]}"},{"line_number":382,"context_line":"              modprobe:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"de098023_c29d3b69","line":379,"range":{"start_line":379,"start_character":20,"end_line":379,"end_character":88},"updated":"2021-06-10 14:19:11.000000000","message":"Perhaps something like this to eliminate the ambiguity?\n\nUnload drivers not supported in RHEL8 in order to pass leapp checks","commit_id":"1e39ea9e6504e561acebd5056d4e00aee92d84c0"}]}