)]}'
{"common/services/role.role.j2.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"da204aafb82771f971594b4b86f4602bbfe010aa","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    description: Parameters specific to the role"},{"line_number":34,"context_line":"    default: {}"},{"line_number":35,"context_line":"    type: json"},{"line_number":36,"context_line":"  ExtraAnsibleGroupVars:"},{"line_number":37,"context_line":"    default: {}"},{"line_number":38,"context_line":"    description: Mapping of Ansible group variable overrides."},{"line_number":39,"context_line":"    type: json"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"63c74358_779384c9","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":24},"updated":"2021-06-14 03:34:50.000000000","message":"We should not add this to ServiceChain. There is already one role specific extra ansible vars interface. But if that\u0027s not useful and we want another (non-role specific) one, then we should add it to overcloud.j2.yaml.\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/overcloud.j2.yaml#L301","commit_id":"b0369036b5d1b32a253a8a2add4a2b9b3e21ca83"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"7d3447173cc2fbe3f30e34ccc7d06d8f8b4db0b4","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    description: Parameters specific to the role"},{"line_number":34,"context_line":"    default: {}"},{"line_number":35,"context_line":"    type: json"},{"line_number":36,"context_line":"  ExtraAnsibleGroupVars:"},{"line_number":37,"context_line":"    default: {}"},{"line_number":38,"context_line":"    description: Mapping of Ansible group variable overrides."},{"line_number":39,"context_line":"    type: json"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"72bf1b09_b566256e","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":24},"in_reply_to":"63c74358_779384c9","updated":"2021-06-14 15:18:23.000000000","message":"done. I pushed the changes to overcloud.j2.yaml","commit_id":"b0369036b5d1b32a253a8a2add4a2b9b3e21ca83"}],"overcloud.j2.yaml":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"459b8dee2f22707068ffeea97b23216fdb7f687e","unresolved":true,"context_lines":[{"line_number":17,"context_line":"# TODO(shadower): we should probably use the parameter groups to put"},{"line_number":18,"context_line":"# some order in here."},{"line_number":19,"context_line":"parameters:"},{"line_number":20,"context_line":"  ExtraAnsibleGroupVars:"},{"line_number":21,"context_line":"    default: {}"},{"line_number":22,"context_line":"    description: Mapping of Ansible group variable overrides."},{"line_number":23,"context_line":"    type: json"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"715d7008_de7d4d0d","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":24},"updated":"2021-06-14 15:33:18.000000000","message":"This template is wild with naming between group and host vars. But maybe to reduce some confusion this should be ExtraAnsibleHostVars?\n\nWhatever the team agrees on. It\u0027s just confusing if you\u0027re thinking about Ansible Host vars and Group vars and could confuse users.","commit_id":"80bb935e941629b4b621fdb88fea7c09738ac83e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"ce786acaf931efba166ac40032973e0a2ae336ed","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# TODO(shadower): we should probably use the parameter groups to put"},{"line_number":18,"context_line":"# some order in here."},{"line_number":19,"context_line":"parameters:"},{"line_number":20,"context_line":"  ExtraAnsibleGroupVars:"},{"line_number":21,"context_line":"    default: {}"},{"line_number":22,"context_line":"    description: Mapping of Ansible group variable overrides."},{"line_number":23,"context_line":"    type: json"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"51ca68d4_90d76586","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":24},"in_reply_to":"715d7008_de7d4d0d","updated":"2021-06-14 15:40:57.000000000","message":"Done","commit_id":"80bb935e941629b4b621fdb88fea7c09738ac83e"}]}