)]}'
{"deployed-server/deployed-server.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a1da74719716bcb0d70b3d6eeeb7a16114da0eaf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6bcdb41a_4ece154f","updated":"2021-06-15 23:20:54.000000000","message":"yes, this looks good","commit_id":"6a4f847769d7c5d3c8c2c502b03288e1a0bc5db7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a1da74719716bcb0d70b3d6eeeb7a16114da0eaf","unresolved":true,"context_lines":[{"line_number":85,"context_line":"    value:"},{"line_number":86,"context_line":"      ctlplane:"},{"line_number":87,"context_line":"        - subnets:"},{"line_number":88,"context_line":"          - cidr: {get_attr: [ControlPlanePort, value, ip_subnet]}"},{"line_number":89,"context_line":"  name:"},{"line_number":90,"context_line":"    value: {get_param: name}"},{"line_number":91,"context_line":"  os_collect_config:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a05c8bd_a87c716f","line":88,"range":{"start_line":88,"start_character":55,"end_line":88,"end_character":64},"updated":"2021-06-15 23:20:54.000000000","message":"This one is IP_ADDRESS/PREFIX_BITs, I think we used to have NETWORK_ADDRESS/PREFIX_BITs here.\ni.e 192.168.24.0/24, not 192.168.24.42/24.\n\nBut afict we always do a split on \u0027/\u0027 and pick just the prefix bits, so this should work fine. +1","commit_id":"6a4f847769d7c5d3c8c2c502b03288e1a0bc5db7"}],"environments/deployed-ports.j2.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"bdc83e2cbb86cf2cf752479c153c1c6d752ea750","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Map all ports by role and network to their equivalent"},{"line_number":2,"context_line":"# deployed_\u003cnetwork.name_lower\u003e.yaml template."},{"line_number":3,"context_line":"resource_registry:"},{"line_number":4,"context_line":"  # Port assignments for the VIPs"},{"line_number":5,"context_line":"  {%- for network in networks if network.vip and network.enabled|default(true) %}"},{"line_number":6,"context_line":"  {%- if network.external_resource_vip_id|default(\u0027\u0027) %}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4bef9eb9_5ea82872","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":17},"updated":"2021-06-15 14:22:14.000000000","message":"Won\u0027t we need to set this here statically here?\n  OS::TripleO::DeployedServer::ControlPlanePort: ../network/ports/deployed_ctlplane.yaml\n\nAnd also add a static ../network/ports/deployed_ctlplane.yaml file, with an output section mimicking a neutron port?","commit_id":"35c67b5ff12f99da2872ec56e3afb5c1b5dd9252"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"0e5704b9cae1a358f16738564038f8eedd8ee935","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Map all ports by role and network to their equivalent"},{"line_number":2,"context_line":"# deployed_\u003cnetwork.name_lower\u003e.yaml template."},{"line_number":3,"context_line":"resource_registry:"},{"line_number":4,"context_line":"  # Port assignments for the VIPs"},{"line_number":5,"context_line":"  {%- for network in networks if network.vip and network.enabled|default(true) %}"},{"line_number":6,"context_line":"  {%- if network.external_resource_vip_id|default(\u0027\u0027) %}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff446703_f780ab85","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":17},"in_reply_to":"4bef9eb9_5ea82872","updated":"2021-06-15 19:17:01.000000000","message":"Yes, thank you. I thought it was already handled by NodePortMap, since that contains a ctlplane key per node.\n\nWhat I\u0027ve actually done is just pull that value and use it directly here instead of an intermediate port resource mapping. I think this will work.","commit_id":"35c67b5ff12f99da2872ec56e3afb5c1b5dd9252"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a1da74719716bcb0d70b3d6eeeb7a16114da0eaf","unresolved":true,"context_lines":[{"line_number":3,"context_line":"resource_registry:"},{"line_number":4,"context_line":"  # Port assignments for the VIPs"},{"line_number":5,"context_line":"  {%- for network in networks if network.vip and network.enabled|default(true) %}"},{"line_number":6,"context_line":"  {%- if network.external_resource_vip_id|default(\u0027\u0027) %}"},{"line_number":7,"context_line":"  OS::TripleO::Network::Ports::{{network.name}}VipPort: ../network/ports/external_resource_{{network.name_lower|default(network.name.lower())}}.yaml"},{"line_number":8,"context_line":"  {%- else %}"},{"line_number":9,"context_line":"  OS::TripleO::Network::Ports::{{network.name}}VipPort: ../network/ports/deployed_vip_{{network.name_lower|default(network.name.lower())}}.yaml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7b8250b9_b0f81365","line":6,"range":{"start_line":6,"start_character":17,"end_line":6,"end_character":41},"updated":"2021-06-15 23:20:54.000000000","message":"network-v2 does not allow this property.\nWill need an update here[1] if we want to allow using this in combination with \u0027overcloud network provision\u0027\n\n[1] https://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/ansible_plugins/module_utils/network_data_v2.py#L248","commit_id":"6a4f847769d7c5d3c8c2c502b03288e1a0bc5db7"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"83b6d2b2685ed8b2a98376b40af8277d200d6916","unresolved":true,"context_lines":[{"line_number":3,"context_line":"resource_registry:"},{"line_number":4,"context_line":"  # Port assignments for the VIPs"},{"line_number":5,"context_line":"  {%- for network in networks if network.vip and network.enabled|default(true) %}"},{"line_number":6,"context_line":"  {%- if network.external_resource_vip_id|default(\u0027\u0027) %}"},{"line_number":7,"context_line":"  OS::TripleO::Network::Ports::{{network.name}}VipPort: ../network/ports/external_resource_{{network.name_lower|default(network.name.lower())}}.yaml"},{"line_number":8,"context_line":"  {%- else %}"},{"line_number":9,"context_line":"  OS::TripleO::Network::Ports::{{network.name}}VipPort: ../network/ports/deployed_vip_{{network.name_lower|default(network.name.lower())}}.yaml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0ba07fca_ca0b7b1c","line":6,"range":{"start_line":6,"start_character":17,"end_line":6,"end_character":41},"in_reply_to":"7b8250b9_b0f81365","updated":"2021-06-16 14:49:11.000000000","message":"ok, i\u0027ve removed this loop and \"if\", as it\u0027s not actually needed. all of the external resource handling is in fact no longer needed with network-v2, so i will clean the rest of that up separately.","commit_id":"6a4f847769d7c5d3c8c2c502b03288e1a0bc5db7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"be1915fd8ff69c990187977a523645f60e879e8a","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# deployed_\u003cnetwork.name_lower\u003e.yaml template."},{"line_number":3,"context_line":"resource_registry:"},{"line_number":4,"context_line":"  # Port assignments for the VIPs"},{"line_number":5,"context_line":"  {%- for network in networks if network.vip and network.enabled|default(true) %}"},{"line_number":6,"context_line":"  OS::TripleO::Network::Ports::{{network.name}}VipPort: ../network/ports/deployed_vip_{{network.name_lower|default(network.name.lower())}}.yaml"},{"line_number":7,"context_line":"  {%- endfor %}"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"369ff8c8_71e6cfd4","line":5,"range":{"start_line":5,"start_character":33,"end_line":5,"end_character":44},"updated":"2021-06-18 04:20:29.000000000","message":"I think vip key is optional in network-data-v2. So this would require a default(?).","commit_id":"34ccb6f2fed15b64779c701531ff21ced7f9965a"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"be1915fd8ff69c990187977a523645f60e879e8a","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  {%- for role in roles %}"},{"line_number":10,"context_line":"  {%-     if role.networks is mapping %}"},{"line_number":11,"context_line":"  {%-         set _role_networks \u003d [] %}"},{"line_number":12,"context_line":"  {%-         for key, val in role.networks.items() %}"},{"line_number":13,"context_line":"  {%-             set _ \u003d _role_networks.append(key) %}"},{"line_number":14,"context_line":"  {%-         endfor %}"},{"line_number":15,"context_line":"  {%-     else %}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3b890166_ec22fcd2","line":12,"range":{"start_line":12,"start_character":22,"end_line":12,"end_character":26},"updated":"2021-06-18 04:20:29.000000000","message":"\u0027_\u0027 could be used.","commit_id":"34ccb6f2fed15b64779c701531ff21ced7f9965a"}]}