)]}'
{"common/deploy-steps.j2":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ce68f307193a34cd3fa56f78a75d7660bf6ca509","unresolved":true,"context_lines":[{"line_number":853,"context_line":"                  vars:"},{"line_number":854,"context_line":"                    step: \"{{ step }}\""},{"line_number":855,"context_line":"{%- endfor %}"},{"line_number":856,"context_line":"                - import_tasks: \"{{role.name}}/host_prep_tasks.yaml\""},{"line_number":857,"context_line":"                  when: tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"},{"line_number":858,"context_line":"                - import_tasks: deploy_steps_tasks_step_0.yaml"},{"line_number":859,"context_line":"                  vars:"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"0e14d3aa_5498a9df","line":856,"range":{"start_line":856,"start_character":18,"end_line":856,"end_character":30},"updated":"2021-09-21 10:50:32.000000000","message":"Keep this as an include, not an import. Include will skip the whole file in one task if the role name doesn\u0027t match - whereas import will result in a ton of skipped tasks because the condition is applied to each imported task.","commit_id":"8be21b3f42665c7150ffef5165f221b4cd2c260a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7afcfe5ed9c8bb3513082274d666a75394e976b4","unresolved":false,"context_lines":[{"line_number":853,"context_line":"                  vars:"},{"line_number":854,"context_line":"                    step: \"{{ step }}\""},{"line_number":855,"context_line":"{%- endfor %}"},{"line_number":856,"context_line":"                - import_tasks: \"{{role.name}}/host_prep_tasks.yaml\""},{"line_number":857,"context_line":"                  when: tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"},{"line_number":858,"context_line":"                - import_tasks: deploy_steps_tasks_step_0.yaml"},{"line_number":859,"context_line":"                  vars:"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"a5413667_cdeb89e1","line":856,"range":{"start_line":856,"start_character":18,"end_line":856,"end_character":30},"in_reply_to":"0e14d3aa_5498a9df","updated":"2022-02-04 11:50:47.000000000","message":"Done","commit_id":"8be21b3f42665c7150ffef5165f221b4cd2c260a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"16d4f8bd7148350b3897d1ae3624b07c48500733","unresolved":true,"context_lines":[{"line_number":853,"context_line":"                  vars:"},{"line_number":854,"context_line":"                    step: \"{{ step }}\""},{"line_number":855,"context_line":"{%- endfor %}"},{"line_number":856,"context_line":"                - import_tasks: \"{{role.name}}/host_prep_tasks.yaml\""},{"line_number":857,"context_line":"                  when: tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"},{"line_number":858,"context_line":"                - import_tasks: deploy_steps_tasks_step_0.yaml"},{"line_number":859,"context_line":"                  vars:"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9117c8be_63701750","line":856,"range":{"start_line":856,"start_character":18,"end_line":856,"end_character":30},"updated":"2021-10-04 12:46:48.000000000","message":"Given that this is conditionally included, wouldn\u0027t it be better to leave this an an include and not an import?","commit_id":"cf0e3d8d9063980d337e06d6d77392d0a83f847b"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"4959ac9238259bc59677939426603e948537cbe4","unresolved":true,"context_lines":[{"line_number":853,"context_line":"                  vars:"},{"line_number":854,"context_line":"                    step: \"{{ step }}\""},{"line_number":855,"context_line":"{%- endfor %}"},{"line_number":856,"context_line":"                - import_tasks: \"{{role.name}}/host_prep_tasks.yaml\""},{"line_number":857,"context_line":"                  when: tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"},{"line_number":858,"context_line":"                - import_tasks: deploy_steps_tasks_step_0.yaml"},{"line_number":859,"context_line":"                  vars:"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"e40bf2d1_44a300b8","line":856,"range":{"start_line":856,"start_character":18,"end_line":856,"end_character":30},"in_reply_to":"9117c8be_63701750","updated":"2021-10-04 13:45:04.000000000","message":"Hum, right. I see the point here. I think I wanted import to be able to skip/target tasks inside the host_prep_tasks .... but now it make no sense anymore.  So ... let\u0027s change this to include_tasks.\nThanks.","commit_id":"cf0e3d8d9063980d337e06d6d77392d0a83f847b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7afcfe5ed9c8bb3513082274d666a75394e976b4","unresolved":false,"context_lines":[{"line_number":853,"context_line":"                  vars:"},{"line_number":854,"context_line":"                    step: \"{{ step }}\""},{"line_number":855,"context_line":"{%- endfor %}"},{"line_number":856,"context_line":"                - import_tasks: \"{{role.name}}/host_prep_tasks.yaml\""},{"line_number":857,"context_line":"                  when: tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"},{"line_number":858,"context_line":"                - import_tasks: deploy_steps_tasks_step_0.yaml"},{"line_number":859,"context_line":"                  vars:"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"364f5ae2_9d1dc262","line":856,"range":{"start_line":856,"start_character":18,"end_line":856,"end_character":30},"in_reply_to":"e40bf2d1_44a300b8","updated":"2022-02-04 11:50:47.000000000","message":"Looks like we discussed this in the master patch: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/740302/13/common/deploy-steps.j2","commit_id":"cf0e3d8d9063980d337e06d6d77392d0a83f847b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7afcfe5ed9c8bb3513082274d666a75394e976b4","unresolved":true,"context_lines":[{"line_number":860,"context_line":"                    step: \"{{ step }}\""},{"line_number":861,"context_line":"{%- endfor %}"},{"line_number":862,"context_line":"                - import_tasks: \"{{role.name}}/host_prep_tasks.yaml\""},{"line_number":863,"context_line":"                  when: tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"},{"line_number":864,"context_line":"                - import_tasks: deploy_steps_tasks_step_0.yaml"},{"line_number":865,"context_line":"                  vars:"},{"line_number":866,"context_line":"                    step: 0"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"6ac2a5fb_f77d5868","line":863,"range":{"start_line":863,"start_character":18,"end_line":863,"end_character":60},"updated":"2022-02-04 11:50:47.000000000","message":"This is a useless condition because of the use of the role name in the line above, but that\u0027s a fix that should land in master first and come down as a subsequent patch to this backport.","commit_id":"a87c0196ea20f10e293ab24383a373e9fb86724d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d4047537c907d68f71bfa739c97e02ad63819149","unresolved":false,"context_lines":[{"line_number":860,"context_line":"                    step: \"{{ step }}\""},{"line_number":861,"context_line":"{%- endfor %}"},{"line_number":862,"context_line":"                - import_tasks: \"{{role.name}}/host_prep_tasks.yaml\""},{"line_number":863,"context_line":"                  when: tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"},{"line_number":864,"context_line":"                - import_tasks: deploy_steps_tasks_step_0.yaml"},{"line_number":865,"context_line":"                  vars:"},{"line_number":866,"context_line":"                    step: 0"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"c7224278_c7f2ee9a","line":863,"range":{"start_line":863,"start_character":18,"end_line":863,"end_character":60},"in_reply_to":"63190f47_70d141ae","updated":"2022-09-23 13:21:06.000000000","message":"Ack","commit_id":"a87c0196ea20f10e293ab24383a373e9fb86724d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"0c6749709477445c9025fbb26a771a2c4ca880e6","unresolved":true,"context_lines":[{"line_number":860,"context_line":"                    step: \"{{ step }}\""},{"line_number":861,"context_line":"{%- endfor %}"},{"line_number":862,"context_line":"                - import_tasks: \"{{role.name}}/host_prep_tasks.yaml\""},{"line_number":863,"context_line":"                  when: tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"},{"line_number":864,"context_line":"                - import_tasks: deploy_steps_tasks_step_0.yaml"},{"line_number":865,"context_line":"                  vars:"},{"line_number":866,"context_line":"                    step: 0"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"63190f47_70d141ae","line":863,"range":{"start_line":863,"start_character":18,"end_line":863,"end_character":60},"in_reply_to":"6ac2a5fb_f77d5868","updated":"2022-09-23 11:31:07.000000000","message":"I kept it as it was in the original, but right, it looked useless then, and it might really be.","commit_id":"a87c0196ea20f10e293ab24383a373e9fb86724d"}]}