)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7e3905ee8976a20cdc5c94cb4cd1f997e58624f3","unresolved":true,"context_lines":[{"line_number":16,"context_line":"   localhost/tripleo/openstack-heat-api:ephemeral"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tripleo-common/+/796614"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I923856c83c14eb54073684ace93e9e1e85f53329"},{"line_number":21,"context_line":"Signed-off-by: Bogdan Dobrelya \u003cbdobreli@redhat.com\u003e"},{"line_number":22,"context_line":"Signed-off-by: Alex Schultz \u003caschultz@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"073c0c0d_4d621a51","line":19,"updated":"2021-06-22 10:29:31.000000000","message":"please include the related bug info on these so we can track the fixes (https://bugs.launchpad.net/tripleo/+bug/1931995)","commit_id":"4bceecbde22f7754a2d4b8580a43ff2b45728c25"}],"deployment/heat/heat-ephemeral-container-ansible.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7e3905ee8976a20cdc5c94cb4cd1f997e58624f3","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  ContainerHeatAllImage:"},{"line_number":8,"context_line":"    description: The container image to use for heat-all"},{"line_number":9,"context_line":"    type: string"},{"line_number":10,"context_line":"  ContainerHeatEngineImage:"},{"line_number":11,"context_line":"    description: image"},{"line_number":12,"context_line":"    type: string"},{"line_number":13,"context_line":"  ContainerHeatConfigImage:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"e2036522_6bb818cc","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":26},"updated":"2021-06-22 10:29:31.000000000","message":"so these are now mandatory parameters? I.e. when using ephemeral heat, the operator must specify the Heat Engine/All/API container that should be used.\n\nI think it is worth considering a release note please?","commit_id":"4bceecbde22f7754a2d4b8580a43ff2b45728c25"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4ecaa94a4002971cda3dc261972cc1836bfa67f6","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  ContainerHeatAllImage:"},{"line_number":8,"context_line":"    description: The container image to use for heat-all"},{"line_number":9,"context_line":"    type: string"},{"line_number":10,"context_line":"  ContainerHeatEngineImage:"},{"line_number":11,"context_line":"    description: image"},{"line_number":12,"context_line":"    type: string"},{"line_number":13,"context_line":"  ContainerHeatConfigImage:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"427eb2dd_0e9cd156","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":26},"in_reply_to":"3b96ab8d_a034754f","updated":"2021-06-22 10:51:21.000000000","message":"ack thank you I did not yet check that patch","commit_id":"4bceecbde22f7754a2d4b8580a43ff2b45728c25"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"dd5daac2a0559b0b3e3f00d6daa9654a743ebcdb","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  ContainerHeatAllImage:"},{"line_number":8,"context_line":"    description: The container image to use for heat-all"},{"line_number":9,"context_line":"    type: string"},{"line_number":10,"context_line":"  ContainerHeatEngineImage:"},{"line_number":11,"context_line":"    description: image"},{"line_number":12,"context_line":"    type: string"},{"line_number":13,"context_line":"  ContainerHeatConfigImage:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3b96ab8d_a034754f","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":26},"in_reply_to":"e2036522_6bb818cc","updated":"2021-06-22 10:46:38.000000000","message":"as I understand the CIP magic, those are automatically evaluated (via the linked dependency patch) so there is nothing to be provided by an operator","commit_id":"4bceecbde22f7754a2d4b8580a43ff2b45728c25"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"a167d5ad8118f018c7d0ade67011f8c321f2e0a1","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    value:"},{"line_number":50,"context_line":"      service_name: heat_ephemeral"},{"line_number":51,"context_line":"      upgrade_tasks: []"},{"line_number":52,"context_line":"      deploy_steps_tasks:"},{"line_number":53,"context_line":"        - name: Tag Ephemeral Heat Containers for Overcloud Deploy"},{"line_number":54,"context_line":"          when:"},{"line_number":55,"context_line":"            - step|int \u003d\u003d 5"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"d59990dc_1bdc721e","line":52,"range":{"start_line":52,"start_character":6,"end_line":52,"end_character":25},"updated":"2021-06-22 03:23:06.000000000","message":"Do we need these additional tasks? As it\u0027s very specific to undercloud, can we not leverage cip (modify ContainerImagePrepare for undercloud to tag them the way we want by adding something like below)?\n- push_destination: true\n  includes:\n  - heat-api\n  - heat-engine\n  - heat-all\n  set:\n    namespace: xxxx\n    tag: ephemeral","commit_id":"4bceecbde22f7754a2d4b8580a43ff2b45728c25"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"684ed412f0762d1e00804bd535761d5ce8dd9584","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    value:"},{"line_number":50,"context_line":"      service_name: heat_ephemeral"},{"line_number":51,"context_line":"      upgrade_tasks: []"},{"line_number":52,"context_line":"      deploy_steps_tasks:"},{"line_number":53,"context_line":"        - name: Tag Ephemeral Heat Containers for Overcloud Deploy"},{"line_number":54,"context_line":"          when:"},{"line_number":55,"context_line":"            - step|int \u003d\u003d 5"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bea2bdd4_5df45f71","line":52,"range":{"start_line":52,"start_character":6,"end_line":52,"end_character":25},"in_reply_to":"075a6f3f_930c0d42","updated":"2021-06-22 13:22:49.000000000","message":"So this prepares heat container images locally on the undercloud to be consumed by the cli later.  CIP does not actually fetch the images on to the system for usage, it populates the registry and generates the urls.  The actual fetching of containers and things occurs in the framework. So this is specific to the undercloud usage where we\u0027ll be running the overcloud deploy later.  standalone/undercloud already have cli params for heat container images which would be different (and not the current target).  We don\u0027t need to use CIP for those either.","commit_id":"4bceecbde22f7754a2d4b8580a43ff2b45728c25"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e720d1bc90a132fe70db67cea60612022b05c793","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    value:"},{"line_number":50,"context_line":"      service_name: heat_ephemeral"},{"line_number":51,"context_line":"      upgrade_tasks: []"},{"line_number":52,"context_line":"      deploy_steps_tasks:"},{"line_number":53,"context_line":"        - name: Tag Ephemeral Heat Containers for Overcloud Deploy"},{"line_number":54,"context_line":"          when:"},{"line_number":55,"context_line":"            - step|int \u003d\u003d 5"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7e289b5e_a3988969","line":52,"range":{"start_line":52,"start_character":6,"end_line":52,"end_character":25},"in_reply_to":"314a6524_acc10041","updated":"2021-06-24 04:19:01.000000000","message":"\u003e CIP does not actually fetch the images on to the system for usage, it populates the registry and generates the urls. \n\nYeah, we fetch the images from local registry to the system and then tag them \u0027ephemeral\u0027 for overcloud deploy to find it.\n\nI initially thought that by default we pull the images to system and then push to local registry. Looks like we copy registry-to-registry. Only in the case we want to modify the image (normally I use with cip and it confused me), we pull from local and then push to local registry again.","commit_id":"4bceecbde22f7754a2d4b8580a43ff2b45728c25"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"d7a4fd1b46c2c748a4b503a22d7eb0975ed8f950","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    value:"},{"line_number":50,"context_line":"      service_name: heat_ephemeral"},{"line_number":51,"context_line":"      upgrade_tasks: []"},{"line_number":52,"context_line":"      deploy_steps_tasks:"},{"line_number":53,"context_line":"        - name: Tag Ephemeral Heat Containers for Overcloud Deploy"},{"line_number":54,"context_line":"          when:"},{"line_number":55,"context_line":"            - step|int \u003d\u003d 5"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"314a6524_acc10041","line":52,"range":{"start_line":52,"start_character":6,"end_line":52,"end_character":25},"in_reply_to":"bea2bdd4_5df45f71","updated":"2021-06-23 02:45:54.000000000","message":"Well as I can see, undercloud cip run will pull the image from remote and upload it to local registry (as the service is included and https://review.opendev.org/c/openstack/tripleo-common/+/796614). You\u0027re \u0027just\u0027 tagging the images[1] to some hard-coded tag  \u0027localhost/tripleo/openstack-heat-all:ephemeral\u0027 for overcloud deploy to look for that all the time.\n\n[1] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_container_tag/tasks/main.yml#L33\n\n\n192.168.24.1:8787/tripleomaster/openstack-heat-engine                4dfe86fffbfd37ec10e4f2e101dc89a4  7864f95e8e94  2 hours ago   957 MB\nlocalhost/tripleo/openstack-heat-engine                              ephemeral                         7864f95e8e94  2 hours ago   957 MB\nlocalhost/tripleo/openstack-heat-api                                 ephemeral                         5e4392335fc9  2 hours ago   957 MB\n192.168.24.1:8787/tripleomaster/openstack-heat-api                   4dfe86fffbfd37ec10e4f2e101dc89a4  5e4392335fc9  2 hours ago   957 MB\n192.168.24.1:8787/tripleomaster/openstack-heat-all                   4dfe86fffbfd37ec10e4f2e101dc89a4  9731ddf19bea  2 hours ago   957 MB\nlocalhost/tripleo/openstack-heat-all                                 ephemeral                         9731ddf19bea  2 hours ago   957 MB","commit_id":"4bceecbde22f7754a2d4b8580a43ff2b45728c25"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"8ce4a936a24e4e2d11794049e312899949a30ea3","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    value:"},{"line_number":50,"context_line":"      service_name: heat_ephemeral"},{"line_number":51,"context_line":"      upgrade_tasks: []"},{"line_number":52,"context_line":"      deploy_steps_tasks:"},{"line_number":53,"context_line":"        - name: Tag Ephemeral Heat Containers for Overcloud Deploy"},{"line_number":54,"context_line":"          when:"},{"line_number":55,"context_line":"            - step|int \u003d\u003d 5"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"075a6f3f_930c0d42","line":52,"range":{"start_line":52,"start_character":6,"end_line":52,"end_character":25},"in_reply_to":"d59990dc_1bdc721e","updated":"2021-06-22 05:00:02.000000000","message":"Ignore that. I guess it would look to pull that tagged image.","commit_id":"4bceecbde22f7754a2d4b8580a43ff2b45728c25"}],"deployment/heat/heat-ephemeral-noop.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1e8c53f5851dd452899b88aecf07fb28d8295d0b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"  Openstack Heat Ephemeral service, provides nothing but container images"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"parameters:"},{"line_number":7,"context_line":"  ContainerHeatEngineImage:"},{"line_number":8,"context_line":"    description: image"},{"line_number":9,"context_line":"    type: string"},{"line_number":10,"context_line":"  ContainerHeatConfigImage:"},{"line_number":11,"context_line":"    description:"},{"line_number":12,"context_line":"    type: string"},{"line_number":13,"context_line":"  ContainerHeatApiImage:"},{"line_number":14,"context_line":"    description: image"},{"line_number":15,"context_line":"    type: string"},{"line_number":16,"context_line":"  ContainerHeatApiConfigImage:"},{"line_number":17,"context_line":"    description:"},{"line_number":18,"context_line":"    type: string"},{"line_number":19,"context_line":"  ContainerHeatAllImage:"},{"line_number":20,"context_line":"    description:"},{"line_number":21,"context_line":"    type: string"},{"line_number":22,"context_line":"  ServiceData:"},{"line_number":23,"context_line":"    default: {}"},{"line_number":24,"context_line":"    description: Dictionary packing service data"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0ebccb6e_26e0e260","line":21,"range":{"start_line":7,"start_character":0,"end_line":21,"end_character":16},"updated":"2021-06-16 09:50:37.000000000","message":"those are not used, but I\u0027m not certain if we must have it or may not, given the way we define it also in https://review.opendev.org/c/openstack/tripleo-common/+/796614/1/container-images/tripleo_containers.yaml.j2","commit_id":"486d340200893883000bf8b4bfa91aa891350b7b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"61283e0e886e762334532cde17c049d05c1e29cb","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    description: Role data for the Heat Ephemeral"},{"line_number":46,"context_line":"    value:"},{"line_number":47,"context_line":"      service_name:  heat_ephemeral"},{"line_number":48,"context_line":"      upgrade_tasks: []"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"00365d25_e6cb50d6","line":48,"updated":"2021-06-21 14:40:02.000000000","message":"So we talked about this service this morning and we should use it to ensure that we get the containers for ephemeral heat fetched on the undercloud for the deployemnt. We can use deploy step tasks to actually tag the fetched containers to something that the tripleoclient will use (e.g. localhost/tripleo/heat-ephemeral:latest) as a default.  This would ensure that the ephemeral heat container images will be available for the overcloud deployment command later and the container image prepare that runs during `openstack undercloud *` command will manage the heat used later","commit_id":"1a095ceed21d4f5a5fb7006130e69cd51cd16c37"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"19d1ffdf5095304e29b71b181799fa32b9be3752","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    description: Role data for the Heat Ephemeral"},{"line_number":46,"context_line":"    value:"},{"line_number":47,"context_line":"      service_name:  heat_ephemeral"},{"line_number":48,"context_line":"      upgrade_tasks: []"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e99e9c72_bae7721a","line":48,"in_reply_to":"00365d25_e6cb50d6","updated":"2021-06-21 16:25:05.000000000","message":"You mean to use that service for more than only ensuring CIP prepares the images by the evaluated tags? That prolly makes sense, although I\u0027m not sure how we want to do that exactly... Mind making a follow-up or update in place?","commit_id":"1a095ceed21d4f5a5fb7006130e69cd51cd16c37"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1fe38cafac9bad4993904d5b21fae9037df353d1","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    description: Role data for the Heat Ephemeral"},{"line_number":46,"context_line":"    value:"},{"line_number":47,"context_line":"      service_name:  heat_ephemeral"},{"line_number":48,"context_line":"      upgrade_tasks: []"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f892da8d_680c58ee","line":48,"in_reply_to":"e99e9c72_bae7721a","updated":"2021-06-21 16:26:11.000000000","message":"yea i\u0027ll fix this up today based on the conversation we had. Right now we don\u0027t do ephemeral for standalone/undercloud so it\u0027s an overcloud thing","commit_id":"1a095ceed21d4f5a5fb7006130e69cd51cd16c37"}],"environments/enable-designate.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"b4be13cb0156919571221f44c009e483de243ae2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"654cb822_758edc99","updated":"2021-06-16 11:25:55.000000000","message":"I guess it was re-generated? This one can be ignored imho.","commit_id":"486d340200893883000bf8b4bfa91aa891350b7b"}],"environments/standalone/standalone-overcloud.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"b4be13cb0156919571221f44c009e483de243ae2","unresolved":true,"context_lines":[{"line_number":69,"context_line":"  OS::TripleO::Services::DesignateProducer: OS::Heat::None"},{"line_number":70,"context_line":"  OS::TripleO::Services::DesignateSink: OS::Heat::None"},{"line_number":71,"context_line":"  OS::TripleO::Services::DesignateWorker: OS::Heat::None"},{"line_number":72,"context_line":"  OS::TripleO::Services::DesignateBind: OS::Heat::None"},{"line_number":73,"context_line":"  OS::TripleO::Services::GnocchiApi: OS::Heat::None"},{"line_number":74,"context_line":"  OS::TripleO::Services::GnocchiMetricd: OS::Heat::None"},{"line_number":75,"context_line":"  OS::TripleO::Services::GnocchiStatsd: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a7738b3b_b0f69454","side":"PARENT","line":72,"updated":"2021-06-16 11:25:55.000000000","message":"Same here..","commit_id":"5fade4ae003a80200f5d5c6ea52e15112f3a38c3"}],"environments/standalone/standalone-tripleo.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"b4be13cb0156919571221f44c009e483de243ae2","unresolved":true,"context_lines":[{"line_number":77,"context_line":"  OS::TripleO::Services::DesignateProducer: OS::Heat::None"},{"line_number":78,"context_line":"  OS::TripleO::Services::DesignateSink: OS::Heat::None"},{"line_number":79,"context_line":"  OS::TripleO::Services::DesignateWorker: OS::Heat::None"},{"line_number":80,"context_line":"  OS::TripleO::Services::DesignateBind: OS::Heat::None"},{"line_number":81,"context_line":"  OS::TripleO::Services::Docker: OS::Heat::None"},{"line_number":82,"context_line":"  OS::TripleO::Services::DockerRegistry: ../../deployment/image-serve/image-serve-baremetal-ansible.yaml"},{"line_number":83,"context_line":"  OS::TripleO::Services::GnocchiApi: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f02f38e_296618ac","side":"PARENT","line":80,"updated":"2021-06-16 11:25:55.000000000","message":"same here","commit_id":"5fade4ae003a80200f5d5c6ea52e15112f3a38c3"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"b4be13cb0156919571221f44c009e483de243ae2","unresolved":true,"context_lines":[{"line_number":87,"context_line":"  OS::TripleO::Services::HeatApiCfn: OS::Heat::None"},{"line_number":88,"context_line":"  OS::TripleO::Services::HeatApiCloudwatch: OS::Heat::None"},{"line_number":89,"context_line":"  OS::TripleO::Services::HeatEngine: OS::Heat::None"},{"line_number":90,"context_line":"  OS::TripleO::Services::HeatEphemeral: ../../deployment/heat/heat-ephemeral-noop.yaml"},{"line_number":91,"context_line":"  OS::TripleO::Services::IpaClient: OS::Heat::None"},{"line_number":92,"context_line":"  OS::TripleO::Services::IronicApi: OS::Heat::None"},{"line_number":93,"context_line":"  OS::TripleO::Services::IronicConductor: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"25c765ee_6caaa8f8","line":90,"updated":"2021-06-16 11:25:55.000000000","message":"that one is important though 😉","commit_id":"486d340200893883000bf8b4bfa91aa891350b7b"}],"environments/undercloud.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7e3905ee8976a20cdc5c94cb4cd1f997e58624f3","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  OS::TripleO::Services::OpenStackClients: ../deployment/clients/openstack-clients-baremetal-ansible.yaml"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  OS::TripleO::Services::HeatEphemeral: ../deployment/heat/heat-ephemeral-container-ansible.yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  # services we disable by default on the undercloud"},{"line_number":22,"context_line":"  OS::TripleO::Services::AodhApi: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"132572dc_7373d0af","line":19,"range":{"start_line":19,"start_character":25,"end_line":19,"end_character":38},"updated":"2021-06-22 10:29:31.000000000","message":"names ;)\n\nmy main concern is this may be confusing... in my mind it is more like \"EphemeralHeatContainers\" service or somesuch... it isn\u0027t really about enabling or using the ephemeral heat feature but specifically for fixing the bug https://bugs.launchpad.net/tripleo/+bug/1931995 and allowing the user to pass through the ceph containers they want to use","commit_id":"4bceecbde22f7754a2d4b8580a43ff2b45728c25"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3c3cc39671f18210b6caa743255e02f23d83564a","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  OS::TripleO::Services::OpenStackClients: ../deployment/clients/openstack-clients-baremetal-ansible.yaml"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  OS::TripleO::Services::HeatEphemeral: ../deployment/heat/heat-ephemeral-container-ansible.yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  # services we disable by default on the undercloud"},{"line_number":22,"context_line":"  OS::TripleO::Services::AodhApi: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"663a404d_41b2ad21","line":19,"range":{"start_line":19,"start_character":25,"end_line":19,"end_character":38},"in_reply_to":"132572dc_7373d0af","updated":"2021-06-22 11:01:17.000000000","message":"yea, but then the env name would be heat-ephemeral-containers-container-ansible.yaml :)","commit_id":"4bceecbde22f7754a2d4b8580a43ff2b45728c25"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7a852821ff09c50138d7a6dd6f4d8d2b4e4b1735","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  OS::TripleO::Services::OpenStackClients: ../deployment/clients/openstack-clients-baremetal-ansible.yaml"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  OS::TripleO::Services::HeatEphemeral: ../deployment/heat/heat-ephemeral-container-ansible.yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  # services we disable by default on the undercloud"},{"line_number":22,"context_line":"  OS::TripleO::Services::AodhApi: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"27a99cd3_f6833f6d","line":19,"range":{"start_line":19,"start_character":25,"end_line":19,"end_character":38},"in_reply_to":"51984621_0cd19804","updated":"2021-06-23 06:44:14.000000000","message":"ack thanks for making the change but seems I was overruled :) I understand Alex point too, though it is speculative, i.e. we may add more config here besides the containers but we also may not. As it stands *today* the service is dealing specifically with heat-api/engine/all containers only.\n\nAnyway thanks for taking the time to update it my intention was obviously not to delay but to make the service name clearer.","commit_id":"4bceecbde22f7754a2d4b8580a43ff2b45728c25"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"97bb6bf861ef7ba4ffe48db425c0ff4c01c26cf3","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  OS::TripleO::Services::OpenStackClients: ../deployment/clients/openstack-clients-baremetal-ansible.yaml"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  OS::TripleO::Services::HeatEphemeral: ../deployment/heat/heat-ephemeral-container-ansible.yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  # services we disable by default on the undercloud"},{"line_number":22,"context_line":"  OS::TripleO::Services::AodhApi: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"51984621_0cd19804","line":19,"range":{"start_line":19,"start_character":25,"end_line":19,"end_character":38},"in_reply_to":"663a404d_41b2ad21","updated":"2021-06-22 11:32:27.000000000","message":"Done","commit_id":"4bceecbde22f7754a2d4b8580a43ff2b45728c25"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8c403d30b1f68cf4f1f904d21441729b4a1efc9f","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  OS::TripleO::Services::OpenStackClients: ../deployment/clients/openstack-clients-baremetal-ansible.yaml"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  OS::TripleO::Services::HeatEphemeralImages: ../deployment/heat/heat-ephemeral-images-container-ansible.yam"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  # services we disable by default on the undercloud"},{"line_number":22,"context_line":"  OS::TripleO::Services::AodhApi: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ffd16340_79675a06","line":19,"range":{"start_line":19,"start_character":105,"end_line":19,"end_character":108},"updated":"2021-06-22 14:26:42.000000000","message":"the l got lost","commit_id":"1807833e802abe6d9e547eea8db33dabd4994828"}],"environments/undercloud/undercloud-minion.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"b4be13cb0156919571221f44c009e483de243ae2","unresolved":true,"context_lines":[{"line_number":153,"context_line":"  OS::TripleO::Services::DesignateProducer: OS::Heat::None"},{"line_number":154,"context_line":"  OS::TripleO::Services::DesignateSink: OS::Heat::None"},{"line_number":155,"context_line":"  OS::TripleO::Services::DesignateWorker: OS::Heat::None"},{"line_number":156,"context_line":"  OS::TripleO::Services::DesignateBind: OS::Heat::None"},{"line_number":157,"context_line":"  OS::TripleO::Services::Docker: OS::Heat::None"},{"line_number":158,"context_line":"  OS::TripleO::Services::DockerRegistry: OS::Heat::None"},{"line_number":159,"context_line":"  OS::TripleO::Services::Etcd: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"452d406c_a93604cd","side":"PARENT","line":156,"updated":"2021-06-16 11:25:55.000000000","message":"bleh... Maybe we should get a dedicated change for this DesignateBind ordering?","commit_id":"5fade4ae003a80200f5d5c6ea52e15112f3a38c3"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2dcce8db9077a2e98733be452d25693f031138ce","unresolved":true,"context_lines":[{"line_number":153,"context_line":"  OS::TripleO::Services::DesignateProducer: OS::Heat::None"},{"line_number":154,"context_line":"  OS::TripleO::Services::DesignateSink: OS::Heat::None"},{"line_number":155,"context_line":"  OS::TripleO::Services::DesignateWorker: OS::Heat::None"},{"line_number":156,"context_line":"  OS::TripleO::Services::DesignateBind: OS::Heat::None"},{"line_number":157,"context_line":"  OS::TripleO::Services::Docker: OS::Heat::None"},{"line_number":158,"context_line":"  OS::TripleO::Services::DockerRegistry: OS::Heat::None"},{"line_number":159,"context_line":"  OS::TripleO::Services::Etcd: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"daf2eb61_377dae98","side":"PARENT","line":156,"in_reply_to":"452d406c_a93604cd","updated":"2021-06-17 12:46:29.000000000","message":"maybe? I just run the sample generator and included its results into the commit..","commit_id":"5fade4ae003a80200f5d5c6ea52e15112f3a38c3"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"61283e0e886e762334532cde17c049d05c1e29cb","unresolved":true,"context_lines":[{"line_number":169,"context_line":"  OS::TripleO::Services::HeatApiCfn: OS::Heat::None"},{"line_number":170,"context_line":"  OS::TripleO::Services::HeatApiCloudwatch: OS::Heat::None"},{"line_number":171,"context_line":"  OS::TripleO::Services::HeatEngine: OS::Heat::None"},{"line_number":172,"context_line":"  OS::TripleO::Services::HeatEphemeral: ../../deployment/heat/heat-ephemeral-noop.yaml"},{"line_number":173,"context_line":"  OS::TripleO::Services::Horizon: OS::Heat::None"},{"line_number":174,"context_line":"  OS::TripleO::Services::IpaClient: OS::Heat::None"},{"line_number":175,"context_line":"  OS::TripleO::Services::Ipsec: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b1a02c5a_d16e2f1d","line":172,"updated":"2021-06-21 14:40:02.000000000","message":"we don\u0027t need to add this here as minion is deprecated and won\u0027t need ephemeral","commit_id":"1a095ceed21d4f5a5fb7006130e69cd51cd16c37"}],"roles/UndercloudMinion.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"61283e0e886e762334532cde17c049d05c1e29cb","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    - OS::TripleO::Services::ContainerImagePrepare"},{"line_number":16,"context_line":"    - OS::TripleO::Services::ContainersLogrotateCrond"},{"line_number":17,"context_line":"    - OS::TripleO::Services::HeatEngine"},{"line_number":18,"context_line":"    - OS::TripleO::Services::HeatEphemeral"},{"line_number":19,"context_line":"    - OS::TripleO::Services::IronicConductor"},{"line_number":20,"context_line":"    - OS::TripleO::Services::Kernel"},{"line_number":21,"context_line":"    - OS::TripleO::Services::MySQLClient"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"74abb64d_534152e6","line":18,"updated":"2021-06-21 14:40:02.000000000","message":"dont\u0027 need this","commit_id":"1a095ceed21d4f5a5fb7006130e69cd51cd16c37"}],"sample-env-generator/standalone.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"61283e0e886e762334532cde17c049d05c1e29cb","unresolved":true,"context_lines":[{"line_number":73,"context_line":"      OS::TripleO::Services::Tmpwatch: ../../deployment/logrotate/tmpwatch-install.yaml"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"      # Ephemeral Heat"},{"line_number":76,"context_line":"      OS::TripleO::Services::HeatEphemeral: ../../deployment/heat/heat-ephemeral-noop.yaml"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"      # Aodh"},{"line_number":79,"context_line":"      OS::TripleO::Services::AodhApi: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"99f4ddd5_dfb498b9","line":76,"updated":"2021-06-21 14:40:02.000000000","message":"don\u0027t need this as we\u0027re not switching standalone/undercloud to ephemeral at this time (slagle can confirm)","commit_id":"1a095ceed21d4f5a5fb7006130e69cd51cd16c37"}],"sample-env-generator/undercloud-minion.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bc952d83f370edfbfddffc8dc853473005ab13af","unresolved":true,"context_lines":[{"line_number":86,"context_line":"      # Install tmpwatch"},{"line_number":87,"context_line":"      OS::TripleO::Services::Tmpwatch: ../../deployment/logrotate/tmpwatch-install.yaml"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"      # Ephemeral Heat"},{"line_number":90,"context_line":"      OS::TripleO::Services::HeatEphemeral: ../../deployment/heat/heat-ephemeral-noop.yaml"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"      # TODO(aschultz): this probably needs an alternative solution"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b0247b91_90206c5d","line":89,"updated":"2021-06-16 09:46:27.000000000","message":"not sure if we want it for UC minions as well?","commit_id":"486d340200893883000bf8b4bfa91aa891350b7b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"61283e0e886e762334532cde17c049d05c1e29cb","unresolved":true,"context_lines":[{"line_number":87,"context_line":"      OS::TripleO::Services::Tmpwatch: ../../deployment/logrotate/tmpwatch-install.yaml"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"      # Ephemeral Heat"},{"line_number":90,"context_line":"      OS::TripleO::Services::HeatEphemeral: ../../deployment/heat/heat-ephemeral-noop.yaml"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"      # TODO(aschultz): this probably needs an alternative solution"},{"line_number":93,"context_line":"      # Need to provide the oslo messaging hieradata"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a053faaf_d5a2dd28","line":90,"updated":"2021-06-21 14:40:02.000000000","message":"don\u0027t need this","commit_id":"1a095ceed21d4f5a5fb7006130e69cd51cd16c37"}]}