)]}'
{"ci/environments/scenario001-standalone.yaml":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"9e25283018b38338134cbc46980c12d24d82880f","unresolved":true,"context_lines":[{"line_number":194,"context_line":"  MultipathdEnable: true"},{"line_number":195,"context_line":"  NovaLibvirtVolumeUseMultipath: true"},{"line_number":196,"context_line":"  BackupAndRestoreSkipNFSTest: true"},{"line_number":197,"context_line":"  # The following container is used to test this patch"},{"line_number":198,"context_line":"  ContainerCephDaemonImage: quay.ceph.io/ceph-ci/daemon:latest-pacific-devel"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"89dad8a0_f6390586","line":197,"updated":"2021-06-22 10:59:06.000000000","message":"a temporary change to show the scenario001 (w/ all the nested patches) working.","commit_id":"07f367abadc11ff188596d259e43c85380c74da9"}],"deployment/cephadm/ceph-base.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"aac608c4ed5b4ed935eb4271e3b344c1b333fc3f","unresolved":true,"context_lines":[{"line_number":452,"context_line":"      value:"},{"line_number":453,"context_line":"        vars:"},{"line_number":454,"context_line":"          tripleo_cephadm_fsid: {get_param: CephClusterFSID}"},{"line_number":455,"context_line":"          tripleo_cephadm_cluster: {get_param: CephClusterName}"},{"line_number":456,"context_line":"          tripleo_cephadm_container_cli: {get_param: ContainerCli}"},{"line_number":457,"context_line":"          tripleo_ceph_client_vars: {get_param: CephClientConfigVars}"},{"line_number":458,"context_line":"          tripleo_cephadm_dashboard_enabled: {get_param: CephEnableDashboard}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cbc6b308_1d18a5d5","side":"PARENT","line":455,"updated":"2021-06-21 20:31:06.000000000","message":"I originally thought of removing these two lines also (in the depends on patch), but I like ensuring my admin key and conf exist so that subsequent CLI calls done by ansible can use them.  By removing the passing of this parameter I ensure that these files will always use the \"ceph\" name (e.g. ceph.conf). Let\u0027s see the results of the test.\n\nhttps://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_cephadm/tasks/bootstrap.yaml#L57-L58","commit_id":"14aa81dd73919630b8d149d75755a5af21bb1300"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"7f07ad9d7e5cf621482ff4f1df34760e3686d85c","unresolved":false,"context_lines":[{"line_number":452,"context_line":"      value:"},{"line_number":453,"context_line":"        vars:"},{"line_number":454,"context_line":"          tripleo_cephadm_fsid: {get_param: CephClusterFSID}"},{"line_number":455,"context_line":"          tripleo_cephadm_cluster: {get_param: CephClusterName}"},{"line_number":456,"context_line":"          tripleo_cephadm_container_cli: {get_param: ContainerCli}"},{"line_number":457,"context_line":"          tripleo_ceph_client_vars: {get_param: CephClientConfigVars}"},{"line_number":458,"context_line":"          tripleo_cephadm_dashboard_enabled: {get_param: CephEnableDashboard}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0b538f66_44b0d50b","side":"PARENT","line":455,"in_reply_to":"cbc6b308_1d18a5d5","updated":"2021-06-22 05:37:34.000000000","message":"Ack","commit_id":"14aa81dd73919630b8d149d75755a5af21bb1300"}],"deployment/cephadm/ceph-client.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"48b19a321c1edbe81d983e48cb0cd6e48912037a","unresolved":true,"context_lines":[{"line_number":122,"context_line":"                vars:"},{"line_number":123,"context_line":"                  tripleo_ceph_client_config_home: {get_param: CephConfigPath}"},{"line_number":124,"context_line":"                  tripleo_ceph_client_vars: {get_param: CephClientConfigVars}"},{"line_number":125,"context_line":"                  tripleo_ceph_client_cluster: {get_param: CephClusterName}"},{"line_number":126,"context_line":"              - include_role:"},{"line_number":127,"context_line":"                  name: tripleo_ceph_client"},{"line_number":128,"context_line":"                name: tripleo client role"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4d1a864e_2b9e237a","line":125,"range":{"start_line":125,"start_character":18,"end_line":125,"end_character":75},"updated":"2021-06-21 20:10:56.000000000","message":"It was a bug that this wasn\u0027t here to begin with.","commit_id":"87e011e42f85837331837960300bd06d34101428"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"7f07ad9d7e5cf621482ff4f1df34760e3686d85c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                vars:"},{"line_number":123,"context_line":"                  tripleo_ceph_client_config_home: {get_param: CephConfigPath}"},{"line_number":124,"context_line":"                  tripleo_ceph_client_vars: {get_param: CephClientConfigVars}"},{"line_number":125,"context_line":"                  tripleo_ceph_client_cluster: {get_param: CephClusterName}"},{"line_number":126,"context_line":"              - include_role:"},{"line_number":127,"context_line":"                  name: tripleo_ceph_client"},{"line_number":128,"context_line":"                name: tripleo client role"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"01bbd7d7_6099bf8d","line":125,"range":{"start_line":125,"start_character":18,"end_line":125,"end_character":45},"updated":"2021-06-22 05:37:34.000000000","message":"Ack, by doing this we can make sure the client still rely on the specified cluster name","commit_id":"1bbdd2822dfcdb11b9cd5c5d7f38604a7c869b8c"}],"releasenotes/notes/ceph_conf_name_override_deprecated-ea26da760b748318.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"48b19a321c1edbe81d983e48cb0cd6e48912037a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The default path for Ceph client configuration files on the container host has"},{"line_number":5,"context_line":"    changed in Wallaby from /etc/ceph/ to the path defined by CephConfigPath, which"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6f60bf4d_fff2e937","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"updated":"2021-06-21 20:10:56.000000000","message":"This upgrade issue needs to be addressed regardless of if this patch merges because of https://github.com/openstack/tripleo-ansible/commit/935963994086560fee021d283f6e4f7e2646522e","commit_id":"87e011e42f85837331837960300bd06d34101428"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"b3bdb891c13a42751401ee8d91846cc73918f8d8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The default path for Ceph client configuration files on the container host has"},{"line_number":5,"context_line":"    changed in Wallaby from /etc/ceph/ to the path defined by CephConfigPath, which"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e7e75dac_22165b73","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"updated":"2021-06-22 10:59:24.000000000","message":"We also need to explain how the change in /etc/ceph/ will be handled. E.g. \n\n1. Pre-Wallaby upgrade\n/etc/ceph/foo.conf\n\n2. Post-Wallaby upgrade\n/etc/ceph/ceph.conf\n/var/lib/tripleo-config/ceph/foo.conf\n\nWhere both of the above files contain the same content.","commit_id":"07f367abadc11ff188596d259e43c85380c74da9"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"8d5ee9a56732f9a8be5572a9eb5dc4f1269b18d4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The default path for Ceph client configuration files on the container host has"},{"line_number":5,"context_line":"    changed in Wallaby from /etc/ceph/ to the path defined by CephConfigPath, which"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"4377212f_2a47db5a","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"in_reply_to":"e7e75dac_22165b73","updated":"2021-06-22 17:16:00.000000000","message":"During upgrade and adoption the same name is kept:\nhttps://github.com/ceph/ceph-ansible/blob/master/infrastructure-playbooks/cephadm-adopt.yml#L1033","commit_id":"07f367abadc11ff188596d259e43c85380c74da9"}]}