)]}'
{"deployment/heat/heat-ephemeral-container-ansible.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ac2c1dbd492b72d1c70ea8a9cb80ee71633b86e8","unresolved":true,"context_lines":[{"line_number":86,"context_line":"                dest: /var/lib/tripleo-config/scripts/undercloud-upgrade-ephemeral-heat.py"},{"line_number":87,"context_line":"                content: {get_file: ../../scripts/undercloud-upgrade-ephemeral-heat.py}"},{"line_number":88,"context_line":"                mode: 0755"},{"line_number":89,"context_line":"            - name: Check if heat engine is still running"},{"line_number":90,"context_line":"              shell: systemctl is-active tripleo_heat_engine.service || systemctl is-enabled tripleo_heat_engine.service"},{"line_number":91,"context_line":"              failed_when: false"},{"line_number":92,"context_line":"              become: true"},{"line_number":93,"context_line":"              register: heat_engine_enabled"},{"line_number":94,"context_line":"            - name: Run undercloud-upgrade-ephemeral-heat.py"},{"line_number":95,"context_line":"              shell: /var/lib/tripleo-config/scripts/undercloud-upgrade-ephemeral-heat.py"},{"line_number":96,"context_line":"              register: upgrade_ephemeral_result"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"95b2940c_41759362","line":93,"range":{"start_line":89,"start_character":0,"end_line":93,"end_character":4},"updated":"2021-06-23 07:05:50.000000000","message":"this is new compared to the earlier tasks\n\nit makes sense that we only run the migrate tasks if there is still a heat service running. It currently relies on something in the script itself there https://opendev.org/openstack/tripleo-heat-templates/src/commit/90dfcc837e160201134e06f96f5dd67a15cc59c2/scripts/undercloud-upgrade-ephemeral-heat.py#L213-L216 but it is cleaner this way . \n\nIn light of this change we should consider updating that script to actually throw an error instead of just returning since the expectation now is it is only running when we have heat service.","commit_id":"2510d5467b730e8bb1bcffdd2611a4b50d23e511"}]}