)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f1390ec3aa1952c10d2f114b07084283a099eecb","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The ComputeVdpa role is basically a copy of ComputeSriov with the"},{"line_number":13,"context_line":"addition of the ExtraKernelModules. Beside these modules, operators"},{"line_number":14,"context_line":"should be able to their ``NovaPCIPassthrough`` as they"},{"line_number":15,"context_line":"normally do for standard SR-IOV as a role parameter. The ``device_type``"},{"line_number":16,"context_line":"attribute should be set to ``vdpa`` instead of ``type-PF`` or"},{"line_number":17,"context_line":"``type-VF``."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"613eb8b4_494927ab","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":17},"updated":"2021-06-23 01:30:15.000000000","message":"define or update","commit_id":"66c184a8d24dcb0284fdd00998e7a5507d4c61a3"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"2496bfe757a83b32fc048317b662986fd5c4a032","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The ComputeVdpa role is basically a copy of ComputeSriov with the"},{"line_number":13,"context_line":"addition of the ExtraKernelModules. Beside these modules, operators"},{"line_number":14,"context_line":"should be able to their ``NovaPCIPassthrough`` as they"},{"line_number":15,"context_line":"normally do for standard SR-IOV as a role parameter. The ``device_type``"},{"line_number":16,"context_line":"attribute should be set to ``vdpa`` instead of ``type-PF`` or"},{"line_number":17,"context_line":"``type-VF``."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"db8c126c_ee8bdbee","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":17},"in_reply_to":"613eb8b4_494927ab","updated":"2021-06-23 17:00:45.000000000","message":"Done","commit_id":"66c184a8d24dcb0284fdd00998e7a5507d4c61a3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f1390ec3aa1952c10d2f114b07084283a099eecb","unresolved":true,"context_lines":[{"line_number":12,"context_line":"The ComputeVdpa role is basically a copy of ComputeSriov with the"},{"line_number":13,"context_line":"addition of the ExtraKernelModules. Beside these modules, operators"},{"line_number":14,"context_line":"should be able to their ``NovaPCIPassthrough`` as they"},{"line_number":15,"context_line":"normally do for standard SR-IOV as a role parameter. The ``device_type``"},{"line_number":16,"context_line":"attribute should be set to ``vdpa`` instead of ``type-PF`` or"},{"line_number":17,"context_line":"``type-VF``."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"When having the right modules loaded, at least in RHEL8.5, the kernel"},{"line_number":20,"context_line":"will automatically create /dev/vhost-vdpa-X devices for each one of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1936b9b4_972f1443","line":17,"range":{"start_line":15,"start_character":52,"end_line":17,"end_character":12},"updated":"2021-06-23 01:30:15.000000000","message":"you shoudl not be seeing the device type in NovaPCIPassthrough its not a vlaid value in the pci whitelist\nand vdpa devices cannot be used with pci aliases as we intentionally block this.\nso tyou can jsut remove this line.","commit_id":"66c184a8d24dcb0284fdd00998e7a5507d4c61a3"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"2496bfe757a83b32fc048317b662986fd5c4a032","unresolved":false,"context_lines":[{"line_number":12,"context_line":"The ComputeVdpa role is basically a copy of ComputeSriov with the"},{"line_number":13,"context_line":"addition of the ExtraKernelModules. Beside these modules, operators"},{"line_number":14,"context_line":"should be able to their ``NovaPCIPassthrough`` as they"},{"line_number":15,"context_line":"normally do for standard SR-IOV as a role parameter. The ``device_type``"},{"line_number":16,"context_line":"attribute should be set to ``vdpa`` instead of ``type-PF`` or"},{"line_number":17,"context_line":"``type-VF``."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"When having the right modules loaded, at least in RHEL8.5, the kernel"},{"line_number":20,"context_line":"will automatically create /dev/vhost-vdpa-X devices for each one of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0847b976_7f06b7e9","line":17,"range":{"start_line":15,"start_character":52,"end_line":17,"end_character":12},"in_reply_to":"1936b9b4_972f1443","updated":"2021-06-23 17:00:45.000000000","message":"Done","commit_id":"66c184a8d24dcb0284fdd00998e7a5507d4c61a3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f1390ec3aa1952c10d2f114b07084283a099eecb","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"When having the right modules loaded, at least in RHEL8.5, the kernel"},{"line_number":20,"context_line":"will automatically create /dev/vhost-vdpa-X devices for each one of the"},{"line_number":21,"context_line":"VFs."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[1] https://opendev.org/openstack/nova-specs/src/branch/master/specs/wallaby/implemented/libvirt-vdpa-support.rst"},{"line_number":24,"context_line":"[2] https://bugzilla.redhat.com/1873409"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6ad40898_f94448ec","line":21,"updated":"2021-06-23 01:30:15.000000000","message":"ack ok cool so this was backported to 8.5 not in 8.4\n\ni was expect you to need to use rhel/ceontos 9\n\nthe kernel moduels is included in kerenl-core for centos 9 stream so it shoudl be avaibale by default\nthere.","commit_id":"66c184a8d24dcb0284fdd00998e7a5507d4c61a3"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"2496bfe757a83b32fc048317b662986fd5c4a032","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"When having the right modules loaded, at least in RHEL8.5, the kernel"},{"line_number":20,"context_line":"will automatically create /dev/vhost-vdpa-X devices for each one of the"},{"line_number":21,"context_line":"VFs."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[1] https://opendev.org/openstack/nova-specs/src/branch/master/specs/wallaby/implemented/libvirt-vdpa-support.rst"},{"line_number":24,"context_line":"[2] https://bugzilla.redhat.com/1873409"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1cbf1b1a_c7dbba05","line":21,"in_reply_to":"6ad40898_f94448ec","updated":"2021-06-23 17:00:45.000000000","message":"Ack","commit_id":"66c184a8d24dcb0284fdd00998e7a5507d4c61a3"}],"roles/ComputeVdpa.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f1390ec3aa1952c10d2f114b07084283a099eecb","unresolved":true,"context_lines":[{"line_number":19,"context_line":"    ExtraKernelModules:"},{"line_number":20,"context_line":"      vdpa: {}"},{"line_number":21,"context_line":"      vhost_vdpa: {}"},{"line_number":22,"context_line":"      mlx5_vdpa: {}"},{"line_number":23,"context_line":"  update_serial: 25"},{"line_number":24,"context_line":"  ServicesDefault:"},{"line_number":25,"context_line":"    - OS::TripleO::Services::Aide"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d0a49939_3693da0b","line":22,"updated":"2021-06-23 01:30:15.000000000","message":"jsut a note that currenlty the only vdpa nics in the market are from melonox/nvidia but there is an intel vdpa dirver upstream as well\nso whenever they get around to release a nic that works with it we might want to add that to the list or make it configurable.\n\n\nwith current kernel i think this is all that is required but \nthey have plans to not auto bind the vdpa devies to vhost_vdpa at some point so this role will likely need to be extended whenever that happens\nto install a systemd servicei file, udev rule or similar script that invokes the cli to do the vdpa bindings.\n\nthat can be done at a later date if/when that change ever happens.","commit_id":"66c184a8d24dcb0284fdd00998e7a5507d4c61a3"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"2496bfe757a83b32fc048317b662986fd5c4a032","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    ExtraKernelModules:"},{"line_number":20,"context_line":"      vdpa: {}"},{"line_number":21,"context_line":"      vhost_vdpa: {}"},{"line_number":22,"context_line":"      mlx5_vdpa: {}"},{"line_number":23,"context_line":"  update_serial: 25"},{"line_number":24,"context_line":"  ServicesDefault:"},{"line_number":25,"context_line":"    - OS::TripleO::Services::Aide"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f8c433f8_9427ab27","line":22,"in_reply_to":"d0a49939_3693da0b","updated":"2021-06-23 17:00:45.000000000","message":"Ack","commit_id":"66c184a8d24dcb0284fdd00998e7a5507d4c61a3"}]}