)]}'
{"deployment/cephadm/ceph-base.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"8b190a93b67a27ad72f14310574a321ffb03cc0d","unresolved":true,"context_lines":[{"line_number":595,"context_line":"                   groups[\u0027ceph_nfs\u0027] | default([]) | length \u003e 0)"},{"line_number":596,"context_line":"                - not deployed_ceph"},{"line_number":597,"context_line":"              vars:"},{"line_number":598,"context_line":"                deployed_ceph: {get_param: DeployedCeph}"},{"line_number":599,"context_line":"            - name: Deploy or configure the cephadm Ceph cluster"},{"line_number":600,"context_line":"              include_role:"},{"line_number":601,"context_line":"                name: tripleo_run_cephadm"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"04ccbad6_468967af","line":598,"range":{"start_line":598,"start_character":16,"end_line":598,"end_character":56},"updated":"2021-06-29 19:55:22.000000000","message":"Because the ceph-admin user is only created for mons,mgrs,osds for deployed_ceph I should still run this for the other groups during non-deployed ceph.\n\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/797538/8/tripleo_ansible/playbooks/cli-deployed-ceph.yaml#79","commit_id":"ae94042c27da043f41a92c7b5febff480956c3ac"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"973172c12d54c27d390ac19d6da05c18420dcdab","unresolved":false,"context_lines":[{"line_number":595,"context_line":"                   groups[\u0027ceph_nfs\u0027] | default([]) | length \u003e 0)"},{"line_number":596,"context_line":"                - not deployed_ceph"},{"line_number":597,"context_line":"              vars:"},{"line_number":598,"context_line":"                deployed_ceph: {get_param: DeployedCeph}"},{"line_number":599,"context_line":"            - name: Deploy or configure the cephadm Ceph cluster"},{"line_number":600,"context_line":"              include_role:"},{"line_number":601,"context_line":"                name: tripleo_run_cephadm"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f75aeb3_5288c526","line":598,"range":{"start_line":598,"start_character":16,"end_line":598,"end_character":56},"in_reply_to":"04ccbad6_468967af","updated":"2021-07-06 21:36:45.000000000","message":"This should now be addressed by the change in patch set 6\n\nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/797539/4..6/deployment/cephadm/ceph-base.yaml","commit_id":"ae94042c27da043f41a92c7b5febff480956c3ac"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"f6578276ea0d694f89110735e024bc904adda6f2","unresolved":true,"context_lines":[{"line_number":595,"context_line":"                       groups[\u0027ceph_nfs\u0027] | default([]) | length \u003e 0))"},{"line_number":596,"context_line":"                    or"},{"line_number":597,"context_line":"                    (deployed_ceph and"},{"line_number":598,"context_line":"                      ((groups[\u0027ceph_rgw\u0027] | default([]) !\u003d"},{"line_number":599,"context_line":"                        groups[\u0027ceph_mon\u0027] | default([]) and"},{"line_number":600,"context_line":"                        groups[\u0027ceph_rgw\u0027] | default([]) | length \u003e 0)"},{"line_number":601,"context_line":"                       or"},{"line_number":602,"context_line":"                       (groups[\u0027ceph_mds\u0027] | default([]) !\u003d"},{"line_number":603,"context_line":"                        groups[\u0027ceph_mon\u0027] | default([]) and"},{"line_number":604,"context_line":"                        groups[\u0027ceph_mds\u0027] | default([]) | length \u003e 0)"},{"line_number":605,"context_line":"                       or"},{"line_number":606,"context_line":"                       (groups[\u0027ceph_nfs\u0027] | default([]) !\u003d"},{"line_number":607,"context_line":"                        groups[\u0027ceph_mon\u0027] | default([]) and"},{"line_number":608,"context_line":"                        groups[\u0027ceph_nfs\u0027] | default([]) | length \u003e 0)"},{"line_number":609,"context_line":"                       or"},{"line_number":610,"context_line":"                       (groups[\u0027ceph_rbdmirror\u0027] | default([]) !\u003d"},{"line_number":611,"context_line":"                        groups[\u0027ceph_mon\u0027] | default([]) and"},{"line_number":612,"context_line":"                        groups[\u0027ceph_rbdmirror\u0027] | default([]) | length \u003e 0)))"},{"line_number":613,"context_line":"              vars:"},{"line_number":614,"context_line":"                deployed_ceph: {get_param: DeployedCeph}"},{"line_number":615,"context_line":"            - name: Deploy or configure the cephadm Ceph cluster"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6a19ba33_ddfa3a81","line":612,"range":{"start_line":598,"start_character":0,"end_line":612,"end_character":78},"updated":"2021-07-06 21:35:10.000000000","message":"If you used deployed_ceph, then at this stage of the deployment enable_ceph_admin_user.yml has already run and created the ceph-admin user on all nodes in the groups ceph_mon, ceph_mgr, and ceph_osd. Thus, we don\u0027t want to re-run enable_ceph_admin_user.yml unless we\u0027re now going to configure the rgw, mds, nfs, or rbdmirror service AND those services are not collocated with the monitor. Only in that case should we re-run it and it will run on the additional nodes in that group. In that case, enable_ceph_admin_user.yml will be run again on all ceph related groups in the overcloud but it is idempotent.","commit_id":"2f6b81a3ce9cd516a44e4c01e7bce316afec5cab"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"72af623009a2ad13a1a95be3d64464ab59480d9d","unresolved":true,"context_lines":[{"line_number":595,"context_line":"                       groups[\u0027ceph_nfs\u0027] | default([]) | length \u003e 0))"},{"line_number":596,"context_line":"                    or"},{"line_number":597,"context_line":"                    (deployed_ceph and"},{"line_number":598,"context_line":"                      ((groups[\u0027ceph_rgw\u0027] | default([]) !\u003d"},{"line_number":599,"context_line":"                        groups[\u0027ceph_mon\u0027] | default([]) and"},{"line_number":600,"context_line":"                        groups[\u0027ceph_rgw\u0027] | default([]) | length \u003e 0)"},{"line_number":601,"context_line":"                       or"},{"line_number":602,"context_line":"                       (groups[\u0027ceph_mds\u0027] | default([]) !\u003d"},{"line_number":603,"context_line":"                        groups[\u0027ceph_mon\u0027] | default([]) and"},{"line_number":604,"context_line":"                        groups[\u0027ceph_mds\u0027] | default([]) | length \u003e 0)"},{"line_number":605,"context_line":"                       or"},{"line_number":606,"context_line":"                       (groups[\u0027ceph_nfs\u0027] | default([]) !\u003d"},{"line_number":607,"context_line":"                        groups[\u0027ceph_mon\u0027] | default([]) and"},{"line_number":608,"context_line":"                        groups[\u0027ceph_nfs\u0027] | default([]) | length \u003e 0)"},{"line_number":609,"context_line":"                       or"},{"line_number":610,"context_line":"                       (groups[\u0027ceph_rbdmirror\u0027] | default([]) !\u003d"},{"line_number":611,"context_line":"                        groups[\u0027ceph_mon\u0027] | default([]) and"},{"line_number":612,"context_line":"                        groups[\u0027ceph_rbdmirror\u0027] | default([]) | length \u003e 0)))"},{"line_number":613,"context_line":"              vars:"},{"line_number":614,"context_line":"                deployed_ceph: {get_param: DeployedCeph}"},{"line_number":615,"context_line":"            - name: Deploy or configure the cephadm Ceph cluster"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"0dc4cd98_a66e5199","line":612,"range":{"start_line":598,"start_character":0,"end_line":612,"end_character":78},"in_reply_to":"6a19ba33_ddfa3a81","updated":"2021-07-29 14:31:27.000000000","message":"I see why you put this condition, which is good in case you need to run this playbook for services on different nodes (not collocated w/ mons || mgrs).","commit_id":"2f6b81a3ce9cd516a44e4c01e7bce316afec5cab"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"fde14ba38985442a1fe5643f83d4ad8f1dd23df9","unresolved":true,"context_lines":[{"line_number":374,"context_line":"      so that the overcloud can use it (create cephx keys, pools, configure RGW"},{"line_number":375,"context_line":"      with haproxy, etc), then this parameter should be set to true. Set this"},{"line_number":376,"context_line":"      parameter to false to have cephadm deploy the ceph cluster during overcloud"},{"line_number":377,"context_line":"      deployment. DeployedCeph and CephDynamicSpec are mutually exclusive."},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"parameter_groups:"},{"line_number":380,"context_line":"- label: deprecated"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"fceafa57_3eb55318","line":377,"range":{"start_line":377,"start_character":18,"end_line":377,"end_character":74},"updated":"2021-08-19 16:08:46.000000000","message":"Adding this comment on the CephDynamicSpec description will help.","commit_id":"feb93b26b42673d1958917603f2498b9456fb34c"}]}