)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"9ad28396c6fe7d98d1a29fa957417df5472cea45","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"nova-vncproxy: removal of tags and steps from post_upgrade_tasks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Post upgrade tasks don\u0027t have any steps or tags apparently, so these"},{"line_number":10,"context_line":"tasks are not executed."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Deleting nova-consoleauth is failing with some of the CIs and this is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"445c769b_09faba36","line":9,"updated":"2021-07-07 07:56:49.000000000","message":"post_upgrade_tasks have steps, max steps\u003d4 https://github.com/openstack/tripleo-heat-templates/blob/master/common/deploy-steps.j2#L16","commit_id":"1956ad932c9513e8a0e7252e3516bbf3f0d18e69"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"bd2ec6537c158faf31bf505dedb616b18034d59a","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"nova-vncproxy: removal of tags and steps from post_upgrade_tasks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Post upgrade tasks don\u0027t have any steps or tags apparently, so these"},{"line_number":10,"context_line":"tasks are not executed."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Deleting nova-consoleauth is failing with some of the CIs and this is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"c4b318ec_88970b0f","line":9,"in_reply_to":"445c769b_09faba36","updated":"2021-07-07 14:41:02.000000000","message":"That\u0027s what I thought as well but there\u0027s no steps really. I tested by removing only the tags initially and it never ran.","commit_id":"1956ad932c9513e8a0e7252e3516bbf3f0d18e69"}],"deployment/nova/nova-vnc-proxy-container-puppet.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"8d180487401814b74a484db5dcbb316328f7f530","unresolved":true,"context_lines":[{"line_number":384,"context_line":"            - step|int \u003d\u003d 3"},{"line_number":385,"context_line":"          environment:"},{"line_number":386,"context_line":"            OS_CLOUD: {get_param: RootStackName}"},{"line_number":387,"context_line":"          become: false"},{"line_number":388,"context_line":"          block:"},{"line_number":389,"context_line":"            - name: Get nova-consoleauth service ID"},{"line_number":390,"context_line":"              shell: |"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a9757dd7_c536a1b5","line":387,"updated":"2021-07-13 06:25:29.000000000","message":"is this required?","commit_id":"b5ce2499bd0d8ad53d14354e3d4a29ce374a8aa1"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"caa9d8a8c328a9566afbd40f8265ea0c06666e23","unresolved":false,"context_lines":[{"line_number":384,"context_line":"            - step|int \u003d\u003d 3"},{"line_number":385,"context_line":"          environment:"},{"line_number":386,"context_line":"            OS_CLOUD: {get_param: RootStackName}"},{"line_number":387,"context_line":"          become: false"},{"line_number":388,"context_line":"          block:"},{"line_number":389,"context_line":"            - name: Get nova-consoleauth service ID"},{"line_number":390,"context_line":"              shell: |"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"325b6f34_9af201f0","line":387,"in_reply_to":"a9757dd7_c536a1b5","updated":"2021-07-13 18:16:36.000000000","message":"I didn\u0027t test without but I don\u0027t think it\u0027s necessary.","commit_id":"b5ce2499bd0d8ad53d14354e3d4a29ce374a8aa1"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"8d180487401814b74a484db5dcbb316328f7f530","unresolved":true,"context_lines":[{"line_number":389,"context_line":"            - name: Get nova-consoleauth service ID"},{"line_number":390,"context_line":"              shell: |"},{"line_number":391,"context_line":"                /usr/bin/openstack compute service list --service nova-consoleauth --column ID  --column Host --format yaml"},{"line_number":392,"context_line":"              register: nova_compute_service_result"},{"line_number":393,"context_line":"              check_mode: false"},{"line_number":394,"context_line":"              run_once: true"},{"line_number":395,"context_line":"              changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b14971e7_616b28f8","line":392,"updated":"2021-07-13 06:25:29.000000000","message":"we want to run this from the undercloud so this should have delegate_to: undercloud","commit_id":"b5ce2499bd0d8ad53d14354e3d4a29ce374a8aa1"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"caa9d8a8c328a9566afbd40f8265ea0c06666e23","unresolved":false,"context_lines":[{"line_number":389,"context_line":"            - name: Get nova-consoleauth service ID"},{"line_number":390,"context_line":"              shell: |"},{"line_number":391,"context_line":"                /usr/bin/openstack compute service list --service nova-consoleauth --column ID  --column Host --format yaml"},{"line_number":392,"context_line":"              register: nova_compute_service_result"},{"line_number":393,"context_line":"              check_mode: false"},{"line_number":394,"context_line":"              run_once: true"},{"line_number":395,"context_line":"              changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"13696bfc_c75a156e","line":392,"in_reply_to":"b14971e7_616b28f8","updated":"2021-07-13 18:16:36.000000000","message":"Done","commit_id":"b5ce2499bd0d8ad53d14354e3d4a29ce374a8aa1"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"8d180487401814b74a484db5dcbb316328f7f530","unresolved":true,"context_lines":[{"line_number":401,"context_line":"                /usr/bin/openstack compute service delete {{ item.ID }}"},{"line_number":402,"context_line":"              loop: \"{{ nova_compute_service_result.stdout | from_yaml }}\""},{"line_number":403,"context_line":"              run_once: true"},{"line_number":404,"context_line":"              ignore_errors: true"},{"line_number":405,"context_line":"              args:"},{"line_number":406,"context_line":"                executable: /bin/bash"},{"line_number":407,"context_line":"      external_upgrade_tasks:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"811d6003_a66f7a94","line":404,"updated":"2021-07-13 06:25:29.000000000","message":"same should be delegate_to: undercloud","commit_id":"b5ce2499bd0d8ad53d14354e3d4a29ce374a8aa1"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"caa9d8a8c328a9566afbd40f8265ea0c06666e23","unresolved":false,"context_lines":[{"line_number":401,"context_line":"                /usr/bin/openstack compute service delete {{ item.ID }}"},{"line_number":402,"context_line":"              loop: \"{{ nova_compute_service_result.stdout | from_yaml }}\""},{"line_number":403,"context_line":"              run_once: true"},{"line_number":404,"context_line":"              ignore_errors: true"},{"line_number":405,"context_line":"              args:"},{"line_number":406,"context_line":"                executable: /bin/bash"},{"line_number":407,"context_line":"      external_upgrade_tasks:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"db04880c_641b6314","line":404,"in_reply_to":"811d6003_a66f7a94","updated":"2021-07-13 18:16:36.000000000","message":"Done","commit_id":"b5ce2499bd0d8ad53d14354e3d4a29ce374a8aa1"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"32d6514a79ee0a771f8bede9c351e44bdc2e1170","unresolved":true,"context_lines":[{"line_number":387,"context_line":"          block:"},{"line_number":388,"context_line":"            - name: Get nova-consoleauth service ID"},{"line_number":389,"context_line":"              shell: |"},{"line_number":390,"context_line":"                /usr/bin/openstack compute service list --service nova-consoleauth --column ID  --column Host --format yaml"},{"line_number":391,"context_line":"              register: nova_compute_service_result"},{"line_number":392,"context_line":"              check_mode: false"},{"line_number":393,"context_line":"              run_once: true"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e4d813c3_82ac4e8d","line":390,"range":{"start_line":390,"start_character":16,"end_line":390,"end_character":25},"updated":"2021-07-14 13:23:31.000000000","message":"you can set the PATH instead hard coding it in the shell","commit_id":"e98d12f68b88433ab4b082df0621b8c902abb847"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"2558fa67316ce7253e7bc15cc2dd315bb2334642","unresolved":false,"context_lines":[{"line_number":387,"context_line":"          block:"},{"line_number":388,"context_line":"            - name: Get nova-consoleauth service ID"},{"line_number":389,"context_line":"              shell: |"},{"line_number":390,"context_line":"                /usr/bin/openstack compute service list --service nova-consoleauth --column ID  --column Host --format yaml"},{"line_number":391,"context_line":"              register: nova_compute_service_result"},{"line_number":392,"context_line":"              check_mode: false"},{"line_number":393,"context_line":"              run_once: true"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ddc1d0b1_86f86a8c","line":390,"range":{"start_line":390,"start_character":16,"end_line":390,"end_character":25},"in_reply_to":"e4d813c3_82ac4e8d","updated":"2021-07-14 18:03:36.000000000","message":"Done","commit_id":"e98d12f68b88433ab4b082df0621b8c902abb847"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"32d6514a79ee0a771f8bede9c351e44bdc2e1170","unresolved":true,"context_lines":[{"line_number":392,"context_line":"              check_mode: false"},{"line_number":393,"context_line":"              run_once: true"},{"line_number":394,"context_line":"              changed_when: false"},{"line_number":395,"context_line":"              ignore_errors: true"},{"line_number":396,"context_line":"              delegate_to: undercloud"},{"line_number":397,"context_line":"              args:"},{"line_number":398,"context_line":"                executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f60a18c6_e5a47685","line":395,"range":{"start_line":395,"start_character":0,"end_line":395,"end_character":33},"updated":"2021-07-14 13:23:31.000000000","message":"failed_when: false","commit_id":"e98d12f68b88433ab4b082df0621b8c902abb847"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"2558fa67316ce7253e7bc15cc2dd315bb2334642","unresolved":false,"context_lines":[{"line_number":392,"context_line":"              check_mode: false"},{"line_number":393,"context_line":"              run_once: true"},{"line_number":394,"context_line":"              changed_when: false"},{"line_number":395,"context_line":"              ignore_errors: true"},{"line_number":396,"context_line":"              delegate_to: undercloud"},{"line_number":397,"context_line":"              args:"},{"line_number":398,"context_line":"                executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c41c6dce_c8aa6e23","line":395,"range":{"start_line":395,"start_character":0,"end_line":395,"end_character":33},"in_reply_to":"f60a18c6_e5a47685","updated":"2021-07-14 18:03:36.000000000","message":"Done","commit_id":"e98d12f68b88433ab4b082df0621b8c902abb847"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"32d6514a79ee0a771f8bede9c351e44bdc2e1170","unresolved":true,"context_lines":[{"line_number":402,"context_line":"              loop: \"{{ nova_compute_service_result.stdout | from_yaml }}\""},{"line_number":403,"context_line":"              run_once: true"},{"line_number":404,"context_line":"              delegate_to: undercloud"},{"line_number":405,"context_line":"              ignore_errors: true"},{"line_number":406,"context_line":"              args:"},{"line_number":407,"context_line":"                executable: /bin/bash"},{"line_number":408,"context_line":"      external_upgrade_tasks:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dff4109f_beebb4c8","line":405,"range":{"start_line":405,"start_character":0,"end_line":405,"end_character":33},"updated":"2021-07-14 13:23:31.000000000","message":"lets fix this one too. failed_when: false","commit_id":"e98d12f68b88433ab4b082df0621b8c902abb847"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"2558fa67316ce7253e7bc15cc2dd315bb2334642","unresolved":false,"context_lines":[{"line_number":402,"context_line":"              loop: \"{{ nova_compute_service_result.stdout | from_yaml }}\""},{"line_number":403,"context_line":"              run_once: true"},{"line_number":404,"context_line":"              delegate_to: undercloud"},{"line_number":405,"context_line":"              ignore_errors: true"},{"line_number":406,"context_line":"              args:"},{"line_number":407,"context_line":"                executable: /bin/bash"},{"line_number":408,"context_line":"      external_upgrade_tasks:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"25096131_9a474ee7","line":405,"range":{"start_line":405,"start_character":0,"end_line":405,"end_character":33},"in_reply_to":"dff4109f_beebb4c8","updated":"2021-07-14 18:03:36.000000000","message":"Done","commit_id":"e98d12f68b88433ab4b082df0621b8c902abb847"}]}