)]}'
{"deployment/octavia/octavia-api-container-puppet.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"407f169dedbb65e9501dbe883263dc6f7f83f76d","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            - \"\\n\""},{"line_number":232,"context_line":"            - - \"include tripleo::profile::base::octavia::api\""},{"line_number":233,"context_line":"              - if:"},{"line_number":234,"context_line":"                - {get_param: OctaviaEnableDriverAgent}"},{"line_number":235,"context_line":"                - \"include octavia::driver_agent\""},{"line_number":236,"context_line":"              - {get_attr: [OctaviaProviderConfig, role_data, step_config]}"},{"line_number":237,"context_line":"              - {get_attr: [MySQLClient, role_data, step_config]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c25156f1_a8878489","side":"PARENT","line":234,"updated":"2021-06-30 15:37:37.000000000","message":"but this is an optional include?  Your include is always now. Is that ok?","commit_id":"8c9c94bf8be8f042b71d4c41666338531ca03f14"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ad8c9fde8d3341a3d5759eefb13d2bae93c2fff3","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            - \"\\n\""},{"line_number":232,"context_line":"            - - \"include tripleo::profile::base::octavia::api\""},{"line_number":233,"context_line":"              - if:"},{"line_number":234,"context_line":"                - {get_param: OctaviaEnableDriverAgent}"},{"line_number":235,"context_line":"                - \"include octavia::driver_agent\""},{"line_number":236,"context_line":"              - {get_attr: [OctaviaProviderConfig, role_data, step_config]}"},{"line_number":237,"context_line":"              - {get_attr: [MySQLClient, role_data, step_config]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f1cc4f68_a12f8bd5","side":"PARENT","line":234,"in_reply_to":"c25156f1_a8878489","updated":"2021-06-30 16:00:03.000000000","message":"The octavia::driver_agent class manages only config parameters and all of them default to $::os_service_default.\nSo it does nothing unless any parameters is difined.\n\nI can make that inclusion optional but for me there seems to be no benefit with implementing such logic atm.","commit_id":"8c9c94bf8be8f042b71d4c41666338531ca03f14"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"59bb0687d0656ca419ad58e4dd0ca13d4e7a8678","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            - \"\\n\""},{"line_number":232,"context_line":"            - - \"include tripleo::profile::base::octavia::api\""},{"line_number":233,"context_line":"              - if:"},{"line_number":234,"context_line":"                - {get_param: OctaviaEnableDriverAgent}"},{"line_number":235,"context_line":"                - \"include octavia::driver_agent\""},{"line_number":236,"context_line":"              - {get_attr: [OctaviaProviderConfig, role_data, step_config]}"},{"line_number":237,"context_line":"              - {get_attr: [MySQLClient, role_data, step_config]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9dba21ab_9be822be","side":"PARENT","line":234,"in_reply_to":"f1cc4f68_a12f8bd5","updated":"2021-06-30 16:04:25.000000000","message":"Ok that makes sense","commit_id":"8c9c94bf8be8f042b71d4c41666338531ca03f14"}]}