)]}'
{"deployment/haproxy/haproxy-public-tls-inject.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8f32a109165166161690c96f4f5206cc3f1d4b6e","unresolved":true,"context_lines":[{"line_number":180,"context_line":"                    else"},{"line_number":181,"context_line":"                      {{ container_cli }} cp {{ cert_path }} {{ item }}:{{ cert_path }}"},{"line_number":182,"context_line":"                    fi"},{"line_number":183,"context_line":"                    {{ container_cli }} exec --user root {{ item }} chgrp haproxy {{ cert_path }}"},{"line_number":184,"context_line":"                    {{ container_cli }} kill --signal\u003dHUP {{ item }}"},{"line_number":185,"context_line":"                  with_items: \"{{ container_id.stdout.split(\u0027\\n\u0027) }}\""},{"line_number":186,"context_line":"                  register: container_kill_result"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9843581a_8b43f5b5","line":183,"updated":"2021-06-29 07:29:07.000000000","message":"are there expectations that that command always applies, even if a new container has been started? if so, we should modify this to issue the command by container name, but still skip the unnecessary reloading, whenever the known UUID changes.","commit_id":"9cfe55f87e0766e2d8d9e1976048f57275c8678f"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"ff73a3538b9971886ab5d154d029552cf3664668","unresolved":true,"context_lines":[{"line_number":180,"context_line":"                    else"},{"line_number":181,"context_line":"                      {{ container_cli }} cp {{ cert_path }} {{ item }}:{{ cert_path }}"},{"line_number":182,"context_line":"                    fi"},{"line_number":183,"context_line":"                    {{ container_cli }} exec --user root {{ item }} chgrp haproxy {{ cert_path }}"},{"line_number":184,"context_line":"                    {{ container_cli }} kill --signal\u003dHUP {{ item }}"},{"line_number":185,"context_line":"                  with_items: \"{{ container_id.stdout.split(\u0027\\n\u0027) }}\""},{"line_number":186,"context_line":"                  register: container_kill_result"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"43f31275_6ff7605f","line":183,"in_reply_to":"9843581a_8b43f5b5","updated":"2021-06-29 15:41:05.000000000","message":"We just want to ensure that no existing container will still keep an old certificate.\nAt the time this block is executed, the new cert has already been deployed on the host, so if the container_id changes at this time, it will pick up the new cert automatically.","commit_id":"9cfe55f87e0766e2d8d9e1976048f57275c8678f"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"ff73a3538b9971886ab5d154d029552cf3664668","unresolved":true,"context_lines":[{"line_number":184,"context_line":"                    {{ container_cli }} kill --signal\u003dHUP {{ item }}"},{"line_number":185,"context_line":"                  with_items: \"{{ container_id.stdout.split(\u0027\\n\u0027) }}\""},{"line_number":186,"context_line":"                  register: container_kill_result"},{"line_number":187,"context_line":"                  ignore_errors: \"does not exist in database: no such container\" in container_kill_result.stderr"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa8ed58c_e4a366af","line":187,"updated":"2021-06-29 15:41:05.000000000","message":"I couldn\u0027t replicate this specific error when running the podman command above manually with podman 3.0.x. These are all the error that I\u0027ve got:\n\n[root@controller-0 ~]# podman exec foo ls\nError: no container with name or ID foo found: no such container\n\n[root@controller-0 ~]#  podman cp /tmp/foo foo:/tmp/foo                                                                                                       \nError: container \"foo\" does not exist\n\n[root@controller-0 ~]#  podman kill --signal\u003dHUP foo\nError: no container with name or ID foo found: no such container\n\nSo there are at least those two additional pattern to consider.\n\nAll the podman errors always return the same generic error code (125)","commit_id":"9cfe55f87e0766e2d8d9e1976048f57275c8678f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b58ea52bbe11bb62dad1fc1572b920a08c0e911f","unresolved":true,"context_lines":[{"line_number":184,"context_line":"                    {{ container_cli }} kill --signal\u003dHUP {{ item }}"},{"line_number":185,"context_line":"                  with_items: \"{{ container_id.stdout.split(\u0027\\n\u0027) }}\""},{"line_number":186,"context_line":"                  register: container_kill_result"},{"line_number":187,"context_line":"                  ignore_errors: \"does not exist in database: no such container\" in container_kill_result.stderr"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f1eac4b3_66385fe9","line":187,"in_reply_to":"fa8ed58c_e4a366af","updated":"2021-07-02 07:50:14.000000000","message":"Fixed that. I also wouldn\u0027t rely on 125 exit code as that likely covers broader scope of failures with some we\u0027d not ignore surely.","commit_id":"9cfe55f87e0766e2d8d9e1976048f57275c8678f"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2ea49a012efcd19f412fdf144815a24c87c8e62a","unresolved":true,"context_lines":[{"line_number":183,"context_line":"                    {{ container_cli }} exec --user root {{ item }} chgrp haproxy {{ cert_path }}"},{"line_number":184,"context_line":"                    {{ container_cli }} kill --signal\u003dHUP {{ item }}"},{"line_number":185,"context_line":"                  register: container_kill_result"},{"line_number":186,"context_line":"                  ignore_errors: (\"no such container\" in container_kill_result.stderr)"},{"line_number":187,"context_line":"                  with_items: \"{{ container_id.stdout.split(\u0027\\n\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cc52cdcb_d5fb9fbe","line":186,"range":{"start_line":186,"start_character":18,"end_line":186,"end_character":31},"updated":"2021-07-05 10:47:27.000000000","message":"Can we use \"failed_when: (\"no such container\" not in container_kill_result.stderr)\" instead?\n\nhttps://medium.com/@sbarnea/why-ansible-ignore-errors-is-evil-500fb6e81229","commit_id":"b608aefc2e7d89de480ea19022e163dfcc5f8beb"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"53d48945b7c39e63103a65d5e61b98381563d4f2","unresolved":true,"context_lines":[{"line_number":183,"context_line":"                    {{ container_cli }} exec --user root {{ item }} chgrp haproxy {{ cert_path }}"},{"line_number":184,"context_line":"                    {{ container_cli }} kill --signal\u003dHUP {{ item }}"},{"line_number":185,"context_line":"                  register: container_kill_result"},{"line_number":186,"context_line":"                  ignore_errors: (\"no such container\" in container_kill_result.stderr)"},{"line_number":187,"context_line":"                  with_items: \"{{ container_id.stdout.split(\u0027\\n\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fc221e7_ea85f87e","line":186,"updated":"2021-07-07 14:04:04.000000000","message":"I think this can also fail when the container UUID still exists, but the container is stopped.\n[root@standalone ~]# podman exec -it \u003ca-stopped-container\u003e ls\nError: can only create exec sessions on running containers: container state improper\n[root@standalone ~]# echo $?\n255\n\nSo we might not want to check all the exit codes, but at least we shouldn\u0027t fail when we see \"container state improper\"","commit_id":"b608aefc2e7d89de480ea19022e163dfcc5f8beb"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"915b7422b272d20436f0eeb78aa1de65194dedf6","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                    {{ container_cli }} exec --user root {{ item }} chgrp haproxy {{ cert_path }}"},{"line_number":184,"context_line":"                    {{ container_cli }} kill --signal\u003dHUP {{ item }}"},{"line_number":185,"context_line":"                  register: container_kill_result"},{"line_number":186,"context_line":"                  ignore_errors: (\"no such container\" in container_kill_result.stderr)"},{"line_number":187,"context_line":"                  with_items: \"{{ container_id.stdout.split(\u0027\\n\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bdd1e44e_08c7e477","line":186,"in_reply_to":"3fc221e7_ea85f87e","updated":"2021-07-23 11:08:03.000000000","message":"Done","commit_id":"b608aefc2e7d89de480ea19022e163dfcc5f8beb"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"915b7422b272d20436f0eeb78aa1de65194dedf6","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                    {{ container_cli }} exec --user root {{ item }} chgrp haproxy {{ cert_path }}"},{"line_number":184,"context_line":"                    {{ container_cli }} kill --signal\u003dHUP {{ item }}"},{"line_number":185,"context_line":"                  register: container_kill_result"},{"line_number":186,"context_line":"                  ignore_errors: (\"no such container\" in container_kill_result.stderr)"},{"line_number":187,"context_line":"                  with_items: \"{{ container_id.stdout.split(\u0027\\n\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2df5de2f_063a67b0","line":186,"range":{"start_line":186,"start_character":18,"end_line":186,"end_character":31},"in_reply_to":"cc52cdcb_d5fb9fbe","updated":"2021-07-23 11:08:03.000000000","message":"Done","commit_id":"b608aefc2e7d89de480ea19022e163dfcc5f8beb"}]}