)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5aa0a756f47399cd9877a5e1bb7a840aae2f72a5","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Lukas Bezdicka \u003clbezdick@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-07-01 14:11:16 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP][FFWD][train-only] Ensure we get ovn_controller cert if needed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We instroduced ssl for ovn_controller in Train which breaks hybrid"},{"line_number":10,"context_line":"mode unless we fetch the new service certificate and point the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"78bbf6de_9f181ad8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"updated":"2021-07-02 11:41:52.000000000","message":"Is this still WIP?","commit_id":"6855a622999a1a21645f2174b3e7e14952f8b68f"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"3d0b9f9bf2894bf29c934bebb13fc1b75deec557","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[FFWD][train-only] Ensure we get ovn_controller cert if needed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We introduced ssl for ovn_controller in Train which breaks hybrid"},{"line_number":10,"context_line":"mode unless we fech the new service certificate and point the"},{"line_number":11,"context_line":"ovn_controller to use it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-authored-by: Jose Luis Franco Arza \u003cjfrancoa@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"8f9eb07f_5613b8c0","line":10,"updated":"2021-10-18 14:04:25.000000000","message":"s/fech/fetch/","commit_id":"6cbb8cdf117016458f012a0837054efb2e0e3e5b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"212be13d16cb0d30413777d7a680f10d6def4c92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"17a5aca1_0582a890","updated":"2021-10-18 13:59:32.000000000","message":"ok, thanks, that was only a question regarding to either to add SANs or not.\nThe concern is only about changing 644 permissions on certs","commit_id":"6cbb8cdf117016458f012a0837054efb2e0e3e5b"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"3e76da20d2fded6fdc5cc6bad77ac1a723288ecc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"360c9456_ca24ff1e","updated":"2021-10-20 12:28:13.000000000","message":"Hold in it on for a little bit more, as it needs better testing.","commit_id":"b11ded780fa4d5058882bcb37051e297ce6f731d"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"e9a66a6b59166f54cca7015d61542ad14d90e6f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"2d16af17_1e34449b","updated":"2021-10-20 12:19:33.000000000","message":"Tested in downstream CI job with no new issues (than the already existing with OVN). Merging it!","commit_id":"b11ded780fa4d5058882bcb37051e297ce6f731d"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"e6fc9939acb68833128d7f37e9015f8a78c50d80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"2a8f27e4_954a2892","updated":"2021-10-21 11:20:39.000000000","message":"Latest version passed CI.","commit_id":"75655715ea31e98855a29b6bba144fb8a6409a9a"}],"deployment/ovn/ovn-controller-container-puppet.yaml":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"d1a751844bbb02e5c877525c2be79137417fe412","unresolved":true,"context_lines":[{"line_number":394,"context_line":"            internal_tls_ca: {get_param: InternalTLSCAFile}"},{"line_number":395,"context_line":"            ovn_cert_hostname:"},{"line_number":396,"context_line":"              str_replace:"},{"line_number":397,"context_line":"                template: \"fqdn_NETWORK\""},{"line_number":398,"context_line":"                params:"},{"line_number":399,"context_line":"                  NETWORK: {get_param: [ServiceNetMap, OvnDbsNetwork]}"},{"line_number":400,"context_line":"            ovn_cert_key_size:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8d3a7b72_06b784c9","line":397,"updated":"2021-06-30 12:28:45.000000000","message":"2021-06-30 12:14:37.921996 | ubuntu-bionic | ERROR: Missed %{hiera(\u0027... NETWORK ...\u0027)} interpolation in str_replace[\u0027template\u0027] in ./deployment/ovn/ovn-controller-container-puppet.yaml, role_data: [\u0027value\u0027, \u0027upgrade_tasks\u0027, 2, \u0027vars\u0027, \u0027ovn_cert_hostname\u0027, \u0027str_replace\u0027, \u0027params\u0027, \u0027NETWORK\u0027, \u0027get_param\u0027, 0]","commit_id":"8230deebc6a02dba18cded54f5701ce7b598cb40"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5aa0a756f47399cd9877a5e1bb7a840aae2f72a5","unresolved":true,"context_lines":[{"line_number":416,"context_line":"              block:"},{"line_number":417,"context_line":"                - name: Get certificate if needed"},{"line_number":418,"context_line":"                  when: enable_internal_tls|bool"},{"line_number":419,"context_line":"                  shell: |"},{"line_number":420,"context_line":"                    /usr/bin/getcert list -i ovn_controller || /usr/bin/getcert request -I ovn_controller -f /etc/pki/tls/certs/ovn_controller.crt -c IPA -N CN\u003d$( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) -K ovn_controller/$( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) -D $( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) -g {{ovn_cert_key_size}} -w -k /etc/pki/tls/private/ovn_controller.key"},{"line_number":421,"context_line":"                - set_fact:"},{"line_number":422,"context_line":"                    ovn_volumes: \u0027{{ [ \"/var/lib/openvswitch/ovn:/run/ovn:shared\","},{"line_number":423,"context_line":"                                      \"/var/log/containers/openvswitch:/var/log/ovn\","}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba836c01_ed64be7d","line":420,"range":{"start_line":419,"start_character":0,"end_line":420,"end_character":440},"updated":"2021-07-02 11:41:52.000000000","message":"We can flatten this to make it easier to read, like:\n\nshell: \u003e-\n  /usr/bin/getcert list -i ovn_controller ||\n  /usr/bin/getcert request -I ovn_controller\n  -f /etc/pki/tls/certs/ovn_controller.crt\n  -c IPA\n  -N CN\u003d$( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} )\n  -K ovn_controller/$( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} )\n  -D $( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} )\n  -g {{ovn_cert_key_size}}\n  -w\n  -k /etc/pki/tls/private/ovn_controller.key","commit_id":"6855a622999a1a21645f2174b3e7e14952f8b68f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5aa0a756f47399cd9877a5e1bb7a840aae2f72a5","unresolved":true,"context_lines":[{"line_number":419,"context_line":"                  shell: |"},{"line_number":420,"context_line":"                    /usr/bin/getcert list -i ovn_controller || /usr/bin/getcert request -I ovn_controller -f /etc/pki/tls/certs/ovn_controller.crt -c IPA -N CN\u003d$( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) -K ovn_controller/$( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) -D $( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) -g {{ovn_cert_key_size}} -w -k /etc/pki/tls/private/ovn_controller.key"},{"line_number":421,"context_line":"                - set_fact:"},{"line_number":422,"context_line":"                    ovn_volumes: \u0027{{ [ \"/var/lib/openvswitch/ovn:/run/ovn:shared\","},{"line_number":423,"context_line":"                                      \"/var/log/containers/openvswitch:/var/log/ovn\","},{"line_number":424,"context_line":"                                      \"/etc/pki/tls/private/ovn_controller.key:/etc/pki/tls/private/ovn_controller.key\","},{"line_number":425,"context_line":"                                      \"/etc/pki/tls/certs/ovn_controller.crt:/etc/pki/tls/certs/ovn_controller.crt\","}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ac024a4a_31eecc57","line":422,"range":{"start_line":422,"start_character":20,"end_line":422,"end_character":31},"updated":"2021-07-02 11:41:52.000000000","message":"Where is this used? I don\u0027t see where.","commit_id":"6855a622999a1a21645f2174b3e7e14952f8b68f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5aa0a756f47399cd9877a5e1bb7a840aae2f72a5","unresolved":true,"context_lines":[{"line_number":428,"context_line":"                                    [ \"/var/lib/openvswitch/ovn:/run/ovn:shared\","},{"line_number":429,"context_line":"                                      \"/var/log/containers/openvswitch:/var/log/ovn\" ]"},{"line_number":430,"context_line":"                                    }}\u0027"},{"line_number":431,"context_line":"                - name: Update the ovn_controller paunch image in config"},{"line_number":432,"context_line":"                  shell: |"},{"line_number":433,"context_line":"                    set -o pipefail"},{"line_number":434,"context_line":"                    jq \u0027.ovn_controller.image \u003d \"{{ ovn_controller_image }}\" |"},{"line_number":435,"context_line":"                        .ovn_controller.volumes +\u003d [ \"/var/lib/openvswitch/ovn:/run/ovn:shared\","},{"line_number":436,"context_line":"                                      \"/var/log/containers/openvswitch:/var/log/ovn\"{% if enable_internal_tls|bool %},"},{"line_number":437,"context_line":"                                      \"/etc/pki/tls/private/ovn_controller.key:/etc/pki/tls/private/ovn_controller.key\","},{"line_number":438,"context_line":"                                      \"/etc/pki/tls/certs/ovn_controller.crt:/etc/pki/tls/certs/ovn_controller.crt\","},{"line_number":439,"context_line":"                                      \"{{ internal_tls_ca }}:{{ internal_tls_ca}}\"{% endif %} ] |"},{"line_number":440,"context_line":"                        {\"ovn_controller\": .ovn_controller }\u0027 \\"},{"line_number":441,"context_line":"                    /var/lib/tripleo-config/docker-container-startup-config-step_4.json \u003e\\"},{"line_number":442,"context_line":"                    /var/lib/tripleo-config/docker-container-hybrid_ovn_controller.json"},{"line_number":443,"context_line":"                - name: Modify /var/lib/kolla/config_files/ovn_controller.json for ssl"},{"line_number":444,"context_line":"                  when: enable_internal_tls|bool"},{"line_number":445,"context_line":"                  shell: |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d410705c_02203ca2","line":442,"range":{"start_line":431,"start_character":0,"end_line":442,"end_character":87},"updated":"2021-07-02 11:41:52.000000000","message":"Could we break this down into two edits - one only happening if enable_internal_tls|bool ? This is quite hard to read.","commit_id":"6855a622999a1a21645f2174b3e7e14952f8b68f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"79c7002ad6139506e928eb3fa9ced6c1f0c644e1","unresolved":true,"context_lines":[{"line_number":422,"context_line":"                    -f /etc/pki/tls/certs/ovn_controller.crt \\"},{"line_number":423,"context_line":"                    -c IPA \\"},{"line_number":424,"context_line":"                    -N CN\u003d$( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) \\"},{"line_number":425,"context_line":"                    -K ovn_controller/$( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) \\"},{"line_number":426,"context_line":"                    -D $( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) \\"},{"line_number":427,"context_line":"                    -g {{ovn_cert_key_size}} \\"},{"line_number":428,"context_line":"                    -w -k /etc/pki/tls/private/ovn_controller.key"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"0490f478_e052fdce","line":425,"range":{"start_line":425,"start_character":38,"end_line":425,"end_character":100},"updated":"2021-07-29 15:28:51.000000000","message":"I thought we provided all the hieradata bits as ansible vars?","commit_id":"4be95a35f612b086b0830556d444d7303601433b"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"f03dc8662226a3747a1133964e196f99ad629460","unresolved":true,"context_lines":[{"line_number":431,"context_line":"                  shell: |"},{"line_number":432,"context_line":"                    set -o pipefail"},{"line_number":433,"context_line":"                    jq \u0027.ovn_controller.image \u003d \"{{ ovn_controller_image }}\" |"},{"line_number":434,"context_line":"                        .ovn_controller.volumes +\u003d [ \"/var/lib/openvswitch/ovn:/run/ovn:shared\","},{"line_number":435,"context_line":"                                      \"/var/log/containers/openvswitch:/var/log/ovn\","},{"line_number":436,"context_line":"                                      \"/etc/pki/tls/private/ovn_controller.key:/etc/pki/tls/private/ovn_controller.key\","},{"line_number":437,"context_line":"                                      \"/etc/pki/tls/certs/ovn_controller.crt:/etc/pki/tls/certs/ovn_controller.crt\","}],"source_content_type":"text/x-yaml","patch_set":9,"id":"978f5158_5de9779a","line":434,"range":{"start_line":434,"start_character":87,"end_line":434,"end_character":96},"updated":"2021-09-15 12:26:14.000000000","message":"The \",z\" is not there relative to the non tls command, is that expected ?","commit_id":"a8dc71f9793f3dad27a7d9970227a54a6bf2f236"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"41b76adcd28f2ea695613f08b237cc668fa00d5b","unresolved":true,"context_lines":[{"line_number":431,"context_line":"                  shell: |"},{"line_number":432,"context_line":"                    set -o pipefail"},{"line_number":433,"context_line":"                    jq \u0027.ovn_controller.image \u003d \"{{ ovn_controller_image }}\" |"},{"line_number":434,"context_line":"                        .ovn_controller.volumes +\u003d [ \"/var/lib/openvswitch/ovn:/run/ovn:shared\","},{"line_number":435,"context_line":"                                      \"/var/log/containers/openvswitch:/var/log/ovn\","},{"line_number":436,"context_line":"                                      \"/etc/pki/tls/private/ovn_controller.key:/etc/pki/tls/private/ovn_controller.key\","},{"line_number":437,"context_line":"                                      \"/etc/pki/tls/certs/ovn_controller.crt:/etc/pki/tls/certs/ovn_controller.crt\","}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ddcc7145_3b3beba4","line":434,"range":{"start_line":434,"start_character":87,"end_line":434,"end_character":96},"in_reply_to":"978f5158_5de9779a","updated":"2021-09-28 06:26:17.000000000","message":"Good catch! The patch is couple of months old and in the meantime some corrections related to selinux issues have landed, so the patch needs updating. I\u0027ll take care of it.\nThanks Sofer","commit_id":"a8dc71f9793f3dad27a7d9970227a54a6bf2f236"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"9e7adef6f41c3275f3142036f6808a67a46b2048","unresolved":false,"context_lines":[{"line_number":431,"context_line":"                  shell: |"},{"line_number":432,"context_line":"                    set -o pipefail"},{"line_number":433,"context_line":"                    jq \u0027.ovn_controller.image \u003d \"{{ ovn_controller_image }}\" |"},{"line_number":434,"context_line":"                        .ovn_controller.volumes +\u003d [ \"/var/lib/openvswitch/ovn:/run/ovn:shared\","},{"line_number":435,"context_line":"                                      \"/var/log/containers/openvswitch:/var/log/ovn\","},{"line_number":436,"context_line":"                                      \"/etc/pki/tls/private/ovn_controller.key:/etc/pki/tls/private/ovn_controller.key\","},{"line_number":437,"context_line":"                                      \"/etc/pki/tls/certs/ovn_controller.crt:/etc/pki/tls/certs/ovn_controller.crt\","}],"source_content_type":"text/x-yaml","patch_set":9,"id":"60c5707c_3ebde44c","line":434,"range":{"start_line":434,"start_character":87,"end_line":434,"end_character":96},"in_reply_to":"ddcc7145_3b3beba4","updated":"2021-09-29 05:40:48.000000000","message":"Done","commit_id":"a8dc71f9793f3dad27a7d9970227a54a6bf2f236"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"f03dc8662226a3747a1133964e196f99ad629460","unresolved":true,"context_lines":[{"line_number":432,"context_line":"                    set -o pipefail"},{"line_number":433,"context_line":"                    jq \u0027.ovn_controller.image \u003d \"{{ ovn_controller_image }}\" |"},{"line_number":434,"context_line":"                        .ovn_controller.volumes +\u003d [ \"/var/lib/openvswitch/ovn:/run/ovn:shared\","},{"line_number":435,"context_line":"                                      \"/var/log/containers/openvswitch:/var/log/ovn\","},{"line_number":436,"context_line":"                                      \"/etc/pki/tls/private/ovn_controller.key:/etc/pki/tls/private/ovn_controller.key\","},{"line_number":437,"context_line":"                                      \"/etc/pki/tls/certs/ovn_controller.crt:/etc/pki/tls/certs/ovn_controller.crt\","},{"line_number":438,"context_line":"                                      \"{{ internal_tls_ca }}:{{ internal_tls_ca}}\" ] |"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5c20faa3_31583186","line":435,"range":{"start_line":435,"start_character":79,"end_line":435,"end_character":85},"updated":"2021-09-15 12:26:14.000000000","message":"Some here \":z\"","commit_id":"a8dc71f9793f3dad27a7d9970227a54a6bf2f236"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"41b76adcd28f2ea695613f08b237cc668fa00d5b","unresolved":false,"context_lines":[{"line_number":432,"context_line":"                    set -o pipefail"},{"line_number":433,"context_line":"                    jq \u0027.ovn_controller.image \u003d \"{{ ovn_controller_image }}\" |"},{"line_number":434,"context_line":"                        .ovn_controller.volumes +\u003d [ \"/var/lib/openvswitch/ovn:/run/ovn:shared\","},{"line_number":435,"context_line":"                                      \"/var/log/containers/openvswitch:/var/log/ovn\","},{"line_number":436,"context_line":"                                      \"/etc/pki/tls/private/ovn_controller.key:/etc/pki/tls/private/ovn_controller.key\","},{"line_number":437,"context_line":"                                      \"/etc/pki/tls/certs/ovn_controller.crt:/etc/pki/tls/certs/ovn_controller.crt\","},{"line_number":438,"context_line":"                                      \"{{ internal_tls_ca }}:{{ internal_tls_ca}}\" ] |"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"b5174fb7_64d1268d","line":435,"range":{"start_line":435,"start_character":79,"end_line":435,"end_character":85},"in_reply_to":"5c20faa3_31583186","updated":"2021-09-28 06:26:17.000000000","message":"Ack","commit_id":"a8dc71f9793f3dad27a7d9970227a54a6bf2f236"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"f03dc8662226a3747a1133964e196f99ad629460","unresolved":true,"context_lines":[{"line_number":439,"context_line":"                        {\"ovn_controller\": .ovn_controller }\u0027 \\"},{"line_number":440,"context_line":"                    /var/lib/tripleo-config/docker-container-startup-config-step_4.json \u003e\\"},{"line_number":441,"context_line":"                    /var/lib/tripleo-config/docker-container-hybrid_ovn_controller.json"},{"line_number":442,"context_line":"                - name: Update the ovn_controller paunch image in config"},{"line_number":443,"context_line":"                  when: not enable_internal_tls|bool"},{"line_number":444,"context_line":"                  shell: |"},{"line_number":445,"context_line":"                    set -o pipefail"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"11aa81ea_bf29dcfa","line":442,"range":{"start_line":442,"start_character":24,"end_line":442,"end_character":72},"updated":"2021-09-15 12:26:14.000000000","message":"Twice the same name, could lead to confusion during debug, not a blocker, but if you have another review.","commit_id":"a8dc71f9793f3dad27a7d9970227a54a6bf2f236"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"41b76adcd28f2ea695613f08b237cc668fa00d5b","unresolved":false,"context_lines":[{"line_number":439,"context_line":"                        {\"ovn_controller\": .ovn_controller }\u0027 \\"},{"line_number":440,"context_line":"                    /var/lib/tripleo-config/docker-container-startup-config-step_4.json \u003e\\"},{"line_number":441,"context_line":"                    /var/lib/tripleo-config/docker-container-hybrid_ovn_controller.json"},{"line_number":442,"context_line":"                - name: Update the ovn_controller paunch image in config"},{"line_number":443,"context_line":"                  when: not enable_internal_tls|bool"},{"line_number":444,"context_line":"                  shell: |"},{"line_number":445,"context_line":"                    set -o pipefail"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"965a79ee_d3ff3521","line":442,"range":{"start_line":442,"start_character":24,"end_line":442,"end_character":72},"in_reply_to":"11aa81ea_bf29dcfa","updated":"2021-09-28 06:26:17.000000000","message":"Ack","commit_id":"a8dc71f9793f3dad27a7d9970227a54a6bf2f236"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4ee69a5f8ed6eb16ea1f83b9878642b62b3fac50","unresolved":true,"context_lines":[{"line_number":429,"context_line":"                    /usr/bin/getcert request -I ovn_controller \\"},{"line_number":430,"context_line":"                    -f /etc/pki/tls/certs/ovn_controller.crt \\"},{"line_number":431,"context_line":"                    -c IPA \\"},{"line_number":432,"context_line":"                    -N CN\u003d$( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) \\"},{"line_number":433,"context_line":"                    -K ovn_controller/$( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) \\"},{"line_number":434,"context_line":"                    -D $( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) \\"},{"line_number":435,"context_line":"                    -g {{ovn_cert_key_size}} \\"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9213b24d_ff7b4f55","line":432,"updated":"2021-10-13 10:06:31.000000000","message":"So CN is for FQDN, but shouldn\u0027t it as well contain some extra Subject Alternative Names, like for VIPs?","commit_id":"6cbb8cdf117016458f012a0837054efb2e0e3e5b"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"0112a61ccd214b794750c2422c4d01309a2984a6","unresolved":true,"context_lines":[{"line_number":429,"context_line":"                    /usr/bin/getcert request -I ovn_controller \\"},{"line_number":430,"context_line":"                    -f /etc/pki/tls/certs/ovn_controller.crt \\"},{"line_number":431,"context_line":"                    -c IPA \\"},{"line_number":432,"context_line":"                    -N CN\u003d$( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) \\"},{"line_number":433,"context_line":"                    -K ovn_controller/$( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) \\"},{"line_number":434,"context_line":"                    -D $( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) \\"},{"line_number":435,"context_line":"                    -g {{ovn_cert_key_size}} \\"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9673a87e_3d4972a6","line":432,"in_reply_to":"9213b24d_ff7b4f55","updated":"2021-10-18 13:51:07.000000000","message":"From checking other deployment jobs there does not seem to be need for anything else than CN. There should be no VIPs involved here.","commit_id":"6cbb8cdf117016458f012a0837054efb2e0e3e5b"}],"deployment/ovn/ovn-metadata-container-puppet.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"79c7002ad6139506e928eb3fa9ced6c1f0c644e1","unresolved":true,"context_lines":[{"line_number":437,"context_line":"                    dest: /var/lib/config-data/puppet-generated/neutron/etc/neutron/ovn_metadata.key"},{"line_number":438,"context_line":"                    mode: \u00270644\u0027"},{"line_number":439,"context_line":"                    remote_src: yes"},{"line_number":440,"context_line":"                - name: Set ovn cert setting in networking-ovn-metadata-agent.ini"},{"line_number":441,"context_line":"                  ini_file:"},{"line_number":442,"context_line":"                    path: /var/lib/config-data/puppet-generated/neutron/etc/neutron/plugins/networking-ovn/networking-ovn-metadata-agent.ini"},{"line_number":443,"context_line":"                    section: ovn"},{"line_number":444,"context_line":"                    option: ovn_sb_certificate"},{"line_number":445,"context_line":"                    value: /etc/neutron/ovn_metadata.crt"},{"line_number":446,"context_line":"                - name: Set ovn cert key setting in networking-ovn-metadata-agent.ini"},{"line_number":447,"context_line":"                  ini_file:"},{"line_number":448,"context_line":"                    path: /var/lib/config-data/puppet-generated/neutron/etc/neutron/plugins/networking-ovn/networking-ovn-metadata-agent.ini"},{"line_number":449,"context_line":"                    section: ovn"},{"line_number":450,"context_line":"                    option: ovn_sb_private_key"},{"line_number":451,"context_line":"                    value: /etc/neutron/ovn_metadata.key"},{"line_number":452,"context_line":"                - name: Set ovn cacert setting in networking-ovn-metadata-agent.ini"},{"line_number":453,"context_line":"                  ini_file:"},{"line_number":454,"context_line":"                    path: /var/lib/config-data/puppet-generated/neutron/etc/neutron/plugins/networking-ovn/networking-ovn-metadata-agent.ini"},{"line_number":455,"context_line":"                    section: ovn"},{"line_number":456,"context_line":"                    option: ovn_sb_ca_cert"},{"line_number":457,"context_line":"                    value: \"{{ internal_tls_ca }}\""},{"line_number":458,"context_line":"            - name: Set fact - OVN SB connection string"},{"line_number":459,"context_line":"              set_fact:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9916cf69_de55ea37","line":456,"range":{"start_line":440,"start_character":0,"end_line":456,"end_character":42},"updated":"2021-07-29 15:28:51.000000000","message":"Should you use a loop instead since this is the same file","commit_id":"4be95a35f612b086b0830556d444d7303601433b"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"e2a68be58ae91733f399a218afee84b4e8d1d100","unresolved":true,"context_lines":[{"line_number":427,"context_line":"                    -w -k /etc/pki/tls/private/ovn_metadata.key"},{"line_number":428,"context_line":"                - name: Copy the certificate and key temporarly for hybrid state into ovn metadata agent container neutron dir"},{"line_number":429,"context_line":"                  copy:"},{"line_number":430,"context_line":"                    src: /etc/pki/tls/certs/\"{{ item }}\""},{"line_number":431,"context_line":"                    dest: /var/lib/config-data/puppet-generated/neutron/etc/neutron/\"{{ item }}\""},{"line_number":432,"context_line":"                    mode: \u00270644\u0027"},{"line_number":433,"context_line":"                    remote_src: yes"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"411f51e4_2efce878","line":430,"updated":"2021-09-30 06:22:02.000000000","message":"2021-09-29 22:41:49 | 2021-09-29 22:41:49.254692 | 525400ed-bcb9-3b19-e7dd-000000000327 |      FATAL | Copy the certificate and key temporarly for hybrid state into ovn metadata agent container neutron dir | compute-1 | item\u003dovn_metadata.crt | error\u003d{\"ansible_loop_var\": \"item\", \"changed\": false, \"item\": \"ovn_metadata.crt\", \"msg\": \"Source /etc/pki/tls/certs/\\\"ovn_metadata.crt\\\" not found\"}\n2021-09-29 22:41:49 | 2021-09-29 22:41:49.256671 | 525400ed-bcb9-3b19-e7dd-000000000327 |     TIMING | Copy the certificate and key temporarly for hybrid state into ovn metadata agent container neutron dir | compute-1 | 0:01:34.963967 | 0.36s\n2021-09-29 22:41:49 | 2021-09-29 22:41:49.561399 | 525400ed-bcb9-3b19-e7dd-000000000327 |      FATAL | Copy the certificate and key temporarly for hybrid state into ovn metadata agent container neutron dir | compute-1 | item\u003dovn_metadata.key | error\u003d{\"ansible_loop_var\": \"item\", \"changed\": false, \"item\": \"ovn_metadata.key\", \"msg\": \"Source /etc/pki/tls/certs/\\\"ovn_metadata.key\\\" not found\"}\n2021-09-29 22:41:49 | 2021-09-29 22:41:49.562198 | 525400ed-bcb9-3b19-e7dd-000000000327 |     TIMING | Copy the certificate and key temporarly for hybrid state into ovn metadata agent container neutron dir | compute-1 | 0:01:35.269512 | 0.67s\n2021-09-29 22:41:49 | 2021-09-29 22:41:49.564007 | 525400ed-bcb9-3b19-e7dd-000000000327 |     TIMING | Copy the certificate and key temporarly for hybrid state into ovn metadata agent container neutron dir | compute-1 | 0:01:35.271327 | 0.67s\n2021-09-29 22:41:49 |","commit_id":"a9a183c87da8a6eff3a18208512d499db42a2176"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"9b1de2ba7effda4b9a10bebb3031f6e0d0e99bfe","unresolved":true,"context_lines":[{"line_number":427,"context_line":"                    -w -k /etc/pki/tls/private/ovn_metadata.key"},{"line_number":428,"context_line":"                - name: Copy the certificate and key temporarly for hybrid state into ovn metadata agent container neutron dir"},{"line_number":429,"context_line":"                  copy:"},{"line_number":430,"context_line":"                    src: /etc/pki/tls/certs/\"{{ item }}\""},{"line_number":431,"context_line":"                    dest: /var/lib/config-data/puppet-generated/neutron/etc/neutron/\"{{ item }}\""},{"line_number":432,"context_line":"                    mode: \u00270644\u0027"},{"line_number":433,"context_line":"                    remote_src: yes"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1be62b48_bf9ec69f","line":430,"range":{"start_line":430,"start_character":20,"end_line":430,"end_character":56},"updated":"2021-09-30 09:29:53.000000000","message":"src: \"/etc/pki/tls/certs/{{ item }}\"","commit_id":"a9a183c87da8a6eff3a18208512d499db42a2176"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"310efb1027f3814b94652c0f8e3aeb30f1c394dc","unresolved":true,"context_lines":[{"line_number":427,"context_line":"                    -w -k /etc/pki/tls/private/ovn_metadata.key"},{"line_number":428,"context_line":"                - name: Copy the certificate and key temporarly for hybrid state into ovn metadata agent container neutron dir"},{"line_number":429,"context_line":"                  copy:"},{"line_number":430,"context_line":"                    src: /etc/pki/tls/certs/\"{{ item }}\""},{"line_number":431,"context_line":"                    dest: /var/lib/config-data/puppet-generated/neutron/etc/neutron/\"{{ item }}\""},{"line_number":432,"context_line":"                    mode: \u00270644\u0027"},{"line_number":433,"context_line":"                    remote_src: yes"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"a473eab5_26574c8e","line":430,"in_reply_to":"411f51e4_2efce878","updated":"2021-09-30 09:19:12.000000000","message":"the bug was in .../certs/\"{{ item }}\"\n\n                         ^          ^\n                        here       here\n\nI think we could have kept the loop if we had remove the quote there.\n\nIf you get to have another review/test cycle ...","commit_id":"a9a183c87da8a6eff3a18208512d499db42a2176"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"fd7c25716e6129d94581743d47b858714fb59128","unresolved":true,"context_lines":[{"line_number":427,"context_line":"                    -w -k /etc/pki/tls/private/ovn_metadata.key"},{"line_number":428,"context_line":"                - name: Copy the certificate and key temporarly for hybrid state into ovn metadata agent container neutron dir"},{"line_number":429,"context_line":"                  copy:"},{"line_number":430,"context_line":"                    src: /etc/pki/tls/certs/\"{{ item }}\""},{"line_number":431,"context_line":"                    dest: /var/lib/config-data/puppet-generated/neutron/etc/neutron/\"{{ item }}\""},{"line_number":432,"context_line":"                    mode: \u00270644\u0027"},{"line_number":433,"context_line":"                    remote_src: yes"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ec01b8b1_cf6004ba","line":430,"in_reply_to":"a473eab5_26574c8e","updated":"2021-09-30 10:53:37.000000000","message":"it wasn\u0027t so much a quotes issue, but a location issue. If you compare to patchset #9 (https://review.opendev.org/c/openstack/tripleo-heat-templates/+/798843/9..11/deployment/ovn/ovn-metadata-container-puppet.yaml) the first task takes the ovn_metadata.key from:\n/etc/pki/tls/certs/ovn_metadata.crt\nBut the key is taken from :\n/etc/pki/tls/private/ovn_metadata.key\n\nnote the certs vs private directory. I didn\u0027t realize about that slight difference in the location, so I reverted to its original format.\n\nI could have looped in a dict though:\n\nloop:\n  - { dir: certs, file: ovn_metadata.crt }\n  - { dir: private, file: ovn_metadata.key }\n\nbut I\u0027m not sure if this improves the understandability of the task, so I left it as it was. wdyt? is it worth?","commit_id":"a9a183c87da8a6eff3a18208512d499db42a2176"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"eabbe8668ce6731a97cde2a88cc19c54c0195622","unresolved":true,"context_lines":[{"line_number":427,"context_line":"                    -w -k /etc/pki/tls/private/ovn_metadata.key"},{"line_number":428,"context_line":"                - name: Copy the certificate and key temporarly for hybrid state into ovn metadata agent container neutron dir"},{"line_number":429,"context_line":"                  copy:"},{"line_number":430,"context_line":"                    src: /etc/pki/tls/certs/\"{{ item }}\""},{"line_number":431,"context_line":"                    dest: /var/lib/config-data/puppet-generated/neutron/etc/neutron/\"{{ item }}\""},{"line_number":432,"context_line":"                    mode: \u00270644\u0027"},{"line_number":433,"context_line":"                    remote_src: yes"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"759cc5ca_1e0b7a11","line":430,"range":{"start_line":430,"start_character":0,"end_line":430,"end_character":5},"updated":"2021-09-30 08:26:33.000000000","message":"Here you have two different paths so you either return back the old task or use nested variable?","commit_id":"990bf20de854033e99fc8187a4d360b6e0c4b41c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e0f288b2fd3ccecbff1e9310a14c36d52b32e105","unresolved":true,"context_lines":[{"line_number":420,"context_line":"                    /usr/bin/getcert request -I ovn_metadata \\"},{"line_number":421,"context_line":"                    -f /etc/pki/tls/certs/ovn_metadata.crt \\"},{"line_number":422,"context_line":"                    -c IPA \\"},{"line_number":423,"context_line":"                    -N CN\u003d$( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) \\"},{"line_number":424,"context_line":"                    -K ovn_metadata/$( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) \\"},{"line_number":425,"context_line":"                    -D $( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) \\"},{"line_number":426,"context_line":"                    -g {{ovn_cert_key_size}} \\"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"6a4eafc7_0b0a7d11","line":423,"updated":"2021-10-13 10:09:45.000000000","message":"ditto (extra SANs?)","commit_id":"6cbb8cdf117016458f012a0837054efb2e0e3e5b"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"0112a61ccd214b794750c2422c4d01309a2984a6","unresolved":true,"context_lines":[{"line_number":420,"context_line":"                    /usr/bin/getcert request -I ovn_metadata \\"},{"line_number":421,"context_line":"                    -f /etc/pki/tls/certs/ovn_metadata.crt \\"},{"line_number":422,"context_line":"                    -c IPA \\"},{"line_number":423,"context_line":"                    -N CN\u003d$( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) \\"},{"line_number":424,"context_line":"                    -K ovn_metadata/$( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) \\"},{"line_number":425,"context_line":"                    -D $( hiera -c /etc/puppet/hiera.yaml fqdn_{{ovn_cert_network}} ) \\"},{"line_number":426,"context_line":"                    -g {{ovn_cert_key_size}} \\"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"cdb0ca67_2c125fb0","line":423,"in_reply_to":"6a4eafc7_0b0a7d11","updated":"2021-10-18 13:51:07.000000000","message":"From checking other deployment jobs there does not seem to be need for anything else than CN. There should be no VIPs involved here.","commit_id":"6cbb8cdf117016458f012a0837054efb2e0e3e5b"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2d6fe7a9fa8638fc571170536dab557cd82e3544","unresolved":true,"context_lines":[{"line_number":429,"context_line":"                  copy:"},{"line_number":430,"context_line":"                    src: /etc/pki/tls/certs/ovn_metadata.crt"},{"line_number":431,"context_line":"                    dest: /var/lib/config-data/puppet-generated/neutron/etc/neutron/ovn_metadata.crt"},{"line_number":432,"context_line":"                    mode: \u00270644\u0027"},{"line_number":433,"context_line":"                    remote_src: yes"},{"line_number":434,"context_line":"                - name: Copy the key temporarly for hybrid state into ovn metadata agent container neutron dir"},{"line_number":435,"context_line":"                  copy:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"028c3ac1_67845e74","line":432,"updated":"2021-10-13 10:03:05.000000000","message":"this shouldn\u0027t be world-read?","commit_id":"6cbb8cdf117016458f012a0837054efb2e0e3e5b"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"0112a61ccd214b794750c2422c4d01309a2984a6","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                  copy:"},{"line_number":430,"context_line":"                    src: /etc/pki/tls/certs/ovn_metadata.crt"},{"line_number":431,"context_line":"                    dest: /var/lib/config-data/puppet-generated/neutron/etc/neutron/ovn_metadata.crt"},{"line_number":432,"context_line":"                    mode: \u00270644\u0027"},{"line_number":433,"context_line":"                    remote_src: yes"},{"line_number":434,"context_line":"                - name: Copy the key temporarly for hybrid state into ovn metadata agent container neutron dir"},{"line_number":435,"context_line":"                  copy:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"f11cc6a4_930a8df8","line":432,"in_reply_to":"028c3ac1_67845e74","updated":"2021-10-18 13:51:07.000000000","message":"Ack","commit_id":"6cbb8cdf117016458f012a0837054efb2e0e3e5b"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e0f288b2fd3ccecbff1e9310a14c36d52b32e105","unresolved":true,"context_lines":[{"line_number":435,"context_line":"                  copy:"},{"line_number":436,"context_line":"                    src: /etc/pki/tls/private/ovn_metadata.key"},{"line_number":437,"context_line":"                    dest: /var/lib/config-data/puppet-generated/neutron/etc/neutron/ovn_metadata.key"},{"line_number":438,"context_line":"                    mode: \u00270644\u0027"},{"line_number":439,"context_line":"                    remote_src: yes"},{"line_number":440,"context_line":"                - name: Set ovn cert setting in networking-ovn-metadata-agent.ini"},{"line_number":441,"context_line":"                  ini_file:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"2dd5ac15_f81a6f03","line":438,"updated":"2021-10-13 10:09:45.000000000","message":"ditto","commit_id":"6cbb8cdf117016458f012a0837054efb2e0e3e5b"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"0112a61ccd214b794750c2422c4d01309a2984a6","unresolved":false,"context_lines":[{"line_number":435,"context_line":"                  copy:"},{"line_number":436,"context_line":"                    src: /etc/pki/tls/private/ovn_metadata.key"},{"line_number":437,"context_line":"                    dest: /var/lib/config-data/puppet-generated/neutron/etc/neutron/ovn_metadata.key"},{"line_number":438,"context_line":"                    mode: \u00270644\u0027"},{"line_number":439,"context_line":"                    remote_src: yes"},{"line_number":440,"context_line":"                - name: Set ovn cert setting in networking-ovn-metadata-agent.ini"},{"line_number":441,"context_line":"                  ini_file:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"d6b98813_86da6dd4","line":438,"in_reply_to":"2dd5ac15_f81a6f03","updated":"2021-10-18 13:51:07.000000000","message":"Ack","commit_id":"6cbb8cdf117016458f012a0837054efb2e0e3e5b"}]}