)]}'
{"common/deploy-steps.j2":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"be82d45a050e8b694bbba5ba0880ffa1dd24ac7d","unresolved":true,"context_lines":[{"line_number":721,"context_line":"                        msg: Use --start-at-task \u0027{{role.name}} Host prep steps\u0027 to resume from this task"},{"line_number":722,"context_line":"                    - name: Run host_prep_data"},{"line_number":723,"context_line":"                      tripleo_host_prep:"},{"line_number":724,"context_line":"                      host_prep_data: {% raw %}{{{% endraw %} lookup(\u0027file\u0027, \"{{role.name}}/container_puppet_tasks.yaml\", errors\u003d\u0027ignore\u0027) | default({}, True) | from_yaml {% raw %}}}{% endraw %}\""},{"line_number":725,"context_line":"                    - include_tasks: {{role.name}}/host_prep_tasks.yaml"},{"line_number":726,"context_line":"{%- endfor %}"},{"line_number":727,"context_line":"              tags:"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"a5c5416e_44b14d1f","line":724,"range":{"start_line":724,"start_character":22,"end_line":724,"end_character":26},"updated":"2021-07-06 21:17:43.000000000","message":"Don\u0027t you need an indent here?","commit_id":"2cba709be07ba56350b161e3a52cc32fc79f1736"}],"deployment/cinder/cinder-api-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d8c9f56dc8ef9774ee1cc57dcbc293639b623141","unresolved":true,"context_lines":[{"line_number":363,"context_line":"        get_attr: [ApacheServiceBase, role_data, deploy_steps_tasks]"},{"line_number":364,"context_line":"      host_prep_data:"},{"line_number":365,"context_line":"        map_merge:"},{"line_number":366,"context_line":"          - {get_attr: [ApacheServiceBase, role_data, deploy_steps_data]}"},{"line_number":367,"context_line":"          - cinder_api:"},{"line_number":368,"context_line":"              directories:"},{"line_number":369,"context_line":"                \"/var/log/containers/cinder\":"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"1e117a51_1433b653","line":366,"updated":"2021-08-02 15:27:30.000000000","message":"Can you help me understand this? It\u0027s not clear why apache\u0027s deploy_steps_data should get folded into c-api\u0027s host_prep_data.","commit_id":"478ad0ca8fa325fb9dbdf010c0f4739a700e040e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"64520327ccee6342110d1cd0f5f5aedb1a142efa","unresolved":true,"context_lines":[{"line_number":363,"context_line":"        get_attr: [ApacheServiceBase, role_data, deploy_steps_tasks]"},{"line_number":364,"context_line":"      host_prep_data:"},{"line_number":365,"context_line":"        map_merge:"},{"line_number":366,"context_line":"          - {get_attr: [ApacheServiceBase, role_data, deploy_steps_data]}"},{"line_number":367,"context_line":"          - cinder_api:"},{"line_number":368,"context_line":"              directories:"},{"line_number":369,"context_line":"                \"/var/log/containers/cinder\":"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"52bbe2c8_41f701e6","line":366,"in_reply_to":"1e117a51_1433b653","updated":"2021-08-09 13:55:19.000000000","message":"Its a consistency thing (which we are terrible at). if there are host prep items that are needed for services running apache (e.g. base log folder creation) we need to ensure they are run if say this service is isolated on a system where no other apache managed services are run.  That being said I don\u0027t think there are any and this was likely a copy-pasta artifact from a different services. I\u0027ll take a look at this further.","commit_id":"478ad0ca8fa325fb9dbdf010c0f4739a700e040e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d8c9f56dc8ef9774ee1cc57dcbc293639b623141","unresolved":true,"context_lines":[{"line_number":366,"context_line":"          - {get_attr: [ApacheServiceBase, role_data, deploy_steps_data]}"},{"line_number":367,"context_line":"          - cinder_api:"},{"line_number":368,"context_line":"              directories:"},{"line_number":369,"context_line":"                \"/var/log/containers/cinder\":"},{"line_number":370,"context_line":"                  mode: \u00270750\u0027"},{"line_number":371,"context_line":"                  setype: container_file_t"},{"line_number":372,"context_line":"                \"/var/log/containers/httpd/cinder-api\":"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"0ce6be6b_439e815a","line":369,"updated":"2021-08-02 15:27:30.000000000","message":"Just curious (mainly for future reference), are the quotes required around the directory name?","commit_id":"478ad0ca8fa325fb9dbdf010c0f4739a700e040e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"64520327ccee6342110d1cd0f5f5aedb1a142efa","unresolved":true,"context_lines":[{"line_number":366,"context_line":"          - {get_attr: [ApacheServiceBase, role_data, deploy_steps_data]}"},{"line_number":367,"context_line":"          - cinder_api:"},{"line_number":368,"context_line":"              directories:"},{"line_number":369,"context_line":"                \"/var/log/containers/cinder\":"},{"line_number":370,"context_line":"                  mode: \u00270750\u0027"},{"line_number":371,"context_line":"                  setype: container_file_t"},{"line_number":372,"context_line":"                \"/var/log/containers/httpd/cinder-api\":"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"bcb8ab34_4e93b21f","line":369,"in_reply_to":"0ce6be6b_439e815a","updated":"2021-08-09 13:55:19.000000000","message":"Not necessarily but it\u0027s a dict key which is best if quoted to prevent accidental issues.","commit_id":"478ad0ca8fa325fb9dbdf010c0f4739a700e040e"}],"deployment/glance/glance-api-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d8c9f56dc8ef9774ee1cc57dcbc293639b623141","unresolved":true,"context_lines":[{"line_number":821,"context_line":"              src: \"{{glance_staging_nfs_share}}\""},{"line_number":822,"context_line":"              opts: \"{{glance_nfs_options}}\""},{"line_number":823,"context_line":"            when: glance_staging_nfs_share !\u003d \u0027\u0027"},{"line_number":824,"context_line":"          - name: ensure ceph configurations exist"},{"line_number":825,"context_line":"            file:"},{"line_number":826,"context_line":"              path: {get_param: CephConfigPath}"},{"line_number":827,"context_line":"              state: directory"},{"line_number":828,"context_line":"      metadata_settings:"},{"line_number":829,"context_line":"        get_attr: [TLSProxyBase, role_data, metadata_settings]"},{"line_number":830,"context_line":"      external_upgrade_tasks:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"077d3c3d_0f5c74d2","line":827,"range":{"start_line":824,"start_character":0,"end_line":827,"end_character":30},"updated":"2021-08-02 15:27:30.000000000","message":"Isn\u0027t this handled now by host_prep_data at L788?","commit_id":"478ad0ca8fa325fb9dbdf010c0f4739a700e040e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"64520327ccee6342110d1cd0f5f5aedb1a142efa","unresolved":true,"context_lines":[{"line_number":821,"context_line":"              src: \"{{glance_staging_nfs_share}}\""},{"line_number":822,"context_line":"              opts: \"{{glance_nfs_options}}\""},{"line_number":823,"context_line":"            when: glance_staging_nfs_share !\u003d \u0027\u0027"},{"line_number":824,"context_line":"          - name: ensure ceph configurations exist"},{"line_number":825,"context_line":"            file:"},{"line_number":826,"context_line":"              path: {get_param: CephConfigPath}"},{"line_number":827,"context_line":"              state: directory"},{"line_number":828,"context_line":"      metadata_settings:"},{"line_number":829,"context_line":"        get_attr: [TLSProxyBase, role_data, metadata_settings]"},{"line_number":830,"context_line":"      external_upgrade_tasks:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"e7d8a8c4_49b89b01","line":827,"range":{"start_line":824,"start_character":0,"end_line":827,"end_character":30},"in_reply_to":"077d3c3d_0f5c74d2","updated":"2021-08-09 13:55:19.000000000","message":"yea i need to remove this now","commit_id":"478ad0ca8fa325fb9dbdf010c0f4739a700e040e"}]}