)]}'
{"tools/convert_v1_net_data.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"7416b8b10cd97630435e69a99328b13dbd4cf089","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e5267a9f_945f6dc3","updated":"2021-07-08 15:28:12.000000000","message":"Would be nice to use the OrderedDict to keep \u0027name\u0027 as the first key.\nSee: https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/tools/convert_heat_nic_config_to_ansible_j2.py and\nhttps://opendev.org/openstack/tripleo-heat-templates/src/branch/master/tools/convert_nic_config.py, the TemplateDumper/TemplateLoader classes are used with yaml to dump ordered dict.","commit_id":"387b82ed19746f0b6b440146af78a895e0532dcb"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"6945703429802bea65fab97a5d3743cdc5ad61c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4b443d7a_6125b288","in_reply_to":"1c103fb5_332aee3f","updated":"2021-07-12 15:41:23.000000000","message":"I kept the ordering by using the native yaml kwarg, it should do everything we need; however, please review whenever you can.","commit_id":"387b82ed19746f0b6b440146af78a895e0532dcb"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"17743951d846cde528be0cc865aba1dc0fc669d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1c103fb5_332aee3f","in_reply_to":"e5267a9f_945f6dc3","updated":"2021-07-12 15:14:54.000000000","message":"Done","commit_id":"387b82ed19746f0b6b440146af78a895e0532dcb"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"7416b8b10cd97630435e69a99328b13dbd4cf089","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    parser \u003d argparse.ArgumentParser("},{"line_number":23,"context_line":"        description\u003d\"Convert a network V1 template to a V2 template.\""},{"line_number":24,"context_line":"    )"},{"line_number":25,"context_line":"    parser.add_argument(\"--v1\", help\u003d\"Existing V1 Template.\", required\u003dTrue)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    return parser.parse_args()"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"78d52a3e_e17156b2","line":25,"range":{"start_line":25,"start_character":25,"end_line":25,"end_character":29},"updated":"2021-07-08 15:28:12.000000000","message":"Do we need an argument name? Can it not just use \u0027input\u0027 here? Like https://opendev.org/openstack/python-tripleoclient/src/branch/master/tripleoclient/v2/overcloud_node.py#L227-L230","commit_id":"387b82ed19746f0b6b440146af78a895e0532dcb"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"17743951d846cde528be0cc865aba1dc0fc669d2","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    parser \u003d argparse.ArgumentParser("},{"line_number":23,"context_line":"        description\u003d\"Convert a network V1 template to a V2 template.\""},{"line_number":24,"context_line":"    )"},{"line_number":25,"context_line":"    parser.add_argument(\"--v1\", help\u003d\"Existing V1 Template.\", required\u003dTrue)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    return parser.parse_args()"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a09354e_d43cc0e4","line":25,"range":{"start_line":25,"start_character":25,"end_line":25,"end_character":29},"in_reply_to":"78d52a3e_e17156b2","updated":"2021-07-12 15:14:54.000000000","message":"sure, I can make this a positional arg.","commit_id":"387b82ed19746f0b6b440146af78a895e0532dcb"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"7416b8b10cd97630435e69a99328b13dbd4cf089","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        )"},{"line_number":50,"context_line":"        new_item[\"vip\"] \u003d item.pop(\"vip\", False)"},{"line_number":51,"context_line":"        new_item[\"mtu\"] \u003d item.pop(\"mtu\", 1500)"},{"line_number":52,"context_line":"        new_item[\"subnets\"] \u003d {\"{}_subnet\".format(name_lower): item}"},{"line_number":53,"context_line":"        new_template_data.append(new_item)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    os.rename(net_data_file, \"{}.bak\".format(net_data_file))"}],"source_content_type":"text/x-python","patch_set":1,"id":"8bbb86e5_f4a289f2","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":27},"updated":"2021-07-08 15:28:12.000000000","message":"you need to pop \"subnets\" from item, and append each subnet to new_item[\"subnet\"].\n If you try this with THT/network_data_subnets_routed.yaml you will see why.","commit_id":"387b82ed19746f0b6b440146af78a895e0532dcb"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"17743951d846cde528be0cc865aba1dc0fc669d2","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        )"},{"line_number":50,"context_line":"        new_item[\"vip\"] \u003d item.pop(\"vip\", False)"},{"line_number":51,"context_line":"        new_item[\"mtu\"] \u003d item.pop(\"mtu\", 1500)"},{"line_number":52,"context_line":"        new_item[\"subnets\"] \u003d {\"{}_subnet\".format(name_lower): item}"},{"line_number":53,"context_line":"        new_template_data.append(new_item)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    os.rename(net_data_file, \"{}.bak\".format(net_data_file))"}],"source_content_type":"text/x-python","patch_set":1,"id":"22482721_c9ce25ae","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":27},"in_reply_to":"8bbb86e5_f4a289f2","updated":"2021-07-12 15:14:54.000000000","message":"Done","commit_id":"387b82ed19746f0b6b440146af78a895e0532dcb"}]}