)]}'
{"deployment/neutron/neutron-api-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"def3dee33a8073518d4f61aa3b57accea873bca5","unresolved":true,"context_lines":[{"line_number":326,"context_line":"            neutron::keystone::authtoken::project_domain_name: \u0027Default\u0027"},{"line_number":327,"context_line":"            neutron::keystone::authtoken::region_name: {get_param: KeystoneRegion}"},{"line_number":328,"context_line":"            neutron::keystone::authtoken::interface: \u0027internal\u0027"},{"line_number":329,"context_line":"            neutron::keystone::authtoken::memcache_use_advanced_pool: false"},{"line_number":330,"context_line":"            neutron::quota::quota_port: {get_param: NeutronPortQuota}"},{"line_number":331,"context_line":"            neutron::quota::quota_security_group: {get_param: NeutronSecurityGroupQuota}"},{"line_number":332,"context_line":"            neutron::server::placement::password: {get_param: NovaPassword}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"c7b5b645_86562410","line":329,"range":{"start_line":329,"start_character":70,"end_line":329,"end_character":75},"updated":"2021-07-20 05:52:55.000000000","message":"this should be reverted.","commit_id":"cd7e2fe70e421f9dea9066f4b02ba5443687d4bd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c1414de0834e3cb28d34dc185cbe910e4c4845d3","unresolved":true,"context_lines":[{"line_number":326,"context_line":"            neutron::keystone::authtoken::project_domain_name: \u0027Default\u0027"},{"line_number":327,"context_line":"            neutron::keystone::authtoken::region_name: {get_param: KeystoneRegion}"},{"line_number":328,"context_line":"            neutron::keystone::authtoken::interface: \u0027internal\u0027"},{"line_number":329,"context_line":"            neutron::keystone::authtoken::memcache_use_advanced_pool: false"},{"line_number":330,"context_line":"            neutron::quota::quota_port: {get_param: NeutronPortQuota}"},{"line_number":331,"context_line":"            neutron::quota::quota_security_group: {get_param: NeutronSecurityGroupQuota}"},{"line_number":332,"context_line":"            neutron::server::placement::password: {get_param: NovaPassword}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"42527255_fdadd7bd","line":329,"range":{"start_line":329,"start_character":70,"end_line":329,"end_character":75},"in_reply_to":"0bfdfc98_20e280cd","updated":"2021-07-21 04:16:12.000000000","message":"That change[1] enables this feature by default and setting this to false reverts that change.\nActually this parameter was intentionally added to make that switch backportable to stable releases.\n\nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/795010\n\nOn the other hand [2] is yet another problem we should fix...","commit_id":"cd7e2fe70e421f9dea9066f4b02ba5443687d4bd"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"8242e3a5b0c6d0ececfea034351c2c3db583a51b","unresolved":true,"context_lines":[{"line_number":326,"context_line":"            neutron::keystone::authtoken::project_domain_name: \u0027Default\u0027"},{"line_number":327,"context_line":"            neutron::keystone::authtoken::region_name: {get_param: KeystoneRegion}"},{"line_number":328,"context_line":"            neutron::keystone::authtoken::interface: \u0027internal\u0027"},{"line_number":329,"context_line":"            neutron::keystone::authtoken::memcache_use_advanced_pool: false"},{"line_number":330,"context_line":"            neutron::quota::quota_port: {get_param: NeutronPortQuota}"},{"line_number":331,"context_line":"            neutron::quota::quota_security_group: {get_param: NeutronSecurityGroupQuota}"},{"line_number":332,"context_line":"            neutron::server::placement::password: {get_param: NovaPassword}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"174b83ec_697e25d6","line":329,"range":{"start_line":329,"start_character":70,"end_line":329,"end_character":75},"in_reply_to":"42527255_fdadd7bd","updated":"2021-07-21 04:31:19.000000000","message":"Yes for old releases we need to set it to \u0027true\u0027 but on master it\u0027s default. So we can get rid of that parameter (once we fix the neutron issue).","commit_id":"cd7e2fe70e421f9dea9066f4b02ba5443687d4bd"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2d9ac127fd49bd8a42ab1f83fb8039b5c62106fd","unresolved":true,"context_lines":[{"line_number":326,"context_line":"            neutron::keystone::authtoken::project_domain_name: \u0027Default\u0027"},{"line_number":327,"context_line":"            neutron::keystone::authtoken::region_name: {get_param: KeystoneRegion}"},{"line_number":328,"context_line":"            neutron::keystone::authtoken::interface: \u0027internal\u0027"},{"line_number":329,"context_line":"            neutron::keystone::authtoken::memcache_use_advanced_pool: false"},{"line_number":330,"context_line":"            neutron::quota::quota_port: {get_param: NeutronPortQuota}"},{"line_number":331,"context_line":"            neutron::quota::quota_security_group: {get_param: NeutronSecurityGroupQuota}"},{"line_number":332,"context_line":"            neutron::server::placement::password: {get_param: NovaPassword}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"0bfdfc98_20e280cd","line":329,"range":{"start_line":329,"start_character":70,"end_line":329,"end_character":75},"in_reply_to":"c7b5b645_86562410","updated":"2021-07-21 04:03:46.000000000","message":"Actually we don\u0027t need to use this with python3-keystonemiddleware-9.3.0[1]. I\u0027m seeing some issues with neutron+mod_wsgi and hence trying to see if it helps without it.\n\n[1] I\u0027m see https://github.com/openstack/keystonemiddleware/commit/788d3c4969e3446778496f3a9055f654602ae2c1\n\n[2] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_44a/800422/2/check/tripleo-ci-centos-8-scenario007-standalone/44a3b0a/logs/undercloud/var/log/containers/neutron/app.log","commit_id":"cd7e2fe70e421f9dea9066f4b02ba5443687d4bd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"def3dee33a8073518d4f61aa3b57accea873bca5","unresolved":true,"context_lines":[{"line_number":498,"context_line":"          #command: \"/usr/bin/bootstrap_host_exec neutron_api su neutron -s /bin/bash -c \u0027neutron-db-manage upgrade heads\u0027\""},{"line_number":499,"context_line":"          config_files: *neutron_api_config_files"},{"line_number":500,"context_line":"          permissions: *neutron_api_permissions"},{"line_number":501,"context_line":"        /var/lib/kolla/config_files/neutron_server_tls_proxy.json:"},{"line_number":502,"context_line":"          command: /usr/sbin/httpd -DFOREGROUND"},{"line_number":503,"context_line":"          config_files:"},{"line_number":504,"context_line":"            - source: \"/var/lib/kolla/config_files/src/*\""},{"line_number":505,"context_line":"              dest: \"/\""},{"line_number":506,"context_line":"              merge: true"},{"line_number":507,"context_line":"              preserve_properties: true"},{"line_number":508,"context_line":"            - source: \"/var/lib/kolla/config_files/src/etc/httpd/conf.d\""},{"line_number":509,"context_line":"              dest: \"/etc/httpd/conf.d\""},{"line_number":510,"context_line":"              merge: false"},{"line_number":511,"context_line":"              preserve_properties: true"},{"line_number":512,"context_line":"            - source: \"/var/lib/kolla/config_files/src/etc/httpd/conf.modules.d\""},{"line_number":513,"context_line":"              dest: \"/etc/httpd/conf.modules.d\""},{"line_number":514,"context_line":"              merge: false"},{"line_number":515,"context_line":"              preserve_properties: true"},{"line_number":516,"context_line":"      docker_config:"},{"line_number":517,"context_line":"        step_2:"},{"line_number":518,"context_line":"          get_attr: [NeutronLogging, docker_config, step_2]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f39f35f1_206c62f1","line":515,"range":{"start_line":501,"start_character":8,"end_line":515,"end_character":39},"updated":"2021-07-20 05:52:55.000000000","message":"because tls is now terminated by httpd, we should remove this as well. I tried to implement the same in another patch so you can pick up some part from that patch.\n\nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/798183","commit_id":"cd7e2fe70e421f9dea9066f4b02ba5443687d4bd"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2d9ac127fd49bd8a42ab1f83fb8039b5c62106fd","unresolved":true,"context_lines":[{"line_number":498,"context_line":"          #command: \"/usr/bin/bootstrap_host_exec neutron_api su neutron -s /bin/bash -c \u0027neutron-db-manage upgrade heads\u0027\""},{"line_number":499,"context_line":"          config_files: *neutron_api_config_files"},{"line_number":500,"context_line":"          permissions: *neutron_api_permissions"},{"line_number":501,"context_line":"        /var/lib/kolla/config_files/neutron_server_tls_proxy.json:"},{"line_number":502,"context_line":"          command: /usr/sbin/httpd -DFOREGROUND"},{"line_number":503,"context_line":"          config_files:"},{"line_number":504,"context_line":"            - source: \"/var/lib/kolla/config_files/src/*\""},{"line_number":505,"context_line":"              dest: \"/\""},{"line_number":506,"context_line":"              merge: true"},{"line_number":507,"context_line":"              preserve_properties: true"},{"line_number":508,"context_line":"            - source: \"/var/lib/kolla/config_files/src/etc/httpd/conf.d\""},{"line_number":509,"context_line":"              dest: \"/etc/httpd/conf.d\""},{"line_number":510,"context_line":"              merge: false"},{"line_number":511,"context_line":"              preserve_properties: true"},{"line_number":512,"context_line":"            - source: \"/var/lib/kolla/config_files/src/etc/httpd/conf.modules.d\""},{"line_number":513,"context_line":"              dest: \"/etc/httpd/conf.modules.d\""},{"line_number":514,"context_line":"              merge: false"},{"line_number":515,"context_line":"              preserve_properties: true"},{"line_number":516,"context_line":"      docker_config:"},{"line_number":517,"context_line":"        step_2:"},{"line_number":518,"context_line":"          get_attr: [NeutronLogging, docker_config, step_2]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5edf438f_27ab5242","line":515,"range":{"start_line":501,"start_character":8,"end_line":515,"end_character":39},"in_reply_to":"f39f35f1_206c62f1","updated":"2021-07-21 04:03:46.000000000","message":"Thanks. I\u0027ll update the patch, though I still see some issues.","commit_id":"cd7e2fe70e421f9dea9066f4b02ba5443687d4bd"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c52ffb9f5b21b88758d02faf5226db0ac3809661","unresolved":true,"context_lines":[{"line_number":581,"context_line":"            - step|int \u003d\u003d 2"},{"line_number":582,"context_line":"            - internal_tls_enabled|bool"},{"line_number":583,"context_line":"      upgrade_tasks:"},{"line_number":584,"context_line":"        - name: Set internal tls variable"},{"line_number":585,"context_line":"          set_fact:"},{"line_number":586,"context_line":"            internal_tls_enabled: {get_param: EnableInternalTLS}"},{"line_number":587,"context_line":"        - name: Remove TLS proxy if configured and running"},{"line_number":588,"context_line":"          include_role:"},{"line_number":589,"context_line":"            name: tripleo_container_rm"},{"line_number":590,"context_line":"          vars:"},{"line_number":591,"context_line":"            tripleo_container_cli: \"{{ container_cli }}\""},{"line_number":592,"context_line":"            tripleo_containers_to_rm:"},{"line_number":593,"context_line":"              - neutron_server_tls_proxy"},{"line_number":594,"context_line":"          when:"},{"line_number":595,"context_line":"            - step|int \u003d\u003d 2"},{"line_number":596,"context_line":"            - internal_tls_enabled|bool"},{"line_number":597,"context_line":"      external_upgrade_tasks:"},{"line_number":598,"context_line":"        - when:"},{"line_number":599,"context_line":"            - step|int \u003d\u003d 1"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"21db3b27_6d26dd1a","line":596,"range":{"start_line":584,"start_character":0,"end_line":596,"end_character":39},"updated":"2021-07-23 12:58:22.000000000","message":"this probably can be referenced via a yaml var","commit_id":"2788a49caf24d1f23ea20d25be4966cb403227cf"}]}