)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"5365488277bf9bee11e62f65ad57f251cd35c965","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"e1a4b298_5178ffbb","updated":"2022-02-11 16:08:18.000000000","message":"Patch ready to merge. After giving a though about implementing https://review.opendev.org/c/openstack/tripleo-heat-templates/+/827472 in the upgrade_rollback steps, it is a timeout config change from one value from 600 to 60 seconds. Usually, the upgrade_rollback is intended to get back to a fully working OSP13 computes and having that RPC timeout option set to 60 seconds won\u0027t harm.","commit_id":"a1658df342bfce658f47ee2d080fd27ad8abc032"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"1eb827b3aba64fb8c04bc9b9e956f7aea2d36975","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"673b6e7f_18264078","updated":"2022-04-21 13:47:07.000000000","message":"recheck","commit_id":"68a7efbee914d1004862b9b748e2ef1d2ec693e9"}],"deployment/iscsid/iscsid-container-puppet.yaml":[{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"26dd07890ef2881d1dd7a642fa5617e54896e277","unresolved":true,"context_lines":[{"line_number":278,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(\u00277\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":279,"context_line":"          block:"},{"line_number":280,"context_line":"            - name: Check if iscsid is running with next release image"},{"line_number":281,"context_line":"              shell: |"},{"line_number":282,"context_line":"                docker ps | grep \"{{iscsid_image}}\""},{"line_number":283,"context_line":"              failed_when: false"},{"line_number":284,"context_line":"              register: hybrid_iscsid_running"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"686143fc_ad0e0466","line":281,"range":{"start_line":281,"start_character":14,"end_line":281,"end_character":22},"updated":"2021-07-16 12:49:01.000000000","message":"set -o pipefail????","commit_id":"a0cc8b85d47758edab4c68294742b8af16fe04d7"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"4986f307e7b02701eb76b828a2b979e741ed4d11","unresolved":true,"context_lines":[{"line_number":278,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(\u00277\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":279,"context_line":"          block:"},{"line_number":280,"context_line":"            - name: Check if iscsid is running with next release image"},{"line_number":281,"context_line":"              shell: |"},{"line_number":282,"context_line":"                docker ps | grep \"{{iscsid_image}}\""},{"line_number":283,"context_line":"              failed_when: false"},{"line_number":284,"context_line":"              register: hybrid_iscsid_running"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"75d88ce9_3c091807","line":281,"range":{"start_line":281,"start_character":14,"end_line":281,"end_character":22},"in_reply_to":"686143fc_ad0e0466","updated":"2022-02-14 06:56:18.000000000","message":"This is copied from the command in line 208, it could be implemented as a new patch covering all the occurrencies (as that\u0027s also present in the other hybrid mode tasks from other service templates)","commit_id":"a0cc8b85d47758edab4c68294742b8af16fe04d7"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"3d7894cadd714a839ae265ebc7a82994c4e187a5","unresolved":false,"context_lines":[{"line_number":278,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(\u00277\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":279,"context_line":"          block:"},{"line_number":280,"context_line":"            - name: Check if iscsid is running with next release image"},{"line_number":281,"context_line":"              shell: |"},{"line_number":282,"context_line":"                docker ps | grep \"{{iscsid_image}}\""},{"line_number":283,"context_line":"              failed_when: false"},{"line_number":284,"context_line":"              register: hybrid_iscsid_running"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"05624507_1e373b3d","line":281,"range":{"start_line":281,"start_character":14,"end_line":281,"end_character":22},"in_reply_to":"75d88ce9_3c091807","updated":"2023-09-04 11:40:15.000000000","message":"Done","commit_id":"a0cc8b85d47758edab4c68294742b8af16fe04d7"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"26dd07890ef2881d1dd7a642fa5617e54896e277","unresolved":true,"context_lines":[{"line_number":291,"context_line":"                    state: absent"},{"line_number":292,"context_line":"                # Finally apply the paunch config to start the restored iscsid"},{"line_number":293,"context_line":"                - name: Apply paunch config for iscsid"},{"line_number":294,"context_line":"                  shell: |"},{"line_number":295,"context_line":"                    paunch apply --file /var/lib/tripleo-config/docker-container-iscsid.json --config-id iscsid"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2341c09c_b1db3532","line":294,"range":{"start_line":294,"start_character":18,"end_line":294,"end_character":23},"updated":"2021-07-16 12:49:01.000000000","message":"is not command a better option here","commit_id":"a0cc8b85d47758edab4c68294742b8af16fe04d7"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"3d7894cadd714a839ae265ebc7a82994c4e187a5","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                    state: absent"},{"line_number":292,"context_line":"                # Finally apply the paunch config to start the restored iscsid"},{"line_number":293,"context_line":"                - name: Apply paunch config for iscsid"},{"line_number":294,"context_line":"                  shell: |"},{"line_number":295,"context_line":"                    paunch apply --file /var/lib/tripleo-config/docker-container-iscsid.json --config-id iscsid"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"738a59ff_5c992d5b","line":294,"range":{"start_line":294,"start_character":18,"end_line":294,"end_character":23},"in_reply_to":"2341c09c_b1db3532","updated":"2023-09-04 11:40:15.000000000","message":"Done","commit_id":"a0cc8b85d47758edab4c68294742b8af16fe04d7"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5ea431d2a6047fd88b181013850474a5c619452f","unresolved":true,"context_lines":[{"line_number":279,"context_line":"          block:"},{"line_number":280,"context_line":"            - name: Check if iscsid is running with next release image"},{"line_number":281,"context_line":"              shell: |"},{"line_number":282,"context_line":"                docker ps | grep \"{{iscsid_image}}\""},{"line_number":283,"context_line":"              failed_when: false"},{"line_number":284,"context_line":"              register: hybrid_iscsid_running"},{"line_number":285,"context_line":"            - name: Implement the restoring from hybrid state for iscsid"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"3d4290c8_456b3148","line":282,"range":{"start_line":282,"start_character":16,"end_line":282,"end_character":51},"updated":"2022-02-02 15:33:50.000000000","message":"Is there not a --filter option in docker ps (i don\u0027t remember)","commit_id":"a1658df342bfce658f47ee2d080fd27ad8abc032"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"2ff0a0c2085f8df9dcba7f21a54ceeb0185ad393","unresolved":true,"context_lines":[{"line_number":279,"context_line":"          block:"},{"line_number":280,"context_line":"            - name: Check if iscsid is running with next release image"},{"line_number":281,"context_line":"              shell: |"},{"line_number":282,"context_line":"                docker ps | grep \"{{iscsid_image}}\""},{"line_number":283,"context_line":"              failed_when: false"},{"line_number":284,"context_line":"              register: hybrid_iscsid_running"},{"line_number":285,"context_line":"            - name: Implement the restoring from hybrid state for iscsid"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"57946d7e_264124c6","line":282,"range":{"start_line":282,"start_character":16,"end_line":282,"end_character":51},"in_reply_to":"3d4290c8_456b3148","updated":"2022-02-14 13:14:58.000000000","message":"docker ps --filter \"name\u003dmemcached\"\nCONTAINER ID        IMAGE                                                              COMMAND                  CREATED             STATUS                PORTS               NAMES\n4146667ee47e        192.168.24.1:8787/rh-osbs/rhosp13-openstack-memcached:20211206.1   \"dumb-init --singl...\"   9 days ago          Up 9 days (healthy)                       memcached","commit_id":"a1658df342bfce658f47ee2d080fd27ad8abc032"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"3d7894cadd714a839ae265ebc7a82994c4e187a5","unresolved":false,"context_lines":[{"line_number":279,"context_line":"          block:"},{"line_number":280,"context_line":"            - name: Check if iscsid is running with next release image"},{"line_number":281,"context_line":"              shell: |"},{"line_number":282,"context_line":"                docker ps | grep \"{{iscsid_image}}\""},{"line_number":283,"context_line":"              failed_when: false"},{"line_number":284,"context_line":"              register: hybrid_iscsid_running"},{"line_number":285,"context_line":"            - name: Implement the restoring from hybrid state for iscsid"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"195d0570_3bea0a10","line":282,"range":{"start_line":282,"start_character":16,"end_line":282,"end_character":51},"in_reply_to":"57946d7e_264124c6","updated":"2023-09-04 11:40:15.000000000","message":"Done","commit_id":"a1658df342bfce658f47ee2d080fd27ad8abc032"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"2ff0a0c2085f8df9dcba7f21a54ceeb0185ad393","unresolved":true,"context_lines":[{"line_number":205,"context_line":"          block:"},{"line_number":206,"context_line":"            - name: Check if iscsid is running with proper image"},{"line_number":207,"context_line":"              shell: |"},{"line_number":208,"context_line":"                docker ps | grep \"{{iscsid_image}}\""},{"line_number":209,"context_line":"              failed_when: false"},{"line_number":210,"context_line":"              register: hybrid_iscsid"},{"line_number":211,"context_line":"            - name: Implement the hybrid state (only if the compute is still Queens)"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"0f9b3a01_e3528ba1","line":208,"updated":"2022-02-14 13:14:58.000000000","message":"This should be fixed as well","commit_id":"24d262bad5c3ff917360dee4904690318d2f9871"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"d3a6e2f8ccb86c8cda4e24eb88241beb590ec1c0","unresolved":true,"context_lines":[{"line_number":205,"context_line":"          block:"},{"line_number":206,"context_line":"            - name: Check if iscsid is running with proper image"},{"line_number":207,"context_line":"              shell: |"},{"line_number":208,"context_line":"                docker ps | grep \"{{iscsid_image}}\""},{"line_number":209,"context_line":"              failed_when: false"},{"line_number":210,"context_line":"              register: hybrid_iscsid"},{"line_number":211,"context_line":"            - name: Implement the hybrid state (only if the compute is still Queens)"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"46192fff_1daccbc5","line":208,"in_reply_to":"0f9b3a01_e3528ba1","updated":"2022-02-16 06:46:00.000000000","message":"But as I mentioned, this is something that is like this all around the hybrid state templates:\n[jfrancoa@localhost tripleo-heat-templates]$ grep -r \"docker ps | grep\" *\ndeployment/ovn/ovn-controller-container-puppet.yaml:                docker ps | grep ovn_controller\ndeployment/ovn/ovn-controller-container-puppet.yaml:                docker ps | grep \"{{ovn_controller_image}}\"\ndeployment/neutron/neutron-sriov-agent-container-puppet.yaml:                docker ps | grep \"{{neutron_sriov_image}}\"\ndeployment/neutron/neutron-ovs-agent-container-puppet.yaml:                docker ps | grep \"{{neutron_ovs_image}}\"\ngrep: deployment/nova/.nova-compute-container-puppet.yaml.un~: binary file matches\ndeployment/nova/nova-compute-container-puppet.yaml:                docker ps | grep \"{{nova_compute_image}}\"\ngrep: deployment/iscsid/.iscsid-container-puppet.yaml.un~: binary file matches\ndeployment/iscsid/iscsid-container-puppet.yaml:                docker ps | grep \"{{iscsid_image}}\"\n\nI think it would make sense in a follow up patch which get well tested. I would like to modify that task and break the hybrid state.","commit_id":"24d262bad5c3ff917360dee4904690318d2f9871"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"a333b7ef68415d632260a0b10cbc851673f8b5ea","unresolved":true,"context_lines":[{"line_number":205,"context_line":"          block:"},{"line_number":206,"context_line":"            - name: Check if iscsid is running with proper image"},{"line_number":207,"context_line":"              shell: |"},{"line_number":208,"context_line":"                docker ps | grep \"{{iscsid_image}}\""},{"line_number":209,"context_line":"              failed_when: false"},{"line_number":210,"context_line":"              register: hybrid_iscsid"},{"line_number":211,"context_line":"            - name: Implement the hybrid state (only if the compute is still Queens)"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9e771b30_73a01c2e","line":208,"in_reply_to":"46192fff_1daccbc5","updated":"2022-04-20 09:44:46.000000000","message":"IMHO, this should be fixed it in a different patch.","commit_id":"24d262bad5c3ff917360dee4904690318d2f9871"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"3d7894cadd714a839ae265ebc7a82994c4e187a5","unresolved":false,"context_lines":[{"line_number":205,"context_line":"          block:"},{"line_number":206,"context_line":"            - name: Check if iscsid is running with proper image"},{"line_number":207,"context_line":"              shell: |"},{"line_number":208,"context_line":"                docker ps | grep \"{{iscsid_image}}\""},{"line_number":209,"context_line":"              failed_when: false"},{"line_number":210,"context_line":"              register: hybrid_iscsid"},{"line_number":211,"context_line":"            - name: Implement the hybrid state (only if the compute is still Queens)"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"fa683f6e_cb05977c","line":208,"in_reply_to":"9e771b30_73a01c2e","updated":"2023-09-04 11:40:15.000000000","message":"Done","commit_id":"24d262bad5c3ff917360dee4904690318d2f9871"}],"deployment/neutron/neutron-ovs-agent-container-puppet.yaml":[{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"26dd07890ef2881d1dd7a642fa5617e54896e277","unresolved":true,"context_lines":[{"line_number":511,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(\u00277\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":512,"context_line":"          block:"},{"line_number":513,"context_line":"            - name: Check if neutron_ovs is running with next release image"},{"line_number":514,"context_line":"              shell: |"},{"line_number":515,"context_line":"                docker ps | grep \"{{neutron_ovs_image}}\""},{"line_number":516,"context_line":"              failed_when: false"},{"line_number":517,"context_line":"              register: hybrid_neutron_ovs_running"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"00702cbb_876bdb04","line":514,"range":{"start_line":514,"start_character":14,"end_line":514,"end_character":22},"updated":"2021-07-16 12:49:01.000000000","message":"set -o pipefail","commit_id":"a0cc8b85d47758edab4c68294742b8af16fe04d7"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"3d7894cadd714a839ae265ebc7a82994c4e187a5","unresolved":false,"context_lines":[{"line_number":511,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(\u00277\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":512,"context_line":"          block:"},{"line_number":513,"context_line":"            - name: Check if neutron_ovs is running with next release image"},{"line_number":514,"context_line":"              shell: |"},{"line_number":515,"context_line":"                docker ps | grep \"{{neutron_ovs_image}}\""},{"line_number":516,"context_line":"              failed_when: false"},{"line_number":517,"context_line":"              register: hybrid_neutron_ovs_running"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8104ce2d_bc0677fc","line":514,"range":{"start_line":514,"start_character":14,"end_line":514,"end_character":22},"in_reply_to":"00702cbb_876bdb04","updated":"2023-09-04 11:40:15.000000000","message":"Done","commit_id":"a0cc8b85d47758edab4c68294742b8af16fe04d7"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"26dd07890ef2881d1dd7a642fa5617e54896e277","unresolved":true,"context_lines":[{"line_number":529,"context_line":"                    replace: \"python \""},{"line_number":530,"context_line":"                # Finally apply the paunch config to start the restored neutron-ovs"},{"line_number":531,"context_line":"                - name: Apply paunch config for neutron_ovs"},{"line_number":532,"context_line":"                  shell: |"},{"line_number":533,"context_line":"                    paunch apply --file /var/lib/tripleo-config/docker-container-neutron_ovs.json --config-id neutron_ovs_agent"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"96a0644b_1d7fcd39","line":532,"range":{"start_line":532,"start_character":18,"end_line":532,"end_character":23},"updated":"2021-07-16 12:49:01.000000000","message":"what about command instead of shell?","commit_id":"a0cc8b85d47758edab4c68294742b8af16fe04d7"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"3d7894cadd714a839ae265ebc7a82994c4e187a5","unresolved":false,"context_lines":[{"line_number":529,"context_line":"                    replace: \"python \""},{"line_number":530,"context_line":"                # Finally apply the paunch config to start the restored neutron-ovs"},{"line_number":531,"context_line":"                - name: Apply paunch config for neutron_ovs"},{"line_number":532,"context_line":"                  shell: |"},{"line_number":533,"context_line":"                    paunch apply --file /var/lib/tripleo-config/docker-container-neutron_ovs.json --config-id neutron_ovs_agent"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4f5fd756_15093464","line":532,"range":{"start_line":532,"start_character":18,"end_line":532,"end_character":23},"in_reply_to":"96a0644b_1d7fcd39","updated":"2023-09-04 11:40:15.000000000","message":"Done","commit_id":"a0cc8b85d47758edab4c68294742b8af16fe04d7"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"7480c1ef3c24fd381d34ef04710adc1da69767fb","unresolved":true,"context_lines":[{"line_number":485,"context_line":"                    - ini_read_result is changed"},{"line_number":486,"context_line":"                  service:"},{"line_number":487,"context_line":"                    name: docker"},{"line_number":488,"context_line":"                    state: restarted"},{"line_number":489,"context_line":"                - name: Remove neutron_ovs_agent container before applying new paunch config"},{"line_number":490,"context_line":"                  docker_container:"},{"line_number":491,"context_line":"                    name: neutron_ovs_agent"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"de163af5_6b8ab8ea","line":488,"updated":"2022-02-04 14:33:27.000000000","message":"I will have to revert also this option modified in here https://review.opendev.org/c/openstack/tripleo-heat-templates/+/827472 . @Lukas, would anything happen if we revert the hybrid state and that option isn\u0027t changed back to its OSP13 value?","commit_id":"a1658df342bfce658f47ee2d080fd27ad8abc032"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"7e5405cce16af333230627524ba55911fdc19ea0","unresolved":false,"context_lines":[{"line_number":485,"context_line":"                    - ini_read_result is changed"},{"line_number":486,"context_line":"                  service:"},{"line_number":487,"context_line":"                    name: docker"},{"line_number":488,"context_line":"                    state: restarted"},{"line_number":489,"context_line":"                - name: Remove neutron_ovs_agent container before applying new paunch config"},{"line_number":490,"context_line":"                  docker_container:"},{"line_number":491,"context_line":"                    name: neutron_ovs_agent"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"2380fea1_e7fdc122","line":488,"in_reply_to":"adda9358_0ee19720","updated":"2023-09-04 11:39:40.000000000","message":"Ack","commit_id":"a1658df342bfce658f47ee2d080fd27ad8abc032"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"e1d5006962a038a3f7b12c0018e163185348484b","unresolved":true,"context_lines":[{"line_number":485,"context_line":"                    - ini_read_result is changed"},{"line_number":486,"context_line":"                  service:"},{"line_number":487,"context_line":"                    name: docker"},{"line_number":488,"context_line":"                    state: restarted"},{"line_number":489,"context_line":"                - name: Remove neutron_ovs_agent container before applying new paunch config"},{"line_number":490,"context_line":"                  docker_container:"},{"line_number":491,"context_line":"                    name: neutron_ovs_agent"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"fbc86bd2_9582469a","line":488,"in_reply_to":"de163af5_6b8ab8ea","updated":"2022-02-04 14:37:48.000000000","message":"After discussion with Lukas:\n\n(03:35:30 PM) lbezdick: jfrancoa: restore procedure runs deploy after or you just restore and go on?\n(03:35:55 PM) jfrancoa: lbezdick: restore just undoes what the hybrid state has executed\n(03:36:12 PM) jfrancoa: lbezdick: it tries to revert those computes to their previous state without running deploy again\n(03:36:46 PM) lbezdick: it\u0027s not a big deal but we probably should revert to hieradata content\n(03:36:51 PM) jfrancoa: lbezdick: so if a config value has been modified, the idea is to revert it back","commit_id":"a1658df342bfce658f47ee2d080fd27ad8abc032"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"7bc6d9a7b8b41c692a56fc64834165b8e6a3db62","unresolved":true,"context_lines":[{"line_number":485,"context_line":"                    - ini_read_result is changed"},{"line_number":486,"context_line":"                  service:"},{"line_number":487,"context_line":"                    name: docker"},{"line_number":488,"context_line":"                    state: restarted"},{"line_number":489,"context_line":"                - name: Remove neutron_ovs_agent container before applying new paunch config"},{"line_number":490,"context_line":"                  docker_container:"},{"line_number":491,"context_line":"                    name: neutron_ovs_agent"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"adda9358_0ee19720","line":488,"in_reply_to":"fbc86bd2_9582469a","updated":"2022-04-20 10:51:31.000000000","message":"Check lines 551-560","commit_id":"a1658df342bfce658f47ee2d080fd27ad8abc032"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"26dd07890ef2881d1dd7a642fa5617e54896e277","unresolved":true,"context_lines":[{"line_number":1377,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(\u00277\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":1378,"context_line":"          block:"},{"line_number":1379,"context_line":"            - name: Check if nova_compute is running with next release image"},{"line_number":1380,"context_line":"              shell: |"},{"line_number":1381,"context_line":"                docker ps | grep \"{{nova_compute_image}}\""},{"line_number":1382,"context_line":"              failed_when: false"},{"line_number":1383,"context_line":"              register: hybrid_nova_compute_running"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9402fa8d_56d65d1c","line":1380,"range":{"start_line":1380,"start_character":14,"end_line":1380,"end_character":22},"updated":"2021-07-16 12:49:01.000000000","message":"set -o pipefail","commit_id":"a0cc8b85d47758edab4c68294742b8af16fe04d7"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"3d7894cadd714a839ae265ebc7a82994c4e187a5","unresolved":false,"context_lines":[{"line_number":1377,"context_line":"            - ansible_facts[\u0027distribution_major_version\u0027] is version(\u00277\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":1378,"context_line":"          block:"},{"line_number":1379,"context_line":"            - name: Check if nova_compute is running with next release image"},{"line_number":1380,"context_line":"              shell: |"},{"line_number":1381,"context_line":"                docker ps | grep \"{{nova_compute_image}}\""},{"line_number":1382,"context_line":"              failed_when: false"},{"line_number":1383,"context_line":"              register: hybrid_nova_compute_running"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"03f633be_18ce61d3","line":1380,"range":{"start_line":1380,"start_character":14,"end_line":1380,"end_character":22},"in_reply_to":"9402fa8d_56d65d1c","updated":"2023-09-04 11:40:15.000000000","message":"Done","commit_id":"a0cc8b85d47758edab4c68294742b8af16fe04d7"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"26dd07890ef2881d1dd7a642fa5617e54896e277","unresolved":true,"context_lines":[{"line_number":1394,"context_line":"                    /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf"},{"line_number":1395,"context_line":"                # Finally apply the paunch config to start the restored nova_compute"},{"line_number":1396,"context_line":"                - name: Apply paunch config for nova_compute"},{"line_number":1397,"context_line":"                  shell: |"},{"line_number":1398,"context_line":"                    paunch apply --file /var/lib/tripleo-config/docker-container-nova-compute.json --config-id nova_compute"},{"line_number":1399,"context_line":"        - name: Remove openstack-nova-compute and python-nova package during upgrade"},{"line_number":1400,"context_line":"          package:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"56b7c101_b5c34479","line":1397,"range":{"start_line":1397,"start_character":18,"end_line":1397,"end_character":24},"updated":"2021-07-16 12:49:01.000000000","message":"command instead of shell?\nOh I see, the previous part is using shell.","commit_id":"a0cc8b85d47758edab4c68294742b8af16fe04d7"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"872b815081d1c11d69fd96407c26b25b4405b370","unresolved":true,"context_lines":[{"line_number":1394,"context_line":"                    /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf"},{"line_number":1395,"context_line":"                # Finally apply the paunch config to start the restored nova_compute"},{"line_number":1396,"context_line":"                - name: Apply paunch config for nova_compute"},{"line_number":1397,"context_line":"                  shell: |"},{"line_number":1398,"context_line":"                    paunch apply --file /var/lib/tripleo-config/docker-container-nova-compute.json --config-id nova_compute"},{"line_number":1399,"context_line":"        - name: Remove openstack-nova-compute and python-nova package during upgrade"},{"line_number":1400,"context_line":"          package:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"78b64bc1_02af35b8","line":1397,"range":{"start_line":1397,"start_character":18,"end_line":1397,"end_character":24},"in_reply_to":"56b7c101_b5c34479","updated":"2021-07-19 12:58:09.000000000","message":"right, it was basically for being consistent with the same task few lines above which was using shell...we could modify it in a follow up patch.","commit_id":"a0cc8b85d47758edab4c68294742b8af16fe04d7"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"3d7894cadd714a839ae265ebc7a82994c4e187a5","unresolved":false,"context_lines":[{"line_number":1394,"context_line":"                    /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf"},{"line_number":1395,"context_line":"                # Finally apply the paunch config to start the restored nova_compute"},{"line_number":1396,"context_line":"                - name: Apply paunch config for nova_compute"},{"line_number":1397,"context_line":"                  shell: |"},{"line_number":1398,"context_line":"                    paunch apply --file /var/lib/tripleo-config/docker-container-nova-compute.json --config-id nova_compute"},{"line_number":1399,"context_line":"        - name: Remove openstack-nova-compute and python-nova package during upgrade"},{"line_number":1400,"context_line":"          package:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4b32f78b_6379e3b7","line":1397,"range":{"start_line":1397,"start_character":18,"end_line":1397,"end_character":24},"in_reply_to":"78b64bc1_02af35b8","updated":"2023-09-04 11:40:15.000000000","message":"Done","commit_id":"a0cc8b85d47758edab4c68294742b8af16fe04d7"}]}